Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

2014-03-27 Thread CloudBees pull request builder plugin 
[jclouds-pull-requests 
#708](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/708/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38783001

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

2014-03-27 Thread CloudBees pull request builder plugin 
[jclouds-java-7-pull-requests 
#1178](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1178/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38783375

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

2014-03-27 Thread Andrew Phillips 
 @@ -26,19 +39,6 @@
  import static org.jclouds.reflect.Reflection2.typeToken;
  import static org.jclouds.util.Throwables2.propagateIfPossible;
  
 -import java.lang.reflect.Method;
 -import java.lang.reflect.Proxy;
 -import java.util.Arrays;
 -import java.util.Collections;
 -import java.util.List;
 -
 -import com.google.common.annotations.Beta;
 -import com.google.common.base.Function;
 -import com.google.common.base.Objects;
 -import com.google.common.collect.ImmutableList;
 -import com.google.common.reflect.Invokable;
 -import com.google.common.reflect.TypeToken;
 -

These imports have just moved, from what I see. Undo this change?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329/files#r11016371

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

2014-03-27 Thread Andrew Phillips 
 @@ -28,8 +25,10 @@
  import org.jclouds.ec2.compute.config.EC2ResolveImagesModule;
  import org.jclouds.rest.internal.BaseHttpApiMetadata;
  
 -import com.google.common.collect.ImmutableSet;
 -import com.google.inject.Module;
 +import java.net.URI;
 +import java.util.Properties;
 +
 +import static org.jclouds.ec2.reference.EC2Constants.PROPERTY_EC2_AMI_OWNERS;

Again, please undo the import reformatting.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329/files#r11016379

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

2014-03-27 Thread Andrew Phillips 
Haven't been able to review this properly, but one initial comment: could you 
take the move import statements changes out of this PR? That should make the 
PR smaller and easier to review.

Thanks, Lahiru!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38786399

Re: [jclouds] Support 'AssociatePublicIpAddress' in AWS EC2 (#329)

2014-03-27 Thread lahirus 
Yes :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/329#issuecomment-38876661