Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409340097
[jira] [Commented] (JCLOUDS-1430) Aliyun ECS support
[ https://issues.apache.org/jira/browse/JCLOUDS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564318#comment-16564318 ] ASF subversion and git services commented on JCLOUDS-1430: -- Commit a5dbf0065d8fa8cabcaf020b7c10fe2f7ccf8d6a in jclouds-labs's branch refs/heads/master from andreaturli [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;h=a5dbf00 ] [JCLOUDS-1430] - add more features - add securitygroup-api - add keypair-api - add tag-api - refactor paginations - refactor tagOptions > Aliyun ECS support > -- > > Key: JCLOUDS-1430 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1430 > Project: jclouds > Issue Type: Wish > Components: jclouds-labs >Reporter: Andrea Turli >Assignee: Andrea Turli >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
Closed #441. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#event-1763661946
Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a5dbf006) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409351737
Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
@andreaturli pushed 1 commit. 4547b1b wip -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441/files/f2e09f774d0d5236589bb1d2c075a887f2afaf43..4547b1b80cc47e1cfabac71e8c1747cd075cbc5b
Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)
@alibazlamit I think there are still unaddressed issues. Can you please address them first? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-409300125
Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#pullrequestreview-142069469
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules improvments (#442)
Closed #442. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/442#event-1763379395
Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
squashed and rebased. waiting for the builder to merge it. thanks @nacx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409311478
Re: [jclouds/jclouds-labs] JCLOUDS-1435 1&1 Firewall rules improvments (#442)
Squashed and merged to master as [d74d7f62](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d74d7f62). There were conflicts when cherry-picking to 2.1.x. If you want it backported there please, open a PR against that branch. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/442#issuecomment-409311388
Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)
nacx commented on this pull request.
> @@ -84,7 +84,7 @@ public static TagOptions keys(Set keys) {
private void validateInput(final String input, int maxLength) {
checkNotNull(input);
checkState(input.length() <= maxLength, String.format("input must be <=
%d chars", maxLength));
- checkState(Iterables.any(FORBIDDEN_PREFIX, new Predicate() {
+ checkState(Iterables.contains(FORBIDDEN_PREFIX, new Predicate() {
H If I understand this correctly, it is still not right.
You want to check that the given input **does not** contain any of the
forbidden inputs, right? It should be something like>
```java
checkState(!Iterables.any(FORBIDDEN_PREFIX, new Predicate() {
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#pullrequestreview-142055089
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)
Isn't this the same PR as https://github.com/jclouds/jclouds/pull/1232 but with wrong checkstyle? If i'm right, could you please close this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233#issuecomment-409387225
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)
@danielestevez thanks for the review.. no, this PR is for a different set of instance types (m5) than #1232 (c5) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233#issuecomment-409389750
[jira] [Commented] (JCLOUDS-1436) Add support for m5 instance types in AWS ec2
[ https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564407#comment-16564407 ] Vikas Rangarajan commented on JCLOUDS-1436: --- https://github.com/jclouds/jclouds/pull/1233 > Add support for m5 instance types in AWS ec2 > > > Key: JCLOUDS-1436 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1436 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.3 >Reporter: Vikas Rangarajan >Priority: Major > Labels: aws-ec2 > Fix For: 2.1.0, 2.0.4 > > > As a jclouds client targeting AWS EC2 as one of the deployment cloud > providers, I would like to avail of the newly added m5 instance types that > offer "balance of compute, memory, and networking resources". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1233 -- Commit Summary -- * JCLOUDS-1436: Add support for aws ec2 m5 instance types -- File Changes -- M apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java (72) M apis/ec2/src/main/java/org/jclouds/ec2/domain/InstanceType.java (72) M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/AWSEC2HardwareSupplier.java (14) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1233.patch https://github.com/jclouds/jclouds/pull/1233.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233
Re: [jclouds/jclouds] JCLOUDS-1387: Add support for c5 instance types in AWS ec2 (#1232)
danielestevez approved this pull request. Thanks @VRanga000 the code looks good for those new profiles! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1232#pullrequestreview-142168312
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)
Sorry! Got it now. Please review the checkstyle since it seems to be breaking the build -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233#issuecomment-409394722
[jira] [Updated] (JCLOUDS-1387) Add support for c5 instance types in AWS ec2
[ https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1387: Fix Version/s: (was: 2.1.0) 2.2.0 > Add support for c5 instance types in AWS ec2 > > > Key: JCLOUDS-1387 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1387 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.3 >Reporter: Vikas Rangarajan >Priority: Major > Labels: aws-ec2 > Fix For: 2.2.0, 2.1.1 > > > As a jclouds client targeting AWS EC2 as one of the deployment cloud > providers, I would like to avail of the newly added C5 instance types that > are cpu optimized but more cost-effective than the previous generation C4 > instance types. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCLOUDS-1436) Add support for m5 instance types in AWS ec2
[ https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1436: Fix Version/s: (was: 2.1.1) 2.2.0 > Add support for m5 instance types in AWS ec2 > > > Key: JCLOUDS-1436 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1436 > Project: jclouds > Issue Type: Improvement > Components: jclouds-compute >Affects Versions: 2.0.3 >Reporter: Vikas Rangarajan >Priority: Major > Labels: aws-ec2 > Fix For: 2.1.0, 2.2.0 > > > As a jclouds client targeting AWS EC2 as one of the deployment cloud > providers, I would like to avail of the newly added m5 instance types that > offer "balance of compute, memory, and networking resources". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)
@VRanga000 pushed 1 commit. 97d37f7 fix: remove duplicate imports -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1233/files/9ef582d31af1ea284c6020f80f6463c1c51bb266..97d37f74fb693e5f5f79c444208fac6cfb35aea1
