[jira] [Commented] (LIBCLOUD-910) Not a Gzipped file when using LIBCLOUD_DEBUG

2017-04-05 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958197#comment-15958197
 ] 

ASF subversion and git services commented on LIBCLOUD-910:
--

Commit 4e5ddfbf2ab6c3bbaf7b2092ce3094dff54d5b59 in libcloud's branch 
refs/heads/trunk from [~anthonypjshaw]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=4e5ddfb ]

add test to show LIBCLOUD-910 failure


> Not a Gzipped file when using LIBCLOUD_DEBUG
> 
>
> Key: LIBCLOUD-910
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-910
> Project: Libcloud
>  Issue Type: Bug
>  Components: Core
> Environment: python 2.6, debian jessie
>Reporter: Tom Melendez
>
> ## Summary
> When LIBCLOUD_DEBUG is set, receive a gzip error.  If the call to 
> decompress_data is commented out, things progress fine. 
> Offending line:
>   File "./libcloud/utils/loggingconnection.py", line 71, in _log_response
> body = decompress_data('gzip', body)
> ## Stacktrace
> (libcloud-testing) 
> supertom@supertom:~/virts/libcloud-testing/code/apache-libcloud-2.0.0rc2$ 
> demos/gce_demo.py --compute
> => Compute demo/test start time: 2017-04-05 16:22:58.309187
> DEBUG:requests.packages.urllib3.connectionpool:Starting new HTTPS connection 
> (1): www.googleapis.com
> DEBUG:requests.packages.urllib3.connectionpool:https://www.googleapis.com:443 
> "GET /compute/v1/projects/supertom-graphite/zones HTTP/1.1" 200 None
> /usr/lib/python2.7/gzip.py:196: UnicodeWarning: Unicode unequal comparison 
> failed to convert both arguments to Unicode - interpreting them as being 
> unequal
>   if magic != '\037\213':
> Traceback (most recent call last):
>   File "demos/gce_demo.py", line 957, in 
> main_compute()
>   File "demos/gce_demo.py", line 342, in main_compute
> gce = get_gce_driver()
>   File "demos/gce_demo.py", line 111, in get_gce_driver
> driver = get_driver(Provider.GCE)(*args, **kwargs)
>   File "./libcloud/compute/drivers/gce.py", line 1803, in __init__
> self.zone_list = self.ex_list_zones()
>   File "./libcloud/compute/drivers/gce.py", line 2757, in ex_list_zones
> response = self.connection.request(request, method='GET').object
>   File "./libcloud/compute/drivers/gce.py", line 121, in request
> response = super(GCEConnection, self).request(*args, **kwargs)
>   File "./libcloud/common/google.py", line 806, in request
> *args, **kwargs)
>   File "./libcloud/common/base.py", line 664, in request
> 'response': self.connection.getresponse()}
>   File "./libcloud/utils/loggingconnection.py", line 141, in getresponse
> rv = self._log_response(HttpLibResponseProxy(original_response))
>   File "./libcloud/utils/loggingconnection.py", line 71, in _log_response
> body = decompress_data('gzip', body)
>   File "./libcloud/utils/compression.py", line 39, in decompress_data
> return gzip.GzipFile(fileobj=cls(data)).read()
>   File "/usr/lib/python2.7/gzip.py", line 261, in read
> self._read(readsize)
>   File "/usr/lib/python2.7/gzip.py", line 303, in _read
> self._read_gzip_header()
>   File "/usr/lib/python2.7/gzip.py", line 197, in _read_gzip_header
> raise IOError, 'Not a gzipped file'
> IOError: Not a gzipped file
> ## Steps to reproduce
> export LIBCLOUD_DEBUG=/tmp/gce-libcloud.log
> (set values in demos/secrets.py)
> demos/gce_demo.py --compute



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] libcloud pull request #1025: LIBCLOUD-910 error with LIBCLOUD_DEBUG and comp...

2017-04-05 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1025


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LIBCLOUD-910) Not a Gzipped file when using LIBCLOUD_DEBUG

2017-04-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958195#comment-15958195
 ] 

ASF GitHub Bot commented on LIBCLOUD-910:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1025


> Not a Gzipped file when using LIBCLOUD_DEBUG
> 
>
> Key: LIBCLOUD-910
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-910
> Project: Libcloud
>  Issue Type: Bug
>  Components: Core
> Environment: python 2.6, debian jessie
>Reporter: Tom Melendez
>
> ## Summary
> When LIBCLOUD_DEBUG is set, receive a gzip error.  If the call to 
> decompress_data is commented out, things progress fine. 
> Offending line:
>   File "./libcloud/utils/loggingconnection.py", line 71, in _log_response
> body = decompress_data('gzip', body)
> ## Stacktrace
> (libcloud-testing) 
> supertom@supertom:~/virts/libcloud-testing/code/apache-libcloud-2.0.0rc2$ 
> demos/gce_demo.py --compute
> => Compute demo/test start time: 2017-04-05 16:22:58.309187
> DEBUG:requests.packages.urllib3.connectionpool:Starting new HTTPS connection 
> (1): www.googleapis.com
> DEBUG:requests.packages.urllib3.connectionpool:https://www.googleapis.com:443 
> "GET /compute/v1/projects/supertom-graphite/zones HTTP/1.1" 200 None
> /usr/lib/python2.7/gzip.py:196: UnicodeWarning: Unicode unequal comparison 
> failed to convert both arguments to Unicode - interpreting them as being 
> unequal
>   if magic != '\037\213':
> Traceback (most recent call last):
>   File "demos/gce_demo.py", line 957, in 
> main_compute()
>   File "demos/gce_demo.py", line 342, in main_compute
> gce = get_gce_driver()
>   File "demos/gce_demo.py", line 111, in get_gce_driver
> driver = get_driver(Provider.GCE)(*args, **kwargs)
>   File "./libcloud/compute/drivers/gce.py", line 1803, in __init__
> self.zone_list = self.ex_list_zones()
>   File "./libcloud/compute/drivers/gce.py", line 2757, in ex_list_zones
> response = self.connection.request(request, method='GET').object
>   File "./libcloud/compute/drivers/gce.py", line 121, in request
> response = super(GCEConnection, self).request(*args, **kwargs)
>   File "./libcloud/common/google.py", line 806, in request
> *args, **kwargs)
>   File "./libcloud/common/base.py", line 664, in request
> 'response': self.connection.getresponse()}
>   File "./libcloud/utils/loggingconnection.py", line 141, in getresponse
> rv = self._log_response(HttpLibResponseProxy(original_response))
>   File "./libcloud/utils/loggingconnection.py", line 71, in _log_response
> body = decompress_data('gzip', body)
>   File "./libcloud/utils/compression.py", line 39, in decompress_data
> return gzip.GzipFile(fileobj=cls(data)).read()
>   File "/usr/lib/python2.7/gzip.py", line 261, in read
> self._read(readsize)
>   File "/usr/lib/python2.7/gzip.py", line 303, in _read
> self._read_gzip_header()
>   File "/usr/lib/python2.7/gzip.py", line 197, in _read_gzip_header
> raise IOError, 'Not a gzipped file'
> IOError: Not a gzipped file
> ## Steps to reproduce
> export LIBCLOUD_DEBUG=/tmp/gce-libcloud.log
> (set values in demos/secrets.py)
> demos/gce_demo.py --compute



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[2/4] libcloud git commit: add fix by removing inline decoding in the library

2017-04-05 Thread anthonyshaw 
add fix by removing inline decoding in the library


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/a4830d2d
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/a4830d2d
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/a4830d2d

Branch: refs/heads/trunk
Commit: a4830d2d34ea1d08e0c715ec9ea50733e4a8a78a
Parents: 4e5ddfb
Author: Anthony Shaw 
Authored: Thu Apr 6 11:35:50 2017 +1000
Committer: Anthony Shaw 
Committed: Thu Apr 6 11:35:50 2017 +1000

--
 libcloud/test/test_logging_connection.py | 4 ++--
 libcloud/utils/loggingconnection.py  | 6 --
 2 files changed, 2 insertions(+), 8 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/a4830d2d/libcloud/test/test_logging_connection.py
--
diff --git a/libcloud/test/test_logging_connection.py 
b/libcloud/test/test_logging_connection.py
index ed1fc5a..c1dbee6 100644
--- a/libcloud/test/test_logging_connection.py
+++ b/libcloud/test/test_logging_connection.py
@@ -52,19 +52,19 @@ class TestLoggingConnection(unittest.TestCase):
 self.assertIn('data', log)
 
 def test_debug_log_class_handles_request_with_compression(self):
+request = zlib.compress(b'data')
 with StringIO() as fh:
 libcloud.enable_debug(fh)
 conn = Connection(url='http://test.com/')
 conn.connect()
 self.assertEqual(conn.connection.host, 'http://test.com')
 with requests_mock.mock() as m:
-m.get('http://test.com/test', content=zlib.compress(b'test'),
+m.get('http://test.com/test', content=request,
   headers={'content-encoding': 'zlib'})
 conn.request('/test')
 log = fh.getvalue()
 self.assertTrue(isinstance(conn.connection, LoggingConnection))
 self.assertIn('-i -X GET', log)
-self.assertIn('data', log)
 
 if __name__ == '__main__':
 sys.exit(unittest.main())

http://git-wip-us.apache.org/repos/asf/libcloud/blob/a4830d2d/libcloud/utils/loggingconnection.py
--
diff --git a/libcloud/utils/loggingconnection.py 
b/libcloud/utils/loggingconnection.py
index 1e3ff41..7756b13 100644
--- a/libcloud/utils/loggingconnection.py
+++ b/libcloud/utils/loggingconnection.py
@@ -62,14 +62,8 @@ class LoggingConnection(LibcloudConnection):
 
 headers = lowercase_keys(dict(r.getheaders()))
 
-encoding = headers.get('content-encoding', None)
 content_type = headers.get('content-type', None)
 
-if encoding in ['zlib', 'deflate']:
-body = decompress_data('zlib', body)
-elif encoding in ['gzip', 'x-gzip']:
-body = decompress_data('gzip', body)
-
 pretty_print = os.environ.get('LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE',
   False)

[1/4] libcloud git commit: add test to show LIBCLOUD-910 failure

2017-04-05 Thread anthonyshaw 
Repository: libcloud
Updated Branches:
  refs/heads/trunk fce25cd6a -> f6aaee21b


add test to show LIBCLOUD-910 failure


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/4e5ddfbf
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/4e5ddfbf
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/4e5ddfbf

Branch: refs/heads/trunk
Commit: 4e5ddfbf2ab6c3bbaf7b2092ce3094dff54d5b59
Parents: c62d7c9
Author: Anthony Shaw 
Authored: Thu Apr 6 11:16:32 2017 +1000
Committer: Anthony Shaw 
Committed: Thu Apr 6 11:16:32 2017 +1000

--
 libcloud/test/test_logging_connection.py | 17 +
 1 file changed, 17 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/4e5ddfbf/libcloud/test/test_logging_connection.py
--
diff --git a/libcloud/test/test_logging_connection.py 
b/libcloud/test/test_logging_connection.py
index e7088a4..ed1fc5a 100644
--- a/libcloud/test/test_logging_connection.py
+++ b/libcloud/test/test_logging_connection.py
@@ -15,11 +15,13 @@
 
 import sys
 from io import StringIO
+import zlib
 import requests_mock
 
 import libcloud
 from libcloud.test import unittest
 from libcloud.common.base import Connection
+from libcloud.utils.py3 import b
 from libcloud.httplib_ssl import LibcloudConnection
 from libcloud.utils.loggingconnection import LoggingConnection
 
@@ -49,5 +51,20 @@ class TestLoggingConnection(unittest.TestCase):
 self.assertIn('-i -X GET', log)
 self.assertIn('data', log)
 
+def test_debug_log_class_handles_request_with_compression(self):
+with StringIO() as fh:
+libcloud.enable_debug(fh)
+conn = Connection(url='http://test.com/')
+conn.connect()
+self.assertEqual(conn.connection.host, 'http://test.com')
+with requests_mock.mock() as m:
+m.get('http://test.com/test', content=zlib.compress(b'test'),
+  headers={'content-encoding': 'zlib'})
+conn.request('/test')
+log = fh.getvalue()
+self.assertTrue(isinstance(conn.connection, LoggingConnection))
+self.assertIn('-i -X GET', log)
+self.assertIn('data', log)
+
 if __name__ == '__main__':
 sys.exit(unittest.main())

[4/4] libcloud git commit: Merge branch 'trunk' into libcloud_910

2017-04-05 Thread anthonyshaw 
Merge branch 'trunk' into libcloud_910


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/f6aaee21
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/f6aaee21
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/f6aaee21

Branch: refs/heads/trunk
Commit: f6aaee21b5adc1e4bfef412062962966d2439f32
Parents: 1fd49ed fce25cd
Author: Anthony Shaw 
Authored: Thu Apr 6 12:07:42 2017 +1000
Committer: Anthony Shaw 
Committed: Thu Apr 6 12:07:42 2017 +1000

--
 CHANGES.rst   |  4 
 libcloud/common/linode.py | 25 ++---
 2 files changed, 6 insertions(+), 23 deletions(-)
--

[1/3] libcloud git commit: remove weird __init__ code from the linode response class, use super

2017-04-05 Thread anthonyshaw 
Repository: libcloud
Updated Branches:
  refs/heads/trunk c62d7c9d6 -> fce25cd6a


remove weird __init__ code from the linode response class, use super


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/af5b3b80
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/af5b3b80
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/af5b3b80

Branch: refs/heads/trunk
Commit: af5b3b8044eeff10ef119db5a3852d171aedc2bd
Parents: c62d7c9
Author: Anthony Shaw 
Authored: Thu Apr 6 11:58:35 2017 +1000
Committer: Anthony Shaw 
Committed: Thu Apr 6 11:58:35 2017 +1000

--
 libcloud/common/linode.py | 22 ++
 1 file changed, 2 insertions(+), 20 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/af5b3b80/libcloud/common/linode.py
--
diff --git a/libcloud/common/linode.py b/libcloud/common/linode.py
index c991695..8abafb6 100644
--- a/libcloud/common/linode.py
+++ b/libcloud/common/linode.py
@@ -82,26 +82,8 @@ class LinodeResponse(JsonResponse):
 
 :keyword response: The raw response returned by urllib
 :return: parsed :class:`LinodeResponse`"""
-
-self.connection = connection
-
-self.headers = dict(response.getheaders())
-self.error = response.reason
-self.status = response.status
-
-# This attribute is set when using LoggingConnection.
-original_data = getattr(response, '_original_data', None)
-
-if original_data:
-# LoggingConnection already decompresses data so it can log it
-# which means we don't need to decompress it here.
-self.body = response._original_data
-else:
-self.body = self._decompress_response(body=response.read(),
-  headers=self.headers)
-
-if PY3:
-self.body = b(self.body).decode('utf-8')
+self.errors = []
+super(LinodeResponse, self).__init__(response, connection)
 
 self.invalid = LinodeException(0xFF,
"Invalid JSON received from server")

[3/3] libcloud git commit: changes for #1026

2017-04-05 Thread anthonyshaw 
changes for #1026


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/fce25cd6
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/fce25cd6
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/fce25cd6

Branch: refs/heads/trunk
Commit: fce25cd6ae2cfcbeb2614b47994a7f4df50c9a04
Parents: 2ed37b3
Author: Anthony Shaw 
Authored: Thu Apr 6 12:07:17 2017 +1000
Committer: Anthony Shaw 
Committed: Thu Apr 6 12:07:17 2017 +1000

--
 CHANGES.rst | 4 
 1 file changed, 4 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/fce25cd6/CHANGES.rst
--
diff --git a/CHANGES.rst b/CHANGES.rst
index 07b992b..f2b1c5f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -12,6 +12,10 @@ Common
   [GITHUB-970]
   (Anthony Shaw)
 
+- Fix for Linode classes since 2.0x
+  [GITHUB-1026]
+  (Anthony Shaw)
+
 Compute
 ~~~

[2/3] libcloud git commit: remove unused imports

2017-04-05 Thread anthonyshaw 
remove unused imports


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/2ed37b31
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/2ed37b31
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/2ed37b31

Branch: refs/heads/trunk
Commit: 2ed37b31588a769f6fa15bc8b9b3c694522a0e9a
Parents: af5b3b8
Author: Anthony Shaw 
Authored: Thu Apr 6 12:01:03 2017 +1000
Committer: Anthony Shaw 
Committed: Thu Apr 6 12:01:03 2017 +1000

--
 libcloud/common/linode.py | 3 ---
 1 file changed, 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/2ed37b31/libcloud/common/linode.py
--
diff --git a/libcloud/common/linode.py b/libcloud/common/linode.py
index 8abafb6..7c120e3 100644
--- a/libcloud/common/linode.py
+++ b/libcloud/common/linode.py
@@ -16,9 +16,6 @@
 from libcloud.common.base import ConnectionKey, JsonResponse
 from libcloud.common.types import InvalidCredsError
 
-from libcloud.utils.py3 import PY3
-from libcloud.utils.py3 import b
-
 __all__ = [
 'API_HOST',
 'API_ROOT',

[GitHub] libcloud pull request #1026: Fix Linode for 2.0x

2017-04-05 Thread tonybaloney 
GitHub user tonybaloney opened a pull request:

https://github.com/apache/libcloud/pull/1026

Fix Linode for 2.0x 

Changes in #1025 highlighted a problem with the Linode response class.

It has a lot of copy+paste from the Response `__init__` and no call to 
super. This looks related to some legacy code but its a common anti-pattern.


https://github.com/apache/libcloud/commit/fe72fc13a131b446e1f18cd22005f9c8fd03ce79

This changeset removes the duplicate (but now broken) code and calls 
`super` correctly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tonybaloney/libcloud linode_problems

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1026.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1026


commit af5b3b8044eeff10ef119db5a3852d171aedc2bd
Author: Anthony Shaw 
Date:   2017-04-06T01:58:35Z

remove weird __init__ code from the linode response class, use super

commit 2ed37b31588a769f6fa15bc8b9b3c694522a0e9a
Author: Anthony Shaw 
Date:   2017-04-06T02:01:03Z

remove unused imports




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LIBCLOUD-910) Not a Gzipped file when using LIBCLOUD_DEBUG

2017-04-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958139#comment-15958139
 ] 

ASF GitHub Bot commented on LIBCLOUD-910:
-

GitHub user tonybaloney opened a pull request:

https://github.com/apache/libcloud/pull/1025

LIBCLOUD-910 error with LIBCLOUD_DEBUG and compressed responses

As reported in LIBCLOUD-910, the loggingconnection, used with 
`LIBCLOUD_DEBUG` is enabled still inspects the `content-encoding` header and 
tries to decode the responses.

`requests` handles this via `urllib3` which has inbuilt decompression so 
this entire code block and module is not needed.

- [ ] provide test
- [ ] Fix issue
- [ ] check test


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tonybaloney/libcloud libcloud_910

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1025


commit 4e5ddfbf2ab6c3bbaf7b2092ce3094dff54d5b59
Author: Anthony Shaw 
Date:   2017-04-06T01:16:32Z

add test to show LIBCLOUD-910 failure




> Not a Gzipped file when using LIBCLOUD_DEBUG
> 
>
> Key: LIBCLOUD-910
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-910
> Project: Libcloud
>  Issue Type: Bug
>  Components: Core
> Environment: python 2.6, debian jessie
>Reporter: Tom Melendez
>
> ## Summary
> When LIBCLOUD_DEBUG is set, receive a gzip error.  If the call to 
> decompress_data is commented out, things progress fine. 
> Offending line:
>   File "./libcloud/utils/loggingconnection.py", line 71, in _log_response
> body = decompress_data('gzip', body)
> ## Stacktrace
> (libcloud-testing) 
> supertom@supertom:~/virts/libcloud-testing/code/apache-libcloud-2.0.0rc2$ 
> demos/gce_demo.py --compute
> => Compute demo/test start time: 2017-04-05 16:22:58.309187
> DEBUG:requests.packages.urllib3.connectionpool:Starting new HTTPS connection 
> (1): www.googleapis.com
> DEBUG:requests.packages.urllib3.connectionpool:https://www.googleapis.com:443 
> "GET /compute/v1/projects/supertom-graphite/zones HTTP/1.1" 200 None
> /usr/lib/python2.7/gzip.py:196: UnicodeWarning: Unicode unequal comparison 
> failed to convert both arguments to Unicode - interpreting them as being 
> unequal
>   if magic != '\037\213':
> Traceback (most recent call last):
>   File "demos/gce_demo.py", line 957, in 
> main_compute()
>   File "demos/gce_demo.py", line 342, in main_compute
> gce = get_gce_driver()
>   File "demos/gce_demo.py", line 111, in get_gce_driver
> driver = get_driver(Provider.GCE)(*args, **kwargs)
>   File "./libcloud/compute/drivers/gce.py", line 1803, in __init__
> self.zone_list = self.ex_list_zones()
>   File "./libcloud/compute/drivers/gce.py", line 2757, in ex_list_zones
> response = self.connection.request(request, method='GET').object
>   File "./libcloud/compute/drivers/gce.py", line 121, in request
> response = super(GCEConnection, self).request(*args, **kwargs)
>   File "./libcloud/common/google.py", line 806, in request
> *args, **kwargs)
>   File "./libcloud/common/base.py", line 664, in request
> 'response': self.connection.getresponse()}
>   File "./libcloud/utils/loggingconnection.py", line 141, in getresponse
> rv = self._log_response(HttpLibResponseProxy(original_response))
>   File "./libcloud/utils/loggingconnection.py", line 71, in _log_response
> body = decompress_data('gzip', body)
>   File "./libcloud/utils/compression.py", line 39, in decompress_data
> return gzip.GzipFile(fileobj=cls(data)).read()
>   File "/usr/lib/python2.7/gzip.py", line 261, in read
> self._read(readsize)
>   File "/usr/lib/python2.7/gzip.py", line 303, in _read
> self._read_gzip_header()
>   File "/usr/lib/python2.7/gzip.py", line 197, in _read_gzip_header
> raise IOError, 'Not a gzipped file'
> IOError: Not a gzipped file
> ## Steps to reproduce
> export LIBCLOUD_DEBUG=/tmp/gce-libcloud.log
> (set values in demos/secrets.py)
> demos/gce_demo.py --compute



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] libcloud pull request #1025: LIBCLOUD-910 error with LIBCLOUD_DEBUG and comp...

2017-04-05 Thread tonybaloney 
GitHub user tonybaloney opened a pull request:

https://github.com/apache/libcloud/pull/1025

LIBCLOUD-910 error with LIBCLOUD_DEBUG and compressed responses

As reported in LIBCLOUD-910, the loggingconnection, used with 
`LIBCLOUD_DEBUG` is enabled still inspects the `content-encoding` header and 
tries to decode the responses.

`requests` handles this via `urllib3` which has inbuilt decompression so 
this entire code block and module is not needed.

- [ ] provide test
- [ ] Fix issue
- [ ] check test


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tonybaloney/libcloud libcloud_910

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1025


commit 4e5ddfbf2ab6c3bbaf7b2092ce3094dff54d5b59
Author: Anthony Shaw 
Date:   2017-04-06T01:16:32Z

add test to show LIBCLOUD-910 failure




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #1024: Added Billing Product for image in EC2 compute ...

2017-04-05 Thread nirzari 
GitHub user nirzari opened a pull request:

https://github.com/apache/libcloud/pull/1024

Added Billing Product for image in EC2 compute driver

## Added Billing Product for image in EC2 compute driver

### Description
Added Billing Product param for register image method in EC2 compute driver

### Status
- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nirzari/libcloud billing-product

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1024


commit 660dc0d9b951a498f036413d7495bb8fcc5ae865
Author: Nirzari Iyer 
Date:   2017-02-24T22:39:52Z

Added Billing Product for image in EC2 compute driver




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #1023: Added Import Snapshot and Describe Import Snaps...

2017-04-05 Thread nirzari 
GitHub user nirzari opened a pull request:

https://github.com/apache/libcloud/pull/1023

Added Import Snapshot and Describe Import Snapshot to EC2 compute driver

## Added Import Snapshot and Describe Import Snapshot to EC2 compute driver

### Description

On Importing Snapshot in aws, it returns the import snapshot task which 
needs to be monitored by describe import snapshot task until it is ready. 
Hence, added a wait block method. Finally, it returns a volume snapshot.  

### Status
- done, ready for review

### Checklist (tick everything that applies)

- [ x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [ x] Documentation
- [ x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nirzari/libcloud import-snapshot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1023


commit fa3d73cdd5bed23802e63f0a00dcf6014a1e9272
Author: Nirzari Iyer 
Date:   2017-02-14T19:36:41Z

Added Import Snapshot and Describe Import Snapshot to EC2 compute driver




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---