[jira] [Commented] (LIBCLOUD-951) Add possibility to define hostname to UpCloud driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194154#comment-16194154
 ] 

ASF GitHub Bot commented on LIBCLOUD-951:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1123


> Add possibility to define hostname to UpCloud driver
> 
>
> Key: LIBCLOUD-951
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-951
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Add way to define hostname



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] libcloud pull request #1123: [LIBCLOUD-951] Add possibility to define hostna...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1123


---

[2/2] libcloud git commit: Add changes for #1123

[quentinp]

Add changes for #1123


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/4fef3b53
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/4fef3b53
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/4fef3b53

Branch: refs/heads/trunk
Commit: 4fef3b5391f413df82f51ca9fc668420da43628a
Parents: f2e0d33
Author: Quentin Pradet 
Authored: Fri Oct 6 09:21:20 2017 +0400
Committer: Quentin Pradet 
Committed: Fri Oct 6 09:21:20 2017 +0400

--
 CHANGES.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/4fef3b53/CHANGES.rst
--
diff --git a/CHANGES.rst b/CHANGES.rst
index 6ab3db6..a61b90b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,7 +7,7 @@ Changes in Apach Libcloud in development
 Compute
 ~~~
 
-- New driver for UpCloud (LIBCLOUD-938, GITHUB-1102)
+- New driver for UpCloud (LIBCLOUD-938, LIBCLOUD-951, GITHUB-1102, GITHUB-1123)
   [Mika Lackman, Ilari Mäkelä]
 
 - [EC2] Add new x1.16xlarge and x1e.32xlarge instance type. (GITHUB-1101)

[1/2] libcloud git commit: upcloud driver to take ex_hostname parameter for defining hostname

[quentinp]

Repository: libcloud
Updated Branches:
  refs/heads/trunk ce5d3be4d -> 4fef3b539


upcloud driver to take ex_hostname parameter for defining hostname

Closes #1123

Signed-off-by: Quentin Pradet 


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/f2e0d33a
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/f2e0d33a
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/f2e0d33a

Branch: refs/heads/trunk
Commit: f2e0d33a4c01e9cbaaf9e3221f5d658dcf12e837
Parents: ce5d3be
Author: Mika Lackman 
Authored: Thu Oct 5 19:34:30 2017 +0300
Committer: Quentin Pradet 
Committed: Fri Oct 6 09:16:32 2017 +0400

--
 libcloud/common/upcloud.py|  8 ++--
 libcloud/compute/drivers/upcloud.py   |  6 +-
 libcloud/test/common/test_upcloud.py  | 32 ++
 libcloud/test/compute/test_upcloud.py |  2 +-
 4 files changed, 44 insertions(+), 4 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/libcloud/blob/f2e0d33a/libcloud/common/upcloud.py
--
diff --git a/libcloud/common/upcloud.py b/libcloud/common/upcloud.py
index b824664..64f844e 100644
--- a/libcloud/common/upcloud.py
+++ b/libcloud/common/upcloud.py
@@ -49,13 +49,17 @@ class UpcloudCreateNodeRequestBody(object):
 (optional)
 :type   auth: :class:`.NodeAuthSSHKey`
 
+:param  ex_hostname: Hostname. Default is 'localhost'. (optional)
+:type   ex_hostname: ``str``
+
 """
 
-def __init__(self, user_id, name, size, image, location, auth=None):
+def __init__(self, user_id, name, size, image, location, auth=None,
+ **kwargs):
 self.body = {
 'server': {
 'title': name,
-'hostname': 'localhost',
+'hostname': kwargs.get('ex_hostname', 'localhost'),
 'plan': size.id,
 'zone': location.id,
 'login_user': _LoginUser(user_id, auth).to_dict(),

http://git-wip-us.apache.org/repos/asf/libcloud/blob/f2e0d33a/libcloud/compute/drivers/upcloud.py
--
diff --git a/libcloud/compute/drivers/upcloud.py 
b/libcloud/compute/drivers/upcloud.py
index c9c762e..5652a3d 100644
--- a/libcloud/compute/drivers/upcloud.py
+++ b/libcloud/compute/drivers/upcloud.py
@@ -151,12 +151,16 @@ class UpcloudDriver(NodeDriver):
 (optional)
 :type auth:   :class:`.NodeAuthSSHKey`
 
+:param ex_hostname: Hostname. Default is 'localhost'. (optional)
+:type ex_hostname: ``str``
+
 :return: The newly created node.
 :rtype: :class:`.Node`
 """
 body = UpcloudCreateNodeRequestBody(user_id=self.connection.user_id,
 name=name, size=size, image=image,
-location=location, auth=auth)
+location=location, auth=auth,
+**kwargs)
 response = self.connection.request('1.2/server',
method='POST',
data=body.to_json())

http://git-wip-us.apache.org/repos/asf/libcloud/blob/f2e0d33a/libcloud/test/common/test_upcloud.py
--
diff --git a/libcloud/test/common/test_upcloud.py 
b/libcloud/test/common/test_upcloud.py
index 2df8213..bfa2b89 100644
--- a/libcloud/test/common/test_upcloud.py
+++ b/libcloud/test/common/test_upcloud.py
@@ -133,6 +133,38 @@ class TestUpcloudCreateNodeRequestBody(unittest.TestCase):
 }
 self.assertDictEqual(expected_body, dict_body)
 
+def test_creating_node_using_hostname(self):
+image = NodeImage(id='0100--4000-8000-30060200',
+  name='Ubuntu Server 16.04 LTS (Xenial Xerus)',
+  driver='',
+  extra={'type': 'template'})
+location = NodeLocation(id='fi-hel1', name='Helsinki #1', 
country='FI', driver='')
+size = NodeSize(id='1xCPU-1GB', name='1xCPU-1GB', ram=1024, disk=30, 
bandwidth=2048,
+extra={'core_number': 1, 'storage_tier': 'maxiops'}, 
price=None, driver='')
+
+body = UpcloudCreateNodeRequestBody(user_id='somename', name='ts', 
image=image, location=location, size=size,
+ex_hostname='myhost.upcloud.com')
+json_body = body.to_json()
+dict_body = json.loads(json_body)
+expected_body = {
+'server': {
+  

[GitHub] libcloud pull request #1123: [LIBCLOUD-951] Add possibility to define hostna...

[mlackman]

GitHub user mlackman reopened a pull request:

https://github.com/apache/libcloud/pull/1123

[LIBCLOUD-951] Add possibility to define hostname to UpCloud driver

## UpCloud driver to support defining hostname

### Description

Added ex_hostname to UpcloudDriver create_node method to define the 
hostname.

### Status

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/UpCloudLtd/libcloud 
LIBCLOUD-951_Add_possibility_to_define_hostname_to_UpCloud_driver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1123


commit ba34061871224ac210a1fcaa2d2d63b7ab74965e
Author: Mika Lackman 
Date:   2017-10-05T16:34:30Z

upcloud driver to take ex_hostname parameter for defining hostname




---

[jira] [Commented] (LIBCLOUD-951) Add possibility to define hostname to UpCloud driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194145#comment-16194145
 ] 

ASF GitHub Bot commented on LIBCLOUD-951:
-

GitHub user mlackman reopened a pull request:

https://github.com/apache/libcloud/pull/1123

[LIBCLOUD-951] Add possibility to define hostname to UpCloud driver

## UpCloud driver to support defining hostname

### Description

Added ex_hostname to UpcloudDriver create_node method to define the 
hostname.

### Status

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/UpCloudLtd/libcloud 
LIBCLOUD-951_Add_possibility_to_define_hostname_to_UpCloud_driver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1123


commit ba34061871224ac210a1fcaa2d2d63b7ab74965e
Author: Mika Lackman 
Date:   2017-10-05T16:34:30Z

upcloud driver to take ex_hostname parameter for defining hostname




> Add possibility to define hostname to UpCloud driver
> 
>
> Key: LIBCLOUD-951
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-951
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Add way to define hostname



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-951) Add possibility to define hostname to UpCloud driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194144#comment-16194144
 ] 

ASF GitHub Bot commented on LIBCLOUD-951:
-

Github user mlackman closed the pull request at:

https://github.com/apache/libcloud/pull/1123


> Add possibility to define hostname to UpCloud driver
> 
>
> Key: LIBCLOUD-951
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-951
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Add way to define hostname



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] libcloud pull request #1123: [LIBCLOUD-951] Add possibility to define hostna...

[mlackman]

Github user mlackman closed the pull request at:

https://github.com/apache/libcloud/pull/1123


---

[jira] [Commented] (LIBCLOUD-951) Add possibility to define hostname to UpCloud driver

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193203#comment-16193203
 ] 

ASF GitHub Bot commented on LIBCLOUD-951:
-

GitHub user mlackman opened a pull request:

https://github.com/apache/libcloud/pull/1123

[LIBCLOUD-951] Add possibility to define hostname to UpCloud driver

## UpCloud driver to support defining hostname

### Description

Added ex_hostname to UpcloudDriver create_node method to define the 
hostname.

### Status

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/UpCloudLtd/libcloud 
LIBCLOUD-951_Add_possibility_to_define_hostname_to_UpCloud_driver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1123


commit ba34061871224ac210a1fcaa2d2d63b7ab74965e
Author: Mika Lackman 
Date:   2017-10-05T16:34:30Z

upcloud driver to take ex_hostname parameter for defining hostname




> Add possibility to define hostname to UpCloud driver
> 
>
> Key: LIBCLOUD-951
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-951
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Add way to define hostname



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] libcloud pull request #1123: [LIBCLOUD-951] Add possibility to define hostna...

[mlackman]

GitHub user mlackman opened a pull request:

https://github.com/apache/libcloud/pull/1123

[LIBCLOUD-951] Add possibility to define hostname to UpCloud driver

## UpCloud driver to support defining hostname

### Description

Added ex_hostname to UpcloudDriver create_node method to define the 
hostname.

### Status

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/UpCloudLtd/libcloud 
LIBCLOUD-951_Add_possibility_to_define_hostname_to_UpCloud_driver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1123


commit ba34061871224ac210a1fcaa2d2d63b7ab74965e
Author: Mika Lackman 
Date:   2017-10-05T16:34:30Z

upcloud driver to take ex_hostname parameter for defining hostname




---

[jira] [Updated] (LIBCLOUD-951) Add possibility to define hostname to UpCloud driver

[Mika Lackman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LIBCLOUD-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mika Lackman updated LIBCLOUD-951:
--
Summary: Add possibility to define hostname to UpCloud driver  (was: 
UpCloud, Possibility to define hostname)

> Add possibility to define hostname to UpCloud driver
> 
>
> Key: LIBCLOUD-951
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-951
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Add way to define hostname



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (LIBCLOUD-948) Add missing UpCloud provider to compute/providers

[Mika Lackman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LIBCLOUD-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mika Lackman closed LIBCLOUD-948.
-
Resolution: Fixed

Merged PR: https://github.com/apache/libcloud/pull/1119

> Add missing UpCloud provider to compute/providers
> -
>
> Key: LIBCLOUD-948
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-948
> Project: Libcloud
>  Issue Type: Bug
>  Components: Compute
>Reporter: Mika Lackman
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-948) Add missing UpCloud provider to compute/providers

[Mika Lackman (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193154#comment-16193154
 ] 

Mika Lackman commented on LIBCLOUD-948:
---

This has been resolved with merged PR: 
https://github.com/apache/libcloud/pull/1119

> Add missing UpCloud provider to compute/providers
> -
>
> Key: LIBCLOUD-948
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-948
> Project: Libcloud
>  Issue Type: Bug
>  Components: Compute
>Reporter: Mika Lackman
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LIBCLOUD-951) UpCloud, Possibility to define hostname

[Mika Lackman (JIRA)]

Mika Lackman created LIBCLOUD-951:
-

 Summary: UpCloud, Possibility to define hostname
 Key: LIBCLOUD-951
 URL: https://issues.apache.org/jira/browse/LIBCLOUD-951
 Project: Libcloud
  Issue Type: Improvement
  Components: Compute
Reporter: Mika Lackman


Add way to define hostname



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] libcloud pull request #1122: Add description to ex_authorize_security_group_...

[r2ronoha]

GitHub user r2ronoha opened a pull request:

https://github.com/apache/libcloud/pull/1122

Add description to ex_authorize_security_group_ingress (same for all …

…cidrIps)

## Changes Title (replace this with a logical title for your changes)

### Description

Replace this with the PR description (mention the changes you have made, why
you have made them, provide some background and any references to the 
provider
documentation if needed, etc.).

For more information on contributing, please see 
[Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.

### Status

Replace this: describe the PR status. Examples:

- work in progress
- done, ready for review

### Checklist (tick everything that applies)

- [ ] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r2ronoha/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1122


commit ed486e6c6a60abe338b365190f8b74a6954f
Author: Arturo Noha 
Date:   2017-10-05T09:58:46Z

Add description to ex_authorize_security_group_ingress (same for all 
cidrIps)




---

[GitHub] libcloud pull request #1121: Scaleway Rebased

[danhunsaker]

GitHub user danhunsaker opened a pull request:

https://github.com/apache/libcloud/pull/1121

Scaleway Rebased

Revisiting #777 by rebasing it against the latest `trunk`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nanobox-io/libcloud scaleway

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1121


commit 77165f1a9b7407f21e466513bdb1eed07639f074
Author: Nandor Kracser 
Date:   2016-04-17T10:44:43Z

Scaleway Compute Driver

commit ec20a6803c24c372c9211b8a21493d2948b983d4
Author: Nandor Kracser 
Date:   2016-06-15T17:54:18Z

Replace Scaleway logo

commit 4daf317a70c5b3022653548bdb510890144111a8
Author: Nandor Kracser 
Date:   2016-10-02T08:32:06Z

Remove double slashes

commit e5538fb1fd835ec3f926f41817921150fbc7e5eb
Author: Nandor Kracser 
Date:   2016-10-02T08:33:05Z

Fix private_ips access




---

[jira] [Commented] (LIBCLOUD-950) Add description to ex_authorize_security_group_ingress

[Quentin Pradet (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192726#comment-16192726
 ] 

Quentin Pradet commented on LIBCLOUD-950:
-

Thank you Arturo for your interest in libcloud and your proposed improvement. 
Can you please open a pull request on GitHub? Thanks!

> Add description to ex_authorize_security_group_ingress
> --
>
> Key: LIBCLOUD-950
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-950
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Libcloud REST
>Reporter: Arturo Noha
>Priority: Minor
>  Labels: ec2, security-groups
>
> We are using libcloud to automate our interaction with our cloud provider.
> We have started doing some work with AWS security groups, and it'd be useful 
> to us to be able to add a description to the ingress rules.
> I made a couple of small changes (see below) to be able to add a description 
> (optional)
> https://github.com/r2ronoha/libcloud/commit/ed486e6c6a60abe338b365190f8b74a6954f
> This could be improve for more granularity but I think it's a starting point



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LIBCLOUD-950) Add description to ex_authorize_security_group_ingress

[Arturo Noha (JIRA)]

Arturo Noha created LIBCLOUD-950:


 Summary: Add description to ex_authorize_security_group_ingress
 Key: LIBCLOUD-950
 URL: https://issues.apache.org/jira/browse/LIBCLOUD-950
 Project: Libcloud
  Issue Type: Improvement
  Components: Libcloud REST
Reporter: Arturo Noha
Priority: Minor


We are using libcloud to automate our interaction with our cloud provider.
We have started doing some work with AWS security groups, and it'd be useful to 
us to be able to add a description to the ingress rules.
I made a couple of small changes (see below) to be able to add a description 
(optional)
https://github.com/r2ronoha/libcloud/commit/ed486e6c6a60abe338b365190f8b74a6954f

This could be improve for more granularity but I think it's a starting point



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)