[GitHub] libcloud pull request #1153: fix path for profitbricks list_snapshots() meth...
GitHub user thehunmonkgroup opened a pull request: https://github.com/apache/libcloud/pull/1153 fix path for profitbricks list_snapshots() method ## Fix path for profitbricks compute driver ```list_snapshots``` method ### Description The leading slash breaks the URL in this method. With it, I get: ``` Traceback (most recent call last): File "./profitbricks.py", line 38, in snapshots = driver.list_snapshots() File "/usr/lib/python2.7/dist-packages/libcloud/compute/drivers/profitbricks.py", line 1176, in list_snapshots method='GET' File "/usr/lib/python2.7/dist-packages/libcloud/compute/drivers/profitbricks.py", line 143, in request raw=raw File "/usr/lib/python2.7/dist-packages/libcloud/common/base.py", line 871, in request response = responseCls(**kwargs) File "/usr/lib/python2.7/dist-packages/libcloud/common/base.py", line 180, in __init__ headers=self.headers) libcloud.common.exceptions.BaseHTTPError ``` Removing the slash makes the method work again, and it's in line with the format of the other API requests in the driver that omit the full URL. ### Status - done, ready for review ### Checklist (tick everything that applies) - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/stirlab/libcloud fix-profitbricks-list-snapshots Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1153 commit 7b2dc78d178240e8605f34b6121049edca50bc2b Author: Chad Phillips Date: 2017-12-12T03:37:56Z fix path for profitbricks list_snapshots() method leading slash breaks the URL ---
[GitHub] libcloud pull request #1152: [LIBCLOUD-969] Add pricing information to UpClo...
GitHub user mlackman opened a pull request: https://github.com/apache/libcloud/pull/1152 [LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes ## Changes Title (replace this with a logical title for your changes) ### Description UpCloud's driver were missing the pricing information from list_sizes return values. Added the information to NodeSize.extra data, because pricing zone specific. ### Status Replace this: describe the PR status. Examples: - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [x] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/UpCloudLtd/libcloud LIBCLOUD-969_Add_pricing_information_to_Upcloud_driver_list_sizes_method Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1152 commit 39c2721ef04e1a9eab0161e744df263d4d09770a Author: Mika Lackman Date: 2017-12-11T09:04:16Z [LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes ---
[jira] [Commented] (LIBCLOUD-969) Add pricing information to Upcloud driver list_sizes method
[ https://issues.apache.org/jira/browse/LIBCLOUD-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285713#comment-16285713 ] ASF GitHub Bot commented on LIBCLOUD-969: - GitHub user mlackman opened a pull request: https://github.com/apache/libcloud/pull/1152 [LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes ## Changes Title (replace this with a logical title for your changes) ### Description UpCloud's driver were missing the pricing information from list_sizes return values. Added the information to NodeSize.extra data, because pricing zone specific. ### Status Replace this: describe the PR status. Examples: - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [x] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/UpCloudLtd/libcloud LIBCLOUD-969_Add_pricing_information_to_Upcloud_driver_list_sizes_method Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1152 commit 39c2721ef04e1a9eab0161e744df263d4d09770a Author: Mika Lackman Date: 2017-12-11T09:04:16Z [LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes > Add pricing information to Upcloud driver list_sizes method > --- > > Key: LIBCLOUD-969 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-969 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Mika Lackman > > Currently no pricing information is included in driver.list_sizes. Idea is to > add pricing information to NodeSize.extra field, because the price is > dependant on the hosting zone. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LIBCLOUD-969) Add pricing information to Upcloud driver list_sizes method
[ https://issues.apache.org/jira/browse/LIBCLOUD-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mika Lackman updated LIBCLOUD-969: -- Summary: Add pricing information to Upcloud driver list_sizes method (was: Add pricing information to Upcloud's driver list_sizes method) > Add pricing information to Upcloud driver list_sizes method > --- > > Key: LIBCLOUD-969 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-969 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Mika Lackman > > Currently no pricing information is included in driver.list_sizes. Idea is to > add pricing information to NodeSize.extra field, because the price is > dependant on the hosting zone. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (LIBCLOUD-969) Add pricing information to Upcloud's driver list_sizes method
Mika Lackman created LIBCLOUD-969: - Summary: Add pricing information to Upcloud's driver list_sizes method Key: LIBCLOUD-969 URL: https://issues.apache.org/jira/browse/LIBCLOUD-969 Project: Libcloud Issue Type: Improvement Components: Compute Reporter: Mika Lackman Currently no pricing information is included in driver.list_sizes. Idea is to add pricing information to NodeSize.extra field, because the price is dependant on the hosting zone. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
