[jira] [Commented] (LIBCLOUD-996) Support GCP service_account authentication from JSON obj/str

2018-05-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487953#comment-16487953
 ] 

ASF GitHub Bot commented on LIBCLOUD-996:
-

GitHub user bverschueren opened a pull request:

https://github.com/apache/libcloud/pull/1214

[LIBCLOUD-996] Support GCP service_account authentication from JSON obj/str

## Support GCP service_account authentication from JSON obj/str

### Description


Currently GCP service_account authentication credentials can be provided 
using the JSON/PEM file acquired from GCP console or gcloud utility. It would 
be convenient if the JSON content could be directly provided as an object or 
serialized JSON string to eliminate the need of having the file locally on the 
calling host.

In this PR:
- add logic to support JSON dict and str handling
- rearrange PEM/JSON related GCE_PARAMS_* constant names in test_google.py 
for better clarity
- add tests for JSON content as a dict and as a str


### Status

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bverschueren/libcloud 
LIBCLOUD-996_gcp_svc_acct_credentials_from_json

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1214


commit 409d428eed31b017c74c9b34378a3817b55398df
Author: Bram Verschueren 
Date:   2018-05-09T13:56:29Z

add support for retrieving private key from JSON object/string/file




> Support GCP service_account authentication from JSON obj/str
> 
>
> Key: LIBCLOUD-996
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-996
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bram
>Priority: Minor
>
> Currently GCP service_account authentication credentials can be provided 
> using the JSON/PEM file acquired from GCP console or gcloud utility. It would 
> be convenient if the JSON content could be directly provided as an object or 
> serialized JSON string to eliminate the need of having the file locally on 
> the calling host.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] libcloud pull request #1214: [LIBCLOUD-996] Support GCP service_account auth...

2018-05-23 Thread bverschueren 
GitHub user bverschueren opened a pull request:

https://github.com/apache/libcloud/pull/1214

[LIBCLOUD-996] Support GCP service_account authentication from JSON obj/str

## Support GCP service_account authentication from JSON obj/str

### Description


Currently GCP service_account authentication credentials can be provided 
using the JSON/PEM file acquired from GCP console or gcloud utility. It would 
be convenient if the JSON content could be directly provided as an object or 
serialized JSON string to eliminate the need of having the file locally on the 
calling host.

In this PR:
- add logic to support JSON dict and str handling
- rearrange PEM/JSON related GCE_PARAMS_* constant names in test_google.py 
for better clarity
- add tests for JSON content as a dict and as a str


### Status

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bverschueren/libcloud 
LIBCLOUD-996_gcp_svc_acct_credentials_from_json

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1214


commit 409d428eed31b017c74c9b34378a3817b55398df
Author: Bram Verschueren 
Date:   2018-05-09T13:56:29Z

add support for retrieving private key from JSON object/string/file




---

[jira] [Created] (LIBCLOUD-996) Support GCP service_account authentication from JSON obj/str

2018-05-23 Thread Bram (JIRA) 
Bram created LIBCLOUD-996:
-

 Summary: Support GCP service_account authentication from JSON 
obj/str
 Key: LIBCLOUD-996
 URL: https://issues.apache.org/jira/browse/LIBCLOUD-996
 Project: Libcloud
  Issue Type: Improvement
  Components: Core
Reporter: Bram


Currently GCP service_account authentication credentials can be provided using 
the JSON/PEM file acquired from GCP console or gcloud utility. It would be 
convenient if the JSON content could be directly provided as an object or 
serialized JSON string to eliminate the need of having the file locally on the 
calling host.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)