[jira] [Commented] (LIBCLOUD-1014) Add tags when create a snapshot
[ https://issues.apache.org/jira/browse/LIBCLOUD-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665408#comment-16665408 ] ASF GitHub Bot commented on LIBCLOUD-1014: -- Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/1240 > Add tags when create a snapshot > --- > > Key: LIBCLOUD-1014 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-1014 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Rafael dos Santos Goncalves >Priority: Minor > Labels: features > Original Estimate: 10m > Remaining Estimate: 10m > > Hello, > In my aws account have a lot of snapshots of many different projects. To > organize that, i need to create tags in my snapshots. Looking the method > [create_volume_snapshot|https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot] > i can't create tags. We can improve that method to accept metadata, what you > think ? > > Thanks :D -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LIBCLOUD-1014) Add tags when create a snapshot
[ https://issues.apache.org/jira/browse/LIBCLOUD-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665404#comment-16665404 ] ASF subversion and git services commented on LIBCLOUD-1014: --- Commit 51b6609f8d34d9fe73134fdc76aa968cd1210425 in libcloud's branch refs/heads/trunk from elesbom [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=51b6609 ] [LIBCLOUD-1014] Accept metadata when create a snapshot > Add tags when create a snapshot > --- > > Key: LIBCLOUD-1014 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-1014 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Rafael dos Santos Goncalves >Priority: Minor > Labels: features > Original Estimate: 10m > Remaining Estimate: 10m > > Hello, > In my aws account have a lot of snapshots of many different projects. To > organize that, i need to create tags in my snapshots. Looking the method > [create_volume_snapshot|https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot] > i can't create tags. We can improve that method to accept metadata, what you > think ? > > Thanks :D -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LIBCLOUD-1014) Add tags when create a snapshot
[ https://issues.apache.org/jira/browse/LIBCLOUD-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665405#comment-16665405 ] ASF subversion and git services commented on LIBCLOUD-1014: --- Commit 7dce67d17764bf47430c5e5207748fc25c8e73c1 in libcloud's branch refs/heads/trunk from elesbom [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=7dce67d ] [LIBCLOUD-1014] Fix test for PR #1240 > Add tags when create a snapshot > --- > > Key: LIBCLOUD-1014 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-1014 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Rafael dos Santos Goncalves >Priority: Minor > Labels: features > Original Estimate: 10m > Remaining Estimate: 10m > > Hello, > In my aws account have a lot of snapshots of many different projects. To > organize that, i need to create tags in my snapshots. Looking the method > [create_volume_snapshot|https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot] > i can't create tags. We can improve that method to accept metadata, what you > think ? > > Thanks :D -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LIBCLOUD-1014) Add tags when create a snapshot
[ https://issues.apache.org/jira/browse/LIBCLOUD-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665406#comment-16665406 ] ASF subversion and git services commented on LIBCLOUD-1014: --- Commit 608598821758cab79ed5e61b370ee0407f03616a in libcloud's branch refs/heads/trunk from elesbom [ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=6085988 ] [LIBCLOUD-1014] PEP8 Signed-off-by: Rick van de Loo > Add tags when create a snapshot > --- > > Key: LIBCLOUD-1014 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-1014 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Rafael dos Santos Goncalves >Priority: Minor > Labels: features > Original Estimate: 10m > Remaining Estimate: 10m > > Hello, > In my aws account have a lot of snapshots of many different projects. To > organize that, i need to create tags in my snapshots. Looking the method > [create_volume_snapshot|https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot] > i can't create tags. We can improve that method to accept metadata, what you > think ? > > Thanks :D -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LIBCLOUD-1014) Add tags when create a snapshot
[ https://issues.apache.org/jira/browse/LIBCLOUD-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626097#comment-16626097 ] ASF GitHub Bot commented on LIBCLOUD-1014: -- GitHub user elesbom opened a pull request: https://github.com/apache/libcloud/pull/1240 [LIBCLOUD-1014] Accept tags when create a snapshot ## Accept tags when create snapshot ### Description In my aws account have a lot of snapshots of many different projects. To organize that, i need to create tags in my snapshots. Looking the method [create_volume_snapshot](https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot) i can't create tags. This pull request allow you pass tags to snapshot. Link for [jira](https://issues.apache.org/jira/browse/LIBCLOUD-1014) ### Status - done, ready for review - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [ ] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/elesbom/libcloud LIBCLOUD-1014_tags_for_snapshot Alternatively you can review and apply these changes as the patch at: https://github.com/apache/libcloud/pull/1240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1240 commit 53d2b2c2044f910cde13e6660590545559d5870a Author: elesbom Date: 2018-09-24T16:18:42Z [LIBCLOUD-1014] Accept metadata when create a snapshot > Add tags when create a snapshot > --- > > Key: LIBCLOUD-1014 > URL: https://issues.apache.org/jira/browse/LIBCLOUD-1014 > Project: Libcloud > Issue Type: Improvement > Components: Compute >Reporter: Rafael dos Santos Goncalves >Priority: Minor > Labels: features > Original Estimate: 10m > Remaining Estimate: 10m > > Hello, > In my aws account have a lot of snapshots of many different projects. To > organize that, i need to create tags in my snapshots. Looking the method > [create_volume_snapshot|https://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html#libcloud.compute.drivers.ec2.BaseEC2NodeDriver.create_volume_snapshot] > i can't create tags. We can improve that method to accept metadata, what you > think ? > > Thanks :D -- This message was sent by Atlassian JIRA (v7.6.3#76005)
