[jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848519#comment-16848519
 ] 

ASF subversion and git services commented on LIBCLOUD-1022:
---

Commit 18bb84a263a7ba821188717193d6326e5a07a283 in libcloud's branch 
refs/heads/trunk from Tomaz Muraus
[ https://gitbox.apache.org/repos/asf?p=libcloud.git;h=18bb84a ]

Merge branch 'LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter' of 
https://github.com/kiniou/libcloud into 
LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter


> enhance digitalocean dns driver with ttl parameter
> --
>
> Key: LIBCLOUD-1022
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
> Project: Libcloud
>  Issue Type: Improvement
>  Components: DNS
>Reporter: Kevin Roy
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> DigitalOcean provides a parameter to update dns records with {{ttl}} 
> parameter but the current driver's code actually doesn't support it.
> For reference:
>  * 
> [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * 
> [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848517#comment-16848517
 ] 

ASF subversion and git services commented on LIBCLOUD-1022:
---

Commit 7078d07a83bf09eed8d776a49e5b919ab6b3bd70 in libcloud's branch 
refs/heads/trunk from Kevin Roy
[ https://gitbox.apache.org/repos/asf?p=libcloud.git;h=7078d07 ]

[LIBCLOUD-1022] check 'ttl' presence instead of try-catching


> enhance digitalocean dns driver with ttl parameter
> --
>
> Key: LIBCLOUD-1022
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
> Project: Libcloud
>  Issue Type: Improvement
>  Components: DNS
>Reporter: Kevin Roy
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> DigitalOcean provides a parameter to update dns records with {{ttl}} 
> parameter but the current driver's code actually doesn't support it.
> For reference:
>  * 
> [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * 
> [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848520#comment-16848520
 ] 

ASF subversion and git services commented on LIBCLOUD-1022:
---

Commit 064ad6cd4cf145ddabd0fc15cb00d965ef7688e4 in libcloud's branch 
refs/heads/trunk from Tomaz Muraus
[ https://gitbox.apache.org/repos/asf?p=libcloud.git;h=064ad6c ]

Merge pull request #1252 from 
kiniou/LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter

> enhance digitalocean dns driver with ttl parameter
> --
>
> Key: LIBCLOUD-1022
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
> Project: Libcloud
>  Issue Type: Improvement
>  Components: DNS
>Reporter: Kevin Roy
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> DigitalOcean provides a parameter to update dns records with {{ttl}} 
> parameter but the current driver's code actually doesn't support it.
> For reference:
>  * 
> [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * 
> [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848521#comment-16848521
 ] 

ASF subversion and git services commented on LIBCLOUD-1022:
---

Commit 064ad6cd4cf145ddabd0fc15cb00d965ef7688e4 in libcloud's branch 
refs/heads/trunk from Tomaz Muraus
[ https://gitbox.apache.org/repos/asf?p=libcloud.git;h=064ad6c ]

Merge pull request #1252 from 
kiniou/LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter

> enhance digitalocean dns driver with ttl parameter
> --
>
> Key: LIBCLOUD-1022
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
> Project: Libcloud
>  Issue Type: Improvement
>  Components: DNS
>Reporter: Kevin Roy
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> DigitalOcean provides a parameter to update dns records with {{ttl}} 
> parameter but the current driver's code actually doesn't support it.
> For reference:
>  * 
> [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * 
> [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848518#comment-16848518
 ] 

ASF subversion and git services commented on LIBCLOUD-1022:
---

Commit 18bb84a263a7ba821188717193d6326e5a07a283 in libcloud's branch 
refs/heads/trunk from Tomaz Muraus
[ https://gitbox.apache.org/repos/asf?p=libcloud.git;h=18bb84a ]

Merge branch 'LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter' of 
https://github.com/kiniou/libcloud into 
LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter


> enhance digitalocean dns driver with ttl parameter
> --
>
> Key: LIBCLOUD-1022
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
> Project: Libcloud
>  Issue Type: Improvement
>  Components: DNS
>Reporter: Kevin Roy
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> DigitalOcean provides a parameter to update dns records with {{ttl}} 
> parameter but the current driver's code actually doesn't support it.
> For reference:
>  * 
> [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * 
> [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LIBCLOUD-1022) enhance digitalocean dns driver with ttl parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682399#comment-16682399
 ] 

ASF GitHub Bot commented on LIBCLOUD-1022:
--

GitHub user kiniou opened a pull request:

https://github.com/apache/libcloud/pull/1252

[LIBCLOUD-1022] Enhance digitalocean dns driver with `ttl` parameter

## Enhance digitalocean dns driver with `ttl` parameter

### Description

DigitalOcean provides a parameter to update dns records with `ttl` but the 
current driver's code actually doesn't support it.

For reference:

- 
https://developers.digitalocean.com/documentation/v2/#update-a-domain-record
- 
https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record

### Status

ready for review


### Checklist (tick everything that applies)

- [X] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [ ] Documentation
- [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kiniou/libcloud 
LIBCLOUD-1022_digitalocean-dns-record-ttl-parameter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1252


commit 57a80f94922eaa1fd8fa813414fac0e45613f80d
Author: Kevin Roy 
Date:   2018-11-10T10:34:17Z

add `ttl` parameters to digitalocean record operations




> enhance digitalocean dns driver with ttl parameter
> --
>
> Key: LIBCLOUD-1022
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-1022
> Project: Libcloud
>  Issue Type: Bug
>  Components: DNS
>Reporter: Kevin Roy
>Priority: Minor
>
> DigitalOcean provides a parameters to update dns records with {{ttl}} 
> parameter but the current driver's code actually doesn't support it.
> For reference:
>  * 
> [https://developers.digitalocean.com/documentation/v2/#update-a-domain-record]
>  * 
> [https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)