[jira] [Commented] (LIBCLOUD-696) GCE Compute driver returns null for image.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542826#comment-14542826
 ] 

ASF GitHub Bot commented on LIBCLOUD-696:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/522


 GCE Compute driver returns null for image.
 --

 Key: LIBCLOUD-696
 URL: https://issues.apache.org/jira/browse/LIBCLOUD-696
 Project: Libcloud
  Issue Type: Bug
  Components: Compute
Reporter: Jason DeTiberus
Assignee: Eric Johnson

 The GCE Compute driver is currently returning null for image.  The issue 
 appears to be related to a change in the data returned from the api.
 In libcloud/compute/drivers/gce.py:
 {code:none|title=_to_node}
 extra['image'] = node.get('image')
 ...
 for disk in extra['disks']:
 if disk.get('boot') and disk.get('type') == 'PERSISTENT':
 bd = self._get_components_from_path(disk['source'])
 extra['boot_disk'] = self.ex_get_volume(bd['name'], bd['zone'])
 extra['image'] = bd['name']
 ...
 if extra['image']:
 image = self._get_components_from_path(extra['image'])['name']
 else:
 image = None
 {code}
 This looks like it should be:
 {code:none}
 for disk in extra['disks']:
 if disk.get('boot') and disk.get('type') == 'PERSISTENT':
 bd = self._get_components_from_path(disk['source'])
 extra['boot_disk'] = self.ex_get_volume(bd['name'], bd['zone'])
 extra['image'] = bd['name']
 ...
 if extra['image']:
 image = self._get_components_from_path(extra['image'])['name']
 else:
 image = None
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LIBCLOUD-696) GCE Compute driver returns null for image.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542824#comment-14542824
 ] 

ASF subversion and git services commented on LIBCLOUD-696:
--

Commit 1e3d3cbc6fcc6f3cc862da31b9e17ca5450b95f6 in libcloud's branch 
refs/heads/trunk from [~erjohnso]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=1e3d3cb ]

[google compute] LIBCLOUD-696: improve node image detection

Closes #522

Signed-off-by: Eric Johnson erjoh...@google.com


 GCE Compute driver returns null for image.
 --

 Key: LIBCLOUD-696
 URL: https://issues.apache.org/jira/browse/LIBCLOUD-696
 Project: Libcloud
  Issue Type: Bug
  Components: Compute
Reporter: Jason DeTiberus
Assignee: Eric Johnson

 The GCE Compute driver is currently returning null for image.  The issue 
 appears to be related to a change in the data returned from the api.
 In libcloud/compute/drivers/gce.py:
 {code:none|title=_to_node}
 extra['image'] = node.get('image')
 ...
 for disk in extra['disks']:
 if disk.get('boot') and disk.get('type') == 'PERSISTENT':
 bd = self._get_components_from_path(disk['source'])
 extra['boot_disk'] = self.ex_get_volume(bd['name'], bd['zone'])
 extra['image'] = bd['name']
 ...
 if extra['image']:
 image = self._get_components_from_path(extra['image'])['name']
 else:
 image = None
 {code}
 This looks like it should be:
 {code:none}
 for disk in extra['disks']:
 if disk.get('boot') and disk.get('type') == 'PERSISTENT':
 bd = self._get_components_from_path(disk['source'])
 extra['boot_disk'] = self.ex_get_volume(bd['name'], bd['zone'])
 extra['image'] = bd['name']
 ...
 if extra['image']:
 image = self._get_components_from_path(extra['image'])['name']
 else:
 image = None
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)