[jira] [Commented] (LIBCLOUD-820) libvirt module only doesn't check if nodes are remote

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305511#comment-15305511
 ] 

ASF GitHub Bot commented on LIBCLOUD-820:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/788


> libvirt module only doesn't check if nodes are remote
> -
>
> Key: LIBCLOUD-820
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-820
> Project: Libcloud
>  Issue Type: Bug
>  Components: Compute
>Reporter: Rene Kjellerup
>  Labels: easyfix
>
> in _get_ip_addresses_for_domain function it states:
> {noformat}
> def _get_ip_addresses_for_domain(self, domain):
> """
> Retrieve IP addresses for the provided domain.
> Note: This functionality is currently only supported on Linux and
> only works if this code is run on the same machine as the VMs run
> on.
> :return: IP addresses for the provided domain.
> :rtype: ``list``
> """
> {noformat}
> however it only checks if the platform is Linux... not if the it's on the 
> same machine. this causes list_nodes() to fail when using 
> uri='qemu+ssh:///systems'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LIBCLOUD-820) libvirt module only doesn't check if nodes are remote

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305509#comment-15305509
 ] 

ASF subversion and git services commented on LIBCLOUD-820:
--

Commit bff3f29321c38825f4be881bc344487aa3052369 in libcloud's branch 
refs/heads/trunk from [~Katana Steel]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=bff3f29 ]

LIBCLOUD-820 added arp cache check using iproute2

In case arp isn't accessable by the user (as is the case for me
on debian testing) the use ip neighbor

Closes #788

Signed-off-by: Tomaz Muraus 


> libvirt module only doesn't check if nodes are remote
> -
>
> Key: LIBCLOUD-820
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-820
> Project: Libcloud
>  Issue Type: Bug
>  Components: Compute
>Reporter: Rene Kjellerup
>  Labels: easyfix
>
> in _get_ip_addresses_for_domain function it states:
> {noformat}
> def _get_ip_addresses_for_domain(self, domain):
> """
> Retrieve IP addresses for the provided domain.
> Note: This functionality is currently only supported on Linux and
> only works if this code is run on the same machine as the VMs run
> on.
> :return: IP addresses for the provided domain.
> :rtype: ``list``
> """
> {noformat}
> however it only checks if the platform is Linux... not if the it's on the 
> same machine. this causes list_nodes() to fail when using 
> uri='qemu+ssh:///systems'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LIBCLOUD-820) libvirt module only doesn't check if nodes are remote

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305510#comment-15305510
 ] 

ASF subversion and git services commented on LIBCLOUD-820:
--

Commit 13e3b6e2c0e134350f6a50ac0af7a8e4cd819d36 in libcloud's branch 
refs/heads/trunk from [~Katana Steel]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=13e3b6e ]

LIBCLOUD-820 fixed lint errors

Closes #788

Signed-off-by: Tomaz Muraus 


> libvirt module only doesn't check if nodes are remote
> -
>
> Key: LIBCLOUD-820
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-820
> Project: Libcloud
>  Issue Type: Bug
>  Components: Compute
>Reporter: Rene Kjellerup
>  Labels: easyfix
>
> in _get_ip_addresses_for_domain function it states:
> {noformat}
> def _get_ip_addresses_for_domain(self, domain):
> """
> Retrieve IP addresses for the provided domain.
> Note: This functionality is currently only supported on Linux and
> only works if this code is run on the same machine as the VMs run
> on.
> :return: IP addresses for the provided domain.
> :rtype: ``list``
> """
> {noformat}
> however it only checks if the platform is Linux... not if the it's on the 
> same machine. this causes list_nodes() to fail when using 
> uri='qemu+ssh:///systems'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LIBCLOUD-820) libvirt module only doesn't check if nodes are remote

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285216#comment-15285216
 ] 

ASF GitHub Bot commented on LIBCLOUD-820:
-

GitHub user Katana-Steel opened a pull request:

https://github.com/apache/libcloud/pull/788

[LIBCLOUD-820] added check if libvirt uri is local

## added check if libvirt uri is local

### Description

without this listing nodes on a remote KVM server will fail to
lookup the IPs in the arp cache

### Status

- done, ready for review

### Checklist (tick everything that applies)

- [X] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [X] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Katana-Steel/libcloud 
LIBCLOUD-820_remote_uri_check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #788


commit c3fc08c40ea87aa0a78b0b885924d6a1be1b9964
Author: Rene Kjellerup 
Date:   2016-05-16T20:07:40Z

[LIBCLOUD-820] added check if libvirt uri is local

without this listing nodes on a remote KVM server will fail to
lookup the IPs in the arp cache




> libvirt module only doesn't check if nodes are remote
> -
>
> Key: LIBCLOUD-820
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-820
> Project: Libcloud
>  Issue Type: Bug
>  Components: Compute
>Reporter: Rene Kjellerup
>  Labels: easyfix
>
> in _get_ip_addresses_for_domain function it states:
> {noformat}
> def _get_ip_addresses_for_domain(self, domain):
> """
> Retrieve IP addresses for the provided domain.
> Note: This functionality is currently only supported on Linux and
> only works if this code is run on the same machine as the VMs run
> on.
> :return: IP addresses for the provided domain.
> :rtype: ``list``
> """
> {noformat}
> however it only checks if the platform is Linux... not if the it's on the 
> same machine. this causes list_nodes() to fail when using 
> uri='qemu+ssh:///systems'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)