[jira] [Commented] (LIBCLOUD-875) Route 53 driver formats TXT records incorrectly

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134596#comment-16134596
 ] 

ASF subversion and git services commented on LIBCLOUD-875:
--

Commit b3b5086d19baa585af4987b0e32e7fdbe595ea5a in libcloud's branch 
refs/heads/trunk from [~anthonypjshaw]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=b3b5086 ]

create tests to validate LIBCLOUD-875


> Route 53 driver formats TXT records incorrectly
> ---
>
> Key: LIBCLOUD-875
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-875
> Project: Libcloud
>  Issue Type: Bug
>  Components: DNS
>Reporter: Tristan Seligmann
>
> Route 53 expects the values of TXT records to be wrapped in quotation marks 
> ("value"), but the driver does not add these for you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-875) Route 53 driver formats TXT records incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134597#comment-16134597
 ] 

ASF GitHub Bot commented on LIBCLOUD-875:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1093


> Route 53 driver formats TXT records incorrectly
> ---
>
> Key: LIBCLOUD-875
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-875
> Project: Libcloud
>  Issue Type: Bug
>  Components: DNS
>Reporter: Tristan Seligmann
>
> Route 53 expects the values of TXT records to be wrapped in quotation marks 
> ("value"), but the driver does not add these for you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-875) Route 53 driver formats TXT records incorrectly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134587#comment-16134587
 ] 

ASF GitHub Bot commented on LIBCLOUD-875:
-

GitHub user tonybaloney opened a pull request:

https://github.com/apache/libcloud/pull/1093

LIBCLOUD-875 fix route 53 DNS quote encapsulation

## fix route 53 DNS quote encapsulation

Amazon's API stipulates that SPF and TXT records have quotes 
http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html#TXTFormat
The driver does not have any special casing for these records. I assume 
that existing users either:
- Get an error - see https://github.com/twisted/txacme/issues/120
- Add quotes before calling the methods, in which case this behaviour 
should be supported

For more information on contributing, please see 
[Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.

### Status

- work in progress

### Checklist (tick everything that applies)

- [ ] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tonybaloney/libcloud route53_formatting

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1093


commit b3b5086d19baa585af4987b0e32e7fdbe595ea5a
Author: Anthony Shaw 
Date:   2017-08-20T22:55:16Z

create tests to validate LIBCLOUD-875




> Route 53 driver formats TXT records incorrectly
> ---
>
> Key: LIBCLOUD-875
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-875
> Project: Libcloud
>  Issue Type: Bug
>  Components: DNS
>Reporter: Tristan Seligmann
>
> Route 53 expects the values of TXT records to be wrapped in quotation marks 
> ("value"), but the driver does not add these for you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-875) Route 53 driver formats TXT records incorrectly

[Glyph Lefkowitz (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072088#comment-16072088
 ] 

Glyph Lefkowitz commented on LIBCLOUD-875:
--

I've filed https://github.com/twisted/txacme/issues/120 to track this issue 
downstream, so if anyone manages to address this it would be nice to update 
there as well.

> Route 53 driver formats TXT records incorrectly
> ---
>
> Key: LIBCLOUD-875
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-875
> Project: Libcloud
>  Issue Type: Bug
>  Components: DNS
>Reporter: Tristan Seligmann
>
> Route 53 expects the values of TXT records to be wrapped in quotation marks 
> ("value"), but the driver does not add these for you.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-875) Route 53 driver formats TXT records incorrectly

[Glyph Lefkowitz (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928609#comment-15928609
 ] 

Glyph Lefkowitz commented on LIBCLOUD-875:
--

It's worth noting that the impact of this bug is that 
https://github.com/mithrandi/txacme can't provision certificates with a Route 
53 backend.

> Route 53 driver formats TXT records incorrectly
> ---
>
> Key: LIBCLOUD-875
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-875
> Project: Libcloud
>  Issue Type: Bug
>  Components: DNS
>Reporter: Tristan Seligmann
>
> Route 53 expects the values of TXT records to be wrapped in quotation marks 
> ("value"), but the driver does not add these for you.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)