[jira] [Commented] (LIBCLOUD-940) Add 'end' to ec2 Reserved Instance data

2017-09-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152000#comment-16152000
 ] 

ASF GitHub Bot commented on LIBCLOUD-940:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1099


> Add 'end' to ec2 Reserved Instance data
> ---
>
> Key: LIBCLOUD-940
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-940
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Chris Clarke
>
> The [DescribeReservedInstances 
> API|http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeReservedInstances.html]
>  returns 3 fields related to the timeframe of the reservation:
>   * start
>   * end
>   * duration
> When a reservation is modified, start changes to the effective date of the 
> modification, but duration remains the same (number of seconds in 1 or 3 
> years). The only way to determine when a modified reservation expires is to 
> use the end date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LIBCLOUD-940) Add 'end' to ec2 Reserved Instance data

2017-08-30 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148005#comment-16148005
 ] 

ASF GitHub Bot commented on LIBCLOUD-940:
-

GitHub user xofer opened a pull request:

https://github.com/apache/libcloud/pull/1099

[LIBCLOUD-940]  Add 'end' to ec2 Reserved Instance data

## Add 'end' to ec2 Reserved Instance data

### Description

The [DescribeReservedInstances 
API](http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeReservedInstances.html)
 returns 3 fields related to the timeframe of the reservation:

  * start
  * end
  * duration

When a reservation is modified, start changes to the effective date of the 
modification, but duration remains the same (number of seconds in 1 or 3 
years). The only way to determine when a modified reservation expires is to use 
the end date.

### Status

done, ready for review

### Checklist (tick everything that applies)

- [ ] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xofer/libcloud ec2-ri-end

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1099.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1099






> Add 'end' to ec2 Reserved Instance data
> ---
>
> Key: LIBCLOUD-940
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-940
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Chris Clarke
>
> The [DescribeReservedInstances 
> API|http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeReservedInstances.html]
>  returns 3 fields related to the timeframe of the reservation:
>   * start
>   * end
>   * duration
> When a reservation is modified, start changes to the effective date of the 
> modification, but duration remains the same (number of seconds in 1 or 3 
> years). The only way to determine when a modified reservation expires is to 
> use the end date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LIBCLOUD-940) Add 'end' to ec2 Reserved Instance data

2017-08-30 Thread Chris Clarke (JIRA)

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148006#comment-16148006
 ] 

Chris Clarke commented on LIBCLOUD-940:
---

https://github.com/apache/libcloud/pull/1099

> Add 'end' to ec2 Reserved Instance data
> ---
>
> Key: LIBCLOUD-940
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-940
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Chris Clarke
>
> The [DescribeReservedInstances 
> API|http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeReservedInstances.html]
>  returns 3 fields related to the timeframe of the reservation:
>   * start
>   * end
>   * duration
> When a reservation is modified, start changes to the effective date of the 
> modification, but duration remains the same (number of seconds in 1 or 3 
> years). The only way to determine when a modified reservation expires is to 
> use the end date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)