[jira] [Commented] (LIBCLOUD-969) Add pricing information to Upcloud driver list_sizes method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291247#comment-16291247
 ] 

ASF GitHub Bot commented on LIBCLOUD-969:
-

Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/1152


> Add pricing information to Upcloud driver list_sizes method
> ---
>
> Key: LIBCLOUD-969
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-969
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Currently no pricing information is included in driver.list_sizes. Idea is to 
> add pricing information to NodeSize.extra field, because the price is 
> dependant on the hosting zone. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-969) Add pricing information to Upcloud driver list_sizes method

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291246#comment-16291246
 ] 

ASF subversion and git services commented on LIBCLOUD-969:
--

Commit 721a83aec40894bd8e3be03cb5e4cea0fd278696 in libcloud's branch 
refs/heads/trunk from [~mlackman]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=721a83a ]

[LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes

Signed-off-by: Quentin Pradet 


> Add pricing information to Upcloud driver list_sizes method
> ---
>
> Key: LIBCLOUD-969
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-969
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Currently no pricing information is included in driver.list_sizes. Idea is to 
> add pricing information to NodeSize.extra field, because the price is 
> dependant on the hosting zone. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LIBCLOUD-969) Add pricing information to Upcloud driver list_sizes method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LIBCLOUD-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285713#comment-16285713
 ] 

ASF GitHub Bot commented on LIBCLOUD-969:
-

GitHub user mlackman opened a pull request:

https://github.com/apache/libcloud/pull/1152

[LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes

## Changes Title (replace this with a logical title for your changes)

### Description

UpCloud's driver were missing the pricing information from list_sizes 
return values. Added the information to NodeSize.extra data, because pricing 
zone specific. 

### Status

Replace this: describe the PR status. Examples:

- done, ready for review

### Checklist (tick everything that applies)

- [x] [Code 
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
 (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] 
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
 (required for bigger changes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/UpCloudLtd/libcloud 
LIBCLOUD-969_Add_pricing_information_to_Upcloud_driver_list_sizes_method

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/1152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1152


commit 39c2721ef04e1a9eab0161e744df263d4d09770a
Author: Mika Lackman 
Date:   2017-12-11T09:04:16Z

[LIBCLOUD-969] Add pricing information to UpCloud's driver list_sizes




> Add pricing information to Upcloud driver list_sizes method
> ---
>
> Key: LIBCLOUD-969
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-969
> Project: Libcloud
>  Issue Type: Improvement
>  Components: Compute
>Reporter: Mika Lackman
>
> Currently no pricing information is included in driver.list_sizes. Idea is to 
> add pricing information to NodeSize.extra field, because the price is 
> dependant on the hosting zone. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)