libcloud git commit: Fixes LIBCLOUD-650: ex_create_multi_value_record only returns one record (route53 driver), adds tests for that function.
Repository: libcloud
Updated Branches:
refs/heads/trunk ecd36734f - eb36e6277
Fixes LIBCLOUD-650: ex_create_multi_value_record only returns one record
(route53 driver), adds tests for that function.
Signed-off-by: Tomaz Muraus to...@apache.org
Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/eb36e627
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/eb36e627
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/eb36e627
Branch: refs/heads/trunk
Commit: eb36e62772de9d2becbd9a9013595c0f7f96ecd0
Parents: ecd3673
Author: Itxaka Serrano itxakaserr...@gmail.com
Authored: Sat Jan 10 11:23:34 2015 +0100
Committer: Tomaz Muraus to...@apache.org
Committed: Sat Jan 17 11:19:48 2015 +0100
--
CHANGES.rst | 5 +
libcloud/dns/drivers/route53.py | 3 +--
libcloud/test/dns/test_route53.py | 20
3 files changed, 26 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/libcloud/blob/eb36e627/CHANGES.rst
--
diff --git a/CHANGES.rst b/CHANGES.rst
index d773d74..1a7bbfa 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -156,6 +156,11 @@ DNS
(GITHUB-413, LIBCLOUD-640)
[VanÄ Levstik]
+- Fix a bug with ``ex_create_multi_value_record`` method in the Route53 driver
+ only returning a single record.
+ (GITHUB-431, LIBCLOUD-650)
+ [Itxaka Serrano]
+
Changes with Apache Libcloud 0.16.0
---
http://git-wip-us.apache.org/repos/asf/libcloud/blob/eb36e627/libcloud/dns/drivers/route53.py
--
diff --git a/libcloud/dns/drivers/route53.py b/libcloud/dns/drivers/route53.py
index f1a8f34..5fce731 100644
--- a/libcloud/dns/drivers/route53.py
+++ b/libcloud/dns/drivers/route53.py
@@ -273,7 +273,7 @@ class Route53DNSDriver(DNSDriver):
driver=self, extra=extra)
records.append(record)
-return record
+return records
def ex_delete_all_records(self, zone):
@@ -346,7 +346,6 @@ class Route53DNSDriver(DNSDriver):
for other_record in other_records:
rrec = ET.SubElement(rrecs, 'ResourceRecord')
ET.SubElement(rrec, 'Value').text = other_record['data']
-
uri = API_ROOT + 'hostedzone/' + record.zone.id + '/rrset'
data = ET.tostring(changeset)
self.connection.set_context({'zone_id': record.zone.id})
http://git-wip-us.apache.org/repos/asf/libcloud/blob/eb36e627/libcloud/test/dns/test_route53.py
--
diff --git a/libcloud/test/dns/test_route53.py
b/libcloud/test/dns/test_route53.py
index 2994203..e9a4026 100644
--- a/libcloud/test/dns/test_route53.py
+++ b/libcloud/test/dns/test_route53.py
@@ -155,6 +155,26 @@ class Route53Tests(unittest.TestCase):
self.assertEqual(record.type, RecordType.A)
self.assertEqual(record.data, '127.0.0.1')
+def test_create_multi_value_record(self):
+zone = self.driver.list_zones()[0]
+records = self.driver.ex_create_multi_value_record(
+name='balancer', zone=zone,
+type=RecordType.A, data='127.0.0.1\n127.0.0.2',
+extra={'ttl': 0}
+
+)
+self.assertEqual(len(records), 2)
+self.assertEqual(records[0].id, 'A:balancer')
+self.assertEqual(records[1].id, 'A:balancer')
+self.assertEqual(records[0].name, 'balancer')
+self.assertEqual(records[1].name, 'balancer')
+self.assertEqual(records[0].zone, zone)
+self.assertEqual(records[1].zone, zone)
+self.assertEqual(records[0].type, RecordType.A)
+self.assertEqual(records[1].type, RecordType.A)
+self.assertEqual(records[0].data, '127.0.0.1')
+self.assertEqual(records[1].data, '127.0.0.2')
+
def test_update_record(self):
zone = self.driver.list_zones()[0]
record = self.driver.list_records(zone=zone)[1]
[jira] [Commented] (LIBCLOUD-650) Route53 ex_create_multi_value_record only returns one record
[
https://issues.apache.org/jira/browse/LIBCLOUD-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281271#comment-14281271
]
ASF subversion and git services commented on LIBCLOUD-650:
--
Commit eb36e62772de9d2becbd9a9013595c0f7f96ecd0 in libcloud's branch
refs/heads/trunk from [~Itxaka]
[ https://git-wip-us.apache.org/repos/asf?p=libcloud.git;h=eb36e62 ]
Fixes LIBCLOUD-650: ex_create_multi_value_record only returns one record
(route53 driver), adds tests for that function.
Signed-off-by: Tomaz Muraus to...@apache.org
Route53 ex_create_multi_value_record only returns one record
Key: LIBCLOUD-650
URL: https://issues.apache.org/jira/browse/LIBCLOUD-650
Project: Libcloud
Issue Type: Bug
Components: DNS
Reporter: Itxaka Serrano
Labels: bug, dns, newbie, test
Original Estimate: 1h
Remaining Estimate: 1h
Calling ex_create_multi_value_record on the Route53 driver only returns one
Record object but it should return several values.
On libcloud.dns.driver.route53.py lines 270-276:
{code}
records = []
for value in values:
record = Record(id=id, name=name, type=type, data=value,
zone=zone,
driver=self, extra=extra)
records.append(record)
return record
{code}
It should return records instead.
Creating a PR for this on github and adding tests to check for correct return
values as well.
This issue was discovered by http://github.com/jvrplmlmn
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] libcloud pull request: Brightbox compute Driver: Fixed attribute n...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Openstack 1 1 support
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Libcloud 359 download template
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: LIBCLOUD-650: ex_create_multi_value_record ...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Added some as-yet-unimplemented methods to ...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
libcloud git commit: Dummy commit to close PRs which:
Repository: libcloud Updated Branches: refs/heads/trunk eb36e6277 - 5591e2eb9 Dummy commit to close PRs which: * have already been merged * are old and obsolete * are not releavant anymore Closes #18 Closes #19 Closes #24 Closes #26 Closes #28 Closes #81 Closes #90 Closes #101 Closes #107 Closes #109 Closes #112 Closes #121 Closes #122 Closes #123 Closes #126 Closes #168 Closes #198 Closes #243 Closes #266 Closes #357 Closes #350 Closes #407 Closes #431 Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/5591e2eb Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/5591e2eb Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/5591e2eb Branch: refs/heads/trunk Commit: 5591e2eb9dd46ce25645dc8ddf9b992413c4f61d Parents: eb36e62 Author: Tomaz Muraus to...@apache.org Authored: Sat Jan 17 11:32:23 2015 +0100 Committer: Tomaz Muraus to...@apache.org Committed: Sat Jan 17 11:32:23 2015 +0100 -- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/libcloud/blob/5591e2eb/README.rst -- diff --git a/README.rst b/README.rst index 6b479ca..a89282c 100644 --- a/README.rst +++ b/README.rst @@ -38,7 +38,7 @@ more information. Documentation = -Documentation can be found at https://libcloud.readthedocs.org. +Documentation can be found at https://libcloud.readthedocs.org. Feedback
[GitHub] libcloud pull request: allow creds to be passed in dict
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Update libvirt_driver.py
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: LIBCLOUD-344: vCloud: ex_query() should ret...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: PEP8 clean up.
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: make CI build faster
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: 0.13.2
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: LIBCLOUD-439
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Update libvirt_driver.py
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: LIBCLOUD-510: Allow creation of private on...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Support for EMC Atmos and thus Ninefold Sto...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] libcloud pull request: Issue LIBCLOUD-356: Provide user-data for O...
Github user asfgit closed the pull request at: https://github.com/apache/libcloud/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
