[jira] [Closed] (LOG4J2-2313) Update LMAX Disruptor from 3.3.7 to 3.4.2

2018-04-09 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-2313.

   Resolution: Fixed
Fix Version/s: 2.11.1
   3.0.0

> Update LMAX Disruptor from 3.3.7 to 3.4.2
> -
>
> Key: LOG4J2-2313
> URL: https://issues.apache.org/jira/browse/LOG4J2-2313
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.11.0
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 3.0.0, 2.11.1
>
>
> Update LMAX Disruptor from 3.3.7 to 3.4.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2313) Update LMAX Disruptor from 3.3.7 to 3.4.2

2018-04-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431606#comment-16431606
 ] 

ASF subversion and git services commented on LOG4J2-2313:
-

Commit 1d735120361e4ff9b0cab92723e777c511030667 in logging-log4j2's branch 
refs/heads/master from [~garydgregory]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=1d73512 ]

[LOG4J2-2313] Update LMAX Disruptor from 3.3.7 to 3.4.2.

> Update LMAX Disruptor from 3.3.7 to 3.4.2
> -
>
> Key: LOG4J2-2313
> URL: https://issues.apache.org/jira/browse/LOG4J2-2313
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.11.0
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
> Fix For: 3.0.0, 2.11.1
>
>
> Update LMAX Disruptor from 3.3.7 to 3.4.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2313) Update LMAX Disruptor from 3.3.7 to 3.4.1.

2018-04-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431568#comment-16431568
 ] 

ASF subversion and git services commented on LOG4J2-2313:
-

Commit ae68a63ab35c13d4c1461782e376bfad10e7ef4f in logging-log4j2's branch 
refs/heads/release-2.x from [~garydgregory]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=ae68a63 ]

[LOG4J2-2313] Update LMAX Disruptor from 3.3.7 to 3.4.2.

> Update LMAX Disruptor from 3.3.7 to 3.4.1.
> --
>
> Key: LOG4J2-2313
> URL: https://issues.apache.org/jira/browse/LOG4J2-2313
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.11.0
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
>
> Update LMAX Disruptor from 3.3.7 to 3.4.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (LOG4J2-2313) Update LMAX Disruptor from 3.3.7 to 3.4.2

2018-04-09 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-2313:
-
Summary: Update LMAX Disruptor from 3.3.7 to 3.4.2  (was: Update LMAX 
Disruptor from 3.3.7 to 3.4.1.)

> Update LMAX Disruptor from 3.3.7 to 3.4.2
> -
>
> Key: LOG4J2-2313
> URL: https://issues.apache.org/jira/browse/LOG4J2-2313
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.11.0
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
>
> Update LMAX Disruptor from 3.3.7 to 3.4.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (LOG4J2-2299) Using "asyncLogger" with AsyncLoggerContextSelector loses some event data

2018-04-09 Thread Carter Kozak (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carter Kozak closed LOG4J2-2299.

   Resolution: Duplicate
Fix Version/s: 3.0.0

LOG4J2-2307 improved message mementos, fixing the data loss portion of this 
ticket. There's still a bit of allocation to create mementos, but I don't like 
the AsyncLoggerConfig factory method returning an object that isn't an 
AsyncLoggerConfig.

> Using "asyncLogger" with AsyncLoggerContextSelector loses some event data
> -
>
> Key: LOG4J2-2299
> URL: https://issues.apache.org/jira/browse/LOG4J2-2299
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.11.0
>Reporter: Carter Kozak
>Assignee: Carter Kozak
>Priority: Major
> Fix For: 3.0.0
>
>
> Using mixed style "asyncLogger" definitions when AsyncLoggerContextSelector 
> is selected and reusable messages are enabled causes parameterized message 
> data to be lost (Guessing we memento the message handing it off between 
> disruptors).
> Proposal:
> Would it be objectionable to parse AsyncLoggerConfigs as standard 
> LoggerConfig when global async mode is enabled?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2313) Update LMAX Disruptor from 3.3.7 to 3.4.1.

2018-04-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431522#comment-16431522
 ] 

ASF subversion and git services commented on LOG4J2-2313:
-

Commit 45517769e19e57e1cf2c399e7884a59ff335e60c in logging-log4j2's branch 
refs/heads/master from [~garydgregory]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=4551776 ]

[LOG4J2-2313] Update LMAX Disruptor from 3.3.7 to 3.4.1. I was getting
some odd 'JVM has quit' error messages so I updated the
Surefire/Failsafe Maven plugins from 2.20.1 to 2.21.0 and that seems to
fix it. The Histogram class from LMAX has been removed so I copied it
into our test code base, it is licensed under the Apache 2.0 license.

> Update LMAX Disruptor from 3.3.7 to 3.4.1.
> --
>
> Key: LOG4J2-2313
> URL: https://issues.apache.org/jira/browse/LOG4J2-2313
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 2.11.0
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Major
>
> Update LMAX Disruptor from 3.3.7 to 3.4.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (LOG4J2-2313) Update LMAX Disruptor from 3.3.7 to 3.4.1.

2018-04-09 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-2313:


 Summary: Update LMAX Disruptor from 3.3.7 to 3.4.1.
 Key: LOG4J2-2313
 URL: https://issues.apache.org/jira/browse/LOG4J2-2313
 Project: Log4j 2
  Issue Type: Improvement
  Components: Core
Affects Versions: 2.11.0
Reporter: Gary Gregory
Assignee: Gary Gregory


Update LMAX Disruptor from 3.3.7 to 3.4.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread Matt Sicker (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Sicker resolved LOG4J2-2171.
-
   Resolution: Fixed
Fix Version/s: 3.0.0

Merged into master. Please verify and close.

> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Assignee: Matt Sicker
>Priority: Major
> Fix For: 3.0.0
>
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread Matt Sicker (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Sicker reassigned LOG4J2-2171:
---

Assignee: Matt Sicker

> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Assignee: Matt Sicker
>Priority: Major
> Fix For: 3.0.0
>
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430772#comment-16430772
 ] 

ASF GitHub Bot commented on LOG4J2-2171:


Github user asfgit closed the pull request at:

https://github.com/apache/logging-log4j2/pull/140


> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] logging-log4j2 pull request #140: [LOG4J2-2171] adding log4j2.forceTCLOnly o...

2018-04-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/logging-log4j2/pull/140


---


[jira] [Commented] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430655#comment-16430655
 ] 

ASF GitHub Bot commented on LOG4J2-2171:


Github user rmannibucau commented on the issue:

https://github.com/apache/logging-log4j2/pull/140
  
Oh missed that, done


> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430639#comment-16430639
 ] 

ASF GitHub Bot commented on LOG4J2-2171:


Github user jvz commented on the issue:

https://github.com/apache/logging-log4j2/pull/140
  
And could you re-add the docs? I just converted the page to asciidoc 
yesterday, so you'll have to check a different file: 
`src/site/asciidoc/manual/configuration.adoc`


> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] logging-log4j2 issue #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option

2018-04-09 Thread jvz
Github user jvz commented on the issue:

https://github.com/apache/logging-log4j2/pull/140
  
And could you re-add the docs? I just converted the page to asciidoc 
yesterday, so you'll have to check a different file: 
`src/site/asciidoc/manual/configuration.adoc`


---


[jira] [Commented] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread Matt Sicker (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430596#comment-16430596
 ] 

Matt Sicker commented on LOG4J2-2171:
-

Also FWIW, I have some ideas to experiment with a new plugin system for 3.0 
which should help avoid ClassLoader hacks entirely, though that's still future 
work.

> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread Ralph Goers (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430559#comment-16430559
 ] 

Ralph Goers commented on LOG4J2-2171:
-

FWIW, ignoreTCL is a carryover from Log4j 1.

> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (LOG4J2-2171) Log4j2 is not embeddable due to its system classloader usage

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430424#comment-16430424
 ] 

ASF GitHub Bot commented on LOG4J2-2171:


Github user rmannibucau commented on the issue:

https://github.com/apache/logging-log4j2/pull/140
  
@jvz  done :)


> Log4j2 is not embeddable due to its system classloader usage
> 
>
> Key: LOG4J2-2171
> URL: https://issues.apache.org/jira/browse/LOG4J2-2171
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> Hi guys,
> in several places, log4j2 enforces the system classloader to be used. I have 
> a case where I isolate a classloader from the app which can have log4j2 and I 
> don't want any leakage between both classloaders.
> This is current not possible. Can we have at least an option to skip this 
> classloader and only use the tccl one?
> For reference: {{org.apache.logging.log4j.util.LoaderUtil#getClassLoaders}}, 
> {{org.apache.logging.log4j.util.LoaderUtil#findUrlResources}}, etc... are the 
> places making it not working



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] logging-log4j2 issue #140: [LOG4J2-2171] adding log4j2.forceTCLOnly option

2018-04-09 Thread rmannibucau
Github user rmannibucau commented on the issue:

https://github.com/apache/logging-log4j2/pull/140
  
@jvz  done :)


---


[GitHub] logging-log4j2 issue #147: LOG4J2-2032 Curly braces in parameters should not...

2018-04-09 Thread kshchepanovskyi
Github user kshchepanovskyi commented on the issue:

https://github.com/apache/logging-log4j2/pull/147
  
Thanks!


---


[jira] [Commented] (LOG4J2-2032) Curly braces in parameters are treated as placeholders

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430146#comment-16430146
 ] 

ASF GitHub Bot commented on LOG4J2-2032:


Github user kshchepanovskyi closed the pull request at:

https://github.com/apache/logging-log4j2/pull/147


> Curly braces in parameters are treated as placeholders
> --
>
> Key: LOG4J2-2032
> URL: https://issues.apache.org/jira/browse/LOG4J2-2032
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders, Layouts
>Affects Versions: 2.8.2, 2.9.0, 2.10.0
> Environment: Tested on Windows and Linux.
> java version "1.8.0_144"
> Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
> Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
>Reporter: Kostiantyn Shchepanovskyi
>Assignee: Carter Kozak
>Priority: Major
> Fix For: 3.0.0
>
>
> When logging event parameter contains two consecutive opening and closing 
> curly braces - {{for example {} in the middle of parameter}}, they are 
> treated as a placeholder and are substituted by provided parameters starting 
> from index zero.
> I suspect that it affects only async loggers.
> My configuration:
> {code:xml}
> 
> 
> 
> 
> 
> %level{length=1} %date{MMdd-HHmm:ss,SSS} %logger{1.} 
> %message %X [%thread]%n
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> Test:
> {code:java}
> package com.playtech.live.platform.core.service;
> import org.junit.jupiter.api.Test;
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> public class Log4jCurlyBracesInParameterTest {
> private static final Logger LOGGER = 
> LoggerFactory.getLogger(Log4jCurlyBracesInParameterTest.class);
> @Test
> void messageWithCurlyBracesInParameter() {
> LOGGER.info("Text containing curly braces: {}", "Curly{}");
> LOGGER.info("Normal text: {}, text containing curly braces {}", 
> "Normal", "Curly{}");
> }
> }
> {code}
> Expected output:
> {code}
> I 0905-1731:01,018 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Text 
> containing curly braces: Curly{} {} [main]
> I 0905-1731:01,033 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Normal text: 
> Normal, text containing curly braces Curly{} {} [main]
> {code}
> Actual output:
> {code}
> I 0905-1731:01,018 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Text 
> containing curly braces: CurlyCurly{} {} [main]
> I 0905-1731:01,033 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Normal text: 
> Normal, text containing curly braces CurlyNormal {} [main]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] logging-log4j2 pull request #147: LOG4J2-2032 Curly braces in parameters sho...

2018-04-09 Thread kshchepanovskyi
Github user kshchepanovskyi closed the pull request at:

https://github.com/apache/logging-log4j2/pull/147


---


[jira] [Commented] (LOG4J2-2032) Curly braces in parameters are treated as placeholders

2018-04-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430145#comment-16430145
 ] 

ASF GitHub Bot commented on LOG4J2-2032:


Github user kshchepanovskyi commented on the issue:

https://github.com/apache/logging-log4j2/pull/147
  
Thanks!


> Curly braces in parameters are treated as placeholders
> --
>
> Key: LOG4J2-2032
> URL: https://issues.apache.org/jira/browse/LOG4J2-2032
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders, Layouts
>Affects Versions: 2.8.2, 2.9.0, 2.10.0
> Environment: Tested on Windows and Linux.
> java version "1.8.0_144"
> Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
> Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
>Reporter: Kostiantyn Shchepanovskyi
>Assignee: Carter Kozak
>Priority: Major
> Fix For: 3.0.0
>
>
> When logging event parameter contains two consecutive opening and closing 
> curly braces - {{for example {} in the middle of parameter}}, they are 
> treated as a placeholder and are substituted by provided parameters starting 
> from index zero.
> I suspect that it affects only async loggers.
> My configuration:
> {code:xml}
> 
> 
> 
> 
> 
> %level{length=1} %date{MMdd-HHmm:ss,SSS} %logger{1.} 
> %message %X [%thread]%n
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> Test:
> {code:java}
> package com.playtech.live.platform.core.service;
> import org.junit.jupiter.api.Test;
> import org.slf4j.Logger;
> import org.slf4j.LoggerFactory;
> public class Log4jCurlyBracesInParameterTest {
> private static final Logger LOGGER = 
> LoggerFactory.getLogger(Log4jCurlyBracesInParameterTest.class);
> @Test
> void messageWithCurlyBracesInParameter() {
> LOGGER.info("Text containing curly braces: {}", "Curly{}");
> LOGGER.info("Normal text: {}, text containing curly braces {}", 
> "Normal", "Curly{}");
> }
> }
> {code}
> Expected output:
> {code}
> I 0905-1731:01,018 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Text 
> containing curly braces: Curly{} {} [main]
> I 0905-1731:01,033 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Normal text: 
> Normal, text containing curly braces Curly{} {} [main]
> {code}
> Actual output:
> {code}
> I 0905-1731:01,018 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Text 
> containing curly braces: CurlyCurly{} {} [main]
> I 0905-1731:01,033 c.p.l.p.c.s.Log4jCurlyBracesInParameterTest Normal text: 
> Normal, text containing curly braces CurlyNormal {} [main]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] logging-log4j2 pull request #163: Add KeyValueLayout which outputs log messa...

2018-04-09 Thread Falmarri
GitHub user Falmarri opened a pull request:

https://github.com/apache/logging-log4j2/pull/163

Add KeyValueLayout which outputs log messages as key/value pairs.

Configurable to allow custom key/value pair separators, optional quotes,
configurable quote escaping

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Falmarri/logging-log4j2 feature/keyvaluelayout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/logging-log4j2/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit 00c4656155daf105a566ff2ba93fcc402a2e6ab3
Author: falmarri 
Date:   2018-04-09T05:40:49Z

Add KeyValueLayout which outputs log messages as key/value pairs.

Configurable to allow custom key/value pair separators, optional quotes,
configurable quote escaping




---