[jira] [Deleted] (LOG4J2-2450) Spam
[ https://issues.apache.org/jira/browse/LOG4J2-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory deleted LOG4J2-2450: - > Spam > > > Key: LOG4J2-2450 > URL: https://issues.apache.org/jira/browse/LOG4J2-2450 > Project: Log4j 2 > Issue Type: Bug >Reporter: Moh.riza >Priority: Major > > Deletion -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (LOG4J2-2451) Spam
Moh.riza created LOG4J2-2451: Summary: Spam Key: LOG4J2-2451 URL: https://issues.apache.org/jira/browse/LOG4J2-2451 Project: Log4j 2 Issue Type: Bug Components: Boot, Configurators, Web/Servlet Reporter: Moh.riza Deletion -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (LOG4J2-2450) Spam
Moh.riza created LOG4J2-2450: Summary: Spam Key: LOG4J2-2450 URL: https://issues.apache.org/jira/browse/LOG4J2-2450 Project: Log4j 2 Issue Type: Bug Components: API Reporter: Moh.riza Fix For: boot-1.0-alpha1 Deletion -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2427) Filter for logging logs with no marker set
[ https://issues.apache.org/jira/browse/LOG4J2-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624760#comment-16624760 ] Moh.riza commented on LOG4J2-2427: -- Removed commented code > Filter for logging logs with no marker set > -- > > Key: LOG4J2-2427 > URL: https://issues.apache.org/jira/browse/LOG4J2-2427 > Project: Log4j 2 > Issue Type: New Feature > Components: Filters >Reporter: Rimaljit Kaur >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2427) Filter for logging logs with no marker set
[ https://issues.apache.org/jira/browse/LOG4J2-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624758#comment-16624758 ] Moh.riza commented on LOG4J2-2427: -- Removed all thank you > Filter for logging logs with no marker set > -- > > Key: LOG4J2-2427 > URL: https://issues.apache.org/jira/browse/LOG4J2-2427 > Project: Log4j 2 > Issue Type: New Feature > Components: Filters >Reporter: Rimaljit Kaur >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LOG4J2-2421) AbstractEventLogger.logEvent doesn't check for missing required context attributes
[
https://issues.apache.org/jira/browse/LOG4J2-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624547#comment-16624547
]
ASF GitHub Bot commented on LOG4J2-2421:
Github user andrei-ivanov commented on the issue:
https://github.com/apache/logging-log4j-audit/pull/8
Should be fine now
> AbstractEventLogger.logEvent doesn't check for missing required context
> attributes
> --
>
> Key: LOG4J2-2421
> URL: https://issues.apache.org/jira/browse/LOG4J2-2421
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Major
>
> Logging an event through {{LogEventFactory$AuditProxy}} validates the missing
> required context attributes:
> {noformat}
> org.apache.logging.log4j.catalog.api.exception.ConstraintValidationException:
> Event cashPaymentIn has errors :
> ThreadContext does not contain required key userName
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:294)
> ~[log4j-audit-api-1.0.0.jar:1.0.0]
> {noformat}
>
> Trying the same through the {{AuditLogger}}, as the {{AuditController}} does,
> doesn't trigger the same validation and the event gets through with a payload
> like this, partially adapted from the samples:
> {code:json}
> {
> "eventName": "CashPaymentIn",
> "requestContextMap": {
> "loginId": "rgoers",
> "corpAccountNumber": "12345",
> "ipAddress": "127.0.0.1"
> },
> "properties": {
> "salesTransaction": "52913b24-2459-416d-803d-e686e63761d0",
> "currency": "EUR",
> "amount": "100.00"
> }
> }
> {code}
> As far as I see in
> [AbstractEventLogger|https://github.com/apache/logging-log4j-audit/blob/master/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/AbstractEventLogger.java#L182],
> the validation of present {{requestContextAttributes}} starts, but there is
> no check to see if the required ones are present in the {{ThreadContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] logging-log4j-audit issue #8: [LOG4J2-2421]
Github user andrei-ivanov commented on the issue: https://github.com/apache/logging-log4j-audit/pull/8 Should be fine now ð ---
[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]
Github user andrei-ivanov commented on the issue: https://github.com/apache/logging-log4j-audit/pull/4 I should have left this one for later, as it actually depends on the other ones :) ---
[jira] [Commented] (LOG4J2-2421) AbstractEventLogger.logEvent doesn't check for missing required context attributes
[
https://issues.apache.org/jira/browse/LOG4J2-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624538#comment-16624538
]
ASF GitHub Bot commented on LOG4J2-2421:
Github user rgoers commented on the issue:
https://github.com/apache/logging-log4j-audit/pull/8
See above. This PR has merge conflicts.
> AbstractEventLogger.logEvent doesn't check for missing required context
> attributes
> --
>
> Key: LOG4J2-2421
> URL: https://issues.apache.org/jira/browse/LOG4J2-2421
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Major
>
> Logging an event through {{LogEventFactory$AuditProxy}} validates the missing
> required context attributes:
> {noformat}
> org.apache.logging.log4j.catalog.api.exception.ConstraintValidationException:
> Event cashPaymentIn has errors :
> ThreadContext does not contain required key userName
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:294)
> ~[log4j-audit-api-1.0.0.jar:1.0.0]
> {noformat}
>
> Trying the same through the {{AuditLogger}}, as the {{AuditController}} does,
> doesn't trigger the same validation and the event gets through with a payload
> like this, partially adapted from the samples:
> {code:json}
> {
> "eventName": "CashPaymentIn",
> "requestContextMap": {
> "loginId": "rgoers",
> "corpAccountNumber": "12345",
> "ipAddress": "127.0.0.1"
> },
> "properties": {
> "salesTransaction": "52913b24-2459-416d-803d-e686e63761d0",
> "currency": "EUR",
> "amount": "100.00"
> }
> }
> {code}
> As far as I see in
> [AbstractEventLogger|https://github.com/apache/logging-log4j-audit/blob/master/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/AbstractEventLogger.java#L182],
> the validation of present {{requestContextAttributes}} starts, but there is
> no check to see if the required ones are present in the {{ThreadContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2443) Consistent validation exceptions
[
https://issues.apache.org/jira/browse/LOG4J2-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624541#comment-16624541
]
ASF GitHub Bot commented on LOG4J2-2443:
Github user andrei-ivanov commented on the issue:
https://github.com/apache/logging-log4j-audit/pull/4
If/when #8 also gets merged, I'll take care of the modifications for this
one.
> Consistent validation exceptions
>
>
> Key: LOG4J2-2443
> URL: https://issues.apache.org/jira/browse/LOG4J2-2443
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Major
>
> Trying to create an {{ExceptionMapper}} for the validation exceptions I
> notice that there are 2 kind of exceptions that are thrown when logging.
> {{AbstractEventLogger}} mostly throws {{AuditException}}, but there's even a
> {{IllegalStateException}} thrown, that probably can be changed to an
> {{AuditException}}.
> But then there's {{LogEventFactory}} that throws
> {{ConstraintValidationException}} for validation errors.
> I then thought there's an exception hierarchy in place, but it seems there's
> no relation between {{AuditException}} and {{ConstraintValidationException}}.
> Please consider making {{AbstractEventLogger}} also throw
> {{ConstraintValidationException}} and maybe create some hierarchy for these
> exceptions to provide them a common base exception, perhaps
> {{AuditException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2443) Consistent validation exceptions
[
https://issues.apache.org/jira/browse/LOG4J2-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624540#comment-16624540
]
ASF GitHub Bot commented on LOG4J2-2443:
Github user rgoers commented on the issue:
https://github.com/apache/logging-log4j-audit/pull/4
This PR has merge conflicts.
> Consistent validation exceptions
>
>
> Key: LOG4J2-2443
> URL: https://issues.apache.org/jira/browse/LOG4J2-2443
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Major
>
> Trying to create an {{ExceptionMapper}} for the validation exceptions I
> notice that there are 2 kind of exceptions that are thrown when logging.
> {{AbstractEventLogger}} mostly throws {{AuditException}}, but there's even a
> {{IllegalStateException}} thrown, that probably can be changed to an
> {{AuditException}}.
> But then there's {{LogEventFactory}} that throws
> {{ConstraintValidationException}} for validation errors.
> I then thought there's an exception hierarchy in place, but it seems there's
> no relation between {{AuditException}} and {{ConstraintValidationException}}.
> Please consider making {{AbstractEventLogger}} also throw
> {{ConstraintValidationException}} and maybe create some hierarchy for these
> exceptions to provide them a common base exception, perhaps
> {{AuditException}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]
Github user andrei-ivanov commented on the issue: https://github.com/apache/logging-log4j-audit/pull/4 If/when #8 also gets merged, I'll take care of the modifications for this one. ---
[GitHub] logging-log4j-audit issue #4: [LOG4J2-2443]
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j-audit/pull/4 This PR has merge conflicts. ---
[GitHub] logging-log4j-audit issue #8: [LOG4J2-2421]
Github user rgoers commented on the issue: https://github.com/apache/logging-log4j-audit/pull/8 See above. This PR has merge conflicts. ---
[jira] [Closed] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Ivanov closed LOG4J2-2417.
-
Looks fine, thank you.
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
> Fix For: Log4j-Audit 1.0.1
>
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Ivanov closed LOG4J2-2420.
-
Looks fine, thank you.
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
> Fix For: Log4j-Audit 1.0.1
>
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2431) Narrow the type returned by LogEventFactory.getEvent
[
https://issues.apache.org/jira/browse/LOG4J2-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624528#comment-16624528
]
Andrei Ivanov commented on LOG4J2-2431:
---
I'll get the ICLA sent on Monday.
Thank you :)
> Narrow the type returned by LogEventFactory.getEvent
>
>
> Key: LOG4J2-2431
> URL: https://issues.apache.org/jira/browse/LOG4J2-2431
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Trivial
> Fix For: Log4j-Audit 1.0.1
>
>
> Seeing that the result of
> [{{LogEventFactory.getEvent}}|https://github.com/apache/logging-log4j-audit/blob/master/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/LogEventFactory.java#L90]
> is always cast to {{AuditEvent}}, I think the definition of the return type
> can be narrowed like this:
> {code:java}
> public static T getEvent(Class intrface)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (LOG4J2-2431) Narrow the type returned by LogEventFactory.getEvent
[
https://issues.apache.org/jira/browse/LOG4J2-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Ivanov closed LOG4J2-2431.
-
> Narrow the type returned by LogEventFactory.getEvent
>
>
> Key: LOG4J2-2431
> URL: https://issues.apache.org/jira/browse/LOG4J2-2431
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Trivial
> Fix For: Log4j-Audit 1.0.1
>
>
> Seeing that the result of
> [{{LogEventFactory.getEvent}}|https://github.com/apache/logging-log4j-audit/blob/master/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/LogEventFactory.java#L90]
> is always cast to {{AuditEvent}}, I think the definition of the return type
> can be narrowed like this:
> {code:java}
> public static T getEvent(Class intrface)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers resolved LOG4J2-2417.
-
Resolution: Fixed
Fix Version/s: Log4j-Audit 1.0.1
Patch applied. Please verify and close.
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
> Fix For: Log4j-Audit 1.0.1
>
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624522#comment-16624522
]
ASF subversion and git services commented on LOG4J2-2420:
-
Commit d98904d92329b7ffe2da5e59830d09200528c875 in logging-log4j-audit's branch
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=d98904d ]
[LOG4J2-2420] allow events without attributes
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
> Fix For: Log4j-Audit 1.0.1
>
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624520#comment-16624520
]
ASF subversion and git services commented on LOG4J2-2417:
-
Commit 3e3bf9d34f5468d474924c2a07e8865893831347 in logging-log4j-audit's branch
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=3e3bf9d ]
[LOG4J2-2417] reuse maxLength extraction routine
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624519#comment-16624519
]
ASF subversion and git services commented on LOG4J2-2417:
-
Commit 882d45a05b51d24a40fda2659b0c02d877e90f24 in logging-log4j-audit's branch
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=882d45a ]
[LOG4J2-2417] fix access of optional annotations
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624521#comment-16624521
]
ASF subversion and git services commented on LOG4J2-2417:
-
Commit 02529bb74a58b87643867c2df7731b402f9f5f86 in logging-log4j-audit's branch
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=02529bb ]
[LOG4J2-2417] handle null properties
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624523#comment-16624523
]
ASF subversion and git services commented on LOG4J2-2417:
-
Commit 07e5419f06a30541ab83181dd0712583e9fd51d3 in logging-log4j-audit's branch
refs/heads/master from [~ralph.go...@dslextreme.com]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=07e5419 ]
LOG4J2-2417 - Better handling of optional properties
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2417) Better handling of optional properties
[
https://issues.apache.org/jira/browse/LOG4J2-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624524#comment-16624524
]
ASF GitHub Bot commented on LOG4J2-2417:
Github user asfgit closed the pull request at:
https://github.com/apache/logging-log4j-audit/pull/7
> Better handling of optional properties
> --
>
> Key: LOG4J2-2417
> URL: https://issues.apache.org/jira/browse/LOG4J2-2417
> Project: Log4j 2
> Issue Type: Bug
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Assignee: Ralph Goers
>Priority: Minor
>
> The Log4j-Audit project page indicates this as the place to file tickets, but
> I don't see the 1.0.0 version for it.
> Investigating the use of the project, I started with a basic `catalog.json`,
> with just an event and 2 attributes, both with {{requestContext = false}}.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraint(LogEventFactory.java:385)
> at
> org.apache.logging.log4j.audit.LogEventFactory.validateContextConstraints(LogEventFactory.java:380)
> at
> org.apache.logging.log4j.audit.LogEventFactory.access$400(LogEventFactory.java:57)
> at
> org.apache.logging.log4j.audit.LogEventFactory$AuditProxy.invoke(LogEventFactory.java:263)
> {noformat}
> As far as I understand, request context attributes are not required.
> ??While usage of a RequestContext is not required, the use of one should be
> considered a best practice.??
> Also, AFAIU, the event attributes should also be optional, there's even a
> test event *login* like that.
> Also the code seems to indicate that {{@MaxLength}} should also be optional,
> same as {{@RequestContext}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] logging-log4j-audit pull request #7: [LOG4J2-2417]
Github user asfgit closed the pull request at: https://github.com/apache/logging-log4j-audit/pull/7 ---
[jira] [Resolved] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers resolved LOG4J2-2420.
-
Resolution: Fixed
Fix Version/s: Log4j-Audit 1.0.1
Patch applied. Please verify and close.
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
> Fix For: Log4j-Audit 1.0.1
>
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624513#comment-16624513
]
ASF subversion and git services commented on LOG4J2-2420:
-
Commit e333cda808ffd3472477bdf48c119fcf256d3970 in logging-log4j-audit's branch
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=e333cda ]
[LOG4J2-2420] switch the logging of request processing duration to TRACE level
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624514#comment-16624514
]
ASF subversion and git services commented on LOG4J2-2420:
-
Commit 83b9afa43f9eac5ce61c3d6c5c535fd7f5143100 in logging-log4j-audit's branch
refs/heads/master from [~ralph.go...@dslextreme.com]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=83b9afa ]
LOG4J2-2420 - RequestContextFilter logging cleanup
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624515#comment-16624515
]
ASF GitHub Bot commented on LOG4J2-2420:
Github user asfgit closed the pull request at:
https://github.com/apache/logging-log4j-audit/pull/6
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (LOG4J2-2420) RequestContextFilter logging cleanup
[
https://issues.apache.org/jira/browse/LOG4J2-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624512#comment-16624512
]
ASF subversion and git services commented on LOG4J2-2420:
-
Commit 390cbe9798a617eafc7102ecd629da8ea4751266 in logging-log4j-audit's branch
refs/heads/master from [~aivanov93]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j-audit.git;h=390cbe9 ]
[LOG4J2-2420] fix parameter logging
> RequestContextFilter logging cleanup
>
>
> Key: LOG4J2-2420
> URL: https://issues.apache.org/jira/browse/LOG4J2-2420
> Project: Log4j 2
> Issue Type: Improvement
> Components: Log4j-Audit
>Affects Versions: Log4j-Audit 1.0.0
>Reporter: Andrei Ivanov
>Priority: Minor
>
> The {{RequestContextFilter}} logs some details that should be done on
> {{DEBUG}} or {{TRACE}} instead of {{INFO}}.
> {noformat}
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Starting
> request {}/productrepository/2594
> INFO [org.apache.logging.log4j.audit.rest.RequestContextFilter] - Request
> /productrepository/2594 completed in 0.139279500 seconds
> {noformat}
> There's even a small bug on the 1st
> [line|https://github.com/apache/logging-log4j-audit/blob/9bab5dad26e67642573cbc8257b6cbcafb23bf3c/log4j-audit/log4j-audit-api/src/main/java/org/apache/logging/log4j/audit/rest/RequestContextFilter.java#L82]
> where concatenation was used.
> The calculation of the request duration should also be moved in an if block,
> to avoid it if it won't be logged.
> Same for the Maven plugin, I think it should print the name of the generated
> classes only on debug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
