[GitHub] dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.
dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458578245 I propose to add both oldFile and newFile to the method arguments. Is there a reasoning why the pull request is not based onto develop? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.
dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458574137 Would it be more appropriate to add an invocation of an emty but virtual PostRollFile method? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
