[GitHub] logging-log4net pull request #27: Added tests for the RollingLockStrategy

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/logging-log4net/pull/27


---

[GitHub] logging-log4net pull request #27: Added tests for the RollingLockStrategy

[astryia]

Github user astryia commented on a diff in the pull request:

https://github.com/apache/logging-log4net/pull/27#discussion_r221872745
  
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -1747,17 +1773,93 @@ public void TestDefaultLockingModel()
DestroyLogger();
}
 
-   [Test, Ignore("Not Implemented: this test should assert that 
the rolling file appender works when configured with rolling lock strategy 
none")]
-   public void TestRollingLockStrategyNone()
+   /// 
+   /// Verifies that the rolling file appender works when 
configured with rolling lock strategy none and local mutex
--- End diff --

Done


---

[GitHub] logging-log4net pull request #27: Added tests for the RollingLockStrategy

[astryia]

Github user astryia commented on a diff in the pull request:

https://github.com/apache/logging-log4net/pull/27#discussion_r221862782
  
--- Diff: tests/src/Appender/RollingFileAppenderTest.cs ---
@@ -1747,17 +1773,93 @@ public void TestDefaultLockingModel()
DestroyLogger();
}
 
-   [Test, Ignore("Not Implemented: this test should assert that 
the rolling file appender works when configured with rolling lock strategy 
none")]
-   public void TestRollingLockStrategyNone()
+   /// 
+   /// Verifies that the rolling file appender works when 
configured with rolling lock strategy none and local mutex
--- End diff --

I can update summary as following
**"Verifies that the rolling file appender works when configured with 
rolling lock strategy"**
since there are two test cases there for 
_RollingLockStrategyKind.LocalMutex_ and for _RollingLockStrategyKind.None_


---

[GitHub] logging-log4net pull request #27: Added tests for the RollingLockStrategy

[astryia]

GitHub user astryia opened a pull request:

https://github.com/apache/logging-log4net/pull/27

 Added tests for the RollingLockStrategy



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astryia/logging-log4net 
feature/rfa-configurable-rolling-mutex

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/logging-log4net/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 6935940dd0d345b395268c95283bf03e6d31ab03
Author: Andrei Stryia 
Date:   2018-10-01T10:36:47Z

Added tests for the RollingLockStrategy

commit f22025fd4d6657019577606a4813953cb0137be2
Author: Andrei Stryia 
Date:   2018-10-01T10:42:43Z

Code was simplified with TestCase




---