Re: [PR] Remove JMX support (logging-log4j2)

[via GitHub]

ppkarwasz commented on PR #2228:
URL: https://github.com/apache/logging-log4j2/pull/2228#issuecomment-1906233393

   Part of  #2163


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove JMX support (logging-log4j2)

[via GitHub]

ppkarwasz merged PR #2228:
URL: https://github.com/apache/logging-log4j2/pull/2228


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove JMX support (logging-log4j2)

[via GitHub]

vy commented on code in PR #2228:
URL: https://github.com/apache/logging-log4j2/pull/2228#discussion_r1463329846


##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
@@ -436,13 +435,7 @@ public boolean stop(final long timeout, final TimeUnit 
timeUnit) {
 }
 
 this.setStopping();
-String name = getName();
-try {
-Server.unregisterLoggerContext(name); // LOG4J2-406, LOG4J2-500
-} catch (final LinkageError | Exception e) {
-// LOG4J2-1506 Hello Android, GAE
-LOGGER.error("Unable to unregister MBeans", e);
-}
+

Review Comment:
   Oh! :facepalm: Got it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove JMX support (logging-log4j2)

[via GitHub]

ppkarwasz commented on code in PR #2228:
URL: https://github.com/apache/logging-log4j2/pull/2228#discussion_r1463254211


##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
@@ -436,13 +435,7 @@ public boolean stop(final long timeout, final TimeUnit 
timeUnit) {
 }
 
 this.setStopping();
-String name = getName();
-try {
-Server.unregisterLoggerContext(name); // LOG4J2-406, LOG4J2-500
-} catch (final LinkageError | Exception e) {
-// LOG4J2-1506 Hello Android, GAE
-LOGGER.error("Unable to unregister MBeans", e);
-}
+

Review Comment:
   I am not sure I understand: I removed the `Server` class and method call, so 
the `try ... catch` becomes empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove JMX support (logging-log4j2)

[via GitHub]

vy commented on code in PR #2228:
URL: https://github.com/apache/logging-log4j2/pull/2228#discussion_r1463058033


##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
@@ -436,13 +435,7 @@ public boolean stop(final long timeout, final TimeUnit 
timeUnit) {
 }
 
 this.setStopping();
-String name = getName();
-try {
-Server.unregisterLoggerContext(name); // LOG4J2-406, LOG4J2-500
-} catch (final LinkageError | Exception e) {
-// LOG4J2-1506 Hello Android, GAE
-LOGGER.error("Unable to unregister MBeans", e);
-}
+

Review Comment:
   Why did we remove this and another below Android-specific guards?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org