[jira] [Commented] (MYNEWT-390) NRF HAL GPIO was not returning 1 for hal_gpio_read when pin input was high
[ https://issues.apache.org/jira/browse/MYNEWT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654902#comment-15654902 ] ASF subversion and git services commented on MYNEWT-390: Commit ee3cd755b8a96c93af1580fd0b2270355ad037d9 in incubator-mynewt-core's branch refs/heads/develop from [~wes3] [ https://git-wip-us.apache.org/repos/asf?p=incubator-mynewt-core.git;h=ee3cd75 ] MYNEWT-390: NRF hal_gpio_read does not return 1 when pin high This API is supposed to return 1 but was returning 1 << pin. This has now been fixed so if the pin is high, 1 is returned. > NRF HAL GPIO was not returning 1 for hal_gpio_read when pin input was high > -- > > Key: MYNEWT-390 > URL: https://issues.apache.org/jira/browse/MYNEWT-390 > Project: Mynewt > Issue Type: Bug >Affects Versions: v0_9_0 >Reporter: William San Filippo >Assignee: William San Filippo > Fix For: v1_0_0_beta1 > > > The HAL gpio API to read an input pin should return 0 if the pin is low and 1 > if the pin is high. The nrf (both 51 and 52) was returning a non-zero value > if the pin was high but not 1 unless pin 0 was being read. It was returning 1 > left-shifted by the pin number. This API should return only 0 or 1 (not zero > and non-zero). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYNEWT-390) NRF HAL GPIO was not returning 1 for hal_gpio_read when pin input was high
[ https://issues.apache.org/jira/browse/MYNEWT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512140#comment-15512140 ] ASF subversion and git services commented on MYNEWT-390: Commit ee3cd755b8a96c93af1580fd0b2270355ad037d9 in incubator-mynewt-core's branch refs/heads/master from [~wes3] [ https://git-wip-us.apache.org/repos/asf?p=incubator-mynewt-core.git;h=ee3cd75 ] MYNEWT-390: NRF hal_gpio_read does not return 1 when pin high This API is supposed to return 1 but was returning 1 << pin. This has now been fixed so if the pin is high, 1 is returned. > NRF HAL GPIO was not returning 1 for hal_gpio_read when pin input was high > -- > > Key: MYNEWT-390 > URL: https://issues.apache.org/jira/browse/MYNEWT-390 > Project: Mynewt > Issue Type: Bug >Affects Versions: v0_9_0 >Reporter: William San Filippo >Assignee: William San Filippo > Fix For: v1_0_0_beta1 > > > The HAL gpio API to read an input pin should return 0 if the pin is low and 1 > if the pin is high. The nrf (both 51 and 52) was returning a non-zero value > if the pin was high but not 1 unless pin 0 was being read. It was returning 1 > left-shifted by the pin number. This API should return only 0 or 1 (not zero > and non-zero). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYNEWT-390) NRF HAL GPIO was not returning 1 for hal_gpio_read when pin input was high
[ https://issues.apache.org/jira/browse/MYNEWT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512138#comment-15512138 ] ASF subversion and git services commented on MYNEWT-390: Commit 72c74e5b138f272c466d35bdd399330ec9de4c1f in incubator-mynewt-core's branch refs/heads/develop from [~wes3] [ https://git-wip-us.apache.org/repos/asf?p=incubator-mynewt-core.git;h=72c74e5 ] MYNEWT-390: NRF hal_gpio_read does not return 1 when pin high This API is supposed to return 1 but was returning 1 << pin. This has now been fixed so if the pin is high, 1 is returned. > NRF HAL GPIO was not returning 1 for hal_gpio_read when pin input was high > -- > > Key: MYNEWT-390 > URL: https://issues.apache.org/jira/browse/MYNEWT-390 > Project: Mynewt > Issue Type: Bug >Affects Versions: v0_9_0 >Reporter: William San Filippo >Assignee: William San Filippo > Fix For: v1_0_0_beta1 > > > The HAL gpio API to read an input pin should return 0 if the pin is low and 1 > if the pin is high. The nrf (both 51 and 52) was returning a non-zero value > if the pin was high but not 1 unless pin 0 was being read. It was returning 1 > left-shifted by the pin number. This API should return only 0 or 1 (not zero > and non-zero). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
