[GitHub] SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them …
SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them … URL: https://github.com/apache/incubator-netbeans/pull/508#issuecomment-412195332 I forgot to save before pushing the first one. Stupid mistake... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them …
SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them … URL: https://github.com/apache/incubator-netbeans/pull/508#issuecomment-412193036 I don't see any existing tests for the blame logic. I would add to them if they were there, but they aren't and I don't know how to write those kinds of tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] arusinha commented on issue #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method
arusinha commented on issue #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method URL: https://github.com/apache/incubator-netbeans/pull/653#issuecomment-412147286 I had implemented in last commit review comments of @rtaneja1 @vikasprabhakar This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop
sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java
##
@@ -159,8 +191,9 @@ private static boolean preConditionChecker(HintContext
ctx) {
}
// hint is not applicable for compound variable declaration.
-if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
+if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
{
return false;
+}
// hint is not applicable for variable declaration where type is
already 'var'
return !info.getTreeUtilities().isVarType(treePath);
Review comment:
for enhanced `for` loop, this helper loops until the nearest textually
following assignment, definitely not good ! It should also watch for
`JavaTokenId.COLON`. Perhaps also `JavaTokenId.SEMICOLON`, for the case a
client executes it on a declaration without an assignment. or
`JavaTokenId.RPAREN` (end of enhanced-loop header).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop
sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java
##
@@ -159,8 +191,9 @@ private static boolean preConditionChecker(HintContext
ctx) {
}
// hint is not applicable for compound variable declaration.
-if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
+if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
{
return false;
+}
// hint is not applicable for variable declaration where type is
already 'var'
return !info.getTreeUtilities().isVarType(treePath);
Review comment:
for enhanced `for` loop, this helper loops until the nearest textually
following assignment, definitely not good ! It should also watch for
`JavaTokenId.COLON`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop
sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java
##
@@ -159,8 +191,9 @@ private static boolean preConditionChecker(HintContext
ctx) {
}
// hint is not applicable for compound variable declaration.
-if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
+if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
{
return false;
+}
// hint is not applicable for variable declaration where type is
already 'var'
return !info.getTreeUtilities().isVarType(treePath);
Review comment:
for enhanced `for` loop, this helper loops back to the nearest textually
following assignment, definitely not good ! It should also watch for
`JavaTokenId.COLON`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop
sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var
hints for enhanced-for-loop
URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399
##
File path:
java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java
##
@@ -159,8 +191,9 @@ private static boolean preConditionChecker(HintContext
ctx) {
}
// hint is not applicable for compound variable declaration.
-if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
+if
(info.getTreeUtilities().isPartOfCompoundVariableDeclaration(treePath.getLeaf()))
{
return false;
+}
// hint is not applicable for variable declaration where type is
already 'var'
return !info.getTreeUtilities().isVarType(treePath);
Review comment:
for enhanced `for` loop, this helper loops back to the nearest textually
preceding assignment, definitely not good ! it seems that the helper need to
stop at the boundary of some Tree parent, e.g. statements, variable decl,
block, lambda, ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda commented on a change in pull request #629: Language Server Protocol client
jlahoda commented on a change in pull request #629: Language Server Protocol client URL: https://github.com/apache/incubator-netbeans/pull/629#discussion_r20981 ## File path: libs.lsp/nbproject/project.properties ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +javac.source=1.7 +javac.compilerargs=-Xlint -Xlint:-serial +release.external/gson-2.7.jar=modules/ext/gson-2.7.jar +release.external/guava-21.0.jar=modules/ext/guava-21.0.jar +release.external/org.eclipse.lsp4j-0.4.1.jar=modules/ext/org.eclipse.lsp4j-0.4.1.jar +release.external/org.eclipse.lsp4j.generator-0.4.1.jar=modules/ext/org.eclipse.lsp4j.generator-0.4.1.jar +release.external/org.eclipse.lsp4j.jsonrpc-0.4.1.jar=modules/ext/org.eclipse.lsp4j.jsonrpc-0.4.1.jar Review comment: I think there's a significant difference between e.g. html.editor and guava. It is not reasonably possible to have multiple copies of html.editor in the IDE, while the side-effects of having multiple copies of guava should be fairly limited. I.e. if some other module needs guava, there's no need to do "hacks and tricks", it can have its own copy. I wonder if there may be multiple versions of an OSGi module under the NB-OSGi combined module system, and if it will select the proper one based on dependencies. If not, then we may putting ourselves into a corner where upgrading various libraries will lead to significant amount of time spent ensuring things still work after the upgrade. And the time, I think, might be better spent on actual features and bugfixes of this project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] rtaneja1 commented on a change in pull request #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method
rtaneja1 commented on a change in pull request #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method URL: https://github.com/apache/incubator-netbeans/pull/653#discussion_r209200265 ## File path: refactoring.java/src/org/netbeans/modules/refactoring/java/plugins/MoveMembersTransformer.java ## @@ -25,6 +25,7 @@ import com.sun.source.util.TreePath; import org.netbeans.api.java.source.support.ErrorAwareTreeScanner; import com.sun.source.util.Trees; +import com.sun.tools.javac.tree.JCTree.JCMemberReference; Review comment: Use MemberReferenceTree here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #629: Language Server Protocol client
JaroslavTulach commented on a change in pull request #629: Language Server Protocol client URL: https://github.com/apache/incubator-netbeans/pull/629#discussion_r209164800 ## File path: libs.lsp/nbproject/project.properties ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +javac.source=1.7 +javac.compilerargs=-Xlint -Xlint:-serial +release.external/gson-2.7.jar=modules/ext/gson-2.7.jar +release.external/guava-21.0.jar=modules/ext/guava-21.0.jar +release.external/org.eclipse.lsp4j-0.4.1.jar=modules/ext/org.eclipse.lsp4j-0.4.1.jar +release.external/org.eclipse.lsp4j.generator-0.4.1.jar=modules/ext/org.eclipse.lsp4j.generator-0.4.1.jar +release.external/org.eclipse.lsp4j.jsonrpc-0.4.1.jar=modules/ext/org.eclipse.lsp4j.jsonrpc-0.4.1.jar Review comment: In the context of friend dependencies discussion (raging on in parallel), I see an attempt to bring private only copy of popular libraries like `gson` or `guava` going the exactly opposite way. Attitude like this brought NetBeans to the "overuse of friend deps" which leads to hacks and tricks to workaround it. I prefer exposing popular 3rd party libraries (especially those packaged as OSGi bundles) as reusable components. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
