[GitHub] [netbeans] geertjanw commented on a change in pull request #1547: [NETBEANS-3164]:Fixed issue in Text-Block

2019-10-05 Thread GitBox
geertjanw commented on a change in pull request #1547: [NETBEANS-3164]:Fixed 
issue in Text-Block
URL: https://github.com/apache/netbeans/pull/1547#discussion_r331742663
 
 

 ##
 File path: extra/nbjavac.impl/release/modules/ext/nb-javac-13-impl.jar.external
 ##
 @@ -1,4 +1,4 @@
-CRC:2001595618
-SIZE:3405169
-URL:https://netbeans.osuosl.org/binaries/58ECEA2987072A9AD96F2ECF82C18AB90CEF8CFD-nb-javac-13-impl.jar
-URL:https://hg.netbeans.org/binaries/58ECEA2987072A9AD96F2ECF82C18AB90CEF8CFD-nb-javac-13-impl.jar
+CRC:96561489
+SIZE:3411241
+URL:http://netbeans.osuosl.org/binaries/344C8C2A8B421A52ABE725A677BF75659C17FEB6-nb-javac-13-impl.jar
 
 Review comment:
   Well, see above, @graben still has the same problem as before.
   
   What is the version that one should see when installing the nb-javac that 
fixes this problem?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[GitHub] [netbeans] geertjanw commented on a change in pull request #1547: [NETBEANS-3164]:Fixed issue in Text-Block

2019-10-05 Thread GitBox
geertjanw commented on a change in pull request #1547: [NETBEANS-3164]:Fixed 
issue in Text-Block
URL: https://github.com/apache/netbeans/pull/1547#discussion_r331741959
 
 

 ##
 File path: extra/nbjavac.impl/release/modules/ext/nb-javac-13-impl.jar.external
 ##
 @@ -1,4 +1,4 @@
-CRC:2001595618
-SIZE:3405169
-URL:https://netbeans.osuosl.org/binaries/58ECEA2987072A9AD96F2ECF82C18AB90CEF8CFD-nb-javac-13-impl.jar
-URL:https://hg.netbeans.org/binaries/58ECEA2987072A9AD96F2ECF82C18AB90CEF8CFD-nb-javac-13-impl.jar
+CRC:96561489
+SIZE:3411241
+URL:http://netbeans.osuosl.org/binaries/344C8C2A8B421A52ABE725A677BF75659C17FEB6-nb-javac-13-impl.jar
 
 Review comment:
   Yes, it does, we need to use https please.
   
   Also, does this PR solve the problem of text block support not working if 
the JDK of NetBeans is not set to JDK 13?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists