Re: [PR] Fix Url in modules description [netbeans]

2024-03-28 Thread via GitHub


ebarboni merged PR #7202:
URL: https://github.com/apache/netbeans/pull/7202


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Re: [PR] Fix Url in modules description [netbeans]

2024-03-27 Thread via GitHub


mbien commented on PR #7202:
URL: https://github.com/apache/netbeans/pull/7202#issuecomment-2022987199

   don't forget to squash before merge ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Re: [PR] Fix Url in modules description [netbeans]

2024-03-27 Thread via GitHub


mbien commented on PR #7202:
URL: https://github.com/apache/netbeans/pull/7202#issuecomment-2022910868

   please use https://github.com/apache/netbeans/labels/ci%3Adev-build label 
for PRs like this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Re: [PR] Fix Url in modules description [netbeans]

2024-03-27 Thread via GitHub


mbien commented on code in PR #7202:
URL: https://github.com/apache/netbeans/pull/7202#discussion_r1541152732


##
webcommon/javascript2.kit/src/org/netbeans/modules/javascript2/kit/Bundle.properties:
##
@@ -20,4 +20,4 @@ OpenIDE-Module-Name=JavaScript2 Kit
 OpenIDE-Module-Short-Description=An umbrella module covering all modules 
required for JavaScript support.
 OpenIDE-Module-Long-Description=\
 JavaScript support: editing, refactoring, hints, etc.\n\n\
-For more information, see\nhttp://wiki.netbeans.org/wiki/view/JavaScript
+For more information, see\n https://netbeans.apache.org/wiki/main/wiki/JavaScript/;>Apache NetBeans 
Javascript

Review Comment:
   ~link doesn't work: https://netbeans.apache.org/wiki/main/wiki/JavaScript/~ 
ah thats the other PR
   
   nitpick: 
- the `\n` is probably no longer needed before the link
- change Javascript to JavaScript



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Re: [PR] Fix Url in modules description [netbeans]

2024-03-27 Thread via GitHub


mbien commented on code in PR #7202:
URL: https://github.com/apache/netbeans/pull/7202#discussion_r1541152732


##
webcommon/javascript2.kit/src/org/netbeans/modules/javascript2/kit/Bundle.properties:
##
@@ -20,4 +20,4 @@ OpenIDE-Module-Name=JavaScript2 Kit
 OpenIDE-Module-Short-Description=An umbrella module covering all modules 
required for JavaScript support.
 OpenIDE-Module-Long-Description=\
 JavaScript support: editing, refactoring, hints, etc.\n\n\
-For more information, see\nhttp://wiki.netbeans.org/wiki/view/JavaScript
+For more information, see\n https://netbeans.apache.org/wiki/main/wiki/JavaScript/;>Apache NetBeans 
Javascript

Review Comment:
   link doesn't work: https://netbeans.apache.org/wiki/main/wiki/JavaScript/
   
   nitpick: 
- the `\n` is probably no longer needed before the link
- change Javascript to JavaScript



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[PR] Fix Url in modules description [netbeans]

2024-03-27 Thread via GitHub


ebarboni opened a new pull request, #7202:
URL: https://github.com/apache/netbeans/pull/7202

   Try to make some url linkable in module long description, to have some 
interaction link we have for gradle / maven plugin. 
   Fix old link.
   
   Found a missing javascript wiki page ressurected in this PR
   https://github.com/apache/netbeans-antora-wiki/pull/9
   
   https://jersey.dev.java.net is https://github.com/eclipse-ee4j/jersey


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists