Re: [PR] Java Code Templates for records and sealed types [netbeans]
lkishalmi merged PR #7088: URL: https://github.com/apache/netbeans/pull/7088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java Code Templates for records and sealed types [netbeans]
lkishalmi commented on PR #7088: URL: https://github.com/apache/netbeans/pull/7088#issuecomment-1967268702 The change is already there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java Code Templates for records and sealed types [netbeans]
mbien commented on PR #7088: URL: https://github.com/apache/netbeans/pull/7088#issuecomment-1967113445 > @mbien Would this be Ok with you? I went with `P` for `public` and `p` for `private` that would be mostly consistent with other abbrevs like `Psfs` for `public static final String` Yes, if this makes it more consistent to other templates - please change it as you think its best. I am no heavy template user, I probably know less than 10. But rec and lofmofsof I will probably remember ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java Code Templates for records and sealed types [netbeans]
lkishalmi commented on PR #7088: URL: https://github.com/apache/netbeans/pull/7088#issuecomment-1966868406 @mbien Would this be Ok with you? I went with `P` for `public` and `p` for `private` that would be mostly consistent with other abbrevs like `Psfs` for `public static final String` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Java Code Templates for records and sealed types [netbeans]
mbien commented on code in PR #7088:
URL: https://github.com/apache/netbeans/pull/7088#discussion_r1498328345
##
java/java.editor/src/org/netbeans/modules/java/editor/resources/DefaultAbbrevs.xml:
##
@@ -489,6 +493,25 @@ ${cursor}]]>
}
}
]]>
+
+
+
+
+
+
+
Review Comment:
how about letting `rec` generate `record ${Type}(${cursor}) {}` and `purec`
`public record ${Type}(${cursor}) {}`?
Since i found declaring records inside methods is quite common, those would
have no `public`/`private` modifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
