[GitHub] emilianbold commented on issue #548: [NETBEANS-781] Adds Maven coordinates for Ant libs

2018-05-15 Thread GitBox 
emilianbold commented on issue #548: [NETBEANS-781] Adds Maven coordinates for 
Ant libs
URL: 
https://github.com/apache/incubator-netbeans/pull/548#issuecomment-389130009
 
 
   I would like for somebody to confirm it's working.
   
   It can be merged, but this won't close NETBEANS-781 though, it's just a 1st 
step necessary.
   
   Once Ant 1.10.4 is officially release I can more easily switch to that 
version if this commit is in (and then close NETBEANS-781).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] geertjanw commented on issue #468: nb-javac jars upgrade for NETBEANS-463 fix

2018-05-15 Thread GitBox 
geertjanw commented on issue #468: nb-javac jars upgrade for NETBEANS-463 fix 
URL: 
https://github.com/apache/incubator-netbeans/pull/468#issuecomment-389135323
 
 
   Great, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] geertjanw closed pull request #468: nb-javac jars upgrade for NETBEANS-463 fix

2018-05-15 Thread GitBox 
geertjanw closed pull request #468: nb-javac jars upgrade for NETBEANS-463 fix 
URL: https://github.com/apache/incubator-netbeans/pull/468
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/java.source.base/test/unit/src/org/netbeans/api/java/source/TreePathHandleTest.java
 
b/java.source.base/test/unit/src/org/netbeans/api/java/source/TreePathHandleTest.java
index 5467a5218..c835d33f6 100644
--- 
a/java.source.base/test/unit/src/org/netbeans/api/java/source/TreePathHandleTest.java
+++ 
b/java.source.base/test/unit/src/org/netbeans/api/java/source/TreePathHandleTest.java
@@ -29,8 +29,11 @@
 import java.security.Permission;
 import javax.lang.model.element.Element;
 import javax.lang.model.element.TypeElement;
+import javax.lang.model.element.VariableElement;
 import org.netbeans.api.java.source.JavaSource.Phase;
 import org.netbeans.junit.NbTestCase;
+import org.netbeans.modules.java.source.parsing.JavacParser;
+import org.netbeans.modules.java.source.usages.ClassFileUtil;
 import org.openide.filesystems.FileLock;
 import org.openide.filesystems.FileObject;
 import org.openide.filesystems.FileUtil;
@@ -422,6 +425,33 @@ public void testLocVar() throws Exception {
 assertNotNull(handle.resolveElement(info));
 }
 
+public void testVarInstanceMember() throws Exception {
+JavacParser.DISABLE_SOURCE_LEVEL_DOWNGRADE = true;
+FileObject file = FileUtil.createData(sourceRoot, "test/Test.java"); 
//NOI18N
+String code = "package test; public class Test {var v1;\n var 
v2=()->{}; \n public Test() {}}"; //NOI18N
+
+writeIntoFile(file, code);
+SourceUtilsTestUtil.setSourceLevel(file, "1.10"); //NOI18N
+JavaSource js = JavaSource.forFileObject(file);
+
+CompilationInfo info = SourceUtilsTestUtil.getCompilationInfo(js, 
Phase.RESOLVED);
+assertTrue(info.getDiagnostics().size() > 0);
+
+TreePath tp = info.getTreeUtilities().pathFor(code.indexOf("var v1") + 
1); //NOI18N
+VariableElement elem = (VariableElement) 
info.getTrees().getElement(tp);
+ClassFileUtil.createFieldDescriptor(elem);
+TreePathHandle handle = TreePathHandle.create(tp, info);
+assertNotNull(handle.getElementHandle());
+
+tp = info.getTreeUtilities().pathFor(code.indexOf("var v2") + 1); 
//NOI18N
+elem = (VariableElement) info.getTrees().getElement(tp);
+ClassFileUtil.createFieldDescriptor(elem);
+
+handle = TreePathHandle.create(tp, info);
+assertNotNull(handle.getElementHandle());
+JavacParser.DISABLE_SOURCE_LEVEL_DOWNGRADE = false;
+}
+
 private static final class SecMan extends SecurityManager {
 
 @Override
diff --git a/libs.javacapi/external/binaries-list 
b/libs.javacapi/external/binaries-list
index 8f48fabb3..f191d048f 100644
--- a/libs.javacapi/external/binaries-list
+++ b/libs.javacapi/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-1FD58C0401F7F012CE366CFE9E1BB9DA7AB7768F nb-javac-9-api.jar
+C118C62F36DEA3EDCBC53B95DDA3275B012B4DFC nb-javac-9-api.jar
diff --git a/libs.javacimpl/external/binaries-list 
b/libs.javacimpl/external/binaries-list
index 0a3d59014..c5db0c20e 100644
--- a/libs.javacimpl/external/binaries-list
+++ b/libs.javacimpl/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-B0715954783E5F4909E329FA39E8BC50E161B1ED nb-javac-9-impl.jar
+58FB802FDDA63D542093356F44F6CC896AF109E1 nb-javac-9-impl.jar


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] geertjanw commented on issue #545: [NETBEANS-785] java.lang.IllegalArgumentException

2018-05-15 Thread GitBox 
geertjanw commented on issue #545: [NETBEANS-785] 
java.lang.IllegalArgumentException
URL: 
https://github.com/apache/incubator-netbeans/pull/545#issuecomment-389127513
 
 
   Looks right, merging it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

2018-05-15 Thread GitBox 
jkovalsky commented on issue #40: Trying to setup a location for updates, 
redirecting to the synergy VM…
URL: 
https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-389148807
 
 
   I confirm that requests for GZipped module catalog 
http://netbeans-vm.apache.org/uc/9.0/updates.xml.gz from IDE are recorded 
correctly:
   
   `<%JSON:httpd_access%> { "time": "2018-05-15T12:23:40+", "clientip": 
"88.101.131.67", "duration": 131427, "status": 200, "request": 
"/uc/9.0/updates.xml.gz?unique=NB_CND_EXTIDE_GFMOD_GROOVY_JAVA_JC_MOB_PHP_WEBCOMMON_WEBEE096a88621-cef6-4ab9-ae6a-96772142ec5f_1dd774a0-d418-45fa-9fae-9fb4d222df8e",
 "uri": "/uc/9.0/updates.xml.gz", "remote_user": "-", "query_string": 
"?unique=NB_CND_EXTIDE_GFMOD_GROOVY_JAVA_JC_MOB_PHP_WEBCOMMON_WEBEE096a88621-cef6-4ab9-ae6a-96772142ec5f_1dd774a0-d418-45fa-9fae-9fb4d222df8e",
 "document": "/var/www/html/uc/9.0/updates.xml.gz", "bytes": 83682, 
"request_method": "GET", "referer": "-", "useragent": "NetBeans", "vhost": 
"netbeans-vm.apache.org", "geo_country": "-", "geo_long": "-", "geo_lat": "-", 
"geo_coords": "-,-", "geo_city": "-", "geo_combo": "-, -" }`
   
   Besides, the puppet configuration for that VM is here: 
https://github.com/apache/infrastructure-puppet/blob/6a50871fb4e28a7876c787ff22aa5ee4ec4e54e9/data/nodes/netbeans-vm.apache.org.yaml


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

2018-05-15 Thread GitBox 
vieiro commented on issue #40: Trying to setup a location for updates, 
redirecting to the synergy VM…
URL: 
https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-389108775
 
 
   Maybe we should set up a RewriteLog [1], but I can't tell without looking at 
the server configuration. Maybe @jkovalsky wants to explain the current setup 
(private email may be better than posting here).
   
   [1] 
https://serverfault.com/questions/10796/apache-where-to-examine-the-redirection-logs


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] geertjanw commented on issue #548: [NETBEANS-781] Adds Maven coordinates for Ant libs

2018-05-15 Thread GitBox 
geertjanw commented on issue #548: [NETBEANS-781] Adds Maven coordinates for 
Ant libs
URL: 
https://github.com/apache/incubator-netbeans/pull/548#issuecomment-389126820
 
 
   Great. Can I merge it or is it waiting for anything else?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] rlenferink opened a new pull request #42: Broken links fixed and typos resolved

2018-05-15 Thread GitBox 
rlenferink opened a new pull request #42: Broken links fixed and typos resolved
URL: https://github.com/apache/incubator-netbeans-website/pull/42
 
 
   Fixed a few typos and resolved a couple of broken links for the NetBeans 
website.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] vieiro commented on issue #42: Broken links fixed and typos resolved

2018-05-15 Thread GitBox 
vieiro commented on issue #42: Broken links fixed and typos resolved
URL: 
https://github.com/apache/incubator-netbeans-website/pull/42#issuecomment-389396795
 
 
   Looks great to me! Thanks @rlenferink !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

2018-05-15 Thread GitBox 
timboudreau commented on issue #537: Maven Indexing Optimizations
URL: 
https://github.com/apache/incubator-netbeans/pull/537#issuecomment-389397789
 
 
   Fixed.
   
   -Tim
   
   On Sun, May 13, 2018 at 12:31 PM, Matthias Bläsing  wrote:
   
   > @timboudreau  - I'm not yet merging. The
   > MatchWords needs to be adjusted. I read it so, that the class should do
   > prefix matches, this fails - under this assumption I added a unittest and
   > change to MatchWords.java.
   >
   > For the FastScanner - it would be good to describe why this replacement
   > for the DefaultScanner from maven-indexer is better and what are the
   > consequences.
   >
   > The Warning-Suppressor in ClassDependencyIndexCreator (line 318) can be
   > removed, as the loop that required it, was modified and is not empty
   > anymore.
   >
   > diff.patch.zip
   > 
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   http://timboudreau.com
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists