[GitHub] [netbeans] junichi11 commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
junichi11 commented on a change in pull request #1496: [NETBEANS-3095] avoid
null pointer exception in SplashPainter
URL: https://github.com/apache/netbeans/pull/1496#discussion_r324423270
##
File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java
##
@@ -544,7 +544,7 @@ private void adjustText(String text) {
if (text == null)
return ;
-if (statusBox.fm == null)
+if (statusBox == null ||statusBox.fm == null)
Review comment:
Please add a whitespace after `||`. Maybe, should use curly braces(`{}`).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#issuecomment-531476536 @eirikbakke Could you please have a look at this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rtaneja1 opened a new pull request #1502: Custom select clusters installer
rtaneja1 opened a new pull request #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502 Enabled Customize panel in installer wizards to select the cluster to install. Support Javase, Javaee, HTML/JS,PHP This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1502: Custom select clusters installer
neilcsmith-net commented on issue #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502#issuecomment-531499351 This looks like it was based off the 11.1 release branch rather than master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rtaneja1 commented on issue #1502: Custom select clusters installer
rtaneja1 commented on issue #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502#issuecomment-531499689 I started work on branch off release 11.1, but this only includes installers related files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw closed pull request #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…
geertjanw closed pull request #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project…
geertjanw commented on issue #1473: [NETBEANS-2751] Register OpenJFX sample artifacts as NetBeans project… URL: https://github.com/apache/netbeans/pull/1473#issuecomment-531504014 Closing this one. Pushing a new one with a different and more complete solution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1502: Custom select clusters installer
neilcsmith-net commented on issue #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502#issuecomment-531504059 11.1 has a lot of commits that are not meant to go in master though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw opened a new pull request #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw opened a new pull request #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503 This does the following: - Integrates the OpenJFX Gluon samples correctly, using their new 0.0.3 release. - Restructures the Samples category in the New Project dialog in "Java with Maven" and "Java with Ant". - Removes the module that was added in 11.1 that did not optimally integrate the OpenJFX Gluon samples. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531504345 https://user-images.githubusercontent.com/5309985/64912519-ea405f00-d730-11e9-816a-651a1579b0ef.png";> That's the new structure in the Samples category from this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531504531 This should go into 11.2, hope my adding the nb11.2 label helps to achieve that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
oyarzun commented on a change in pull request #1496: [NETBEANS-3095] avoid null
pointer exception in SplashPainter
URL: https://github.com/apache/netbeans/pull/1496#discussion_r324435218
##
File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java
##
@@ -544,7 +544,7 @@ private void adjustText(String text) {
if (text == null)
return ;
-if (statusBox.fm == null)
+if (statusBox == null ||statusBox.fm == null)
Review comment:
Added the missing whitespace and braces around if statements.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex…
geertjanw commented on issue #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex… URL: https://github.com/apache/netbeans/pull/1499#issuecomment-531507709 Thanks, merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex…
geertjanw merged pull request #1499: [NETBEANS-3082]: Fixed formatting issue happening on use of Switch-Ex… URL: https://github.com/apache/netbeans/pull/1499 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An…
geertjanw commented on issue #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An… URL: https://github.com/apache/netbeans/pull/1487#issuecomment-531507782 Great, very useful, merging, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An…
geertjanw merged pull request #1487: [NETBEANS-3078]:Provided Error Hint to turn on Preview Features in An… URL: https://github.com/apache/netbeans/pull/1487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men…
geertjanw merged pull request #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men… URL: https://github.com/apache/netbeans/pull/1491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men…
geertjanw commented on issue #1491: [NETBEANS-2953] Fix for NPE after pressing 'DTDs and XML Schemas' men… URL: https://github.com/apache/netbeans/pull/1491#issuecomment-531507853 Thanks, merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1477: [NETBEANS-2788] The link provided for downloading Groovy is obsolete
geertjanw commented on issue #1477: [NETBEANS-2788] The link provided for downloading Groovy is obsolete URL: https://github.com/apache/netbeans/pull/1477#issuecomment-531507922 Is this ready to merge, all comments completed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1431: Fixing java.source.base tests when running with nb-javac
geertjanw commented on issue #1431: Fixing java.source.base tests when running with nb-javac URL: https://github.com/apache/netbeans/pull/1431#issuecomment-531507984 Please merge when ready, @jlahoda. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid
null pointer exception in SplashPainter
URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437438
##
File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java
##
@@ -244,10 +244,12 @@ private static Icon loadContentIcon(boolean about) {
if (about) {
ret =
ImageUtilities.loadImage("org/netbeans/core/startup/about.png", true);
}
-if (ret == null)
+if (ret == null) {
Review comment:
Ah, sorry... I must take care to learn the NetBeans style.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid
null pointer exception in SplashPainter
URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437425
##
File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java
##
@@ -633,7 +637,10 @@ final void addToMaxSteps(int steps) {
}
void paint() {
-image.paintIcon(comp, graphics, 0, 0);
+// loadContentIcon may return a null image
+if (image != null) {
Review comment:
Yes, reviewing the initialization of image, this one can be null if the
graphic file is not found. So this is a good check to include. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
eirikbakke commented on a change in pull request #1496: [NETBEANS-3095] avoid
null pointer exception in SplashPainter
URL: https://github.com/apache/netbeans/pull/1496#discussion_r324437404
##
File path: platform/core.startup/src/org/netbeans/core/startup/Splash.java
##
@@ -518,7 +520,7 @@ public void run() {
return;
}
-if (statusBox.fm == null) {
+if (statusBox == null || statusBox.fm == null) {
Review comment:
It was never the intention for statusBox to be able to be null here. I
failed to see the "if (maxSteps > 0)" condition in SplashPainter.init(). It
seems to be an attempt to avoid running init() twice, but maxSteps can be
increased in other ways, so this is not quite correct.
I'd rather change "if (maxSteps > 0) { return; }" to "if (statusBox != null)
{ return; }" in SplashPainter.init(). Then you can get rid of this other null
check. Would you mind seeing if this solves the problem?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1503: [NETBEANS-2751] OpenJFX Samples
matthiasblaesing commented on a change in pull request #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#discussion_r324437904 ## File path: javafx/javafx2.samples/src/org/netbeans/modules/javafx2/samples/resources/layer.xml ## @@ -24,351 +24,353 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
[GitHub] [netbeans] lbruun opened a new pull request #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too
lbruun opened a new pull request #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too URL: https://github.com/apache/netbeans/pull/1504 Currently the NBI cleaner process fails to attempt files/folders if they have the read-only attribute set. With this change the cleaner will - in such case - attempt to remove the read-only attribute before proceeding to delete the file/folder. I've deliberately not squashed as each commit is a story of its own. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531513601 Thanks, fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531513664 Also thanks for liking and approving it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter
junichi11 commented on issue #1496: [NETBEANS-3095] avoid null pointer exception in SplashPainter URL: https://github.com/apache/netbeans/pull/1496#issuecomment-531522004 @oyarzun Thank you! @eirikbakke Thank you for your review! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rtaneja1 closed pull request #1502: Custom select clusters installer
rtaneja1 closed pull request #1502: Custom select clusters installer URL: https://github.com/apache/netbeans/pull/1502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rtaneja1 opened a new pull request #1505: Install subsets
rtaneja1 opened a new pull request #1505: Install subsets URL: https://github.com/apache/netbeans/pull/1505 Enabled Customize panel in installer wizards to select the cluster to install. Currently support Javase, Javaee, HTML/JS,PHP Test installers are shared here: https://github.com/rtaneja1/netbeans/releases/tag/Testv1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects
lkishalmi merged pull request #1483: [NETBEANS-3076] Try to create unit-test with Gradle Projects URL: https://github.com/apache/netbeans/pull/1483 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon
lkishalmi merged pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon URL: https://github.com/apache/netbeans/pull/1501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw merged pull request #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw merged pull request #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples
geertjanw commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531536293 I don’t think this is a fundamental change, just a little bit of reorganization, i.e., a lot of debate and discussion is not needed for this one (correct me if I am wrong and reopen if applicable) and so I am merging this now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
