[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855416#comment-15855416 ] Jacques Le Roux commented on OFBIZ-9204: I guess Deepak means bq. orderReadHelper.getOrderGrandTotal() > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855385#comment-15855385
]
Deepak Dixit commented on OFBIZ-9204:
-
Hi Maurice,
Better fix is to use OrderReadHelper method directly to get grandTotal.
{code}
orh,getOrderGrandTotal()
{code}
You can create patch with these changes.
> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named
> DEMO10090 here:
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119:
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Foxworthy updated OFBIZ-6330:
--
Attachment: OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch
> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice
> service
>
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did
> not call the method to get invoiceTaxTotal.
> class-name="org.ofbiz.accounting.invoice.InvoiceWorker"
> ret-field="invoiceTaxTotal">
>
>
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code
> below:
> decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
>
>
>
>
>
> That it should work like the createAcctgTransForSalesInvoice service of the
> sales invoice.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855110#comment-15855110
]
Paul Foxworthy commented on OFBIZ-6330:
---
Kongrath,
I found your report after I encountered exactly this issue. Thank you for this.
You are absolutely right. This is a serious problem and it's disappointing it
has been in OFBiz so long. For my own part, I'm sorry I missed this issue when
you first raised it.
I think there are several factors that have contributed to it. Many people are
using OFBiz for e-commerce and ERP but not for accounting, so incorrect figures
in the General Ledger accounts don't affect them. In addition, in the US there
are sales taxes that apply to (you guessed it) sales, but not to purchases, so
there would be no tax to add on to the base purchase price for the total owed.
In Europe, Australia, New Zealand and other places with VAT or GST, tax applies
to purchases too.
There is a similar issue with the createAcctgTransForCustomerReturnInvoice
method also. I will revise your patch to add that.
If there are no comments in the next few days, I'll commit the change.
Thanks again
Paul Foxworthy
> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice
> service
>
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did
> not call the method to get invoiceTaxTotal.
> class-name="org.ofbiz.accounting.invoice.InvoiceWorker"
> ret-field="invoiceTaxTotal">
>
>
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code
> below:
> decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
>
>
>
>
>
> That it should work like the createAcctgTransForSalesInvoice service of the
> sales invoice.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Foxworthy reassigned OFBIZ-6330:
-
Assignee: Paul Foxworthy
> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice
> service
>
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did
> not call the method to get invoiceTaxTotal.
> class-name="org.ofbiz.accounting.invoice.InvoiceWorker"
> ret-field="invoiceTaxTotal">
>
>
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code
> below:
> decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
>
>
>
>
>
> That it should work like the createAcctgTransForSalesInvoice service of the
> sales invoice.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854355#comment-15854355 ] Michael Brohl commented on OFBIZ-9204: -- Hi Maurice, thanks for bringing this up. Is it possible for you to provide a patch for this issue? Thanks and regards, Michael > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-9204: Assignee: Michael Brohl > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
Maurice Meyer created OFBIZ-9204: Summary: Cancelled OrderItems are still included in orderGrandTotal Key: OFBIZ-9204 URL: https://issues.apache.org/jira/browse/OFBIZ-9204 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 16.11 Reporter: Maurice Meyer Cancelled OrderItems are still included in the calculation of the order price. Tested with release 16.11, revision: 1781126 Steps to reproduce: 1. Setup a fresh OFBiz and do loadDefault 2. Go to the Order Manager and cancel the only existing demo order named DEMO10090 here: https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ because all the items got cancelled. The error is probably in OrderView.groovy line 119: OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9203) Update \tools\demo-backup\README.MD now that we use "Let's encrypt" on demos
Jacques Le Roux created OFBIZ-9203: -- Summary: Update \tools\demo-backup\README.MD now that we use "Let's encrypt" on demos Key: OFBIZ-9203 URL: https://issues.apache.org/jira/browse/OFBIZ-9203 Project: OFBiz Issue Type: Task Components: Demo Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Upcoming Release After OFBIZ-7928 we now use "Let's encrypt" on demos. We need to update ofbiz\tools\demo-backup\README.MD which is used to generate https://cwiki.apache.org/confluence/display/OFBIZ/The+official+demos+and+how+to+maintain+them -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-7928) Use "Let's encrypt" for OFBiz demos SSL/TLS certificates
[
https://issues.apache.org/jira/browse/OFBIZ-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-7928.
--
Resolution: Done
Fix Version/s: Release Branch 13.07
Trunk
Release Branch 16.11
This is now done, thanks to Pierre and infra see INFRA-11960
I'll create a task to maintain the documentation in
ofbiz\tools\demo-backup\README.MD which is then used to generate
https://cwiki.apache.org/confluence/display/OFBIZ/The+official+demos+and+how+to+maintain+them
> Use "Let's encrypt" for OFBiz demos SSL/TLS certificates
>
>
> Key: OFBIZ-7928
> URL: https://issues.apache.org/jira/browse/OFBIZ-7928
> Project: OFBiz
> Issue Type: Task
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
> Fix For: Release Branch 16.11, Trunk, Release Branch 13.07
>
>
> This is a transtion from INFRA-11960
> {quote}
> After some tries, I have finally decided to adapt and use
> http://blog.ivantichy.cz/blogpost/view/74 which is the most convenient way
> for OFBiz
> Since we need to use SANs (for demo-trunk-ofbiz.apache.org,
> demo-stable-ofbiz.apache.org and demo-old-ofbiz.apache.org which are actually
> OFBiz instances using different set of ports), I will try to use "-d
> ofbiz-vm.apache.org" as 1st "-d" argument and if that does not work I'll
> simply use the "-d" parameter with the other sub-domains only. What I
> actually need is a renewable certificate in the OFBiz Java keystore
> (ofbiz.jks) with the SANs present. From my experiences, the (adapted) script
> above should provide me that.
> {quote}
> Maybe another possibility would be to install our own HTTPS and use the
> instructions provided by Sam Ruby in INFRA-11960. I have to balance the work
> with adapting the script I refered to above.
> {quote}
> The EFF has published new instructions:
> https://certbot.eff.org/#ubuntutrusty-apache
> FWIW, I had no problem moving from whimy-vm2 to whimsy-vm3. I've now got
> certs for a second machine (ghmon-vm). Here's the puppet instructions to
> download certbot, create a cronjob, and add use the certificates with Apache
> httpd:
> https://github.com/apache/infrastructure-puppet/pull/107/commits/8fea8223f398a77e67173c1b0c1b06b80fe576b0
> Once this is deployed, all that is left is running a single command:
> certbot-auto -d host1.apache.org -d host2.apache.org... and answering two
> prompts (you need to provide an email address and to indicate that you have
> read the terms of service).
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
