[jira] [Commented] (OFBIZ-9191) Navigate Accounts tree does not work

2017-02-07 Thread Moatasim Al Masri (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857593#comment-15857593
 ] 

Moatasim Al Masri commented on OFBIZ-9191:
--

thank you

> Navigate Accounts tree does not work
> 
>
> Key: OFBIZ-9191
> URL: https://issues.apache.org/jira/browse/OFBIZ-9191
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 16.11
> Environment: windows 10
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, 16.11.02
>
>
> go to 
> Accounting --> Global GL Setting --> Navigate Accounts
> when I try to open tree, gave me in URL 
> https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10
> and gave me white page !!? it should expand the tree !
> NOTE: OFBiz ver. 16.11.01 and database Oracle 12c



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9207) Invoice reference Number

2017-02-07 Thread Moatasim Al Masri (JIRA)
Moatasim Al Masri created OFBIZ-9207:


 Summary: Invoice reference Number
 Key: OFBIZ-9207
 URL: https://issues.apache.org/jira/browse/OFBIZ-9207
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Release Branch 16.11
 Environment: windows server, oracle12c database
Reporter: Moatasim Al Masri


Dears
I would like to ask for Accounting manager, when I create invoices, there is a 
Reference Number field, my understanding is this field used for company 
Reference Number that link company reference invoice with ofbiz system invoice 
generated? Is this right as a business concept? If yes, so when I fill this 
reference number it should not duplicate with the same vendor!! so there is no 
validation 




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (OFBIZ-5928) Prototype of a Product Association recommender

2017-02-07 Thread Pallavi Goyal (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857414#comment-15857414
 ] 

Pallavi Goyal edited comment on OFBIZ-5928 at 2/8/17 5:19 AM:
--

Patch for the automation of the "getProductAssociationRecommendations" service 
in RecommenderServices.java.

Thanks Anil Patel, Divesh Dutta and Deepak Dixit for your guidance.


was (Author: pallavi.goyal):
Patch for the automation of the "getProductAssociationRecommendations" service 
in RecommenderServices.java.

> Prototype of a Product Association recommender
> --
>
> Key: OFBIZ-5928
> URL: https://issues.apache.org/jira/browse/OFBIZ-5928
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Anahita Goljahani
>Priority: Minor
> Attachments: product-recommendation.patch, recommender.zip, 
> recommender.zip
>
>
> Hi all, as anticipated in my ApacheCon Europe presentation 'Introduction to a 
> Recommender System for Apache OFBiz' (downloadable from 
> https://cwiki.apache.org/confluence/x/OYPfAg), I have developed a prototype 
> of a Product Association recommender for OFBiz. Product Association 
> recommendations are suggestions of the type 'Customers who bought this item 
> also bought:', that are provided to online shoppers to help them in the 
> selection of products to buy. 
> Attached to this Jira ticket you will find a zip archive containing a 
> component named 'recommender', which implements the logic to generate 
> Production Association recommendations. The component contains a short guide 
> to its functionalities in the main folder. The guide also includes a short 
> paragraph that explains how to run a recommender demo. 
> I would really appreciate any review, feedback and suggestion by anyone 
> interested in this topic.   
> Thank you



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-5928) Prototype of a Product Association recommender

2017-02-07 Thread Pallavi Goyal (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857428#comment-15857428
 ] 

Pallavi Goyal commented on OFBIZ-5928:
--

The following changes are for Ofbiz 15.12

Changes in RecommenderServices.java

1. Earlier:
Attribute numbOfRecommendedProducts was an optional input in service 
'getProductAssociationRecommendations' with default value 1.

Now:
Removed this attribute from service definition, as added the value in 
properties.

2. Earlier:
The numbOfRecommendedProducts variable was getting value as an optional input 
from user with default value equal to 1.

Now:
The numbOfRecommendedProducts variable is getting value from catalog.properties 
and default value is 3.

3. Earlier:
Each time the service 'getProductAssociationRecommendations'was invoked, it 
deleted the old recommendations from ProductAssoc entity. 
If new recommendations were not formed, old recommendations were also getting 
deleted.

Now:
A check is applied that if new recommendations are created, i.e., 
recommendedProducts map is NOT null, then only delete the old recommendations 
for the input product.
Because of this, if new recommendations are not created for any product, old 
recommendations will still persist for the same.

4. Earlier:
Dynamic view entity was having multiple alias for the same field for different 
entities.
Example:  dve.addAlias("OH", "orderId"); 
  dve.addAlias("OI", "orderId");

Now:
Optimised the code by removing unnecessary addAlias() methods. 
Example: removed dve.addAlias(“OI', “orderId”);

5. Earlier:
There are several conditions on which AND operator is applied to get a final 
condition. 
For this, two conditions were taken at a time and AND operator was used on them.

Now:
Optimised the code by using list for such conditions. 
Added these conditions in list and applied the operator AND on the list.

6. Earlier:
For getting occurrences[][] of order, two distinct() methods were used in the 
EntityQuery.
i.e., occurrences[0][0] =   
  
EntityQuery.use(delegator).select(UtilMisc.toSet("orderId")).distinct().cursorScrollSensitive().distinct().from(dve).where(condition).queryCount();

Now: 
Optimised the code by removing extra distinct() method from the code.

7. Earlier:
The jar file used was commons-math3-3.3.jar.

Now: 
Used latest version of jar file: commons-math3-3.6.1.jar file.

8. Earlier:
For getting cobought products and orders to calculate conditional 
probabilities, all the orders present in the database were processed 
irrespective of their age. (i.e., even if an order was 10 years old, it was 
processed.)

Now:
Added the limitation, that orders of a limited age will be processed. ( Ex: 
orders for last one year).
By default taking orders for last one year. Has set the property in 
catalog.properties.

9. Added:
A service method “createProductRecommendationsForOrderItems” in 
RecommenderServices.java which will invoke 
“getProductAssociationRecommendations” every day in mid night.

10. Added:
A new alias 'orderDate' from OrderHeader entity in dynamic view entities.

11. Added:
New entity condition to get the orders of a limited age in the entity query 
results. (Default: last one year orders)


For Automation of the service “getProductAssociationRecommendations” :

1.  Added a service method, “createProductRecommendationsForOrderItems”.

This service is scheduled to run once daily in mid-night. 

Working:

   (i) This service will get all the SALES orders present in the previous one 
day. 
   (ii) Then it will prepare a list of order items that were in those orders. 
The list will have distinct order items i.e., even thoughan item is in 
multiple orders, it is included in the list only one time.
   (iii)For each order item in the list, invoke the service 
“getProductAssociationRecommendations”.

Thus, for each product for which a sales order was present on previous day, 
recommendations will be refreshed for them.

2.  For scheduling, data is prepared in ScheduledJobs.xml.

3. Variable product.recommendation.numbOfRecommendedProducts is added in 
catalog.properties with value 3.

4. Variable product.recommendation.getOrdersFromLastDays is added in 
catalog.properties with value 365.

5. Passed a new parameter 'ordersFromDate' in the invocation of service 
'getProductAssociationRecommendations'.

6. Also made the systemProperty entry in CommonSystemPropertyData.xml.

7. Placed the jar file commons-math3-3.6.1.jar in framework.

8. Made class path entry for the new jar file.

> Prototype of a Product Association recommender
> --
>
> Key: OFBIZ-5928
> URL: https://issues.apache.org/jira/browse/OFBIZ-5928
> Project: OFBiz
>  Issue Type: New Feature
>

[jira] [Updated] (OFBIZ-5928) Prototype of a Product Association recommender

2017-02-07 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-5928:
-
Attachment: product-recommendation.patch

Patch for the automation of the "getProductAssociationRecommendations" service 
in RecommenderServices.java.

> Prototype of a Product Association recommender
> --
>
> Key: OFBIZ-5928
> URL: https://issues.apache.org/jira/browse/OFBIZ-5928
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Anahita Goljahani
>Priority: Minor
> Attachments: product-recommendation.patch, recommender.zip, 
> recommender.zip
>
>
> Hi all, as anticipated in my ApacheCon Europe presentation 'Introduction to a 
> Recommender System for Apache OFBiz' (downloadable from 
> https://cwiki.apache.org/confluence/x/OYPfAg), I have developed a prototype 
> of a Product Association recommender for OFBiz. Product Association 
> recommendations are suggestions of the type 'Customers who bought this item 
> also bought:', that are provided to online shoppers to help them in the 
> selection of products to buy. 
> Attached to this Jira ticket you will find a zip archive containing a 
> component named 'recommender', which implements the logic to generate 
> Production Association recommendations. The component contains a short guide 
> to its functionalities in the main folder. The guide also includes a short 
> paragraph that explains how to run a recommender demo. 
> I would really appreciate any review, feedback and suggestion by anyone 
> interested in this topic.   
> Thank you



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service

2017-02-07 Thread Paul Foxworthy (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856988#comment-15856988
 ] 

Paul Foxworthy commented on OFBIZ-6330:
---

Hi Nicolas,

The code here generates individual accounting entries for the tax authorities. 
There is nothing adding the amounts up, so when the tax-inclusive price is 
calculated, the variable invoiceTaxTotal has never been used and will have a 
value of zero.

One reason I didn't take that approach (and I guess Kongrath thought the same) 
is that createAcctgTransForSalesInvoice also just calls getInvoiceTaxTotal.

I understand that adding up the tax amounts would avoid a call to one more 
method, at the expense of making the code a little more complicated. If you 
still think that's a good idea, I'll change all three methods 
createAcctgTransForCustomerReturnInvoice, createAcctgTransForSalesInvoice, 
createAcctgTransForPurchaseInvoice to work that way.

What do you think?

Cheers

Paul

> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice 
> service
> 
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of 
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did 
> not call the method to get invoiceTaxTotal.
>  class-name="org.ofbiz.accounting.invoice.InvoiceWorker" 
> ret-field="invoiceTaxTotal">
> 
> 
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code 
> below:
>  decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
> 
> 
> 
> 
> 
> That it should work like the createAcctgTransForSalesInvoice service of the 
> sales invoice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service

2017-02-07 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856723#comment-15856723
 ] 

Nicolas Malin edited comment on OFBIZ-6330 at 2/7/17 8:27 PM:
--

Hello,
I checked the code and found a nice detail to resolve all tax merged by 
taxAuthority.
line 2033 on 
{code:xml}

























{code}

Did you check why this method doesn't works well ? Because I think it's more 
powerfull than just resolve all tax on one line.



was (Author: soledad):
Hello,
I checked the code and found a nice detail to resolve all tax merged by 
taxAuthority.
line 2033 on 
{code|lang=xml}

























{code}

Did you check why this method doesn't works well ? Because I think it's more 
powerfull than just resolve all tax on one line.


> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice 
> service
> 
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of 
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did 
> not call the method to get invoiceTaxTotal.
>  class-name="org.ofbiz.accounting.invoice.InvoiceWorker" 
> ret-field="invoiceTaxTotal">
> 
> 
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code 
> below:
>  decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
> 
> 
> 
> 
> 
> That it should work like the createAcctgTransForSalesInvoice service of the 
> sales invoice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service

2017-02-07 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856723#comment-15856723
 ] 

Nicolas Malin commented on OFBIZ-6330:
--

Hello,
I checked the code and found a nice detail to resolve all tax merged by 
taxAuthority.
line 2033 on 
{code|lang=xml}

























{code}

Did you check why this method doesn't works well ? Because I think it's more 
powerfull than just resolve all tax on one line.


> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice 
> service
> 
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
> Attachments: GeneralLedgerServices.patch, 
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of 
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did 
> not call the method to get invoiceTaxTotal.
>  class-name="org.ofbiz.accounting.invoice.InvoiceWorker" 
> ret-field="invoiceTaxTotal">
> 
> 
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code 
> below:
>  decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
> 
> 
> 
> 
> 
> That it should work like the createAcctgTransForSalesInvoice service of the 
> sales invoice.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (OFBIZ-9201) Birt logging unlogical high

2017-02-07 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-9201.


> Birt logging unlogical high
> ---
>
> Key: OFBIZ-9201
> URL: https://issues.apache.org/jira/browse/OFBIZ-9201
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, 
> Release Branch 16.11
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, 16.11.02
>
> Attachments: OFBIZ-9201.patch
>
>
> I found a several issue to use the birt component on production
> The class BirtContainer call the birt engine with hard coding level ALL oO .
> The result : to generate a reporting of 100Mo we had a log file of 10Go.
> {code}
> config.setTempDir(ofbizHome + File.separatorChar + "runtime" + 
> File.separatorChar + "tempfiles");
> config.setLogConfig(ofbizHome + File.separatorChar + "runtime" + 
> File.separatorChar + "logs" + File.separatorChar + "birt", Level.ALL);
> {code}
> The problem come from birt use java.util.Logger to generate log, I can't 
> found how use the org.apache.log4j.Logger instead of, so I create a quick 
> patch to create a level matching between Log4j and java Logger
> I found some example to implement it like 
> http://stackoverflow.com/questions/24318087/direct-birt-report-logs-to-log4j 
> but I failed to do it on OFBiz. So if you can check my quick correction or 
> resolve how use directly log4j it's mostly appreciate ;)
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9206) Login and logout process in demos shows a certificate issue

2017-02-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856192#comment-15856192
 ] 

Jacques Le Roux commented on OFBIZ-9206:


We crossed on wire Pierre, your summary is better, put back

> Login and logout process in demos shows a certificate issue
> ---
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9206) Login and logout process in demos shows a certificate issue

2017-02-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9206:
---
Summary: Login and logout process in demos shows a certificate issue  (was: 
Login or login out in demos shows a certificate issue)

> Login and logout process in demos shows a certificate issue
> ---
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9206) Login or login out in demos shows a certificate issue

2017-02-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9206:
---
Summary: Login or login out in demos shows a certificate issue  (was: Login 
and logout process in demos shows a certificate issue)

> Login or login out in demos shows a certificate issue
> -
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9205) Wrong OrderAdjustments (because of tax) when cancelling an Order

2017-02-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855952#comment-15855952
 ] 

Jacques Le Roux commented on OFBIZ-9205:


Thanks Maurice, please note that, since our demos restart anew everyday at 3 
UTC, the Demo10090 will only be available today. Not a big issue seems easily 
reproductible.

> Wrong OrderAdjustments (because of tax) when cancelling an Order
> 
>
> Key: OFBIZ-9205
> URL: https://issues.apache.org/jira/browse/OFBIZ-9205
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Maurice Meyer
>
> The Problem (tested with order Demo10090): When cancelling an order new 
> OrderAdjustments are created to substract the tax of the cancelled orderItems 
> from the existing order total amount. This leads to an amount of -0.04$ with 
> the demo order DEMO10090.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right states -0.04$. It should be 0$.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9206) Login and logout process in demos shows a certificate issue

2017-02-07 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9206:

Summary: Login and logout process in demos shows a certificate issue  (was: 
Loginor login out in demos shows a certificate issue)

> Login and logout process in demos shows a certificate issue
> ---
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9206) Loginor login out in demos shows a certificate issue

2017-02-07 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855943#comment-15855943
 ] 

Pierre Smits commented on OFBIZ-9206:
-

The issue occurs after the login and logout process has been invoked/executed. 

Steps to reproduce the login issue:
# go to https://demo-trunk.ofbiz.apache.org/catalog
# provide login details - userId: admin, password: ofbiz

Steps to reproduce the logout issue:
# access the demo via 
http://demo-old.ofbiz.apache.org/catalog/control/main?USERNAME=adminPASSWORD=ofbizJavaScriptEnabled=Y
# log out from the application via the 'logout' button/function

> Loginor login out in demos shows a certificate issue
> 
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9206) Loginor login out in demos shows a certificate issue

2017-02-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9206:
---
Description: 
When, from the site main page http://ofbiz.apache.org/, you get to the demos 
depending on browser (tested on Windows 7) you get some issues:
* FF
** Management Apps: OK
** Ecommerce: OK
* Chrome (Management Apps or Ecommerce)
** stable: OK
** old: KO - If you copy the URL by hand it works, and after even from the main 
page it works.
** trunk: OK
* IE, same than Chrome

If, from any browser, you logout from Management Apps you get a certificate 
issue. Actually as we use HSTS the browsers protect us from any 3rd party 
intrusions... Same issue when login in.

So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. Maybe 
it's due to how OFBiz redirects when login in or login out because, so far, 
only the login page is concerned...

  was:
When, from the site main page http://ofbiz.apache.org/, you get to the demos 
depending on browser (tested on Windows 7) you get some issues:
# FF
* Management Apps: OK
* Ecommerce: OK
# Chrome
* Initially
** Management Apps or Ecommerce
*** stable: OK
*** old: KO
*** trunk: OK
* If you copy the URL by hand all work, and after even from the main page it 
works for old.
# IE, same than Chrome

If, from any browser, you logout from Management Apps you get a certificate 
issue. Actually as we use HSTS the browsers protect us from any 3rd party 
intrusions... Same issue when login in.

So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. Maybe 
it's due to how OFBiz redirects when login in or login out because, so far, 
only the login page is concerned...


> Loginor login out in demos shows a certificate issue
> 
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9206) Loginor login out in demos shows a certificate issue

2017-02-07 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-9206:
--

 Summary: Loginor login out in demos shows a certificate issue
 Key: OFBIZ-9206
 URL: https://issues.apache.org/jira/browse/OFBIZ-9206
 Project: OFBiz
  Issue Type: Bug
  Components: Demo
Reporter: Jacques Le Roux
Priority: Minor


When, from the site main page http://ofbiz.apache.org/, you get to the demos 
depending on browser (tested on Windows 7) you get some issues:
# FF
* Management Apps: OK
* Ecommerce: OK
# Chrome
* Initially
** Management Apps or Ecommerce
*** stable: OK
*** old: KO
*** trunk: OK
* If you copy the URL by hand all work, and after even from the main page it 
works for old.
# IE, same than Chrome

If, from any browser, you logout from Management Apps you get a certificate 
issue. Actually as we use HSTS the browsers protect us from any 3rd party 
intrusions... Same issue when login in.

So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. Maybe 
it's due to how OFBiz redirects when login in or login out because, so far, 
only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9205) Wrong OrderAdjustments (because of tax) when cancelling an Order

2017-02-07 Thread Maurice Meyer (JIRA)
Maurice Meyer created OFBIZ-9205:


 Summary: Wrong OrderAdjustments (because of tax) when cancelling 
an Order
 Key: OFBIZ-9205
 URL: https://issues.apache.org/jira/browse/OFBIZ-9205
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Release Branch 16.11
Reporter: Maurice Meyer


The Problem (tested with order Demo10090): When cancelling an order new 
OrderAdjustments are created to substract the tax of the cancelled orderItems 
from the existing order total amount. This leads to an amount of -0.04$ with 
the demo order DEMO10090.

Tested with release 16.11, revision: 1781126
Steps to reproduce:
1. Setup a fresh OFBiz and do loadDefault
2. Go to the Order Manager and cancel the only existing demo order named 
DEMO10090 here: 
https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
3. The "Total Due" at the bottom right states -0.04$. It should be 0$.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal

2017-02-07 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855881#comment-15855881
 ] 

Michael Brohl commented on OFBIZ-9204:
--

Yes, please file a new issue, thanks Maurice!

> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
> Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, 16.11.02
>
> Attachments: OFBIZ-9204.patch
>
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ 
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119: 
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal

2017-02-07 Thread Maurice Meyer (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855863#comment-15855863
 ] 

Maurice Meyer commented on OFBIZ-9204:
--

Great, thanks for comitting.

What about the tax issue? With the patch applied the "Total Due" of the 
cancelled order "DEMO10090" is - 0.04$. That's not working as intended, is it? 
Should a new Ticket be opened for that?

> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
> Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, 16.11.02
>
> Attachments: OFBIZ-9204.patch
>
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ 
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119: 
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal

2017-02-07 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-9204:
-
Fix Version/s: Release Branch 14.12
   Release Branch 15.12
   16.11.02
   Upcoming Release

> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, 
> Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
> Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, 16.11.02
>
> Attachments: OFBIZ-9204.patch
>
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ 
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119: 
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal

2017-02-07 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-9204:
-
Affects Version/s: Release Branch 14.12
   Trunk
   Release Branch 15.12

> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, 
> Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
> Attachments: OFBIZ-9204.patch
>
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ 
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119: 
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Comment Edited] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal

2017-02-07 Thread Maurice Meyer (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855639#comment-15855639
 ] 

Maurice Meyer edited comment on OFBIZ-9204 at 2/7/17 9:39 AM:
--

With the suggestion from Deepak / Jacques it works. Thanks!

I noticed one more thing, but that doesn't belong to this ticket: The 
orderGrandTotal is - 0.04$ instead of 0$. This is because of some tax 
adjustment OFBiz tries to undo when cancelling the order.


was (Author: mauricemeyer):
With the suggestion from Deepak / Jacques it works. Thanks!

I noticed one more thing, but that doesn't belong to this ticket: The 
orderGrandTotal is - 0.04$ instead of 0$.

> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
> Attachments: OFBIZ-9204.patch
>
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ 
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119: 
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal

2017-02-07 Thread Maurice Meyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maurice Meyer updated OFBIZ-9204:
-
Attachment: OFBIZ-9204.patch

With the suggestion from Deepak / Jacques it works. Thanks!

I noticed one more thing, but that doesn't belong to this ticket: The 
orderGrandTotal is - 0.04$ instead of 0$.

> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
> Attachments: OFBIZ-9204.patch
>
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named 
> DEMO10090 here: 
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ 
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119: 
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)