[jira] [Comment Edited] (OFBIZ-5891) Party Content Upload Ajax Is Broken
[ https://issues.apache.org/jira/browse/OFBIZ-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14229595#comment-14229595 ] Jacques Le Roux edited comment on OFBIZ-5891 at 2/9/17 7:45 AM: Here is the patch for this issue. This issue due to OFBIZ-5409 Added the dataType: 'json', for getUploadProgressStatus method. {code} [java] 2014-12-01 15:06:00,977 |ttp-bio-8443-exec-77 |CommonEvents |W| for security reason (OFBIZ-5409) the the '//' prefix was added handling the JSON response. Normally you simply have to access the data you want, so should not be annoyed by the '//' prefix.You might need to remove it if you use Ajax GET responses (not recommended).In case, the util.js scrpt is there to help you {code} was (Author: deepak.dixit): Here is the patch for this issue. This issue due to https://issues.apache.org/jira/browse/OFBIZ-5409 Added the dataType: 'json', for getUploadProgressStatus method. {code} [java] 2014-12-01 15:06:00,977 |ttp-bio-8443-exec-77 |CommonEvents |W| for security reason (OFBIZ-5409) the the '//' prefix was added handling the JSON response. Normally you simply have to access the data you want, so should not be annoyed by the '//' prefix.You might need to remove it if you use Ajax GET responses (not recommended).In case, the util.js scrpt is there to help you {code} > Party Content Upload Ajax Is Broken > --- > > Key: OFBIZ-5891 > URL: https://issues.apache.org/jira/browse/OFBIZ-5891 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 13.07, 14.12.01 >Reporter: Adrian Crum >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 14.12.01, 12.04.06, 13.07.02 > > Attachments: OFBIZ-5891.patch > > > When you upload Party Content, an "Upload..." message appears next to the > Upload button, but it never goes away. While still on the same screen, check > the OFBiz console - the getFileUploadProgressStatus request is invoked once > per second indefinitely. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices
[ https://issues.apache.org/jira/browse/OFBIZ-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859156#comment-15859156 ] Jacopo Cappellato commented on OFBIZ-4514: -- [~paul_foxworthy] we should also commit part of this patch with OFBIZ-6330 > Taxes are not handled correctly when creating accounting transactions from > purchase invoices > > > Key: OFBIZ-4514 > URL: https://issues.apache.org/jira/browse/OFBIZ-4514 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Martin Kreidenweis >Priority: Trivial > Labels: VAT, tax > Attachments: OFBIZ-4514.patch > > > Taxes are not handled correctly when creating accounting transactions from > purchase invoices in GeneralLedgerServices#createAcctgTransForPurchaseInvoice -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[ https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859151#comment-15859151 ] Jacopo Cappellato commented on OFBIZ-6330: -- [~paul_foxworthy] I agree with the fix you have proposed: the same code that is already used by the createAcctgTransForSalesInvoice should be applied to the return and purchase services. And your patch does this. I would also apologize with [~kongrath] for having missed this valid contribution. Thank you Kongrath. > The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice > service > > > Key: OFBIZ-6330 > URL: https://issues.apache.org/jira/browse/OFBIZ-6330 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Paul Foxworthy > Attachments: GeneralLedgerServices.patch, > OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch > > > Hi All, > Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of > purchase invoice are not equal. > Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did > not call the method to get invoiceTaxTotal. > class-name="org.ofbiz.accounting.invoice.InvoiceWorker" > ret-field="invoiceTaxTotal"> > > > And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code > below: > decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}"> > > > > > > That it should work like the createAcctgTransForSalesInvoice service of the > sales invoice. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[ https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859023#comment-15859023 ] Paul Foxworthy commented on OFBIZ-6330: --- [~jacopoc], you commented on a similar issue OFBIZ-4514. What do you think of this? > The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice > service > > > Key: OFBIZ-6330 > URL: https://issues.apache.org/jira/browse/OFBIZ-6330 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Kongrath Suankaewmanee >Assignee: Paul Foxworthy > Attachments: GeneralLedgerServices.patch, > OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch > > > Hi All, > Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of > purchase invoice are not equal. > Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did > not call the method to get invoiceTaxTotal. > class-name="org.ofbiz.accounting.invoice.InvoiceWorker" > ret-field="invoiceTaxTotal"> > > > And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code > below: > decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}"> > > > > > > That it should work like the createAcctgTransForSalesInvoice service of the > sales invoice. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9208) reinstate url cache in UtilURL.fromResource
[ https://issues.apache.org/jira/browse/OFBIZ-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-9208: - Description: Adrian created the following commit to cache URL objects {noformat} Revision: 1649979 Author: adrianc Date: 07 January 2015 00:24:28 Message: Some optimizations for URL lookups. Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java {noformat} and was later reverted in this commit {noformat} Revision: 1650347 Author: adrianc Date: 08 January 2015 17:53:59 Message: Some small fixups for some of my previous commits. Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java {noformat} We have found in one of our production servers that line 98 in UtilURL.java {code} url = loader.getResource(resourceName); {code} has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method I propose the cache gets added back (we have done this as a patch on our systems with no ill effect) FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210 was: Adrian created the following commit to cache URL objects Revision: 1649979 Author: adrianc Date: 07 January 2015 00:24:28 Message: Some optimizations for URL lookups. Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java and was later reverted in this commit Revision: 1650347 Author: adrianc Date: 08 January 2015 17:53:59 Message: Some small fixups for some of my previous commits. Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java We have found in one of our production servers that url = loader.getResource(resourceName); has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method I propose the cache gets added back (we have done this as a patch on our systems with no ill effect) FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210 > reinstate url cache in UtilURL.fromResource > --- > > Key: OFBIZ-9208 > URL: https://issues.apache.org/jira/browse/OFBIZ-9208 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Trunk >Reporter: Gareth Carter >Priority: Trivial > > Adrian created the following commit to cache URL objects > {noformat} > Revision: 1649979 > Author: adrianc > Date: 07 January 2015 00:24:28 > Message: > Some optimizations for URL lookups. > > Modified : > /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java > Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java > {noformat} > and was later reverted in this commit > {noformat} > Revision: 1650347 > Author: adrianc > Date: 08 January 2015 17:53:59 > Message: > Some small fixups for some of my previous commits. > > Modified : > /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java > Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java > {noformat} > We have found in one of our production servers that line 98 in UtilURL.java > {code} > url = loader.getResource(resourceName); > {code} > has caused locking and looking at the stack trace (from jstack) there are > numerous threads waiting on locks from within this method > I propose the cache gets added back (we have done this as a patch on our > systems with no ill effect) > FYI - The commits are in reference to the EntityClassLoader which is not used > and does not work see OFBIZ-6210 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9208) reinstate url cache in UtilURL.fromResource
Gareth Carter created OFBIZ-9208: Summary: reinstate url cache in UtilURL.fromResource Key: OFBIZ-9208 URL: https://issues.apache.org/jira/browse/OFBIZ-9208 Project: OFBiz Issue Type: Bug Components: base Affects Versions: Trunk Reporter: Gareth Carter Priority: Trivial Adrian created the following commit to cache URL objects Revision: 1649979 Author: adrianc Date: 07 January 2015 00:24:28 Message: Some optimizations for URL lookups. Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java and was later reverted in this commit Revision: 1650347 Author: adrianc Date: 08 January 2015 17:53:59 Message: Some small fixups for some of my previous commits. Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java We have found in one of our production servers that url = loader.getResource(resourceName); has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method I propose the cache gets added back (we have done this as a patch on our systems with no ill effect) FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857696#comment-15857696 ] Jacques Le Roux commented on OFBIZ-9191: Yes, it's fixed at r1781125, but we should be able to encode links in nodes trees. In this case I preferred to keep things simple, so OFBIZ-9202 more to remember for a perfect future ;) > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857636#comment-15857636 ] Moatasim Al Masri commented on OFBIZ-9191: -- I downloaded the current trunk from https://ci.apache.org/projects/ofbiz/snapshots/ and it is worked fine > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857622#comment-15857622 ] Jacques Le Roux commented on OFBIZ-9191: BTW I created OFBIZ-9202 "Encoding links for nodes in trees does not work" > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)