[jira] [Commented] (OFBIZ-9206) Login and logout process in demos shows a certificate issue

2017-02-24 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883587#comment-15883587
 ] 

Jacques Le Roux commented on OFBIZ-9206:


Of course, for a site not protected by a certificate (like when developing with 
localhost) and because if port.https is empty we rely on the port in the 1st 
request sent, you need to put the correct port when login in, something like 
https://localhost:8443/catalog/control/login. Then all follow...

> Login and logout process in demos shows a certificate issue
> ---
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9206.patch
>
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (OFBIZ-9224) 16.11 ofbizUrl include host+port and break some reverse-proxy / docker setups

2017-02-24 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883508#comment-15883508
 ] 

Jacques Le Roux commented on OFBIZ-9224:


Hi Leonard, please test the patch in OFBIZ-9206, thanks.

> 16.11 ofbizUrl include host+port and break some reverse-proxy / docker setups
> -
>
> Key: OFBIZ-9224
> URL: https://issues.apache.org/jira/browse/OFBIZ-9224
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Leonard Lin
>Assignee: Jacques Le Roux
>
> OFBiz 16.11 has changed how it generates urls in its templates.
> It sometimes includes hostname+port.
> This can be reproduced on the official ofbiz-demo site:
> Go to http://ofbiz.apache.org/
> - Open the Ofbiz 13.07 Demo (Management Apps)
> - - it will auto-login for your, do a logout so that you can see the 
> login-mask
> - - look at the HTML code and look for the form-post url etc. You can see 
> that none of the URLs include hostname:port. They are all "/url/path"
> - Open the Ofbiz 16.11 Demo (Management Apps)
> - - it will auto-login for your, do a logout so that you can see the 
> login-mask
> - - look at the HTML code and look for the form-post url etc.
> - - the post-urls and login-links have format: https://hostname:port/url/path
> The new 16.11 behaviour can cause problems in cluster / reverse-proxy setups 
> where actual host:port does not match public host:port 
> Before 16.11 this was not an issue because all links were without 
> hostname:port. But now the login masks loads but the subsequent links all 
> show the wrong port.
> url.properties does control port/hostname but preferably we wouldn't need to 
> configure it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (OFBIZ-9206) Login and logout process in demos shows a certificate issue

2017-02-24 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9206:
--

Assignee: Jacques Le Roux

> Login and logout process in demos shows a certificate issue
> ---
>
> Key: OFBIZ-9206
> URL: https://issues.apache.org/jira/browse/OFBIZ-9206
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> When, from the site main page http://ofbiz.apache.org/, you get to the demos 
> depending on browser (tested on Windows 7) you get some issues:
> * FF
> ** Management Apps: OK
> ** Ecommerce: OK
> * Chrome (Management Apps or Ecommerce)
> ** stable: OK
> ** old: KO - If you copy the URL by hand it works, and after even from the 
> main page it works.
> ** trunk: OK
> * IE, same than Chrome
> If, from any browser, you logout from Management Apps you get a certificate 
> issue. Actually as we use HSTS the browsers protect us from any 3rd party 
> intrusions... Same issue when login in.
> So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. 
> Maybe it's due to how OFBiz redirects when login in or login out because, so 
> far, only the login page is concerned...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OFBIZ-9230) Missing reference to the delegator in framework/widget/templates/HtmlFormMacroLibrary.ftl

2017-02-24 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882447#comment-15882447
 ] 

Jacques Le Roux edited comment on OFBIZ-9230 at 2/24/17 10:54 AM:
--

Thanks Zhang for report,

The reason is in the context of a FTL macro we lose the delegator (in context) 
when calling  
executeMacro(writer, sr.toString()); 
from 
MacroFormRenderer.renderTextField()
So we need to find a way to pass the delegator to be used when evaluating the 
Freemarker template. For now I have simply added a clearer explanation of the 
reason at r1784259



was (Author: jacques.le.roux):
The reason is in the context of a FTL macro we lose the delegator (in context) 
when calling  
executeMacro(writer, sr.toString()); 
from 
MacroFormRenderer.renderTextField()
So we need to find a way to pass the delegator to be used when evaluating the 
Freemarker template. For now I have simply added a clearer explanation of the 
reason at r1784259


> Missing reference to the delegator in 
> framework/widget/templates/HtmlFormMacroLibrary.ftl
> -
>
> Key: OFBIZ-9230
> URL: https://issues.apache.org/jira/browse/OFBIZ-9230
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Jacques Le Roux
>Priority: Minor
>
> To reproduce
> 1. Load test data  systemPropertyId="widget.autocompleter.defaultMinLength" 
> systemPropertyValue="3"/> 
> 2. Open https://localhost:8443/partymgr/control/main
> 3. You will still get warning below in log file
> {quote}
> 2017-02-24 12:56:16,348 |http-nio-8443-exec-7 |EntityUtilProperties  
> |I| Could not get a system property for widget.autocompleter.defaultMinLength 
> : null
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (OFBIZ-9231) Remove unnecessary null from cc and bcc

2017-02-24 Thread Suraj Khurana (JIRA) 
Suraj Khurana created OFBIZ-9231:


 Summary: Remove unnecessary null from cc and bcc
 Key: OFBIZ-9231
 URL: https://issues.apache.org/jira/browse/OFBIZ-9231
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Affects Versions: Trunk
Reporter: Suraj Khurana


Go to partymgr.
Click on Communication tab.
Click on find button.
It will show list of some communication emails send on order confirmation etc.
If CC and BCC are not found, it shows 'null' .

Proposed solution:
Instead of showing null, we can have a proper null check to improve visiblity 
of the screen. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Reopened] (OFBIZ-6884) Replace Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue in .ftl files with EntityUtilProperties variant

2017-02-24 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6884:


Breaks OFBIZ-9230. I guess it's a missing delegator in some special cases...

> Replace Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue in .ftl 
> files with EntityUtilProperties variant
> -
>
> Key: OFBIZ-6884
> URL: https://issues.apache.org/jira/browse/OFBIZ-6884
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: multi-tenant
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6884-PropertiesInFtl.patch, 
> OFBIZ-6884-PropertiesInFtl-v2.patch, OFBIZ-6884-PropertiesInFtl-v3.patch
>
>
> Static["org.ofbiz.base.util.UtilProperties"].getPropertyValue is used in 
> several .ftl files. 
> Replace with EnittyUtilProperties variant where appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OFBIZ-3972) user of tenant generate errors on entity Server_Hit

2017-02-24 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882287#comment-15882287
 ] 

Jacques Le Roux edited comment on OFBIZ-3972 at 2/24/17 9:17 AM:
-

Agreed, just done at https://s.apache.org/TOed


was (Author: jacques.le.roux):
Agreed, just done

> user of tenant generate errors on entity Server_Hit
> ---
>
> Key: OFBIZ-3972
> URL: https://issues.apache.org/jira/browse/OFBIZ-3972
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Trunk
>
>
> When a user is active in a tenant and he/she logs off, server_hits are 
> generated. However the persistence is rolled back. See excerpt of error.log 
> below.
> 2010-10-01 11:34:12,169 (http-0.0.0.0-8443-5) [   
> GenericDelegator.java:889:ERROR] 
>  exception report 
> --
> Failure in create operation for entity [ServerHit]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServerHit][contentId,catalog.logout(java.lang.String)][createdStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][createdTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][hitStartDateTime,2010-10-01 
> 11:34:11.732(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][lastUpdatedTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][partyId,DEMO55-admin(java.lang.String)][referrerUrl,https://localhost:8443/catalog/control/main?externalLoginKey=EL814028348655(java.lang.String)][requestUrl,https://localhost:8443/catalog/control/logout(java.lang.String)][runningTimeMillis,406(java.lang.Long)][serverHostName,zase(java.lang.String)][serverIpAddress,10.0.0.125(java.lang.String)][userLoginId,DEMO55-admin(java.lang.String)][visitId,10024(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
> 'SERVER_HIT' caused a violation of foreign key constraint 'SERVER_HIT_USER' 
> for key (DEMO55-admin).  The statement has been rolled back.)). Rolling back 
> transaction.
> Exception: org.ofbiz.entity.GenericEntityException
> Message: Error while inserting: 
> [GenericEntity:ServerHit][contentId,catalog.logout(java.lang.String)][createdStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][createdTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][hitStartDateTime,2010-10-01 
> 11:34:11.732(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][lastUpdatedTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][partyId,DEMO55-admin(java.lang.String)][referrerUrl,https://localhost:8443/catalog/control/main?externalLoginKey=EL814028348655(java.lang.String)][requestUrl,https://localhost:8443/catalog/control/logout(java.lang.String)][runningTimeMillis,406(java.lang.Long)][serverHostName,zase(java.lang.String)][serverIpAddress,10.0.0.125(java.lang.String)][userLoginId,DEMO55-admin(java.lang.String)][visitId,10024(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
> 'SERVER_HIT' caused a violation of foreign key constraint 'SERVER_HIT_USER' 
> for key (DEMO55-admin).  The statement has been rolled back.))
>  cause 
> -
> Exception: org.ofbiz.entity.GenericDataSourceException
> Message: SQL Exception while executing the following:INSERT INTO 
> OFBIZ.SERVER_HIT (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, 
> NUM_OF_BYTES, RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, 
> REFERRER_URL, SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID,

[jira] [Commented] (OFBIZ-3972) user of tenant generate errors on entity Server_Hit

2017-02-24 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882287#comment-15882287
 ] 

Jacques Le Roux commented on OFBIZ-3972:


Agreed, just done

> user of tenant generate errors on entity Server_Hit
> ---
>
> Key: OFBIZ-3972
> URL: https://issues.apache.org/jira/browse/OFBIZ-3972
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Trunk
>
>
> When a user is active in a tenant and he/she logs off, server_hits are 
> generated. However the persistence is rolled back. See excerpt of error.log 
> below.
> 2010-10-01 11:34:12,169 (http-0.0.0.0-8443-5) [   
> GenericDelegator.java:889:ERROR] 
>  exception report 
> --
> Failure in create operation for entity [ServerHit]: 
> org.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServerHit][contentId,catalog.logout(java.lang.String)][createdStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][createdTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][hitStartDateTime,2010-10-01 
> 11:34:11.732(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][lastUpdatedTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][partyId,DEMO55-admin(java.lang.String)][referrerUrl,https://localhost:8443/catalog/control/main?externalLoginKey=EL814028348655(java.lang.String)][requestUrl,https://localhost:8443/catalog/control/logout(java.lang.String)][runningTimeMillis,406(java.lang.Long)][serverHostName,zase(java.lang.String)][serverIpAddress,10.0.0.125(java.lang.String)][userLoginId,DEMO55-admin(java.lang.String)][visitId,10024(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
> 'SERVER_HIT' caused a violation of foreign key constraint 'SERVER_HIT_USER' 
> for key (DEMO55-admin).  The statement has been rolled back.)). Rolling back 
> transaction.
> Exception: org.ofbiz.entity.GenericEntityException
> Message: Error while inserting: 
> [GenericEntity:ServerHit][contentId,catalog.logout(java.lang.String)][createdStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][createdTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][hitStartDateTime,2010-10-01 
> 11:34:11.732(java.sql.Timestamp)][hitTypeId,REQUEST(java.lang.String)][lastUpdatedStamp,2010-10-01
>  11:34:12.138(java.sql.Timestamp)][lastUpdatedTxStamp,2010-10-01 
> 11:34:12.138(java.sql.Timestamp)][partyId,DEMO55-admin(java.lang.String)][referrerUrl,https://localhost:8443/catalog/control/main?externalLoginKey=EL814028348655(java.lang.String)][requestUrl,https://localhost:8443/catalog/control/logout(java.lang.String)][runningTimeMillis,406(java.lang.Long)][serverHostName,zase(java.lang.String)][serverIpAddress,10.0.0.125(java.lang.String)][userLoginId,DEMO55-admin(java.lang.String)][visitId,10024(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.SERVER_HIT 
> (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, NUM_OF_BYTES, 
> RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, REFERRER_URL, 
> SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
> 'SERVER_HIT' caused a violation of foreign key constraint 'SERVER_HIT_USER' 
> for key (DEMO55-admin).  The statement has been rolled back.))
>  cause 
> -
> Exception: org.ofbiz.entity.GenericDataSourceException
> Message: SQL Exception while executing the following:INSERT INTO 
> OFBIZ.SERVER_HIT (VISIT_ID, CONTENT_ID, HIT_START_DATE_TIME, HIT_TYPE_ID, 
> NUM_OF_BYTES, RUNNING_TIME_MILLIS, USER_LOGIN_ID, STATUS_ID, REQUEST_URL, 
> REFERRER_URL, SERVER_IP_ADDRESS, SERVER_HOST_NAME, LAST_UPDATED_STAMP, 
> LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, INTERNAL_CONTENT_ID, 
> PARTY_ID, ID_BY_IP_CONTACT_MECH_ID, REF_BY_WEB_CONTACT_MECH_ID) VALUES (?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 
>