[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979871#comment-15979871
]
Jacques Le Roux commented on OFBIZ-9254:
Hi Devanshu,
Yes best way to handle it indeed, notably because it allows several people to
work on it.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9254_groovy.patch, OFBIZ-9254_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979842#comment-15979842 ] Pierre Smits commented on OFBIZ-7827: - I am all for components delivering a pre-defined and accepted set of functionalities. The Party Component is not one of those. In the past it has been referred to as a User Mgt solution, as a HR solution, as a shopping list mgt tool etc. Leading to a all kinds of duplicated (and some time halfly completed) functionalities. Not every party oriented overview in other components needs to be replicated into the party component. All these duplications make it unnecessarily difficult to 'sell' OFBiz as the Swiss army knife that it is. But where the real Swiss army knife has only 1 cork screw, the OFBiz variant isn't that concise. Focus will enable the project > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png, OFBIZ-7827_trunk.patch > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits resolved OFBIZ-6679. - Resolution: Done Closing with correct setting given the type of the issue. > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reopened OFBIZ-6679: - Reopening due to incorrect setting of the resolution. > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8266) From Date and Thru Date doesn't reflect on List Quote Roles screen.
[
https://issues.apache.org/jira/browse/OFBIZ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979837#comment-15979837
]
Deepak Dixit commented on OFBIZ-8266:
-
I think its a but as passed fromDate is not set in QuoteRole, ticket summary
may be confusing, see the description:
{code}
4) Create a Quote role by clicking on 'Create New Quote Role' button.
{code}
Service was not honoring passed fromDate
> From Date and Thru Date doesn't reflect on List Quote Roles screen.
> ---
>
> Key: OFBIZ-8266
> URL: https://issues.apache.org/jira/browse/OFBIZ-8266
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Reporter: Akshay Modak
>Assignee: Deepak Dixit
> Fix For: Upcoming Release, 16.11.02
>
> Attachments: OFBIZ-8266.patch
>
>
> Steps to regenerate:
> 1) Login to Order component.
> 2) Switch to Quotes tab.
> 3) In Quotes tab, open 'Quotes Role' child tab.
> 4) Create a Quote role by clicking on 'Create New Quote Role' button.
> 5) You will see Quote Role 'From Date' and 'Thru Date' details does not
> reflect on Quote Roles List screen.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979833#comment-15979833 ] Deepak Dixit commented on OFBIZ-7827: - So Pierre you are proposing to remove all the stuff from party profile like content, resume, product store roles form here as well as they all have their separate screens ;) > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png, OFBIZ-7827_trunk.patch > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6679. -- Resolution: Incomplete > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979832#comment-15979832 ] Jacques Le Roux commented on OFBIZ-6679: Hi Deepak, Pierre, I agree with both of you. > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8266) From Date and Thru Date doesn't reflect on List Quote Roles screen.
[ https://issues.apache.org/jira/browse/OFBIZ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979830#comment-15979830 ] Pierre Smits commented on OFBIZ-8266: - This is not a bug, but an improvement. > From Date and Thru Date doesn't reflect on List Quote Roles screen. > --- > > Key: OFBIZ-8266 > URL: https://issues.apache.org/jira/browse/OFBIZ-8266 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Akshay Modak >Assignee: Deepak Dixit > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-8266.patch > > > Steps to regenerate: > 1) Login to Order component. > 2) Switch to Quotes tab. > 3) In Quotes tab, open 'Quotes Role' child tab. > 4) Create a Quote role by clicking on 'Create New Quote Role' button. > 5) You will see Quote Role 'From Date' and 'Thru Date' details does not > reflect on Quote Roles List screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979829#comment-15979829 ] Pierre Smits commented on OFBIZ-7827: - Following the reasoning of Deepak, we could also do shipment receipts, invoicing and ordering for the party mgr. Maybe we should bring all functionalities into one big application, as everything has a user involved ;-) > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png, OFBIZ-7827_trunk.patch > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979828#comment-15979828 ] Pierre Smits commented on OFBIZ-6679: - In stead of reopening a closed issue, creating a new one would make sense too. > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979819#comment-15979819 ] Deepak Dixit commented on OFBIZ-6679: - Thanks Jacques, So as we are going to update PK of QuoteRole entity so we have to make it Deprecated and need to add data migration service. https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-DeprecatedEntities > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9331. --- Resolution: Done > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release, 16.11.02 > > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-8266) From Date and Thru Date doesn't reflect on List Quote Roles screen.
[ https://issues.apache.org/jira/browse/OFBIZ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979814#comment-15979814 ] Deepak Dixit edited comment on OFBIZ-8266 at 4/22/17 8:44 AM: -- Thank Akshay Modak for you for your contribution, slightly modified patch has been committed at Framework trunk at r#1792272 Release 16.11 at r#1792274 was (Author: deepak.dixit): Thank Akshay Modak for you for your contribution, slightly modified patch has been committed at trunk at r#1792272 > From Date and Thru Date doesn't reflect on List Quote Roles screen. > --- > > Key: OFBIZ-8266 > URL: https://issues.apache.org/jira/browse/OFBIZ-8266 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Akshay Modak >Assignee: Deepak Dixit > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-8266.patch > > > Steps to regenerate: > 1) Login to Order component. > 2) Switch to Quotes tab. > 3) In Quotes tab, open 'Quotes Role' child tab. > 4) Create a Quote role by clicking on 'Create New Quote Role' button. > 5) You will see Quote Role 'From Date' and 'Thru Date' details does not > reflect on Quote Roles List screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-9331: - > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release, 16.11.02 > > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-8266) From Date and Thru Date doesn't reflect on List Quote Roles screen.
[ https://issues.apache.org/jira/browse/OFBIZ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-8266. --- Resolution: Fixed Fix Version/s: 16.11.02 Upcoming Release > From Date and Thru Date doesn't reflect on List Quote Roles screen. > --- > > Key: OFBIZ-8266 > URL: https://issues.apache.org/jira/browse/OFBIZ-8266 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Akshay Modak >Assignee: Deepak Dixit > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-8266.patch > > > Steps to regenerate: > 1) Login to Order component. > 2) Switch to Quotes tab. > 3) In Quotes tab, open 'Quotes Role' child tab. > 4) Create a Quote role by clicking on 'Create New Quote Role' button. > 5) You will see Quote Role 'From Date' and 'Thru Date' details does not > reflect on Quote Roles List screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9331: Fix Version/s: 16.11.02 > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release, 16.11.02 > > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979805#comment-15979805 ] Deepak Dixit edited comment on OFBIZ-9331 at 4/22/17 8:40 AM: -- Converted create and remove QuoteRole service to entity-auto also added update and expire QuoteRole service. This has been done at Framework trunk at r#1792270 Release 16.11 at r#1792273 OFBIZ-8266 is dependent on this, so backported this improvement to Releaes16.11 as well. was (Author: deepak.dixit): Converted create and remove QuoteRole service to entity-auto also added update and expire QuoteRole service. This has been done at r#1792270 > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release > > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8266) From Date and Thru Date doesn't reflect on List Quote Roles screen.
[ https://issues.apache.org/jira/browse/OFBIZ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979814#comment-15979814 ] Deepak Dixit commented on OFBIZ-8266: - Thank Akshay Modak for you for your contribution, slightly modified patch has been committed at trunk at r#1792272 > From Date and Thru Date doesn't reflect on List Quote Roles screen. > --- > > Key: OFBIZ-8266 > URL: https://issues.apache.org/jira/browse/OFBIZ-8266 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Akshay Modak >Assignee: Deepak Dixit > Attachments: OFBIZ-8266.patch > > > Steps to regenerate: > 1) Login to Order component. > 2) Switch to Quotes tab. > 3) In Quotes tab, open 'Quotes Role' child tab. > 4) Create a Quote role by clicking on 'Create New Quote Role' button. > 5) You will see Quote Role 'From Date' and 'Thru Date' details does not > reflect on Quote Roles List screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979813#comment-15979813 ] Jacques Le Roux edited comment on OFBIZ-8316 at 4/22/17 8:26 AM: - BTW we need to move the Lucene index from the Solr component. Actually both should be in the common runtime directory, I started a discussion on dev ML: https://s.apache.org/KJ6n and this is related with OFBIZ-7265 was (Author: jacques.le.roux): BTW we need to move the Lucene index from the Solr component. Actually both should be in the common runtime directory, I started a discussion on dev ML: https://s.apache.org/KJ6n > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979813#comment-15979813 ] Jacques Le Roux commented on OFBIZ-8316: BTW we need to move the Lucene index from the Solr component. Actually both should be in the common runtime directory, I started a discussion on dev ML: https://s.apache.org/KJ6n > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979812#comment-15979812 ] Jacques Le Roux commented on OFBIZ-8316: Ping? > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979811#comment-15979811 ] Jacques Le Roux commented on OFBIZ-7827: OK that's a way of thinking, but what about the 2nd point? bq. And we have also the same functionnality with the Billing Account button in the sub tab bar where there is a new button and this one works. This is the one I used. The URL is https://ofbiz-vm2.apache.org:8443/accounting/control/EditBillingAccount?roleTypeId=BILL_TO_CUSTOMER=DemoCustomer Then why not EFT Account Gift Card Credit Card Check Account in the sub tab bar, to be consistent? I have several EFT, CC and Check accounts... BTW for demo URL better to use https://demo-trunk.ofbiz.apache.org/ ;) > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png, OFBIZ-7827_trunk.patch > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979809#comment-15979809 ] Jacques Le Roux commented on OFBIZ-6679: That makes sense indeed Deepak > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9331. --- Resolution: Fixed Fix Version/s: Upcoming Release > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release > > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979805#comment-15979805 ] Deepak Dixit commented on OFBIZ-9331: - Converted create and remove QuoteRole service to entity-auto also added update and expire QuoteRole service. This has been done at r#1792270 > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release > > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979804#comment-15979804 ] Deepak Dixit commented on OFBIZ-6679: - I think we need to add fromDate as part of primary key as well. > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-6679) PartyRole Lifespan fields - Have QuoteRole entity work with the change
[ https://issues.apache.org/jira/browse/OFBIZ-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-6679: - > PartyRole Lifespan fields - Have QuoteRole entity work with the change > -- > > Key: OFBIZ-6679 > URL: https://issues.apache.org/jira/browse/OFBIZ-6679 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: quote, roles > Fix For: 16.11.01 > > Attachments: OFBIZ-6679-QuoteRole.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
[ https://issues.apache.org/jira/browse/OFBIZ-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-9331: --- Assignee: Deepak Dixit > Convert QuoteRole entity related service from simple to entity auto. > - > > Key: OFBIZ-9331 > URL: https://issues.apache.org/jira/browse/OFBIZ-9331 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Deepak Dixit >Assignee: Deepak Dixit > > We have createQuoteRole and removeQuoteRole entity define as simple method, > convert them into entity-auto. > - There is some custom login in createQuoteRole entity to createPartyRole, so > it should be removed from createQuoteRole service. > - upateQuoteRole service is also missing, as we have fromDate and thruDate in > QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9331) Convert QuoteRole entity related service from simple to entity auto.
Deepak Dixit created OFBIZ-9331: --- Summary: Convert QuoteRole entity related service from simple to entity auto. Key: OFBIZ-9331 URL: https://issues.apache.org/jira/browse/OFBIZ-9331 Project: OFBiz Issue Type: Sub-task Reporter: Deepak Dixit We have createQuoteRole and removeQuoteRole entity define as simple method, convert them into entity-auto. - There is some custom login in createQuoteRole entity to createPartyRole, so it should be removed from createQuoteRole service. - upateQuoteRole service is also missing, as we have fromDate and thruDate in QuoteRole entity so update service should be exists for QuoteRole -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-8266) From Date and Thru Date doesn't reflect on List Quote Roles screen.
[ https://issues.apache.org/jira/browse/OFBIZ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-8266: --- Assignee: Deepak Dixit (was: Akshay Modak) > From Date and Thru Date doesn't reflect on List Quote Roles screen. > --- > > Key: OFBIZ-8266 > URL: https://issues.apache.org/jira/browse/OFBIZ-8266 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Akshay Modak >Assignee: Deepak Dixit > Attachments: OFBIZ-8266.patch > > > Steps to regenerate: > 1) Login to Order component. > 2) Switch to Quotes tab. > 3) In Quotes tab, open 'Quotes Role' child tab. > 4) Create a Quote role by clicking on 'Create New Quote Role' button. > 5) You will see Quote Role 'From Date' and 'Thru Date' details does not > reflect on Quote Roles List screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979783#comment-15979783 ] Deepak Dixit edited comment on OFBIZ-7827 at 4/22/17 6:28 AM: -- I think at different way, as BillingAccount and party is related so its good to keep it on party profile. Like we have Content, Product Store Roles etc, that have separate functionality and user can manage this from party profile page. So IMO its not duplicate, its an another way to add billing account for party. was (Author: deepak.dixit): I look it in different way, as BillingAccount and party is related so its good to keep it on party profile. Like we Content, Product Store Roles etc, that we have separate functionality for those as well. So IMO its not duplicate, its an another way to add billing account for party. > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png, OFBIZ-7827_trunk.patch > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7827) Create billing account functionality not working on party profile
[ https://issues.apache.org/jira/browse/OFBIZ-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979783#comment-15979783 ] Deepak Dixit commented on OFBIZ-7827: - I look it in different way, as BillingAccount and party is related so its good to keep it on party profile. Like we Content, Product Store Roles etc, that we have separate functionality for those as well. So IMO its not duplicate, its an another way to add billing account for party. > Create billing account functionality not working on party profile > - > > Key: OFBIZ-7827 > URL: https://issues.apache.org/jira/browse/OFBIZ-7827 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Arvind Singh Tomar > Attachments: errorinaddbilling.png, OFBIZ-7827_trunk.patch > > > On party profile page when try to add billing account it throws error on > screen. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
