[jira] [Commented] (OFBIZ-9303) Remove hard-coded success/error message variables set in service output
[
https://issues.apache.org/jira/browse/OFBIZ-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985333#comment-15985333
]
Deepak Dixit commented on OFBIZ-9303:
-
Hi Devanshu,
Could you please upload patch for plugins as well?
Also I found some occurrences after patch applied, could you please update
that as well.
> Remove hard-coded success/error message variables set in service output
>
>
> Key: OFBIZ-9303
> URL: https://issues.apache.org/jira/browse/OFBIZ-9303
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9303.patch
>
>
> I found that certain services in OFBiz set error/success message values in o
> hard-codedly like:
> {code}
> result.put("errorMessage", errMsg);
> result.put("successMessage", message);
> {code}
> I think it shouldn't be set like this, as we have constants in ModelService
> class for this purpose.
> ModelService.ERROR_MESSAGE/ModelService.SUCCESS_MESSAGE should be used to set
> the error and success messages, for in case we want to change the constant's
> value, no services will be affected.
> {code}
> result.put(ModelService.ERROR_MESSAGE, errMsg);
> result.put(ModelService.SUCCESS_MESSAGE, errMsg);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9327) Remove Deprecated Entities
[ https://issues.apache.org/jira/browse/OFBIZ-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9327. --- Resolution: Done Fix Version/s: Upcoming Release > Remove Deprecated Entities > -- > > Key: OFBIZ-9327 > URL: https://issues.apache.org/jira/browse/OFBIZ-9327 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Release > > > We have deprecated entities define in entitymodel prefix with "Old", we can > remove these entities as they are too old. > [Deprecated Entities|https://cwiki.apache.org/confluence/x/KYBr] > [Dev list > discussion|https://lists.apache.org/thread.html/45081cf2c344f2e0de709a3e987749798ad60390bb93cab3a6ab6c25@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9327) Remove Deprecated Entities
[ https://issues.apache.org/jira/browse/OFBIZ-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985313#comment-15985313 ] Deepak Dixit commented on OFBIZ-9327: - Removed old data migration service at r#1792788 Added not on Data Migration doc as well. > Remove Deprecated Entities > -- > > Key: OFBIZ-9327 > URL: https://issues.apache.org/jira/browse/OFBIZ-9327 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > > We have deprecated entities define in entitymodel prefix with "Old", we can > remove these entities as they are too old. > [Deprecated Entities|https://cwiki.apache.org/confluence/x/KYBr] > [Dev list > discussion|https://lists.apache.org/thread.html/45081cf2c344f2e0de709a3e987749798ad60390bb93cab3a6ab6c25@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9337) Update msyql sql-type for datetime field-type
[ https://issues.apache.org/jira/browse/OFBIZ-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-9337: --- Assignee: Deepak Dixit > Update msyql sql-type for datetime field-type > - > > Key: OFBIZ-9337 > URL: https://issues.apache.org/jira/browse/OFBIZ-9337 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > > Mysql 5.6 added support to store microseconds in datetime/time field. > Here is the link for discussion on dev list: > https://s.apache.org/ytBk > Need to update fieldtypemysql.xml and update the following field-type > - date-time : use DATETIME (3) > - time : use TIME (3) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9337) Update msyql sql-type for datetime field-type
[ https://issues.apache.org/jira/browse/OFBIZ-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984956#comment-15984956 ] Jacques Le Roux commented on OFBIZ-9337: bq. Deepak rightly mentioned that [...] we need to create an entry in "data migration" wiki page > Update msyql sql-type for datetime field-type > - > > Key: OFBIZ-9337 > URL: https://issues.apache.org/jira/browse/OFBIZ-9337 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > Mysql 5.6 added support to store microseconds in datetime/time field. > Here is the link for discussion on dev list: > https://s.apache.org/ytBk > Need to update fieldtypemysql.xml and update the following field-type > - date-time : use DATETIME (3) > - time : use TIME (3) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9337) Update msyql sql-type for datetime field-type
[ https://issues.apache.org/jira/browse/OFBIZ-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9337: Description: Mysql 5.6 added support to store microseconds in datetime/time field. Here is the link for discussion on dev list: https://s.apache.org/ytBk Need to update fieldtypemysql.xml and update the following field-type - date-time : use DATETIME (3) - time : use TIME (3) was: Mysql 5.6 added support to store microseconds in datetime/time field. Here is the link for discussion on dev list: https://lists.apache.org/thread.html/32d9249d58c00bae20264c96b6de0288eb6a36b5e97d60332ad5ad49@%3Cdev.ofbiz.apache.org%3E Need to update fieldtypemysql.xml and update the following field-type - date-time : use DATETIME (3) - time : use TIME (3) > Update msyql sql-type for datetime field-type > - > > Key: OFBIZ-9337 > URL: https://issues.apache.org/jira/browse/OFBIZ-9337 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Deepak Dixit > > Mysql 5.6 added support to store microseconds in datetime/time field. > Here is the link for discussion on dev list: > https://s.apache.org/ytBk > Need to update fieldtypemysql.xml and update the following field-type > - date-time : use DATETIME (3) > - time : use TIME (3) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9337) Update msyql sql-type for datetime field-type
Deepak Dixit created OFBIZ-9337: --- Summary: Update msyql sql-type for datetime field-type Key: OFBIZ-9337 URL: https://issues.apache.org/jira/browse/OFBIZ-9337 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Deepak Dixit Mysql 5.6 added support to store microseconds in datetime/time field. Here is the link for discussion on dev list: https://lists.apache.org/thread.html/32d9249d58c00bae20264c96b6de0288eb6a36b5e97d60332ad5ad49@%3Cdev.ofbiz.apache.org%3E Need to update fieldtypemysql.xml and update the following field-type - date-time : use DATETIME (3) - time : use TIME (3) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9336) Ecommerce login/logout events don't work properly for Shopping Cart
Alexander Tzvetanov created OFBIZ-9336: -- Summary: Ecommerce login/logout events don't work properly for Shopping Cart Key: OFBIZ-9336 URL: https://issues.apache.org/jira/browse/OFBIZ-9336 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Release Branch 16.11, Release Branch 15.12 Environment: Linux, PostgreSQL Reporter: Alexander Tzvetanov How to reproduce: 1. Sign in; 2. Add more than two items in the shopping cart; 3. Sign out (or close the browser); 4. Sign in back again. You will see that only one item is restored back in the shopping cart (instead of many). The other items are not restored back there. 5. In the system console appears an error that show that you do not have permissions to modify somebody else's shopping cart. This error prevents the items that are in the user's list to be completely restored. Only first item stays restored in the cart. What caused this: Since I tracked the sign-in process I found the following events order: The events that occurred during the login process are: 1. Pre-processor calls "keepCartUpdated". However at this time the session context is not still in "signed in" stage, and the shopping cart object is restored as from an anonymous user; 2. Log-in has been called afterwards, and session becomes "signed in" with the user; 3. At the end the "logIn" function calls "after-login" section, described in "context.xml" file; 4. In "after-login" section, there is again "keepCartUpdated" listed. It is there in order to update the shopping cart with the new context including the logged in user. However, because "preprocessor" already called "keepCartUpdated", Ofbiz skipped to call this event handler again. And as a result the shopping card stays "anonymous". How I fixed this issue on my side: I just renamed "keepCartUpdated" event to "keepCartUpdated1" in the "after-login" section in "context.xml" and shopping cart worked correctly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
