[jira] [Resolved] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin resolved OFBIZ-9381. -- Resolution: Done Fix Version/s: Upcoming Release Ok done at revision 1796428. > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Fix For: Upcoming Release > > Attachments: OFBIZ-9381-1.patch, OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9374) Fix TemporalExpressions.Frequency to avoid moving job start times away from given freqCount raster
[
https://issues.apache.org/jira/browse/OFBIZ-9374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9374:
---
Fix Version/s: (was: Release Branch 16.11)
16.11.03
Hi Michael,
We don't use the "Released versions" in the "Fix Version/s" field for the
pending release but the corresponding one in "Unreleased versions". So I
changed from "Release Branch R16.11" to "16.11.03"
I know the rules are a bit complicated, I tried to explain them here
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues
To complete: last exchange with Jacopo about it https://s.apache.org/awBU
Thanks
> Fix TemporalExpressions.Frequency to avoid moving job start times away from
> given freqCount raster
> ---
>
> Key: OFBIZ-9374
> URL: https://issues.apache.org/jira/browse/OFBIZ-9374
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
>Assignee: Michael Brohl
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
> Attachments: OFBIZ-9374.patch
>
>
> If a job is scheduled using TemporalExpressions.Frequency the start time of
> the job will gradually move forward when the excecution of the job is delayed
> by one or more units of the frequency type.
> Example: Job is set up to start at 2017-01-01 00:00:00 and run every ten
> minutes. One month later due to some circumstances the job starts at
> 2017-02-01 00:01:01 which results in the next execution to be scheduled at
> 2017-02-01 01:11:00 in stead of 2017-02-01 01:10:00.
> The reason behind this behaviour is the
> TemporalExpressions.Frequency#prepareCal function. It has the purpose to jump
> from the first starting time to the latest possible execution of the job. But
> instead it just sets it to the current time (with the precision of the chosen
> frequency type) and calculates the next execution time from this point.
> {code:title=Frequencies.java}
> protected Calendar prepareCal(Calendar cal) {
> // Performs a "sane" skip forward in time - avoids time consuming
> loops
> // like incrementing every second from Jan 1 2000 until today
> Calendar skip = (Calendar) cal.clone();
> skip.setTime(this.start);
> long deltaMillis = cal.getTimeInMillis() - this.start.getTime();
> if (deltaMillis < 1000) {
> return skip;
> }
> long divisor = deltaMillis;
> if (this.freqType == Calendar.DAY_OF_MONTH) {
> divisor = 8640;
> } else if (this.freqType == Calendar.HOUR) {
> divisor = 360;
> } else if (this.freqType == Calendar.MINUTE) {
> divisor = 6;
> } else if (this.freqType == Calendar.SECOND) {
> divisor = 1000;
> } else {
> return skip;
> }
> float units = deltaMillis / divisor;
> units = (units / this.freqCount) * this.freqCount;
> skip.add(this.freqType, (int)units);
> while (skip.after(cal)) {
> skip.add(this.freqType, -this.freqCount);
> }
> return skip;
> }
> {code}
> The error is at {{units = (units / this.freqCount) * this.freqCount;}}. This
> is no operation. What should have been done (and to me it looks like this was
> the intention), is a substraction of the remainder of an integer division of
> {{units}} and {{this.freqCount}} to get the number of units of the frequency
> type that have passed since the first start time.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027411#comment-16027411
]
Jacques Le Roux commented on OFBIZ-9372:
Hi Leila, Deepak,
About
bq. Please use != null check for genericValue instead of using UtilValidate
method
Actually you can even follow
http://groovy-lang.org/semantics.html#Groovy-Truth. Also for String, etc.
So for instance
bq. while ( UtilValidate.isNotEmpty(currentOrganizationPartyId) &&
containsEmptyFields) {
can be written
bq. while (currentOrganizationPartyId && containsEmptyFields) {
and
bq. if (UtilValidate.isNotEmpty(currentPartyAcctgPref)) {
bq. if (currentPartyAcctgPref) {
etc. There are plenty of examples in current source.
> Convert AcctgAdminServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-9372
> URL: https://issues.apache.org/jira/browse/OFBIZ-9372
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Attachments: OFBIZ-9372.patch
>
>
> This is an attempt to migrate AcctgAdminServices.xml to groovy file version.
> The discussion is still running about the automation of the migration and the
> langage to use for service migration (Java or groovy)
> In both case, maybe this can help migrate it to java or to identify some
> automatic migration matching patterns.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027408#comment-16027408 ] Deepak Dixit commented on OFBIZ-9381: - Thanks [~soledad], yes it looks good to me, You can remove unused Debug class from import. :) > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381-1.patch, OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-7120) Multisite support in specialpurpose/cmssite
[ https://issues.apache.org/jira/browse/OFBIZ-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-7120. --- > Multisite support in specialpurpose/cmssite > --- > > Key: OFBIZ-7120 > URL: https://issues.apache.org/jira/browse/OFBIZ-7120 > Project: OFBiz > Issue Type: New Feature > Components: cmssite >Affects Versions: Trunk >Reporter: Pranay Pandey >Assignee: Deepak Dixit > Fix For: 16.11.03 > > Attachments: OFBIZ-7120-1.patch, OFBIZ-7120-1.patch, > OFBIZ-7120-2.patch, OFBIZ-7120-2.patch, OFBIZ-7120-branch-16.11.patch, > OFBIZ-7120-framework.patch > > > Idea is to implement a WebSiteFilter in specialpurose/cmssite component which > can demonstrate OFBiz CMS ability to serve multiple websites with single > webapp. > To demonstrate WebSiteFilter usage, will also be adding sample website data, > in addition to the one we already have. > Originally this idea and implementation is from [~lektran]. I will be > providing the patch for review and acceptance by the community. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7120) Multisite support in specialpurpose/cmssite
[ https://issues.apache.org/jira/browse/OFBIZ-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027407#comment-16027407 ] Deepak Dixit commented on OFBIZ-7120: - Thanks [~rehan.khan] for your contribution, Your patch has been committed at Trunk at r#1796382 Release 16.11 at r#1796384 > Multisite support in specialpurpose/cmssite > --- > > Key: OFBIZ-7120 > URL: https://issues.apache.org/jira/browse/OFBIZ-7120 > Project: OFBiz > Issue Type: New Feature > Components: cmssite >Affects Versions: Trunk >Reporter: Pranay Pandey >Assignee: Deepak Dixit > Fix For: 16.11.03 > > Attachments: OFBIZ-7120-1.patch, OFBIZ-7120-1.patch, > OFBIZ-7120-2.patch, OFBIZ-7120-2.patch, OFBIZ-7120-branch-16.11.patch, > OFBIZ-7120-framework.patch > > > Idea is to implement a WebSiteFilter in specialpurose/cmssite component which > can demonstrate OFBiz CMS ability to serve multiple websites with single > webapp. > To demonstrate WebSiteFilter usage, will also be adding sample website data, > in addition to the one we already have. > Originally this idea and implementation is from [~lektran]. I will be > providing the patch for review and acceptance by the community. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-7120) Multisite support in specialpurpose/cmssite
[ https://issues.apache.org/jira/browse/OFBIZ-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-7120: --- Assignee: Deepak Dixit (was: Pranay Pandey) > Multisite support in specialpurpose/cmssite > --- > > Key: OFBIZ-7120 > URL: https://issues.apache.org/jira/browse/OFBIZ-7120 > Project: OFBiz > Issue Type: New Feature > Components: cmssite >Affects Versions: Trunk >Reporter: Pranay Pandey >Assignee: Deepak Dixit > Fix For: 16.11.01 > > Attachments: OFBIZ-7120-1.patch, OFBIZ-7120-1.patch, > OFBIZ-7120-2.patch, OFBIZ-7120-2.patch, OFBIZ-7120-branch-16.11.patch, > OFBIZ-7120-framework.patch > > > Idea is to implement a WebSiteFilter in specialpurose/cmssite component which > can demonstrate OFBiz CMS ability to serve multiple websites with single > webapp. > To demonstrate WebSiteFilter usage, will also be adding sample website data, > in addition to the one we already have. > Originally this idea and implementation is from [~lektran]. I will be > providing the patch for review and acceptance by the community. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027405#comment-16027405 ] Nicolas Malin edited comment on OFBIZ-9381 at 5/27/17 11:38 AM: Ok I separate the code to convert only the minilang to groovy with move default value on the service definition. If it's OK for you [~deepak.dixit] I will commit this and after I will move the delete service name to expire was (Author: soledad): Ok I separate the code to convert only the minilang to groovy with move default value on the service definition. If it's OK for you [~deepakddixit] I will commit this and after I will move the delete service name to expire > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381-1.patch, OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027406#comment-16027406
]
Aditya Sharma commented on OFBIZ-9351:
--
Thanks Deepak :)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-9381: - Attachment: OFBIZ-9381-1.patch Ok I separate the code to convert only the minilang to groovy with move default value on the service definition. If it's OK for you [~deepakddixit] I will commit this and after I will move the delete service name to expire > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381-1.patch, OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027404#comment-16027404
]
Deepak Dixit commented on OFBIZ-9351:
-
Thanks Aditya for your contribution,
OFBIZ-9351.patch has been committed to ofbiz-framework at r#r1796379
and
OFBIZ-9351_plugins.patch has been committed to ofbiz-plugins at r#1796380
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-9351:
Affects Version/s: Trunk
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-9351:
Issue Type: Improvement (was: Task)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reassigned OFBIZ-9351:
---
Assignee: Deepak Dixit (was: Aditya Sharma)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-4514) Taxes are not handled correctly when creating accounting transactions from purchase invoices
[ https://issues.apache.org/jira/browse/OFBIZ-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027372#comment-16027372 ] Deepak Nigam commented on OFBIZ-4514: - In the case of Purchase Invoice,a prominent feature of Sales Tax calculation was missing from the systems,which leads towards invalid Account Postings of General Ledger,also there were no provision of calculation of freight charges. Now after the patch has submitted,the system comes to a stage where the sales taxes at Purchase invoice is now being taking into the calculation. > Taxes are not handled correctly when creating accounting transactions from > purchase invoices > > > Key: OFBIZ-4514 > URL: https://issues.apache.org/jira/browse/OFBIZ-4514 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Martin Kreidenweis >Priority: Trivial > Labels: VAT, tax > Attachments: OFBIZ-4514_combined.patch, OFBIZ-4514.patch > > > Taxes are not handled correctly when creating accounting transactions from > purchase invoices in GeneralLedgerServices#createAcctgTransForPurchaseInvoice -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027370#comment-16027370
]
Deepak Dixit commented on OFBIZ-9380:
-
Also as its not a bug so changing the ticket type to improvement.
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-9380:
Issue Type: Improvement (was: Bug)
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit resolved OFBIZ-9380.
-
Resolution: Done
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: 16.11.03, Release Branch 15.12, Release Branch 14.12
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Reopened] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reopened OFBIZ-9380:
-
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-9380.
---
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-9380.
---
Thanks Jacques,
I was waiting for Chuck Kosta reply, but I think we can close will reopen if
required.
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9380) renderDateTimeField works in IE, not working with lastest Chrome
[
https://issues.apache.org/jira/browse/OFBIZ-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027367#comment-16027367
]
Jacques Le Roux commented on OFBIZ-9380:
Hi Deepak,
Should we not close?
> renderDateTimeField works in IE, not working with lastest Chrome
>
>
> Key: OFBIZ-9380
> URL: https://issues.apache.org/jira/browse/OFBIZ-9380
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12
>Reporter: Chuck Kosta
>Assignee: Deepak Dixit
> Fix For: Release Branch 14.12, Release Branch 15.12, 16.11.03
>
>
> {code}
> <@htmlTemplate.renderDateTimeField ... />
> {code}
> Works correctly in IE; but in firefox and chrome, it ignores the values when
> sent to an entity updating service call. The page gets refreshed with the
> original date.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027305#comment-16027305 ] Deepak Dixit commented on OFBIZ-9372: - Hi Leila, I reviewed your patch and it looks good to me, here are some couple of improvement that can be done - We can use entity-auto for createPartyAcctgPreference service - Please use != null check for genericValue instead of using UtilValidate method - We can use EntityConditionBuilder to make the entity condition. > Convert AcctgAdminServices.xml mini lang to groovy > -- > > Key: OFBIZ-9372 > URL: https://issues.apache.org/jira/browse/OFBIZ-9372 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Leila Mekika >Priority: Minor > Attachments: OFBIZ-9372.patch > > > This is an attempt to migrate AcctgAdminServices.xml to groovy file version. > The discussion is still running about the automation of the migration and the > langage to use for service migration (Java or groovy) > In both case, maybe this can help migrate it to java or to identify some > automatic migration matching patterns. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027299#comment-16027299 ] Deepak Dixit commented on OFBIZ-9372: - Converted this ticket as sub-ticket of OFBIZ-9350, It will help to track the whole effort. > Convert AcctgAdminServices.xml mini lang to groovy > -- > > Key: OFBIZ-9372 > URL: https://issues.apache.org/jira/browse/OFBIZ-9372 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Leila Mekika >Priority: Minor > Attachments: OFBIZ-9372.patch > > > This is an attempt to migrate AcctgAdminServices.xml to groovy file version. > The discussion is still running about the automation of the migration and the > langage to use for service migration (Java or groovy) > In both case, maybe this can help migrate it to java or to identify some > automatic migration matching patterns. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9372: Issue Type: Sub-task (was: Task) Parent: OFBIZ-9350 > Convert AcctgAdminServices.xml mini lang to groovy > -- > > Key: OFBIZ-9372 > URL: https://issues.apache.org/jira/browse/OFBIZ-9372 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Leila Mekika >Priority: Minor > Attachments: OFBIZ-9372.patch > > > This is an attempt to migrate AcctgAdminServices.xml to groovy file version. > The discussion is still running about the automation of the migration and the > langage to use for service migration (Java or groovy) > In both case, maybe this can help migrate it to java or to identify some > automatic migration matching patterns. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027297#comment-16027297 ] Deepak Dixit commented on OFBIZ-9381: - Converted this ticket as sub-ticket of OFBIZ-9350, It will help to track the whole effort. > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9381: Issue Type: Sub-task (was: Task) Parent: OFBIZ-9350 > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9381) Convert RateServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027290#comment-16027290 ] Deepak Dixit commented on OFBIZ-9381: - Hi Nicoals, I reviewed it and it looks good to me, some minor improvement can be done: - I think we can use entity-auto for updateRateAmount/deleteRateAmount service, they are belongs to CRUD operation - Instead of Debug.log we can use Debug.logVerbose to print the newEntity.toMapString() - I think we can change delete to expire in separate commit - We can use default-value attribute for setting the default value for service in parameter. > Convert RateServices.xml mini-lang to groovyDSL > --- > > Key: OFBIZ-9381 > URL: https://issues.apache.org/jira/browse/OFBIZ-9381 > Project: OFBiz > Issue Type: Task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9381.patch, OFBIZ-9381.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. > I converted updateRateAmount, deleteRateAmount, updatePartyRate and > deleteRateAmount. > Delete isn't a good definition for the service who expire the element instead > of remove if. So I propose with the patch to move the deleteRateAmount and > deletePartyRate to expireRateAmount and expirePartyRate. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
