[jira] [Comment Edited] (OFBIZ-10047) Tomcat SSO
[
https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293385#comment-16293385
]
Jacques Le Roux edited comment on OFBIZ-10047 at 12/15/17 11:06 PM:
Actually it works as long as you don't try to use a /login screen, ie you can
get to another application w/o issues and use any screen there but login. Also
it seems the session is "forever" (by forever I mean at least more than the
std 60 mins) something to check . So at least 2 issues so far.
And it seems the problem is rather that:
{code}
2017-12-15 23:10:45,120 |jsse-nio-8443-exec-7 |LoginWorker
|I| Setting default delegator
javax.servlet.ServletException: This request has already been authenticated
at org.apache.catalina.connector.Request.login(Request.java:2750)
at
org.apache.catalina.connector.RequestFacade.login(RequestFacade.java:1073)
at
javax.servlet.http.HttpServletRequestWrapper.login(HttpServletRequestWrapper.java:365)
at
org.apache.ofbiz.common.login.LoginServices.TomcatSSOLogin(LoginServices.java:1039)
at
org.apache.ofbiz.common.login.LoginServices.userLogin(LoginServices.java:218)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:400)
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at
org.apache.ofbiz.webapp.control.LoginWorker.login(LoginWorker.java:430)
{code}
The issue above being benign, but to fix also, so 3 issues :)
was (Author: jacques.le.roux):
Actually it works as long as you don't try to use a /login screen, ie you can
get to another application w/o issues and use any screen there but login. Also
it seems the session is "forever" something to check. So at least 2 issues so
far.
And it seems the problem is rather that:
{code}
2017-12-15 23:10:45,120 |jsse-nio-8443-exec-7 |LoginWorker
|I| Setting default delegator
javax.servlet.ServletException: This request has already been authenticated
at org.apache.catalina.connector.Request.login(Request.java:2750)
at
org.apache.catalina.connector.RequestFacade.login(RequestFacade.java:1073)
at
javax.servlet.http.HttpServletRequestWrapper.login(HttpServletRequestWrapper.java:365)
at
org.apache.ofbiz.common.login.LoginServices.TomcatSSOLogin(LoginServices.java:1039)
at
org.apache.ofbiz.common.login.LoginServices.userLogin(LoginServices.java:218)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:400)
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at
org.apache.ofbiz.webapp.control.LoginWorker.login(LoginWorker.java:430)
{code}
The issue above being benign, but to fix also, so 3 issues :)
> Tomcat SSO
> --
>
> Key: OFBIZ-10047
> URL: https://issues.apache.org/jira/browse/OFBIZ-10047
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch
>
>
> Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On.
> This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10058) Issues in error.log both locally and in trunk demo
[
https://issues.apache.org/jira/browse/OFBIZ-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293392#comment-16293392
]
Jacques Le Roux commented on OFBIZ-10058:
-
OK this was due to me playing with svn update to revisions. It still exists in
trunk HEAD and I'm now sure OFBIZ-9138 is NOT concerned. It's a recent bug.
> Issues in error.log both locally and in trunk demo
> --
>
> Key: OFBIZ-10058
> URL: https://issues.apache.org/jira/browse/OFBIZ-10058
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I have no ideas yet why this happens, here some errors from the trunk demo:
> {code}
> 2017-12-15 09:59:49,860 |ajp-nio-8009-exec-5 |JuelConnector
> |F| null
> javax.el.PropertyNotFoundException: Cannot resolve identifier 'layoutSettings'
> at
> de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
> ~[juel-impl-2.2.7.jar:2.2.7]
> at
> org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
> [ofbiz.jar:?]
> at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
> [juel-impl-2.2.7.jar:2.2.7]
> at
> de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
> [juel-impl-2.2.7.jar:2.2.7]
> at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:177)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$SetField.runAction(AbstractModelAction.java:906)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:141)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:273)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:859)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:138)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:100)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:122)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:999)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:646)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.5.23.jar:8.5.23]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:213)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
>
[jira] [Commented] (OFBIZ-10047) Tomcat SSO
[
https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293385#comment-16293385
]
Jacques Le Roux commented on OFBIZ-10047:
-
Actually it works as long as you don't try to use a /login screen, ie you can
get to another application w/o issues and use any screen there but login. Also
it seems the session is "forever" something to check. So at least 2 issues so
far.
And it seems the problem is rather that:
{code}
2017-12-15 23:10:45,120 |jsse-nio-8443-exec-7 |LoginWorker
|I| Setting default delegator
javax.servlet.ServletException: This request has already been authenticated
at org.apache.catalina.connector.Request.login(Request.java:2750)
at
org.apache.catalina.connector.RequestFacade.login(RequestFacade.java:1073)
at
javax.servlet.http.HttpServletRequestWrapper.login(HttpServletRequestWrapper.java:365)
at
org.apache.ofbiz.common.login.LoginServices.TomcatSSOLogin(LoginServices.java:1039)
at
org.apache.ofbiz.common.login.LoginServices.userLogin(LoginServices.java:218)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:400)
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:228)
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
at
org.apache.ofbiz.webapp.control.LoginWorker.login(LoginWorker.java:430)
{code}
The issue above being benign, but to fix also, so 3 issues :)
> Tomcat SSO
> --
>
> Key: OFBIZ-10047
> URL: https://issues.apache.org/jira/browse/OFBIZ-10047
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch
>
>
> Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On.
> This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10058) Issues in error.log both locally and in trunk demo
[
https://issues.apache.org/jira/browse/OFBIZ-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293381#comment-16293381
]
Jacques Le Roux commented on OFBIZ-10058:
-
It seems I can't reproduce after updating to trunk HEAD. I'll check the trunk
demo tomorrow morning and close if it's also OK there.
> Issues in error.log both locally and in trunk demo
> --
>
> Key: OFBIZ-10058
> URL: https://issues.apache.org/jira/browse/OFBIZ-10058
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I have no ideas yet why this happens, here some errors from the trunk demo:
> {code}
> 2017-12-15 09:59:49,860 |ajp-nio-8009-exec-5 |JuelConnector
> |F| null
> javax.el.PropertyNotFoundException: Cannot resolve identifier 'layoutSettings'
> at
> de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
> ~[juel-impl-2.2.7.jar:2.2.7]
> at
> org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
> [ofbiz.jar:?]
> at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
> [juel-impl-2.2.7.jar:2.2.7]
> at
> de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
> [juel-impl-2.2.7.jar:2.2.7]
> at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:177)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$SetField.runAction(AbstractModelAction.java:906)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:141)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:273)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:859)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:138)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:100)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:122)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:999)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:646)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.5.23.jar:8.5.23]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:213)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
> [ofbiz.jar:?]
> at
[jira] [Closed] (OFBIZ-10079) [Refactoring] Package org.apache.ofbiz.content.survey
[ https://issues.apache.org/jira/browse/OFBIZ-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10079. - Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1818337. > [Refactoring] Package org.apache.ofbiz.content.survey > - > > Key: OFBIZ-10079 > URL: https://issues.apache.org/jira/browse/OFBIZ-10079 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-No_org.apache.ofbiz.content.survey.PdfSurveyServices.patch, > OFBIZ-No_org.apache.ofbiz.content.survey.SurveyWrapper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10079) [Refactoring] Package org.apache.ofbiz.content.survey
[ https://issues.apache.org/jira/browse/OFBIZ-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10079: - Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.content.survey > - > > Key: OFBIZ-10079 > URL: https://issues.apache.org/jira/browse/OFBIZ-10079 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.content.survey.PdfSurveyServices.patch, > OFBIZ-No_org.apache.ofbiz.content.survey.SurveyWrapper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10080) [Refactoring] Package org.apache.ofbiz.content.webapp.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10080. - Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1818335. > [Refactoring] Package org.apache.ofbiz.content.webapp.ftl > - > > Key: OFBIZ-10080 > URL: https://issues.apache.org/jira/browse/OFBIZ-10080 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.CheckPermissionTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentCacheTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.InjectNodeTrailCsvTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LimitedSubContentCacheTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LoopSubContentTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.OfbizContentAltUrlTransforms.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAndSubContent.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAsText.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentTransform.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10080) [Refactoring] Package org.apache.ofbiz.content.webapp.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10080: - Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.content.webapp.ftl > - > > Key: OFBIZ-10080 > URL: https://issues.apache.org/jira/browse/OFBIZ-10080 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.CheckPermissionTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentCacheTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.InjectNodeTrailCsvTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LimitedSubContentCacheTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LoopSubContentTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.OfbizContentAltUrlTransforms.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAndSubContent.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAsText.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentTransform.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10081) [Refactoring] Package org.apache.ofbiz.product.promo
[ https://issues.apache.org/jira/browse/OFBIZ-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10081. - Resolution: Implemented Fix Version/s: Upcoming Release Thanks Dennis, your patch is in trunk r1818333. > [Refactoring] Package org.apache.ofbiz.product.promo > > > Key: OFBIZ-10081 > URL: https://issues.apache.org/jira/browse/OFBIZ-10081 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-10081_org.apache.ofbiz.product.promo.PromoServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10081) [Refactoring] Package org.apache.ofbiz.product.promo
[ https://issues.apache.org/jira/browse/OFBIZ-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10081: - Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.product.promo > > > Key: OFBIZ-10081 > URL: https://issues.apache.org/jira/browse/OFBIZ-10081 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-10081_org.apache.ofbiz.product.promo.PromoServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10082) [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport
[ https://issues.apache.org/jira/browse/OFBIZ-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10082. - Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1818330. > [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport > > > Key: OFBIZ-10082 > URL: https://issues.apache.org/jira/browse/OFBIZ-10082 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ImportProductServices.patch, > OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ProductHelper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10082) [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport
[ https://issues.apache.org/jira/browse/OFBIZ-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10082: - Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport > > > Key: OFBIZ-10082 > URL: https://issues.apache.org/jira/browse/OFBIZ-10082 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ImportProductServices.patch, > OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ProductHelper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10084) [Refactoring] Package org.apache.ofbiz.order.shoppingcart
[ https://issues.apache.org/jira/browse/OFBIZ-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10084. - Resolution: Implemented Fix Version/s: Upcoming Release Thanks Dennis, your patch is in trunk r1818329. > [Refactoring] Package org.apache.ofbiz.order.shoppingcart > - > > Key: OFBIZ-10084 > URL: https://issues.apache.org/jira/browse/OFBIZ-10084 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CartEventListener.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutEvents.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutHelper.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCart.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartHelper.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartItem.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10084) [Refactoring] Package org.apache.ofbiz.order.shoppingcart
[ https://issues.apache.org/jira/browse/OFBIZ-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10084: - Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.order.shoppingcart > - > > Key: OFBIZ-10084 > URL: https://issues.apache.org/jira/browse/OFBIZ-10084 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CartEventListener.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutEvents.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutHelper.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCart.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartHelper.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartItem.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9878) [Refactoring] Package org.apache.ofbiz.common.image
[ https://issues.apache.org/jira/browse/OFBIZ-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-9878: Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.common.image > --- > > Key: OFBIZ-9878 > URL: https://issues.apache.org/jira/browse/OFBIZ-9878 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-9878_org.apache.ofbiz.common.image.ImageTransform_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9877) [Refactoring] Package org.apache.ofbiz.accounting.tax
[ https://issues.apache.org/jira/browse/OFBIZ-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9877. Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1818325. > [Refactoring] Package org.apache.ofbiz.accounting.tax > - > > Key: OFBIZ-9877 > URL: https://issues.apache.org/jira/browse/OFBIZ-9877 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: > OFBIZ-9877_org.apache.ofbiz.accounting.tax.TaxAuthorityServices_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9877) [Refactoring] Package org.apache.ofbiz.accounting.tax
[ https://issues.apache.org/jira/browse/OFBIZ-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-9877: Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.accounting.tax > - > > Key: OFBIZ-9877 > URL: https://issues.apache.org/jira/browse/OFBIZ-9877 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Attachments: > OFBIZ-9877_org.apache.ofbiz.accounting.tax.TaxAuthorityServices_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10047) Tomcat SSO
[
https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293005#comment-16293005
]
Jacques Le Roux commented on OFBIZ-10047:
-
I surmise it could be related with
{code}
2017-12-15 10:10:42,711 |jsse-nio-8443-exec-5 |RequestHandler
|E| null
org.apache.ofbiz.webapp.event.EventHandlerException: Pre-Processor event
[checkServletRequestRemoteUserLogin] did not return 'success'.
{code}
But just a bet
> Tomcat SSO
> --
>
> Key: OFBIZ-10047
> URL: https://issues.apache.org/jira/browse/OFBIZ-10047
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch
>
>
> Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On.
> This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10047) Tomcat SSO
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292993#comment-16292993 ] Jacques Le Roux commented on OFBIZ-10047: - The problem I thought was in OFBIZ-10057 is easily reproducible w/ only the patch here. Simply log with https://localhost:8443/catalog/control/login?USERNAME=admin=ofbiz=Y and then try to log again using the same URL (works w/o the patch) or even simply try w/ https://localhost:8443/catalog/control/login > Tomcat SSO > -- > > Key: OFBIZ-10047 > URL: https://issues.apache.org/jira/browse/OFBIZ-10047 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch > > > Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On. > This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10057) Using "gradlew svnInfoFooter" while OFBiz is running breaks the admin password
[ https://issues.apache.org/jira/browse/OFBIZ-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10057. --- Resolution: Invalid Assignee: Jacques Le Roux Actually I close here. It's not related with "gradlew svnInfoFooter". It's only a problem of OFBIZ-10047 that I will explain there. > Using "gradlew svnInfoFooter" while OFBiz is running breaks the admin password > -- > > Key: OFBIZ-10057 > URL: https://issues.apache.org/jira/browse/OFBIZ-10057 > Project: OFBiz > Issue Type: Bug > Components: framework, Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > I have nothing more to add for now, WIP... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10057) Using "gradlew svnInfoFooter" while OFBiz is running breaks the admin password
[ https://issues.apache.org/jira/browse/OFBIZ-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292949#comment-16292949 ] Jacques Le Roux commented on OFBIZ-10057: - After doing "gradlew svnInfoFooter" the admin paswoord is changed (did not check what it is then in DB) so you can't login again, in the same session (or not I did not try w/ another session but must be the same) > Using "gradlew svnInfoFooter" while OFBiz is running breaks the admin password > -- > > Key: OFBIZ-10057 > URL: https://issues.apache.org/jira/browse/OFBIZ-10057 > Project: OFBiz > Issue Type: Bug > Components: framework, Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > > I have nothing more to add for now, WIP... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10047) Tomcat SSO
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292763#comment-16292763 ] Jacques Le Roux commented on OFBIZ-10047: - Also this page should then be removed https://cwiki.apache.org/confluence/display/OFBIZ/Why+do+I+have+to+login+when+there+is+a+externalLoginKey > Tomcat SSO > -- > > Key: OFBIZ-10047 > URL: https://issues.apache.org/jira/browse/OFBIZ-10047 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch > > > Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On. > This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10054) Product content management screen doesn't validate trusted users' input
[
https://issues.apache.org/jira/browse/OFBIZ-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292756#comment-16292756
]
Jacques Le Roux commented on OFBIZ-10054:
-
Here are the most relevant parts of the discussion held in the OFBiz private
security at the time of the disclosure by Loris Nardo. I think they can help
here.
Jacopo wrote
My suggestion is to fix this by editing the service definition for service
"updateProductContent" by setting allow-html="safe" on a few fields
(small/medium/large images and a few others).
However there are some fields where embedding html should be allowed and this
will still allow authenticated malicious backend users to cause similar
problems: for this reason I don't think we should treat this report as an
official security vulnerability (with CVE etc...): all in all an authenticated
malicious user may cause any kind of troubles in the system.
So I would suggest to treat it as an enhancement to security rather than a
security vulnerability.
Gregory answered to Jacopo:
If there are fields where html is needed and we can authorize a specific set of
html tags the following solution can fit.
All the content is html encoded and then a regex is applied to replace all
encoded tags by the authorized html tag.
Example:
{code}
[jira] [Closed] (OFBIZ-10056) [FB] Package org.apache.ofbiz.order.order
[ https://issues.apache.org/jira/browse/OFBIZ-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10056. - Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1818291. Some classes need more refactoring like internationalization of error messages but this is out of scope here... > [FB] Package org.apache.ofbiz.order.order > - > > Key: OFBIZ-10056 > URL: https://issues.apache.org/jira/browse/OFBIZ-10056 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-No_org.apache.ofbiz.order.order_bugfixes.patch > > > OrderChangeHelper.java:75, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:99, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:137, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:214, NP_LOAD_OF_KNOWN_NULL_VALUE > - NP: Load of known null value in > org.apache.ofbiz.order.order.OrderChangeHelper.orderStatusChanges(LocalDispatcher, > GenericValue, String, String, String, String, String) > The variable referenced at this point is known to be null due to an earlier > check against null. Although this is valid, it might be a mistake (perhaps > you intended to refer to a different variable, or perhaps the earlier check > to see if the variable is null should have been a check to see if it was > non-null). > OrderContentWrapper.java:103, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > - RCN: Nullcheck of OrderContentWrapper.orderContentCache at line 115 of > value previously dereferenced in > org.apache.ofbiz.order.order.OrderContentWrapper.getOrderContentAsText(GenericValue, > String, Locale, String, Delegator, LocalDispatcher, String) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have
[jira] [Commented] (OFBIZ-10047) Tomcat SSO
[
https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292656#comment-16292656
]
Jacques Le Roux commented on OFBIZ-10047:
-
Hi James,
I'd really like to have this feature in the next to come R17 branch. Here are
some other points (apart OFBIZ-10057) I found reviewing and testing
{code}
+} catch (ServletException e) {
+e.printStackTrace();
{code}
This should use Debug.logError()
I also noticed this error in log, not sure what were the conditions so maybe a
false issue.
{code}
2017-12-15 10:10:42,711 |jsse-nio-8443-exec-5 |RequestHandler
|E| null
org.apache.ofbiz.webapp.event.EventHandlerException: Pre-Processor event
[checkServletRequestRemoteUserLogin] did not return 'success'.
{code}
it's related with
{code}
-if (allowRemoteUserLogin) {
+if (useTomcatSSO || allowRemoteUserLogin) {
{code}
that I have to double check. BTW, though I see no real problem, I wonder about
using the same code for external (remote) and internal (SSO) sign on.
Also minor, there a diamond is better:
{code}
List roles = new ArrayList<>();
roles.add("PLACEHOLDER_ROLE");
{code}
PLACEHOLDER_ROLE should not be a problem since OFBiz uses its own roles
handling.
So, apart OFBIZ-10057 that I have to double check, I find your patch ready to
be committed, though I'd appreciate other reviews...
I also think that we can then deprecate the externalLoginKey stuff.
> Tomcat SSO
> --
>
> Key: OFBIZ-10047
> URL: https://issues.apache.org/jira/browse/OFBIZ-10047
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-10047.patch, OFBIZ-10047.patch
>
>
> Proposing Tomcat SSO to be used in OFBiz to improve on Single-Sign-On.
> This aim to fix the issues mentioned in OFBIZ-6963, OFBIZ-6994.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10056) [FB] Package org.apache.ofbiz.order.order
[ https://issues.apache.org/jira/browse/OFBIZ-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10056: - Assignee: Michael Brohl > [FB] Package org.apache.ofbiz.order.order > - > > Key: OFBIZ-10056 > URL: https://issues.apache.org/jira/browse/OFBIZ-10056 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-No_org.apache.ofbiz.order.order_bugfixes.patch > > > OrderChangeHelper.java:75, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:99, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:137, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:214, NP_LOAD_OF_KNOWN_NULL_VALUE > - NP: Load of known null value in > org.apache.ofbiz.order.order.OrderChangeHelper.orderStatusChanges(LocalDispatcher, > GenericValue, String, String, String, String, String) > The variable referenced at this point is known to be null due to an earlier > check against null. Although this is valid, it might be a mistake (perhaps > you intended to refer to a different variable, or perhaps the earlier check > to see if the variable is null should have been a check to see if it was > non-null). > OrderContentWrapper.java:103, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > - RCN: Nullcheck of OrderContentWrapper.orderContentCache at line 115 of > value previously dereferenced in > org.apache.ofbiz.order.order.OrderContentWrapper.getOrderContentAsText(GenericValue, > String, Locale, String, Delegator, LocalDispatcher, String) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the previous dereference disagree as to whether > this value is allowed to be null. Either the check is redundant or the > previous dereference is erroneous. >
[jira] [Updated] (OFBIZ-10084) [Refactoring] Package org.apache.ofbiz.order.shoppingcart
[ https://issues.apache.org/jira/browse/OFBIZ-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10084: -- Attachment: OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CartEventListener.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutEvents.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutHelper.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCart.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartHelper.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartItem.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartServices.patch > [Refactoring] Package org.apache.ofbiz.order.shoppingcart > - > > Key: OFBIZ-10084 > URL: https://issues.apache.org/jira/browse/OFBIZ-10084 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CartEventListener.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutEvents.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.CheckOutHelper.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCart.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartHelper.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartItem.patch, > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.ShoppingCartServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10084) [Refactoring] Package org.apache.ofbiz.order.shoppingcart
Dennis Balkir created OFBIZ-10084: - Summary: [Refactoring] Package org.apache.ofbiz.order.shoppingcart Key: OFBIZ-10084 URL: https://issues.apache.org/jira/browse/OFBIZ-10084 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10083) Replace all the "e.printStackTrace();" by calls to Debug class
Jacques Le Roux created OFBIZ-10083: --- Summary: Replace all the "e.printStackTrace();" by calls to Debug class Key: OFBIZ-10083 URL: https://issues.apache.org/jira/browse/OFBIZ-10083 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Trivial We have 57 cases like that in Java and Groovy files. Most of the the time Debug.logError() should be used I guess. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10082) [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport
[ https://issues.apache.org/jira/browse/OFBIZ-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10082: Attachment: OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ImportProductServices.patch OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ProductHelper.patch > [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport > > > Key: OFBIZ-10082 > URL: https://issues.apache.org/jira/browse/OFBIZ-10082 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ImportProductServices.patch, > OFBIZ-No_org.apache.ofbiz.product.spreadsheetimport.ProductHelper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10082) [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport
Julian Leichert created OFBIZ-10082: --- Summary: [Refactoring] Package org.apache.ofbiz.product.spreadsheetimport Key: OFBIZ-10082 URL: https://issues.apache.org/jira/browse/OFBIZ-10082 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10057) Using "gradlew svnInfoFooter" while OFBiz is running breaks the admin password
[ https://issues.apache.org/jira/browse/OFBIZ-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292547#comment-16292547 ] James Yong commented on OFBIZ-10057: Hi Jacques, what do you mean by 'breaks the admin password'? > Using "gradlew svnInfoFooter" while OFBiz is running breaks the admin password > -- > > Key: OFBIZ-10057 > URL: https://issues.apache.org/jira/browse/OFBIZ-10057 > Project: OFBiz > Issue Type: Bug > Components: framework, Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > > I have nothing more to add for now, WIP... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10081) [Refactoring] Package org.apache.ofbiz.product.promo
[ https://issues.apache.org/jira/browse/OFBIZ-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10081: -- Attachment: OFBIZ-10081_org.apache.ofbiz.product.promo.PromoServices.patch > [Refactoring] Package org.apache.ofbiz.product.promo > > > Key: OFBIZ-10081 > URL: https://issues.apache.org/jira/browse/OFBIZ-10081 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: > OFBIZ-10081_org.apache.ofbiz.product.promo.PromoServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10081) [Refactoring] Package org.apache.ofbiz.product.promo
Dennis Balkir created OFBIZ-10081: - Summary: [Refactoring] Package org.apache.ofbiz.product.promo Key: OFBIZ-10081 URL: https://issues.apache.org/jira/browse/OFBIZ-10081 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10080) [Refactoring] Package org.apache.ofbiz.content.webapp.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10080: Attachment: OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.CheckPermissionTransform.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentCacheTransform.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentTransform.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.InjectNodeTrailCsvTransform.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LimitedSubContentCacheTransform.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LoopSubContentTransform.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.OfbizContentAltUrlTransforms.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAndSubContent.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAsText.patch OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentTransform.patch > [Refactoring] Package org.apache.ofbiz.content.webapp.ftl > - > > Key: OFBIZ-10080 > URL: https://issues.apache.org/jira/browse/OFBIZ-10080 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.CheckPermissionTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentCacheTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.EditRenderSubContentTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.InjectNodeTrailCsvTransform.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LimitedSubContentCacheTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.LoopSubContentTransform.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.OfbizContentAltUrlTransforms.patch, > > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAndSubContent.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentAsText.patch, > OFBIZ-No_org.apache.ofbiz.content.webapp.ftl.RenderContentTransform.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10079) [Refactoring] Package org.apache.ofbiz.content.survey
[ https://issues.apache.org/jira/browse/OFBIZ-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10079: Attachment: OFBIZ-No_org.apache.ofbiz.content.survey.PdfSurveyServices.patch OFBIZ-No_org.apache.ofbiz.content.survey.SurveyWrapper.patch > [Refactoring] Package org.apache.ofbiz.content.survey > - > > Key: OFBIZ-10079 > URL: https://issues.apache.org/jira/browse/OFBIZ-10079 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.content.survey.PdfSurveyServices.patch, > OFBIZ-No_org.apache.ofbiz.content.survey.SurveyWrapper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10077) [Refactoring] Package org.apache.ofbiz.content.data
[ https://issues.apache.org/jira/browse/OFBIZ-10077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10077: Attachment: OFBIZ-No_org.apache.ofbiz.content.data.DataEvents.patch OFBIZ-No_org.apache.ofbiz.content.data.DataResourceWorker.patch OFBIZ-No_org.apache.ofbiz.content.data.DataServices.patch > [Refactoring] Package org.apache.ofbiz.content.data > --- > > Key: OFBIZ-10077 > URL: https://issues.apache.org/jira/browse/OFBIZ-10077 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: OFBIZ-No_org.apache.ofbiz.content.data.DataEvents.patch, > OFBIZ-No_org.apache.ofbiz.content.data.DataResourceWorker.patch, > OFBIZ-No_org.apache.ofbiz.content.data.DataServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10078) [Refactoring] Package org.apache.ofbiz.content.output
Julian Leichert created OFBIZ-10078: --- Summary: [Refactoring] Package org.apache.ofbiz.content.output Key: OFBIZ-10078 URL: https://issues.apache.org/jira/browse/OFBIZ-10078 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10077) [Refactoring] Package org.apache.ofbiz.content.data
Julian Leichert created OFBIZ-10077: --- Summary: [Refactoring] Package org.apache.ofbiz.content.data Key: OFBIZ-10077 URL: https://issues.apache.org/jira/browse/OFBIZ-10077 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10076) [Refactoring] Package org.apache.ofbiz.product.test
[ https://issues.apache.org/jira/browse/OFBIZ-10076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10076: Attachment: OFBIZ-No_org.apache.ofbiz.product.test.IventoryItemTransferTest.patch OFBIZ-No_org.apache.ofbiz.product.test.StockMovesTest.patch > [Refactoring] Package org.apache.ofbiz.product.test > --- > > Key: OFBIZ-10076 > URL: https://issues.apache.org/jira/browse/OFBIZ-10076 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.test.IventoryItemTransferTest.patch, > OFBIZ-No_org.apache.ofbiz.product.test.StockMovesTest.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10076) [Refactoring] Package org.apache.ofbiz.product.test
Julian Leichert created OFBIZ-10076: --- Summary: [Refactoring] Package org.apache.ofbiz.product.test Key: OFBIZ-10076 URL: https://issues.apache.org/jira/browse/OFBIZ-10076 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10075) [Refactoring] Package org.apache.ofbiz.product.supplier
[ https://issues.apache.org/jira/browse/OFBIZ-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10075: Attachment: OFBIZ-No_org.apache.ofbiz.product.supplier.SupplierProductServices.patch > [Refactoring] Package org.apache.ofbiz.product.supplier > --- > > Key: OFBIZ-10075 > URL: https://issues.apache.org/jira/browse/OFBIZ-10075 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.supplier.SupplierProductServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10075) [Refactoring] Package org.apache.ofbiz.product.supplier
Julian Leichert created OFBIZ-10075: --- Summary: [Refactoring] Package org.apache.ofbiz.product.supplier Key: OFBIZ-10075 URL: https://issues.apache.org/jira/browse/OFBIZ-10075 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10074) [Refactoring] Package org.apache.ofbiz.product.subscription
[ https://issues.apache.org/jira/browse/OFBIZ-10074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10074: Attachment: OFBIZ-No_org.apache.ofbiz.product.subscription.SubscriptionServices.patch > [Refactoring] Package org.apache.ofbiz.product.subscription > --- > > Key: OFBIZ-10074 > URL: https://issues.apache.org/jira/browse/OFBIZ-10074 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.subscription.SubscriptionServices.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10074) [Refactoring] Package org.apache.ofbiz.product.subscription
Julian Leichert created OFBIZ-10074: --- Summary: [Refactoring] Package org.apache.ofbiz.product.subscription Key: OFBIZ-10074 URL: https://issues.apache.org/jira/browse/OFBIZ-10074 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10073) [Refactoring] Package org.apache.ofbiz.product.product
Julian Leichert created OFBIZ-10073: --- Summary: [Refactoring] Package org.apache.ofbiz.product.product Key: OFBIZ-10073 URL: https://issues.apache.org/jira/browse/OFBIZ-10073 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10073) [Refactoring] Package org.apache.ofbiz.product.product
[ https://issues.apache.org/jira/browse/OFBIZ-10073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10073: Attachment: OFBIZ-No_org.apache.ofbiz.product.product.KeywordIndex.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductConentWrapper.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch > [Refactoring] Package org.apache.ofbiz.product.product > -- > > Key: OFBIZ-10073 > URL: https://issues.apache.org/jira/browse/OFBIZ-10073 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.product.KeywordIndex.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductConentWrapper.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch, > OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.ProductConentWrapper.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
> Attachments:
> OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch
>
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: (was:
OFBIZ-No_org.apache.ofbiz.product.product.KeywordIndex.patch)
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
> Attachments:
> OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch
>
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements
[
https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-9836:
---
Attachment: OFBIZ-No_org.apache.ofbiz.product.product.KeywordIndex.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductConentWrapper.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch
OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch
> General refactoring and code improvements
> -
>
> Key: OFBIZ-9836
> URL: https://issues.apache.org/jira/browse/OFBIZ-9836
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
> Attachments:
> OFBIZ-No_org.apache.ofbiz.product.product.ProducUtilServices.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductContentWrapper.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductEvents.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearch.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchEvents.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductServices.patch,
> OFBIZ-No_org.apache.ofbiz.product.product.ProductWorker.patch
>
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase
> always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if
> possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
> System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw
> exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even,
> because some coders use it and some don't)
> there will be separate patches for each class of the package for easier
> reviewing and patching purposes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-10072) [Refactoring] Package org.apache.ofbiz.product.inventory
[ https://issues.apache.org/jira/browse/OFBIZ-10072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10072: Attachment: OFBIZ-No_org.apache.ofbiz.product.inventory.IventoryServices.patch OFBIZ-No_org.apache.ofbiz.product.inventory.IventoryWorker.patch > [Refactoring] Package org.apache.ofbiz.product.inventory > > > Key: OFBIZ-10072 > URL: https://issues.apache.org/jira/browse/OFBIZ-10072 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.inventory.IventoryServices.patch, > OFBIZ-No_org.apache.ofbiz.product.inventory.IventoryWorker.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10072) [Refactoring] Package org.apache.ofbiz.product.inventory
Julian Leichert created OFBIZ-10072: --- Summary: [Refactoring] Package org.apache.ofbiz.product.inventory Key: OFBIZ-10072 URL: https://issues.apache.org/jira/browse/OFBIZ-10072 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10071) [Refactoring] Package org.apache.ofbiz.product.imagemanagement
[ https://issues.apache.org/jira/browse/OFBIZ-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10071: Attachment: OFBIZ-No_org.apache.ofbiz.product.imagemanagement.CropImage.patch OFBIZ-No_org.apache.ofbiz.product.imagemanagement.FrameImage.patch OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ImageManagementHelper.patch OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ImageManagementServices.patch OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ImageUrlServlet.patch OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ReplaceImage.patch OFBIZ-No_org.apache.ofbiz.product.imagemanagement.RotateImage.patch > [Refactoring] Package org.apache.ofbiz.product.imagemanagement > -- > > Key: OFBIZ-10071 > URL: https://issues.apache.org/jira/browse/OFBIZ-10071 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.CropImage.patch, > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.FrameImage.patch, > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ImageManagementHelper.patch, > > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ImageManagementServices.patch, > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ImageUrlServlet.patch, > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.ReplaceImage.patch, > OFBIZ-No_org.apache.ofbiz.product.imagemanagement.RotateImage.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10071) [Refactoring] Package org.apache.ofbiz.product.imagemanagement
Julian Leichert created OFBIZ-10071: --- Summary: [Refactoring] Package org.apache.ofbiz.product.imagemanagement Key: OFBIZ-10071 URL: https://issues.apache.org/jira/browse/OFBIZ-10071 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10070) [Refactoring] Package org.apache.ofbiz.product.image
[ https://issues.apache.org/jira/browse/OFBIZ-10070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10070: Attachment: OFBIZ-No_org.apache.ofbiz.product.image.ScaleImage.patch > [Refactoring] Package org.apache.ofbiz.product.image > - > > Key: OFBIZ-10070 > URL: https://issues.apache.org/jira/browse/OFBIZ-10070 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: OFBIZ-No_org.apache.ofbiz.product.image.ScaleImage.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10070) [Refactoring] Package org.apache.ofbiz.product.image
Julian Leichert created OFBIZ-10070: --- Summary: [Refactoring] Package org.apache.ofbiz.product.image Key: OFBIZ-10070 URL: https://issues.apache.org/jira/browse/OFBIZ-10070 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10069) [Refactoring] Package org.apache.ofbiz.product.config
[ https://issues.apache.org/jira/browse/OFBIZ-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10069: Attachment: OFBIZ-No_org.apache.ofbiz.product.config.ProductConfigItemContentWrapper.patch OFBIZ-No_org.apache.ofbiz.product.config.ProductConfigWorker.patch OFBIZ-No_org.apache.ofbiz.product.config.ProductConfigWrapper.patch > [Refactoring] Package org.apache.ofbiz.product.config > - > > Key: OFBIZ-10069 > URL: https://issues.apache.org/jira/browse/OFBIZ-10069 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.product.config.ProductConfigItemContentWrapper.patch, > OFBIZ-No_org.apache.ofbiz.product.config.ProductConfigWorker.patch, > OFBIZ-No_org.apache.ofbiz.product.config.ProductConfigWrapper.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10069) [Refactoring] Package org.apache.ofbiz.product.config
Julian Leichert created OFBIZ-10069: --- Summary: [Refactoring] Package org.apache.ofbiz.product.config Key: OFBIZ-10069 URL: https://issues.apache.org/jira/browse/OFBIZ-10069 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10058) Issues in error.log both locally and in trunk demo
[
https://issues.apache.org/jira/browse/OFBIZ-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292448#comment-16292448
]
Jacques Le Roux commented on OFBIZ-10058:
-
Yes OFBIZ-9138 could be the culprit, but I'm not sure because AFAIK this is new
in error.log. So it would be a mix w/ a recent change or rather a recent change
alone...
> Issues in error.log both locally and in trunk demo
> --
>
> Key: OFBIZ-10058
> URL: https://issues.apache.org/jira/browse/OFBIZ-10058
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I have no ideas yet why this happens, here some errors from the trunk demo:
> {code}
> 2017-12-15 09:59:49,860 |ajp-nio-8009-exec-5 |JuelConnector
> |F| null
> javax.el.PropertyNotFoundException: Cannot resolve identifier 'layoutSettings'
> at
> de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
> ~[juel-impl-2.2.7.jar:2.2.7]
> at
> org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
> [ofbiz.jar:?]
> at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
> [juel-impl-2.2.7.jar:2.2.7]
> at
> de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
> [juel-impl-2.2.7.jar:2.2.7]
> at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:177)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$SetField.runAction(AbstractModelAction.java:906)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:141)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:273)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:859)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:138)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:100)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:122)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:999)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:646)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.5.23.jar:8.5.23]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:213)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
>
[jira] [Updated] (OFBIZ-10068) [Refactoring] Package org.apache.ofbiz.party.party
[ https://issues.apache.org/jira/browse/OFBIZ-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10068: Attachment: OFBIZ-No_org.apache.ofbiz.party.party.PartyHelper_refactoring.patch OFBIZ-No_org.apache.ofbiz.party.party.PartyRelationshipHelper_refactoring.patch OFBIZ-No_org.apache.ofbiz.party.party.PartyRelationshipService_refactoring.patch OFBIZ-No_org.apache.ofbiz.party.party.PartyServices_refactoring.patch OFBIZ-No_org.apache.ofbiz.party.party.PartyWorker_refactoring.patch > [Refactoring] Package org.apache.ofbiz.party.party > -- > > Key: OFBIZ-10068 > URL: https://issues.apache.org/jira/browse/OFBIZ-10068 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.party.party.PartyHelper_refactoring.patch, > OFBIZ-No_org.apache.ofbiz.party.party.PartyRelationshipHelper_refactoring.patch, > > OFBIZ-No_org.apache.ofbiz.party.party.PartyRelationshipService_refactoring.patch, > OFBIZ-No_org.apache.ofbiz.party.party.PartyServices_refactoring.patch, > OFBIZ-No_org.apache.ofbiz.party.party.PartyWorker_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10068) [Refactoring] Package org.apache.ofbiz.party.party
Julian Leichert created OFBIZ-10068: --- Summary: [Refactoring] Package org.apache.ofbiz.party.party Key: OFBIZ-10068 URL: https://issues.apache.org/jira/browse/OFBIZ-10068 Project: OFBiz Issue Type: Sub-task Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10067) [Refactoring] Package org.apache.ofbiz.party.contact
Julian Leichert created OFBIZ-10067: --- Summary: [Refactoring] Package org.apache.ofbiz.party.contact Key: OFBIZ-10067 URL: https://issues.apache.org/jira/browse/OFBIZ-10067 Project: OFBiz Issue Type: Sub-task Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9365) Screen rendering error on Content Advanced Search page
[ https://issues.apache.org/jira/browse/OFBIZ-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292411#comment-16292411 ] Deepak Dixit commented on OFBIZ-9365: - Thanks Aditya for reporting the issue. Content Advanced search was broken since long, still need to review work done at r#1102554, In this commit most of the issue has been fixed. This has been fixed at ofbiz framework trunk at r#1818273 and ofbiz release 16.11 at r#1818274 > Screen rendering error on Content Advanced Search page > -- > > Key: OFBIZ-9365 > URL: https://issues.apache.org/jira/browse/OFBIZ-9365 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Trivial > Fix For: 16.11.04 > > Attachments: screenshot-1.png > > > Steps to reproduce: > 1. Go to Content component > (https://demo-trunk.ofbiz.apache.org/content/control/main) > 2. Click on Content from > submenu.(https://demo-trunk.ofbiz.apache.org/content/control/findContent) > 3. Click on the Advanced Search button > (https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions). > 4. Provide Content Id and click on Find button. > It gives a ScreenRenderException. > The error only occurs when Content Id is provided to refine the search. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9365) Screen rendering error on Content Advanced Search page
[ https://issues.apache.org/jira/browse/OFBIZ-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9365. --- Resolution: Fixed Fix Version/s: 16.11.04 > Screen rendering error on Content Advanced Search page > -- > > Key: OFBIZ-9365 > URL: https://issues.apache.org/jira/browse/OFBIZ-9365 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Trivial > Fix For: 16.11.04 > > Attachments: screenshot-1.png > > > Steps to reproduce: > 1. Go to Content component > (https://demo-trunk.ofbiz.apache.org/content/control/main) > 2. Click on Content from > submenu.(https://demo-trunk.ofbiz.apache.org/content/control/findContent) > 3. Click on the Advanced Search button > (https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions). > 4. Provide Content Id and click on Find button. > It gives a ScreenRenderException. > The error only occurs when Content Id is provided to refine the search. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9365) Screen rendering error on Content Advanced Search page
[ https://issues.apache.org/jira/browse/OFBIZ-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-9365: --- Assignee: Deepak Dixit (was: Sonal Patwari) > Screen rendering error on Content Advanced Search page > -- > > Key: OFBIZ-9365 > URL: https://issues.apache.org/jira/browse/OFBIZ-9365 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Trivial > Attachments: screenshot-1.png > > > Steps to reproduce: > 1. Go to Content component > (https://demo-trunk.ofbiz.apache.org/content/control/main) > 2. Click on Content from > submenu.(https://demo-trunk.ofbiz.apache.org/content/control/findContent) > 3. Click on the Advanced Search button > (https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions). > 4. Provide Content Id and click on Find button. > It gives a ScreenRenderException. > The error only occurs when Content Id is provided to refine the search. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10066) [Refactoring] Package org.apache.ofbiz.party.communication
[ https://issues.apache.org/jira/browse/OFBIZ-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10066: Attachment: OFBIZ-No_org.apache.ofbiz.party.communication.CommunicationServices_refactoring.patch > [Refactoring] Package org.apache.ofbiz.party.communication > -- > > Key: OFBIZ-10066 > URL: https://issues.apache.org/jira/browse/OFBIZ-10066 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.party.communication.CommunicationServices_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10066) [Refactoring] Package org.apache.ofbiz.party.communication
Julian Leichert created OFBIZ-10066: --- Summary: [Refactoring] Package org.apache.ofbiz.party.communication Key: OFBIZ-10066 URL: https://issues.apache.org/jira/browse/OFBIZ-10066 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10065) [Refactoring] Package org.apache.ofbiz.order.shoppingcart.product
[ https://issues.apache.org/jira/browse/OFBIZ-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10065: Attachment: OFBIZ-No_org.apache.ofbiz.order.shoppingcart.product.ProductDisplayWorker_refactoring.patch OFBIZ-No_org.apache.ofbiz.order.shoppingcart.product.ProductPromoWorker_refactoring.patch > [Refactoring] Package org.apache.ofbiz.order.shoppingcart.product > - > > Key: OFBIZ-10065 > URL: https://issues.apache.org/jira/browse/OFBIZ-10065 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.product.ProductDisplayWorker_refactoring.patch, > > OFBIZ-No_org.apache.ofbiz.order.shoppingcart.product.ProductPromoWorker_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10065) [Refactoring] Package org.apache.ofbiz.order.shoppingcart.product
Julian Leichert created OFBIZ-10065: --- Summary: [Refactoring] Package org.apache.ofbiz.order.shoppingcart.product Key: OFBIZ-10065 URL: https://issues.apache.org/jira/browse/OFBIZ-10065 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10064) [Refactoring] Package org.apache.ofbiz.order.thirdparty.paypal
[ https://issues.apache.org/jira/browse/OFBIZ-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10064: Attachment: OFBIZ-No_org.apache.ofbiz.order.thirdparty.paypal.ExpressCheckoutEvents_refactoring.patch > [Refactoring] Package org.apache.ofbiz.order.thirdparty.paypal > -- > > Key: OFBIZ-10064 > URL: https://issues.apache.org/jira/browse/OFBIZ-10064 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.order.thirdparty.paypal.ExpressCheckoutEvents_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10064) [Refactoring] Package org.apache.ofbiz.order.thirdparty.paypal
Julian Leichert created OFBIZ-10064: --- Summary: [Refactoring] Package org.apache.ofbiz.order.thirdparty.paypal Key: OFBIZ-10064 URL: https://issues.apache.org/jira/browse/OFBIZ-10064 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10063) [Refactoring] Package org.apache.ofbiz.order.test
Julian Leichert created OFBIZ-10063: --- Summary: [Refactoring] Package org.apache.ofbiz.order.test Key: OFBIZ-10063 URL: https://issues.apache.org/jira/browse/OFBIZ-10063 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10042) [Refactoring] Package org.apache.ofbiz.order.shoppinglist
[ https://issues.apache.org/jira/browse/OFBIZ-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert closed OFBIZ-10042. --- Resolution: Duplicate > [Refactoring] Package org.apache.ofbiz.order.shoppinglist > - > > Key: OFBIZ-10042 > URL: https://issues.apache.org/jira/browse/OFBIZ-10042 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10062) [Refactoring] Package org.apache.ofbiz.order.shoppinglist
[ https://issues.apache.org/jira/browse/OFBIZ-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10062: Attachment: OFBIZ-No_org.apache.ofbiz.order.shoppinglist.ShoppingListEvents_refactoring.patch OFBIZ-No_org.apache.ofbiz.order.shoppinglist.ShoppingListServices_refactoring.patch > [Refactoring] Package org.apache.ofbiz.order.shoppinglist > - > > Key: OFBIZ-10062 > URL: https://issues.apache.org/jira/browse/OFBIZ-10062 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: > OFBIZ-No_org.apache.ofbiz.order.shoppinglist.ShoppingListEvents_refactoring.patch, > > OFBIZ-No_org.apache.ofbiz.order.shoppinglist.ShoppingListServices_refactoring.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10062) [Refactoring] Package org.apache.ofbiz.order.shoppinglist
Julian Leichert created OFBIZ-10062: --- Summary: [Refactoring] Package org.apache.ofbiz.order.shoppinglist Key: OFBIZ-10062 URL: https://issues.apache.org/jira/browse/OFBIZ-10062 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9532) Edit Party Group page does not shows current set values
[ https://issues.apache.org/jira/browse/OFBIZ-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9532. --- Resolution: Fixed Assignee: Deepak Dixit (was: Aditya Sharma) Fix Version/s: 16.11.04 > Edit Party Group page does not shows current set values > --- > > Key: OFBIZ-9532 > URL: https://issues.apache.org/jira/browse/OFBIZ-9532 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Trivial > Fix For: 16.11.04 > > Attachments: screenshot-1.png > > > Steps to reproduce: > 1. Go to SFA component (https://demo-trunk.ofbiz.apache.org/sfa/control/main). > 2. Click on Leads from sub menu > (https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads). > 3. Click on partyId link of lead with some related company > (https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?roleTypeId=LEAD=sfa101) > 4. Click on update button under party group information > (https://demo-trunk.ofbiz.apache.org/sfa/control/editpartygroup?partyId=sfa101) > Even though the party has a Group Name still it shows empty field. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9532) Edit Party Group page does not shows current set values
[ https://issues.apache.org/jira/browse/OFBIZ-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292386#comment-16292386 ] Deepak Dixit edited comment on OFBIZ-9532 at 12/15/17 11:34 AM: Thanks Aditya Sharma for reporting the issue. This has been fixed at ofbiz framework trunk r#1818269 and backported to ofbiz 16.11 at r#1818270 was (Author: deepak.dixit): Thanks Aditya Sharma for reporting the issue. This has been fixed at ofbiz framework trunk r#1818269 > Edit Party Group page does not shows current set values > --- > > Key: OFBIZ-9532 > URL: https://issues.apache.org/jira/browse/OFBIZ-9532 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Fix For: 16.11.04 > > Attachments: screenshot-1.png > > > Steps to reproduce: > 1. Go to SFA component (https://demo-trunk.ofbiz.apache.org/sfa/control/main). > 2. Click on Leads from sub menu > (https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads). > 3. Click on partyId link of lead with some related company > (https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?roleTypeId=LEAD=sfa101) > 4. Click on update button under party group information > (https://demo-trunk.ofbiz.apache.org/sfa/control/editpartygroup?partyId=sfa101) > Even though the party has a Group Name still it shows empty field. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9532) Edit Party Group page does not shows current set values
[ https://issues.apache.org/jira/browse/OFBIZ-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292386#comment-16292386 ] Deepak Dixit commented on OFBIZ-9532: - Thanks Aditya Sharma for reporting the issue. This has been fixed at ofbiz framework trunk r#1818269 > Edit Party Group page does not shows current set values > --- > > Key: OFBIZ-9532 > URL: https://issues.apache.org/jira/browse/OFBIZ-9532 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Attachments: screenshot-1.png > > > Steps to reproduce: > 1. Go to SFA component (https://demo-trunk.ofbiz.apache.org/sfa/control/main). > 2. Click on Leads from sub menu > (https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads). > 3. Click on partyId link of lead with some related company > (https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?roleTypeId=LEAD=sfa101) > 4. Click on update button under party group information > (https://demo-trunk.ofbiz.apache.org/sfa/control/editpartygroup?partyId=sfa101) > Even though the party has a Group Name still it shows empty field. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10061) [FB] Package org.apache.ofbiz.service.jms
[
https://issues.apache.org/jira/browse/OFBIZ-10061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Leichert updated OFBIZ-10061:
Attachment: OFBIZ-No_org.apache.ofbiz.service.jms_bugfixes.patch
* multicatch
* unecessary null-check removed
> [FB] Package org.apache.ofbiz.service.jms
> -
>
> Key: OFBIZ-10061
> URL: https://issues.apache.org/jira/browse/OFBIZ-10061
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Priority: Minor
> Attachments: OFBIZ-No_org.apache.ofbiz.service.jms_bugfixes.patch
>
>
> JmsListenerFactory.java:47, MS_SHOULD_BE_FINAL
> - MS: org.apache.ofbiz.service.jms.JmsListenerFactory.listeners isn't final
> but should be
> This static field public but not final, and could be changed by malicious
> code or by accident from another package. The field could be made final to
> avoid this vulnerability.
> JmsListenerFactory.java:48, MS_SHOULD_BE_FINAL
> - MS: org.apache.ofbiz.service.jms.JmsListenerFactory.servers isn't final but
> should be
> This static field public but not final, and could be changed by malicious
> code or by accident from another package. The field could be made final to
> avoid this vulnerability.
> JmsListenerFactory.java:74, SC_START_IN_CTOR
> - SC: new org.apache.ofbiz.service.jms.JmsListenerFactory(Delegator) invokes
> Thread.start()
> The constructor starts a thread. This is likely to be wrong if the class is
> ever extended/subclassed, since the thread will be started before the
> subclass constructor is started.
> JmsListenerFactory.java:126, REC_CATCH_EXCEPTION
> - REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.jms.JmsListenerFactory.loadListeners()
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> JmsListenerFactory.java:160, REC_CATCH_EXCEPTION
> - REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.jms.JmsListenerFactory.loadListener(String, Server)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> JmsServiceEngine.java:97, REC_CATCH_EXCEPTION, Priorität: Niedrig
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.jms.JmsServiceEngine.makeMessage(Session,
> ModelService, Map)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> JmsServiceEngine.java:269, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> - RCN: Redundant nullcheck of clientId, which is
[jira] [Comment Edited] (OFBIZ-10033) RuntimeException on viewroles page of Scrum component
[
https://issues.apache.org/jira/browse/OFBIZ-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292312#comment-16292312
]
Jacques Le Roux edited comment on OFBIZ-10033 at 12/15/17 11:14 AM:
Thanks Aditya Sharma for reporting the issue,
ViewPartyRoles form was changed to grid at r#1815193, and in scrum component it
was added as form
This issue has been fixed at ofbiz plugins trunk at r#1818259
was (Author: deepak.dixit):
Thanks Aditya Sharma for reporting the issue,
ViewPartyRoles form was changed to grid at r#18151933, and in scrum component
it was added as form
This issue has been fixed at ofbiz plugins trunk at r#1818259
> RuntimeException on viewroles page of Scrum component
> -
>
> Key: OFBIZ-10033
> URL: https://issues.apache.org/jira/browse/OFBIZ-10033
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to Scrum component
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> 2. Click on My Profile link from menu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewprofile?partyId=admin)
> 3. Click on Roles link from submenu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewroles?partyId=admin)
> It gives RuntimeException exception
> {quote}java.lang.RuntimeException: Error rendering screenlet in screen named
> [viewroles]: java.io.IOException: java.lang.NullPointerException{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10033) RuntimeException on viewroles page of Scrum component
[
https://issues.apache.org/jira/browse/OFBIZ-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292358#comment-16292358
]
Jacques Le Roux commented on OFBIZ-10033:
-
My bad, thanks Deepak!
> RuntimeException on viewroles page of Scrum component
> -
>
> Key: OFBIZ-10033
> URL: https://issues.apache.org/jira/browse/OFBIZ-10033
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to Scrum component
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> 2. Click on My Profile link from menu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewprofile?partyId=admin)
> 3. Click on Roles link from submenu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewroles?partyId=admin)
> It gives RuntimeException exception
> {quote}java.lang.RuntimeException: Error rendering screenlet in screen named
> [viewroles]: java.io.IOException: java.lang.NullPointerException{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-10061) [FB] Package org.apache.ofbiz.service.jms
Julian Leichert created OFBIZ-10061:
---
Summary: [FB] Package org.apache.ofbiz.service.jms
Key: OFBIZ-10061
URL: https://issues.apache.org/jira/browse/OFBIZ-10061
Project: OFBiz
Issue Type: Sub-task
Affects Versions: Trunk
Reporter: Julian Leichert
Priority: Minor
JmsListenerFactory.java:47, MS_SHOULD_BE_FINAL
- MS: org.apache.ofbiz.service.jms.JmsListenerFactory.listeners isn't final but
should be
This static field public but not final, and could be changed by malicious code
or by accident from another package. The field could be made final to avoid
this vulnerability.
JmsListenerFactory.java:48, MS_SHOULD_BE_FINAL
- MS: org.apache.ofbiz.service.jms.JmsListenerFactory.servers isn't final but
should be
This static field public but not final, and could be changed by malicious code
or by accident from another package. The field could be made final to avoid
this vulnerability.
JmsListenerFactory.java:74, SC_START_IN_CTOR
- SC: new org.apache.ofbiz.service.jms.JmsListenerFactory(Delegator) invokes
Thread.start()
The constructor starts a thread. This is likely to be wrong if the class is
ever extended/subclassed, since the thread will be started before the subclass
constructor is started.
JmsListenerFactory.java:126, REC_CATCH_EXCEPTION
- REC: Exception is caught when Exception is not thrown in
org.apache.ofbiz.service.jms.JmsListenerFactory.loadListeners()
This method uses a try-catch block that catches Exception objects, but
Exception is not thrown within the try block, and RuntimeException is not
explicitly caught. It is a common bug pattern to say try { ... } catch
(Exception e) { something } as a shorthand for catching a number of types of
exception each of whose catch blocks is identical, but this construct also
accidentally catches RuntimeException as well, masking potential bugs.
A better approach is to either explicitly catch the specific exceptions that
are thrown, or to explicitly catch RuntimeException exception, rethrow it, and
then catch all non-Runtime Exceptions, as shown below:
try {
...
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
... deal with all non-runtime exceptions ...
}
JmsListenerFactory.java:160, REC_CATCH_EXCEPTION
- REC: Exception is caught when Exception is not thrown in
org.apache.ofbiz.service.jms.JmsListenerFactory.loadListener(String, Server)
This method uses a try-catch block that catches Exception objects, but
Exception is not thrown within the try block, and RuntimeException is not
explicitly caught. It is a common bug pattern to say try { ... } catch
(Exception e) { something } as a shorthand for catching a number of types of
exception each of whose catch blocks is identical, but this construct also
accidentally catches RuntimeException as well, masking potential bugs.
A better approach is to either explicitly catch the specific exceptions that
are thrown, or to explicitly catch RuntimeException exception, rethrow it, and
then catch all non-Runtime Exceptions, as shown below:
try {
...
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
... deal with all non-runtime exceptions ...
}
JmsServiceEngine.java:97, REC_CATCH_EXCEPTION, Priorität: Niedrig
REC: Exception is caught when Exception is not thrown in
org.apache.ofbiz.service.jms.JmsServiceEngine.makeMessage(Session,
ModelService, Map)
This method uses a try-catch block that catches Exception objects, but
Exception is not thrown within the try block, and RuntimeException is not
explicitly caught. It is a common bug pattern to say try { ... } catch
(Exception e) { something } as a shorthand for catching a number of types of
exception each of whose catch blocks is identical, but this construct also
accidentally catches RuntimeException as well, masking potential bugs.
A better approach is to either explicitly catch the specific exceptions that
are thrown, or to explicitly catch RuntimeException exception, rethrow it, and
then catch all non-Runtime Exceptions, as shown below:
try {
...
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
... deal with all non-runtime exceptions ...
}
JmsServiceEngine.java:269, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
- RCN: Redundant nullcheck of clientId, which is known to be non-null in
org.apache.ofbiz.service.jms.JmsServiceEngine.runXaQueue(ModelService, Map,
Element)
This method contains a redundant check of a known non-null value against the
constant null.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-10060) [FB] Package org.apache.ofbiz.accounting.thirdparty.valuelink
[ https://issues.apache.org/jira/browse/OFBIZ-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10060: Attachment: OFBIZ-number_FB_accounting_thirdparty_valuelink_3.patch * added volatile * added utf8 * removed dls > [FB] Package org.apache.ofbiz.accounting.thirdparty.valuelink > - > > Key: OFBIZ-10060 > URL: https://issues.apache.org/jira/browse/OFBIZ-10060 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: OFBIZ-number_FB_accounting_thirdparty_valuelink_3.patch > > > ValueLinkApi.java:159, DM_DEFAULT_ENCODING > * Dm: Found reliance on default encoding in > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.encryptPin(String): > String.getBytes() > Found a call to a method which will perform a byte to String (or String to > byte) conversion, and will assume that the default platform encoding is > suitable. This will cause the application behaviour to vary between > platforms. Use an alternative API and specify a charset name or Charset > object explicitly. > ValueLinkApi.java:212, DM_DEFAULT_ENCODING > * Dm: Found reliance on default encoding in > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.decryptPin(String): > new String(byte[]) > Found a call to a method which will perform a byte to String (or String to > byte) conversion, and will assume that the default platform encoding is > suitable. This will cause the application behaviour to vary between > platforms. Use an alternative API and specify a charset name or Charset > object explicitly. > ValueLinkApi.java:531, PZLA_PREFER_ZERO_LENGTH_ARRAYS > * PZLA: Should > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.generateMwk() > return a zero length array rather than null? > It is often a better design to return a length zero array rather than a null > reference to indicate that there are no results (i.e., an empty list of > results). This way, no explicit check for null is needed by clients of the > method. > On the other hand, using null to indicate "there is no answer to this > question" is probably appropriate. For example, File.listFiles() returns an > empty list if given a directory containing no files, and returns null if the > file is not a directory. > ValueLinkApi.java:566, PZLA_PREFER_ZERO_LENGTH_ARRAYS > * PZLA: Should > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.generateMwk(byte[]) > return a zero length array rather than null? > It is often a better design to return a length zero array rather than a null > reference to indicate that there are no results (i.e., an empty list of > results). This way, no explicit check for null is needed by clients of the > method. > On the other hand, using null to indicate "there is no answer to this > question" is probably appropriate. For example, File.listFiles() returns an > empty list if given a directory containing no files, and returns null if the > file is not a directory. > ValueLinkApi.java:647, DC_DOUBLECHECK > * DC: Possible doublecheck on > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.mwkIndex in > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.getWorkingKeyIndex() > This method may contain an instance of double-checked locking. This idiom is > not correct according to the semantics of the Java memory model. For more > information, see the web page > http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html. > ValueLinkApi.java:910, DM_CONVERT_CASE > * Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.parseResponse(String) > A String is being converted to upper or lowercase, using the platform's > default encoding. This may result in improper conversions when used with > international characters. Use the > String.toUpperCase( Locale l ) > String.toLowerCase( Locale l ) > versions instead. > ValueLinkApi.java:967, DM_CONVERT_CASE > * Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in > org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.parseHistoryResponse(String) > A String is being converted to upper or lowercase, using the platform's > default encoding. This may result in improper conversions when used with > international characters. Use the > String.toUpperCase( Locale l ) > String.toLowerCase( Locale l ) > versions instead. > ValueLinkServices.java:171, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > * RCN: Redundant nullcheck of response, which is known to be non-null in >
[jira] [Created] (OFBIZ-10060) [FB] Package org.apache.ofbiz.accounting.thirdparty.valuelink
Julian Leichert created OFBIZ-10060: --- Summary: [FB] Package org.apache.ofbiz.accounting.thirdparty.valuelink Key: OFBIZ-10060 URL: https://issues.apache.org/jira/browse/OFBIZ-10060 Project: OFBiz Issue Type: Sub-task Affects Versions: Trunk Reporter: Julian Leichert Priority: Minor ValueLinkApi.java:159, DM_DEFAULT_ENCODING * Dm: Found reliance on default encoding in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.encryptPin(String): String.getBytes() Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. ValueLinkApi.java:212, DM_DEFAULT_ENCODING * Dm: Found reliance on default encoding in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.decryptPin(String): new String(byte[]) Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. ValueLinkApi.java:531, PZLA_PREFER_ZERO_LENGTH_ARRAYS * PZLA: Should org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.generateMwk() return a zero length array rather than null? It is often a better design to return a length zero array rather than a null reference to indicate that there are no results (i.e., an empty list of results). This way, no explicit check for null is needed by clients of the method. On the other hand, using null to indicate "there is no answer to this question" is probably appropriate. For example, File.listFiles() returns an empty list if given a directory containing no files, and returns null if the file is not a directory. ValueLinkApi.java:566, PZLA_PREFER_ZERO_LENGTH_ARRAYS * PZLA: Should org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.generateMwk(byte[]) return a zero length array rather than null? It is often a better design to return a length zero array rather than a null reference to indicate that there are no results (i.e., an empty list of results). This way, no explicit check for null is needed by clients of the method. On the other hand, using null to indicate "there is no answer to this question" is probably appropriate. For example, File.listFiles() returns an empty list if given a directory containing no files, and returns null if the file is not a directory. ValueLinkApi.java:647, DC_DOUBLECHECK * DC: Possible doublecheck on org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.mwkIndex in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.getWorkingKeyIndex() This method may contain an instance of double-checked locking. This idiom is not correct according to the semantics of the Java memory model. For more information, see the web page http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html. ValueLinkApi.java:910, DM_CONVERT_CASE * Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.parseResponse(String) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. ValueLinkApi.java:967, DM_CONVERT_CASE * Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkApi.parseHistoryResponse(String) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. ValueLinkServices.java:171, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE * RCN: Redundant nullcheck of response, which is known to be non-null in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkServices.assignWorkingKey(DispatchContext, Map) This method contains a redundant check of a known non-null value against the constant null. ValueLinkServices.java:255, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE * RCN: Redundant nullcheck of response, which is known to be non-null in org.apache.ofbiz.accounting.thirdparty.valuelink.ValueLinkServices.activate(DispatchContext, Map) This method contains a redundant check of a known non-null value against the constant null. ValueLinkServices.java:314, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE * RCN: Redundant nullcheck of
[jira] [Updated] (OFBIZ-10056) [FB] Package org.apache.ofbiz.order.order
[ https://issues.apache.org/jira/browse/OFBIZ-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Leichert updated OFBIZ-10056: Attachment: OFBIZ-No_org.apache.ofbiz.order.order_bugfixes.patch * removed unnecessary null-checks * changed "" to '' in indexOf (better performance) * keySet to entrySet * removed dls * removed unecessary unboxing > [FB] Package org.apache.ofbiz.order.order > - > > Key: OFBIZ-10056 > URL: https://issues.apache.org/jira/browse/OFBIZ-10056 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julian Leichert >Priority: Minor > Attachments: OFBIZ-No_org.apache.ofbiz.order.order_bugfixes.patch > > > OrderChangeHelper.java:75, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:99, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:137, RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > - Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > We are trying to reduce the false positives as much as possible, but in some > cases this warning might be wrong. Common false-positive cases include: > - The method is designed to be overridden and produce a side effect in other > projects which are out of the scope of the analysis. > - The method is called to trigger the class loading which may have a side > effect. > - The method is called just to get some exception. > If you feel that our assumption is incorrect, you can use a @CheckReturnValue > annotation to instruct FindBugs that ignoring the return value of this method > is acceptable. > OrderChangeHelper.java:214, NP_LOAD_OF_KNOWN_NULL_VALUE > - NP: Load of known null value in > org.apache.ofbiz.order.order.OrderChangeHelper.orderStatusChanges(LocalDispatcher, > GenericValue, String, String, String, String, String) > The variable referenced at this point is known to be null due to an earlier > check against null. Although this is valid, it might be a mistake (perhaps > you intended to refer to a different variable, or perhaps the earlier check > to see if the variable is null should have been a check to see if it was > non-null). > OrderContentWrapper.java:103, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > - RCN: Nullcheck of OrderContentWrapper.orderContentCache at line 115 of > value previously dereferenced in > org.apache.ofbiz.order.order.OrderContentWrapper.getOrderContentAsText(GenericValue, > String, Locale, String, Delegator, LocalDispatcher, String) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the
[jira] [Closed] (OFBIZ-9854) Error when unsubscribing Newsletter from Ecommerce store
[
https://issues.apache.org/jira/browse/OFBIZ-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-9854.
---
> Error when unsubscribing Newsletter from Ecommerce store
>
>
> Key: OFBIZ-9854
> URL: https://issues.apache.org/jira/browse/OFBIZ-9854
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: EcommerceUnsubscribeError.png, OFBIZ-9854.patch
>
>
> Steps to regenerate:
> 1. Go to Ecommerce component
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main)
> 2. From Sign up from Contact List section, select newsletter, provide an
> already subscribed email address and click on unsubscribe
> Following error message:
> {code:java}
> ERROR: Could not complete the Unsubscribe for contact list
> [file:/home/ofbizDemo/trunk/applications/marketing/minilang/marketing/contact/ContactListServices.xml#unsubscribeContactListParty]
> process [problem invoking the [updateContactListParty] service with the map
> named [updateContactListPartyMap] containing
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2017-10-17
> 03:06:03.658(java.sql.Timestamp)][createdTxStamp,2017-10-17
> 03:06:03.504(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2017-10-17
> 03:06:11.284(java.sql.Timestamp)][lastUpdatedTxStamp,2017-10-17
> 03:06:11.22(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
> statusId=CLPT_UNSUBS_PENDING, baseLocation=/ecommerce, contactListId=9000,
> preferredContactMechId=1, partyId=_NA_, locale=en_US}]: Outgoing result
> (in runSync : updateContactListParty) does not match expected requirements
> (Unknown parameter found: [updateContactListParty.contactListId])]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9854) Error when unsubscribing Newsletter from Ecommerce store
[
https://issues.apache.org/jira/browse/OFBIZ-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292330#comment-16292330
]
Deepak Dixit commented on OFBIZ-9854:
-
This has been already fixed at OFBIZ-9698
> Error when unsubscribing Newsletter from Ecommerce store
>
>
> Key: OFBIZ-9854
> URL: https://issues.apache.org/jira/browse/OFBIZ-9854
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: EcommerceUnsubscribeError.png, OFBIZ-9854.patch
>
>
> Steps to regenerate:
> 1. Go to Ecommerce component
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main)
> 2. From Sign up from Contact List section, select newsletter, provide an
> already subscribed email address and click on unsubscribe
> Following error message:
> {code:java}
> ERROR: Could not complete the Unsubscribe for contact list
> [file:/home/ofbizDemo/trunk/applications/marketing/minilang/marketing/contact/ContactListServices.xml#unsubscribeContactListParty]
> process [problem invoking the [updateContactListParty] service with the map
> named [updateContactListPartyMap] containing
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2017-10-17
> 03:06:03.658(java.sql.Timestamp)][createdTxStamp,2017-10-17
> 03:06:03.504(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2017-10-17
> 03:06:11.284(java.sql.Timestamp)][lastUpdatedTxStamp,2017-10-17
> 03:06:11.22(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
> statusId=CLPT_UNSUBS_PENDING, baseLocation=/ecommerce, contactListId=9000,
> preferredContactMechId=1, partyId=_NA_, locale=en_US}]: Outgoing result
> (in runSync : updateContactListParty) does not match expected requirements
> (Unknown parameter found: [updateContactListParty.contactListId])]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10058) Issues in error.log both locally and in trunk demo
[
https://issues.apache.org/jira/browse/OFBIZ-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292325#comment-16292325
]
Deepak Dixit commented on OFBIZ-10058:
--
I think something broken,as if object not available then set field initialize
them
Here are some more,
{code}
2017-12-15 16:07:20,917 |sse-nio-8443-exec-10 |JuelConnector
|F| null
javax.el.PropertyNotFoundException: Cannot resolve identifier 'lookupFieldMap'
at
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
~[juel-impl-2.2.7.jar:2.2.7]
at
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
[ofbiz.jar:?]
at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
[juel-impl-2.2.7.jar:2.2.7]
at
de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
[juel-impl-2.2.7.jar:2.2.7]
at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
[ofbiz.jar:?]
{code}
{code}
javax.el.PropertyNotFoundException: Cannot resolve identifier
'VT_HDR_JAVASCRIPT'
at
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
~[juel-impl-2.2.7.jar:2.2.7]
at
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstBracket.setValue(JuelConnector.java:80)
[ofbiz.jar:?]
at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
[juel-impl-2.2.7.jar:2.2.7]
at
de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
[juel-impl-2.2.7.jar:2.2.7
{code}
{code}
javax.el.PropertyNotFoundException: Cannot resolve identifier
'VT_HELPSTYLESHEET'
at
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
~[juel-impl-2.2.7.jar:2.2.7]
at
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstBracket.setValue(JuelConnector.java:80)
[ofbiz.jar:?]
at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
[juel-impl-2.2.7.jar:2.2.7]
at
de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
[juel-impl-2.2.7.jar:2.2.7]
at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
[ofbiz.jar:?]
at
org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:177)
[ofbiz.jar:?]
at
org.apache.ofbiz.widget.model.ModelTheme.addThemeProperty(ModelTheme.java:279)
[ofbiz.jar:?]
{code}
{code}
javax.el.PropertyNotFoundException: Cannot resolve identifier 'line'
at
de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
~[juel-impl-2.2.7.jar:2.2.7]
at
org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
[ofbiz.jar:?]
at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
[juel-impl-2.2.7.jar:2.2.7]
at
de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
[juel-impl-2.2.7.jar:2.2.7]
at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
[ofbiz.jar:?]
at
org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:17
{code}
> Issues in error.log both locally and in trunk demo
> --
>
> Key: OFBIZ-10058
> URL: https://issues.apache.org/jira/browse/OFBIZ-10058
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I have no ideas yet why this happens, here some errors from the trunk demo:
> {code}
> 2017-12-15 09:59:49,860 |ajp-nio-8009-exec-5 |JuelConnector
> |F| null
> javax.el.PropertyNotFoundException: Cannot resolve identifier 'layoutSettings'
> at
> de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
> ~[juel-impl-2.2.7.jar:2.2.7]
> at
> org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
> [ofbiz.jar:?]
> at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
> [juel-impl-2.2.7.jar:2.2.7]
> at
> de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
> [juel-impl-2.2.7.jar:2.2.7]
> at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:177)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$SetField.runAction(AbstractModelAction.java:906)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:141)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:273)
> [ofbiz.jar:?]
> at
>
[jira] [Commented] (OFBIZ-10058) Issues in error.log both locally and in trunk demo
[
https://issues.apache.org/jira/browse/OFBIZ-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292322#comment-16292322
]
Deepak Dixit commented on OFBIZ-10058:
--
This is because some screens uses layoutsetting object to set the js/css files
and its not available in context.
> Issues in error.log both locally and in trunk demo
> --
>
> Key: OFBIZ-10058
> URL: https://issues.apache.org/jira/browse/OFBIZ-10058
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I have no ideas yet why this happens, here some errors from the trunk demo:
> {code}
> 2017-12-15 09:59:49,860 |ajp-nio-8009-exec-5 |JuelConnector
> |F| null
> javax.el.PropertyNotFoundException: Cannot resolve identifier 'layoutSettings'
> at
> de.odysseus.el.tree.impl.ast.AstIdentifier.eval(AstIdentifier.java:93)
> ~[juel-impl-2.2.7.jar:2.2.7]
> at
> org.apache.ofbiz.base.util.string.JuelConnector$ExtendedAstDot.setValue(JuelConnector.java:116)
> [ofbiz.jar:?]
> at de.odysseus.el.tree.impl.ast.AstEval.setValue(AstEval.java:87)
> [juel-impl-2.2.7.jar:2.2.7]
> at
> de.odysseus.el.TreeValueExpression.setValue(TreeValueExpression.java:146)
> [juel-impl-2.2.7.jar:2.2.7]
> at org.apache.ofbiz.base.util.string.UelUtil.setValue(UelUtil.java:104)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.base.util.collections.FlexibleMapAccessor.put(FlexibleMapAccessor.java:177)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction$SetField.runAction(AbstractModelAction.java:906)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:141)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:273)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$DecoratorScreen.renderWidgetString(ModelScreenWidget.java:859)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:138)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:100)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:122)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:999)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:646)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:686)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
> [javax.servlet-api-4.0.0.jar:4.0.0]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.5.23.jar:8.5.23]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:213)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.24.jar:8.5.24]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
> [ofbiz.jar:?]
> at
>
[jira] [Closed] (OFBIZ-10033) RuntimeException on viewroles page of Scrum component
[
https://issues.apache.org/jira/browse/OFBIZ-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-10033.
Resolution: Done
Fix Version/s: Upcoming Release
Backport to 16.11 not required as list form to grid conversion done only in
trunk.
> RuntimeException on viewroles page of Scrum component
> -
>
> Key: OFBIZ-10033
> URL: https://issues.apache.org/jira/browse/OFBIZ-10033
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to Scrum component
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> 2. Click on My Profile link from menu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewprofile?partyId=admin)
> 3. Click on Roles link from submenu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewroles?partyId=admin)
> It gives RuntimeException exception
> {quote}java.lang.RuntimeException: Error rendering screenlet in screen named
> [viewroles]: java.io.IOException: java.lang.NullPointerException{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Reopened] (OFBIZ-10033) RuntimeException on viewroles page of Scrum component
[
https://issues.apache.org/jira/browse/OFBIZ-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reopened OFBIZ-10033:
--
> RuntimeException on viewroles page of Scrum component
> -
>
> Key: OFBIZ-10033
> URL: https://issues.apache.org/jira/browse/OFBIZ-10033
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to Scrum component
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> 2. Click on My Profile link from menu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewprofile?partyId=admin)
> 3. Click on Roles link from submenu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewroles?partyId=admin)
> It gives RuntimeException exception
> {quote}java.lang.RuntimeException: Error rendering screenlet in screen named
> [viewroles]: java.io.IOException: java.lang.NullPointerException{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (OFBIZ-10033) RuntimeException on viewroles page of Scrum component
[
https://issues.apache.org/jira/browse/OFBIZ-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-10033.
> RuntimeException on viewroles page of Scrum component
> -
>
> Key: OFBIZ-10033
> URL: https://issues.apache.org/jira/browse/OFBIZ-10033
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to Scrum component
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> 2. Click on My Profile link from menu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewprofile?partyId=admin)
> 3. Click on Roles link from submenu
> (https://demo-trunk.ofbiz.apache.org/scrum/control/viewroles?partyId=admin)
> It gives RuntimeException exception
> {quote}java.lang.RuntimeException: Error rendering screenlet in screen named
> [viewroles]: java.io.IOException: java.lang.NullPointerException{quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
