[jira] [Comment Edited] (OFBIZ-9924) Make the general.SystemPropertyValue same than the related property in general properties
[ https://issues.apache.org/jira/browse/OFBIZ-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274801#comment-16274801 ] Jacques Le Roux edited comment on OFBIZ-9924 at 2/16/18 7:15 AM: - Done with r1816899. Only VISUAL_THEME value was concerned was (Author: jacques.le.roux): Only VISUAL_THEME value was concerned > Make the general.SystemPropertyValue same than the related property in > general properties > - > > Key: OFBIZ-9924 > URL: https://issues.apache.org/jira/browse/OFBIZ-9924 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 17.12.01 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6881) Rainbow Stone theme improvements
[ https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365938#comment-16365938 ] Jacques Le Roux commented on OFBIZ-6881: Thanks Julien, does it change something functionaly? > Rainbow Stone theme improvements > > > Key: OFBIZ-6881 > URL: https://issues.apache.org/jira/browse/OFBIZ-6881 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: MenuFirstProposal.png, OFBIZ-6881.patch > > > These are some points I think are worth to be reported even if they will not > all be taken in account. > # Theme colorization to avoid themes duplication (this also applies to > Bootstrap themes) > # Where are shown the "Last system notes"? > # -Remove Julien's avatar from the theme images provided (in the list of > themes to choose).- > # Is there a way for users to set their own avatar? > # how can contributors from countries with missing flags propose their > countries flag? Note: for some languages nothing appears (like ES or NL). > # I like how menus are handled in Boostrap theme, could we use the same in > Rainbow? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-6881) Rainbow Stone theme improvements
[ https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365685#comment-16365685 ] Julien NICOLAS edited comment on OFBIZ-6881 at 2/15/18 3:08 PM: A new improvement to improve less file maintenance :) Commited in r1824321 was (Author: julien.nicolas): A new improvement to improve less file maintenance :) > Rainbow Stone theme improvements > > > Key: OFBIZ-6881 > URL: https://issues.apache.org/jira/browse/OFBIZ-6881 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: MenuFirstProposal.png, OFBIZ-6881.patch > > > These are some points I think are worth to be reported even if they will not > all be taken in account. > # Theme colorization to avoid themes duplication (this also applies to > Bootstrap themes) > # Where are shown the "Last system notes"? > # -Remove Julien's avatar from the theme images provided (in the list of > themes to choose).- > # Is there a way for users to set their own avatar? > # how can contributors from countries with missing flags propose their > countries flag? Note: for some languages nothing appears (like ES or NL). > # I like how menus are handled in Boostrap theme, could we use the same in > Rainbow? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6881) Rainbow Stone theme improvements
[ https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365685#comment-16365685 ] Julien NICOLAS commented on OFBIZ-6881: --- A new improvement to improve less file maintenance :) > Rainbow Stone theme improvements > > > Key: OFBIZ-6881 > URL: https://issues.apache.org/jira/browse/OFBIZ-6881 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: MenuFirstProposal.png, OFBIZ-6881.patch > > > These are some points I think are worth to be reported even if they will not > all be taken in account. > # Theme colorization to avoid themes duplication (this also applies to > Bootstrap themes) > # Where are shown the "Last system notes"? > # -Remove Julien's avatar from the theme images provided (in the list of > themes to choose).- > # Is there a way for users to set their own avatar? > # how can contributors from countries with missing flags propose their > countries flag? Note: for some languages nothing appears (like ES or NL). > # I like how menus are handled in Boostrap theme, could we use the same in > Rainbow? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-6881) Rainbow Stone theme improvements
[ https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien NICOLAS updated OFBIZ-6881: -- Attachment: OFBIZ-6881.patch > Rainbow Stone theme improvements > > > Key: OFBIZ-6881 > URL: https://issues.apache.org/jira/browse/OFBIZ-6881 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: MenuFirstProposal.png, OFBIZ-6881.patch > > > These are some points I think are worth to be reported even if they will not > all be taken in account. > # Theme colorization to avoid themes duplication (this also applies to > Bootstrap themes) > # Where are shown the "Last system notes"? > # -Remove Julien's avatar from the theme images provided (in the list of > themes to choose).- > # Is there a way for users to set their own avatar? > # how can contributors from countries with missing flags propose their > countries flag? Note: for some languages nothing appears (like ES or NL). > # I like how menus are handled in Boostrap theme, could we use the same in > Rainbow? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10222) Access the online help in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10222: Fix Version/s: 16.11.05 17.12.01 > Access the online help in Rainbow themes > > > Key: OFBIZ-10222 > URL: https://issues.apache.org/jira/browse/OFBIZ-10222 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Julien NICOLAS >Priority: Minor > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-10222.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10222) Access the online help in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365675#comment-16365675 ] Jacques Le Roux commented on OFBIZ-10222: - Thanks Julien, Since this is most annoying for final users I decided to backport in R17.12 at least and maybe R16.11 if easy. R17.12 r1824319 R16.11 r1824320 > Access the online help in Rainbow themes > > > Key: OFBIZ-10222 > URL: https://issues.apache.org/jira/browse/OFBIZ-10222 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Julien NICOLAS >Priority: Minor > Attachments: OFBIZ-10222.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10222) Access the online help in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien NICOLAS closed OFBIZ-10222. -- Resolution: Fixed r1824314 > Access the online help in Rainbow themes > > > Key: OFBIZ-10222 > URL: https://issues.apache.org/jira/browse/OFBIZ-10222 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Julien NICOLAS >Priority: Minor > Attachments: OFBIZ-10222.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10223) Use Tomcat default ciphers
[ https://issues.apache.org/jira/browse/OFBIZ-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10223. --- Resolution: Implemented Fix Version/s: 16.11.05 17.12.01 Done in trunk r1824316 R17.12 r1824317 R16.11 r1824318 > Use Tomcat default ciphers > -- > > Key: OFBIZ-10223 > URL: https://issues.apache.org/jira/browse/OFBIZ-10223 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01, 16.11.05 > > > This follow this discussion [http://markmail.org/message/xfhgamlm73dye662] > Summary: Tomcat provides a default ciphers definition better to use it and > let Tomcat handles that for us, we know Tomcat security is strong. > This is not a bug, but as security could evolve in futur better to backport > in supported branches -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10223) Use Tomcat default ciphers
[ https://issues.apache.org/jira/browse/OFBIZ-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10223: Description: This follow this discussion [http://markmail.org/message/xfhgamlm73dye662] Summary: Tomcat provides a default ciphers definition better to use it and let Tomcat handles that for us, we know Tomcat security is strong. This is not a bug, but as security could evolve in futur better to backport in supported branches was: This follow this discussion [http://markmail.org/message/xfhgamlm73dye662] Summary: Tomcat provides a default ciphers definition better to use it and let Tomcat handles that for us, we know Tomcat security is strong. THhs is not a bug, but as security could evolve in futur better to backport in supported branches > Use Tomcat default ciphers > -- > > Key: OFBIZ-10223 > URL: https://issues.apache.org/jira/browse/OFBIZ-10223 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > This follow this discussion [http://markmail.org/message/xfhgamlm73dye662] > Summary: Tomcat provides a default ciphers definition better to use it and > let Tomcat handles that for us, we know Tomcat security is strong. > This is not a bug, but as security could evolve in futur better to backport > in supported branches -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10222) Access the online help in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365626#comment-16365626 ] Julien NICOLAS commented on OFBIZ-10222: Commited in rev : 1824314 > Access the online help in Rainbow themes > > > Key: OFBIZ-10222 > URL: https://issues.apache.org/jira/browse/OFBIZ-10222 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Julien NICOLAS >Priority: Minor > Attachments: OFBIZ-10222.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8341) Fix Default or Empty Catch block in Java and Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365457#comment-16365457 ] Jacques Le Roux commented on OFBIZ-8341: I fixed few remaining swallowed Exception in Groovy files in trunk r1824157 and r1824294 > Fix Default or Empty Catch block in Java and Groovy files > - > > Key: OFBIZ-8341 > URL: https://issues.apache.org/jira/browse/OFBIZ-8341 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-8341- OrderReadHelper.patch > > > In many Java and Groovy files we have auto generated catch blocks or empty > catch blocks. > To avoid such exception swallowing this should be improved to at least log > the error and also return error in case of service. > As of now I found following classes with such patterns - > InventoryServices.java > FreeMarkerWorker.java > QRCodeEvents.java > QRCodeServices.java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365371#comment-16365371
]
Paul Foxworthy commented on OFBIZ-6330:
---
I've made a minor change to the patch, adding a few comments. If there are no
objections I'll commit this.
> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice
> service
>
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
>Priority: Major
> Labels: tax, vat
> Attachments: GL.PNG, GeneralLedgerServices.patch, JORTAXAUTH.PNG,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns-alternative.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns_inline.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns_inline.patch, pic01.PNG,
> pic02.png
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did
> not call the method to get invoiceTaxTotal.
> {code}
> class-name="org.ofbiz.accounting.invoice.InvoiceWorker"
> ret-field="invoiceTaxTotal">
>
>
> {code}
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code
> below:
> {code}
> decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
>
>
>
>
>
> {code}
> That it should work like the createAcctgTransForSalesInvoice service of the
> sales invoice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-6330) The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice service
[
https://issues.apache.org/jira/browse/OFBIZ-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Foxworthy updated OFBIZ-6330:
--
Attachment: OFBIZ-6330_TaxAccountingOnPurchasesAndReturns_inline.patch
> The invoiceTaxTotal value is missing from createAcctgTransForPurchaseInvoice
> service
>
>
> Key: OFBIZ-6330
> URL: https://issues.apache.org/jira/browse/OFBIZ-6330
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Paul Foxworthy
>Priority: Major
> Labels: tax, vat
> Attachments: GL.PNG, GeneralLedgerServices.patch, JORTAXAUTH.PNG,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns-alternative.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns_inline.patch,
> OFBIZ-6330_TaxAccountingOnPurchasesAndReturns_inline.patch, pic01.PNG,
> pic02.png
>
>
> Hi All,
> Scenario: The sum of debit and credit in InvoiceAcctgTransEntriesPdf of
> purchase invoice are not equal.
> Question: I'm not sure why the createAcctgTransForPurchaseInvoice service did
> not call the method to get invoiceTaxTotal.
> {code}
> class-name="org.ofbiz.accounting.invoice.InvoiceWorker"
> ret-field="invoiceTaxTotal">
>
>
> {code}
> And the invoiceTaxTotal value needs to add to totalAmountFromInvoice via code
> below:
> {code}
> decimal-scale="${ledgerDecimals}" rounding-mode="${roundingMode}">
>
>
>
>
>
> {code}
> That it should work like the createAcctgTransForSalesInvoice service of the
> sales invoice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10221) Improve layout and structure of forms
[ https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365314#comment-16365314 ] Jacques Le Roux edited comment on OFBIZ-10221 at 2/15/18 10:06 AM: --- Hi Nicolas, Julian, Viewing the patch, I think so Nicolas. Though it's actually the widget engine and replacing FTL by forms as much as possible. Even FTL passes by the "screen engine" ;) BTW I suggested the same some years ago and [~ofbizzer] began to work on that [https://s.apache.org/97Pl] I even thought I created an unmbrella task for that, but it seems we actually referred to OFBIZ-5040 which is not totally related. We could use the current Jira (I'll continue to look for the one I thought I created) was (Author: jacques.le.roux): Hi Nicolas, Julian, Viewing the patch, I think so Nicolas. Though it's actually the widget engine and replacing FTL by forms as much as possible. Even FTL passes by the "screen engine" ;) BTW I suggested the same some years ago and [~ofbizzer] began to work on that https://s.apache.org/97Pl I even thought I created an unmbrella task for that, but it seems we actually referred to OFBIZ-5040 which is not totally related. We could use this Jira (I'll continue to look for the one I thought I created) > Improve layout and structure of forms > - > > Key: OFBIZ-10221 > URL: https://issues.apache.org/jira/browse/OFBIZ-10221 > Project: OFBiz > Issue Type: Improvement >Reporter: Julian Leichert >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch > > > While working at a Theme, i discovered that the forms differ in their style > and structure. > I propose a standard form-structure, so that further styling and look is > coherent. > I.e. class definitions ( class="basic-form") are often missing, input-fields > vary in size and the layout does not follow a standard structure. > As mentioned in > [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E] > I have attached an example patch, which modifies a form defined in FreeMarker > to conform it to the forms defined in any *Forms.xml. > Often those forms within FreeMarker templates differ from most other forms in > Ofbiz, > I propose a refactoring of these FreeMarker forms, to equalize all forms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms
[ https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365314#comment-16365314 ] Jacques Le Roux commented on OFBIZ-10221: - Hi Nicolas, Julian, Viewing the patch, I think so Nicolas. Though it's actually the widget engine and replacing FTL by forms as much as possible. Even FTL passes by the "screen engine" ;) BTW I suggested the same some years ago and [~ofbizzer] began to work on that https://s.apache.org/97Pl I even thought I created an unmbrella task for that, but it seems we actually referred to OFBIZ-5040 which is not totally related. We could use this Jira (I'll continue to look for the one I thought I created) > Improve layout and structure of forms > - > > Key: OFBIZ-10221 > URL: https://issues.apache.org/jira/browse/OFBIZ-10221 > Project: OFBiz > Issue Type: Improvement >Reporter: Julian Leichert >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch > > > While working at a Theme, i discovered that the forms differ in their style > and structure. > I propose a standard form-structure, so that further styling and look is > coherent. > I.e. class definitions ( class="basic-form") are often missing, input-fields > vary in size and the layout does not follow a standard structure. > As mentioned in > [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E] > I have attached an example patch, which modifies a form defined in FreeMarker > to conform it to the forms defined in any *Forms.xml. > Often those forms within FreeMarker templates differ from most other forms in > Ofbiz, > I propose a refactoring of these FreeMarker forms, to equalize all forms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10222) Access the online help in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365288#comment-16365288 ] Jacques Le Roux commented on OFBIZ-10222: - Thanks Julien, I now see the help link :) I also noticed that we have an issue with special chars in French in Help. But anyway this will be revisited with the documentation effort > Access the online help in Rainbow themes > > > Key: OFBIZ-10222 > URL: https://issues.apache.org/jira/browse/OFBIZ-10222 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Julien NICOLAS >Priority: Minor > Attachments: OFBIZ-10222.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10222) Access the online help in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien NICOLAS updated OFBIZ-10222: --- Attachment: OFBIZ-10222.patch > Access the online help in Rainbow themes > > > Key: OFBIZ-10222 > URL: https://issues.apache.org/jira/browse/OFBIZ-10222 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Julien NICOLAS >Priority: Minor > Attachments: OFBIZ-10222.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
