[jira] [Closed] (OFBIZ-10364) Update Currency UOM data as per iso amendment 164, 165 and 166

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-10364.

   Resolution: Done
Fix Version/s: 16.11.05

> Update Currency UOM data as per iso amendment 164, 165 and 166
> --
>
> Key: OFBIZ-10364
> URL: https://issues.apache.org/jira/browse/OFBIZ-10364
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, 17.12.01, Release Branch 16.11
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 16.11.05
>
>
> We have updated currency data as till amendment 163 in OFBIZ-OFBIZ-9413
> After this three amendment done for currency, here is the link for reference 
> https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_164.pdf
> https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_165.pdf
> https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_166.pdf



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10364) Update Currency UOM data as per iso amendment 164, 165 and 166

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446642#comment-16446642
 ] 

Deepak Dixit commented on OFBIZ-10364:
--

This has been committed at 

ofbiz framework trunk at r#1829690
ofbiz framework R17.12 at r#1829692
R16.11 at r#1829693

> Update Currency UOM data as per iso amendment 164, 165 and 166
> --
>
> Key: OFBIZ-10364
> URL: https://issues.apache.org/jira/browse/OFBIZ-10364
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, 17.12.01, Release Branch 16.11
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
>
> We have updated currency data as till amendment 163 in OFBIZ-OFBIZ-9413
> After this three amendment done for currency, here is the link for reference 
> https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_164.pdf
> https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_165.pdf
> https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_166.pdf



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10364) Update Currency UOM data as per iso amendment 164, 165 and 166

[Deepak Dixit (JIRA)]

Deepak Dixit created OFBIZ-10364:


 Summary: Update Currency UOM data as per iso amendment 164, 165 
and 166
 Key: OFBIZ-10364
 URL: https://issues.apache.org/jira/browse/OFBIZ-10364
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Release Branch 16.11, Trunk, 17.12.01
Reporter: Deepak Dixit
Assignee: Deepak Dixit


We have updated currency data as till amendment 163 in OFBIZ-OFBIZ-9413
After this three amendment done for currency, here is the link for reference 
https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_164.pdf
https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_165.pdf
https://www.currency-iso.org/dam/isocy/downloads/dl_currency_iso_amendment_166.pdf



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-10339) Release notes lost in the new site

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-10339.

Resolution: Fixed

As we added the missing notes in new website, so we can close this ticket. 

> Release notes lost in the new site
> --
>
> Key: OFBIZ-10339
> URL: https://issues.apache.org/jira/browse/OFBIZ-10339
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
>
> Old release notes are missing from new site
> [http://ofbiz.apache.org/release-notes-12.04.06.html]
> [http://ofbiz.apache.org/release-notes-13.07.01.html]
> [http://ofbiz.apache.org/release-notes-13.07.02.html]
> [http://ofbiz.apache.org/release-notes-16.11.01.html]
> [http://ofbiz.apache.org/release-notes-16.11.02.html]
>  Please refer dev list discussion for more detail https://s.apache.org/tyir



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10356) display of entities in text input field

[Rajesh Kumar Mallah (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446631#comment-16446631
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10356:
-

OK , I had thought it was an oversight.

The  thought over raising this concern was that entity representation 
in a text field shall require user to be careful  not to edit those parts.

Probably we cannot push that onus on endusers. IMHO

Also in :

https://demo-stable.ofbiz.apache.org/catalog/control/EditProduct?productId=GZ-1006-1

The escaping is NOT done and is left as it is.

regds

mallah.

 

> display of entities in text input field
> ---
>
> Key: OFBIZ-10356
> URL: https://issues.apache.org/jira/browse/OFBIZ-10356
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Rajesh Kumar Mallah
>Assignee: Swapnil M Mane
>Priority: Minor
>
>  
> In the url:
> [https://demo-stable.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1006-1]
>  
> the "Product Name" under "Override Simple Fields" is unnecessarily 
> expressed in entity format . The string displayed in product name 
> field is: "Open Gizmo LGPL"  it could have been a 
> simple "Open Gizmo (LGPL)"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OFBIZ-10356) display of entities in text input field

[Swapnil M Mane (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446622#comment-16446622
 ] 

Swapnil M Mane edited comment on OFBIZ-10356 at 4/21/18 4:09 AM:
-

Thanks [~rmallah] for reporting this issue.

Hi team,

Special character in the product name is shown due to HTML escaping in the code.

ofbiz/applications/product/template/product/EditProductContent.ftl at line 48
{code:java}

{code}
This change was intentional, done by [~jacques.le.roux] many years ago at 
[r490268|https://lists.apache.org/thread.html/3a9cf63564e4a29eff76b70cba4933ac846cb08f92648b021cb61726@1167115681@%3Ccommits.ofbiz.apache.org%3E]
 to fix an issue.
 I guess this change was done to protect from Script Injection Attacks.

IMO, trusted authorized users have permission to change the product attributes 
(here name), so I think we can remove the Auto-escaping of HTML, i.e.
{code:java}

{code}
I would like to know the community thoughts on removing HTML escaping from this 
code, thank you!


was (Author: swapnilmmane):
Thanks [~rmallah] for reporting this issue.

Hi team,

Special character in the product name is shown due to HTML escaping in the code.

ofbiz/applications/product/template/product/EditProductContent.ftl at line 48
{code:java}

{code}
This change was intentional, done by Jacques many years ago at 
[r490268|https://lists.apache.org/thread.html/3a9cf63564e4a29eff76b70cba4933ac846cb08f92648b021cb61726@1167115681@%3Ccommits.ofbiz.apache.org%3E]
 to fix an issue.
 I guess this change was done to protect from Script Injection Attacks.

IMO, trusted authorized users have permission to change the product attributes 
(here name), so I think we can remove the Auto-escaping of HTML, i.e.
{code:java}

{code}
I would like to know the community thoughts on removing HTML escaping from this 
code, thank you!

> display of entities in text input field
> ---
>
> Key: OFBIZ-10356
> URL: https://issues.apache.org/jira/browse/OFBIZ-10356
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Rajesh Kumar Mallah
>Assignee: Swapnil M Mane
>Priority: Minor
>
>  
> In the url:
> [https://demo-stable.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1006-1]
>  
> the "Product Name" under "Override Simple Fields" is unnecessarily 
> expressed in entity format . The string displayed in product name 
> field is: "Open Gizmo LGPL"  it could have been a 
> simple "Open Gizmo (LGPL)"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10356) display of entities in text input field

[Swapnil M Mane (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446622#comment-16446622
 ] 

Swapnil M Mane commented on OFBIZ-10356:


Thanks [~rmallah] for reporting this issue.

Hi team,

Special character in the product name is shown due to HTML escaping in the code.

ofbiz/applications/product/template/product/EditProductContent.ftl at line 48
{code:java}

{code}
This change was intentional, done by Jacques many years ago at 
[r490268|https://lists.apache.org/thread.html/3a9cf63564e4a29eff76b70cba4933ac846cb08f92648b021cb61726@1167115681@%3Ccommits.ofbiz.apache.org%3E]
 to fix an issue.
 I guess this change was done to protect from Script Injection Attacks.

IMO, trusted authorized users have permission to change the product attributes 
(here name), so I think we can remove the Auto-escaping of HTML, i.e.
{code:java}

{code}
I would like to know the community thoughts on removing HTML escaping from this 
code, thank you!

> display of entities in text input field
> ---
>
> Key: OFBIZ-10356
> URL: https://issues.apache.org/jira/browse/OFBIZ-10356
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Rajesh Kumar Mallah
>Assignee: Swapnil M Mane
>Priority: Minor
>
>  
> In the url:
> [https://demo-stable.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1006-1]
>  
> the "Product Name" under "Override Simple Fields" is unnecessarily 
> expressed in entity format . The string displayed in product name 
> field is: "Open Gizmo LGPL"  it could have been a 
> simple "Open Gizmo (LGPL)"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-9540) UI inconsistency in "Current Status Id" dropdown of FindRouting screen.

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445882#comment-16445882
 ] 

Pierre Smits commented on OFBIZ-9540:
-

I agree that current functionality is confusing and the solution provided 
(based on shown WorkEffort image) is an improvement. I must admit, however, 
that I did not test the patch.

> UI inconsistency in "Current Status Id" dropdown of FindRouting screen.
> ---
>
> Key: OFBIZ-9540
> URL: https://issues.apache.org/jira/browse/OFBIZ-9540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Assignee: Akash Jain
>Priority: Minor
>  Labels: routing
> Attachments: FindRouting.png, OFBIZ-9540.patch, WorkEffort.png
>
>
> 1. Click on Manufacturing component.
> 2. Here you can see one label "Routing". Click on it, you will redirect to 
> [https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRouting]
> 3. Select status from "Current Status Id" drop-down, where status with Remove 
> label will be shown, which is not consistent with the other forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10321) Multi-level BOM (same raw MM in different level) MRP not supportive

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445874#comment-16445874
 ] 

Pierre Smits commented on OFBIZ-10321:
--

I concur that this should be fixed, but a way to circumvent this issue is to 
split up the BoM into 2 (or more) separate single-level ones. Even with the 
table example provide the material 'wood' would be to generic.

 

> Multi-level BOM (same raw MM in different level) MRP not supportive
> ---
>
> Key: OFBIZ-10321
> URL: https://issues.apache.org/jira/browse/OFBIZ-10321
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 16.11, 16.11.04
> Environment: OS: Windows Server 2008 R2
> Database: MySQL 5.7
> JDK: 1.8.0_131
>Reporter: Schumann Ye
>Assignee: Jacopo Cappellato
>Priority: Major
>  Labels: usability
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> For MRP funciton in Manufacturing Manager, I intentionally created a BOM as 
> follows:
> Level 0:   Table (Qty 1, finished goods)
> Level 1:   Wood (Qty 5, raw material)
> Level 1:   Nails (Qty 20, raw material)
> Level 1:   Varnish (Qty 1, raw material)
> Level 1:   TableBoardCover (Qty 1, finished goods)
> Level 2:   Wood (Qty 1, raw material)
> I've done all routing tasks associated with routings and linked with products.
> Everything is ok but when I run MRP, I get the following error messages:
>  
> Code below:
> {code} 
> Caused by: org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception 
> while executing the following:INSERT INTO MRP_EVENT (MRP_ID, PRODUCT_ID, 
> EVENT_DATE, MRP_EVENT_TYPE_ID, FACILITY_ID, QUANTI
> TY, EVENT_NAME, IS_LATE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) 
> (Duplicate entry '10008-{color:#f79232}10010{color}-2018-03-29 16:03:39-MRP_R
> EQUIREMENT' for key 'PRIMARY')
>     at 
> org.apache.ofbiz.entity.jdbc.SQLProcessor.executeUpdate(SQLProcessor.java:434)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.datasource.GenericDAO.singleInsert(GenericDAO.java:173)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:115) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:65)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:883) 
> ~[ofbiz.jar:?]
>     at org.apache.ofbiz.entity.GenericValue.create(GenericValue.java:73) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.manufacturing.mrp.InventoryEventPlannedServices.createOrUpdateMrpEvent(InventoryEventPlannedServices.java:77)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.manufacturing.mrp.MrpServices.processBomComponent(MrpServices.java:568)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.manufacturing.mrp.MrpServices.executeMrp(MrpServices.java:799)
>  ~[ofbiz.jar:?]
>     ... 14 more
> Caused by: 
> com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: 
> Duplicate entry '10008-{color:#f79232}10010{color}-2018-03-29 
> 16:03:39-MRP_REQUIREMENT' for key 'PRIMARY'
>     at sun.reflect.GeneratedConstructorAccessor179.newInstance(Unknown 
> Source) ~[?:?]
>     at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>  ~[?:1.8.0_131]
>     at java.lang.reflect.Constructor.newInstance(Constructor.java:423) 
> ~[?:1.8.0_131]
>     at com.mysql.jdbc.Util.handleNewInstance(Util.java:425) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.Util.getInstance(Util.java:408) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:935) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3973) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3909) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2527) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2680) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2487) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at 
> com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858) 
> ~[mysql-connector-java-5.1.44-bin.jar:5.1.44]
>     at 
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2079)
>  

[jira] [Assigned] (OFBIZ-10205) The setToComplete of ofbizsetup run in error when running demo General Chart Of Accounts.

[Pierre Smits (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10205:


Assignee: Pierre Smits

> The setToComplete of ofbizsetup run in error when running demo General Chart 
> Of Accounts.
> -
>
> Key: OFBIZ-10205
> URL: https://issues.apache.org/jira/browse/OFBIZ-10205
> Project: OFBiz
>  Issue Type: Bug
>  Components: commonext
>Affects Versions: Trunk
>Reporter: fumiyoshi.to
>Assignee: Pierre Smits
>Priority: Critical
> Attachments: SetupEvents.xml.patch
>
>
> The file name of demo General Chart Of Accounts is wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10205) The setToComplete of ofbizsetup run in error when running demo General Chart Of Accounts.

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445850#comment-16445850
 ] 

Pierre Smits commented on OFBIZ-10205:
--

Hi,

It seems that the patch provided has been invalidated with more recents events 
(commits). Per commit [http://svn.apache.org/viewvc?rev=1823177=rev] (per 
OFBIZ-9501).

All accounting demo data is now available under 
/applications/datamodel/data/demo/ in AccountingDemoData.xml.

Can you please verify that the data you require is captured there, and if so 
provide a new patch?

Best regards,

Pierre

> The setToComplete of ofbizsetup run in error when running demo General Chart 
> Of Accounts.
> -
>
> Key: OFBIZ-10205
> URL: https://issues.apache.org/jira/browse/OFBIZ-10205
> Project: OFBiz
>  Issue Type: Bug
>  Components: commonext
>Affects Versions: Trunk
>Reporter: fumiyoshi.to
>Assignee: Pierre Smits
>Priority: Critical
> Attachments: SetupEvents.xml.patch
>
>
> The file name of demo General Chart Of Accounts is wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-9139) Refactor list related forms into grids in ProjectMgr

[Pierre Smits (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9139:

Attachment: ofbiz-9139-projctmgr-widgets-grid.patch

> Refactor list related forms into grids in ProjectMgr
> 
>
> Key: OFBIZ-9139
> URL: https://issues.apache.org/jira/browse/OFBIZ-9139
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: refactoring, widget
> Attachments: OFBIZ-9139-ProjectMgr-grid.patch, 
> ofbiz-9139-projctmgr-widgets-grid.patch
>
>
> Refactoring various list forms into grids.
> Refactoring various list form references into grid references in screens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10363) Improve Dutch UiLabels

[Pierre Smits (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10363:
-
Attachment: ofbiz-10363-AccountingUiLabels.xml.patch

> Improve Dutch UiLabels
> --
>
> Key: OFBIZ-10363
> URL: https://issues.apache.org/jira/browse/OFBIZ-10363
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: ofbiz-10363-AccountingUiLabels.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10363) Improve Dutch UiLabels

[Pierre Smits (JIRA)]

Pierre Smits created OFBIZ-10363:


 Summary: Improve Dutch UiLabels
 Key: OFBIZ-10363
 URL: https://issues.apache.org/jira/browse/OFBIZ-10363
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10362) Improve Hindi UiLables

[Pawan Verma (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445670#comment-16445670
 ] 

Pawan Verma commented on OFBIZ-10362:
-

Attached patch for this task.

> Improve Hindi UiLables
> --
>
> Key: OFBIZ-10362
> URL: https://issues.apache.org/jira/browse/OFBIZ-10362
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10362.patch
>
>
> There are some uiLables available in PartyErrorUiLabels.xml which have wrong 
> translation of English uiLables to Hindi.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10362) Improve Hindi UiLables

[Pawan Verma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-10362:

Attachment: OFBIZ-10362.patch

> Improve Hindi UiLables
> --
>
> Key: OFBIZ-10362
> URL: https://issues.apache.org/jira/browse/OFBIZ-10362
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10362.patch
>
>
> There are some uiLables available in PartyErrorUiLabels.xml which have wrong 
> translation of English uiLables to Hindi.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10362) Improve Hindi UiLables

[Pawan Verma (JIRA)]

Pawan Verma created OFBIZ-10362:
---

 Summary: Improve Hindi UiLables
 Key: OFBIZ-10362
 URL: https://issues.apache.org/jira/browse/OFBIZ-10362
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Affects Versions: Trunk
Reporter: Pawan Verma


There are some uiLables available in PartyErrorUiLabels.xml which have wrong 
translation of English uiLables to Hindi.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

[Pradhan Yash Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445489#comment-16445489
 ] 

Pradhan Yash Sharma commented on OFBIZ-10359:
-

Attaching patch file for the same.

> Refactoring Variable Scope  for org.apache.ofbiz.security
> -
>
> Key: OFBIZ-10359
> URL: https://issues.apache.org/jira/browse/OFBIZ-10359
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10359.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10359:

Attachment: OFBIZ-10359.patch

> Refactoring Variable Scope  for org.apache.ofbiz.security
> -
>
> Key: OFBIZ-10359
> URL: https://issues.apache.org/jira/browse/OFBIZ-10359
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10359.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10358:

Attachment: OFBIZ-10358.patch

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10358:

Attachment: (was: OFBIZ-10358.patch)

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

[Pradhan Yash Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445486#comment-16445486
 ] 

Pradhan Yash Sharma commented on OFBIZ-10358:
-

Attaching patch file for the same.

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10358:

Attachment: OFBIZ-10358.patch

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10360:

Component/s: framework

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10360:

Affects Version/s: Trunk

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10360:

Fix Version/s: Trunk

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10360:

Summary: Refactoring Variable Scope for org.apache.ofbiz.webapp   (was: 
Refactoring Variable Scope  )

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pradhan Yash Sharma
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10360:

Summary: Refactoring Variable Scope(was: R)

> Refactoring Variable Scope  
> 
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pradhan Yash Sharma
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10360:

Priority: Minor  (was: Major)

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pradhan Yash Sharma
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10360) R

[Pradhan Yash Sharma (JIRA)]

Pradhan Yash Sharma created OFBIZ-10360:
---

 Summary: R
 Key: OFBIZ-10360
 URL: https://issues.apache.org/jira/browse/OFBIZ-10360
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Pradhan Yash Sharma






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10361) Refactoring Variable Scope for org.apache.ofbiz.service

[Pradhan Yash Sharma (JIRA)]

Pradhan Yash Sharma created OFBIZ-10361:
---

 Summary: Refactoring Variable Scope for org.apache.ofbiz.service
 Key: OFBIZ-10361
 URL: https://issues.apache.org/jira/browse/OFBIZ-10361
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Pradhan Yash Sharma
 Fix For: Trunk






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

[Pradhan Yash Sharma (JIRA)]

Pradhan Yash Sharma created OFBIZ-10359:
---

 Summary: Refactoring Variable Scope  for org.apache.ofbiz.security
 Key: OFBIZ-10359
 URL: https://issues.apache.org/jira/browse/OFBIZ-10359
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Pradhan Yash Sharma
 Fix For: Trunk






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

[Pradhan Yash Sharma (JIRA)]

Pradhan Yash Sharma created OFBIZ-10358:
---

 Summary: Refactoring Variable Scope for org.apache.ofbiz.base.start
 Key: OFBIZ-10358
 URL: https://issues.apache.org/jira/browse/OFBIZ-10358
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework
Affects Versions: Trunk
Reporter: Pradhan Yash Sharma
 Fix For: Trunk






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10114) Not able to delete the rate amount and an error is displayed in Workeffort

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445444#comment-16445444
 ] 

Pierre Smits commented on OFBIZ-10114:
--

The title and the description of this ticket are misleading. I suggest 
adjusting it to better reflect the issue for our adopters. Rates have a 
lifespan and do not get deleted, as these may be used in other areas. The patch 
also indicates that deleting the rate is not good enough by removing the delete 
rate function with:
{code:java}
-{code}
and replacing it with:
{code:java}
+
{code}

> Not able to delete the rate amount and an error is displayed in Workeffort
> --
>
> Key: OFBIZ-10114
> URL: https://issues.apache.org/jira/browse/OFBIZ-10114
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-10114.patch, screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events]
> 2) Click on the event created.
> 3) To add the rates amount of events, click on the "Rates" button.
> 4) Add the rate amount and click on Add.
> 5) Try to delete the Rate Amount.
> Actual: Not able to delete the rate amount and an error is displayed.
> Note: Please refer the attached screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the key benefits of using lambdas will introduce [Functional style over 
Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*

Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
{code:java}
Map systemProps = UtilGenerics. 
checkMap(System.getProperties());{code}
{code:java}
Map systemProps = 
UtilGenerics.checkMap(System.getProperties());{code}
 
 *4.) Use of single quote for character*

There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
{code:java}
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);{code}
{code:java}
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" {code}
"]" is comparatively slower than ']' Java internally uses Flyweight Design 
pattern to create String literals so for every call it will not create a new 
Object and used an existing one this will improve performance to some extent a 
study can be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*

Lastly, some of the variable declarations are updated this doesn't create a 
huge difference but helps JVM at the from implicit conversion. 
 
{code:java}
private long cumulativeEvents = 0;{code}
{code:java}
private long cumulativeEvents = 0L;{code}
Based on above findings, I have done some code improvement and provided 
following patches.

*And need community help for reviewing these changes.*

Kindly provide any improvements or suggestion you have in mind :)

 

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
  
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
  
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
  
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
  
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the key benefits of using lambdas will introduce [Functional style over 
Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
  
 *3.) Using Type Inference*

Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
  
{code:java}
Map systemProps = UtilGenerics. 
checkMap(System.getProperties());{code}
{code:java}
Map systemProps = 
UtilGenerics.checkMap(System.getProperties());{code}
 
 *4.) Use of single quote for character*

There is a significant usage of <"Single Character"> in the codebase for 
example:-
  
{code:java}
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);{code}
{code:java}
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" {code}
 

is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
  
 *5.) Updated Variable Declaration*

Lastly some of the variable declarations is updated this doesn't create a huge 
difference but helps JVM at the from implicit conversion. 
  
{code:java}
private long cumulativeEvents = 0;{code}
 
{code:java}
private long cumulativeEvents = 0L;{code}
 

Based on above findings, I have done some code improvement and provided 
following patches.

*And need community help for reviewing these changes.*

Kindly provide any improvements or suggestion you have in mind :)

 

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the key benefits of using lambdas will introduce [Functional style over 
Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*

Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
{code:java}
Map systemProps = UtilGenerics. 
checkMap(System.getProperties());{code}
{code:java}
Map systemProps = 
UtilGenerics.checkMap(System.getProperties());{code}
 
 *4.) Use of single quote for character*

There is a significant usage of <"Single Character"> in the codebase for 
example:-
 

{code:java}
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);{code}


{code:java}
 throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" {code}

is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*Lastly some of the variable declarations is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.* 
 
 private long cumulativeEvents = 0;
private long cumulativeEvents = 0L;   - Based on above findings, I have done 
some code improvement and provided following patches. *And need community help 
for reviewing these changes.* Kindly provide any improvements or suggestion you 
have in mind :)

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*


I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*


Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the key benefits of using lambdas will introduce [Functional style over 
Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*

Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
{code:java}
Map systemProps = UtilGenerics. 
checkMap(System.getProperties());{code}
{code:java}
Map systemProps = 
UtilGenerics.checkMap(System.getProperties());{code}
 
 *4.) Use of single quote for character*

There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
{code:java}
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);{code}
{code:java}
 throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" {code}
is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*Lastly some of the variable declarations is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.* 
 
 private long cumulativeEvents = 0;
private long cumulativeEvents = 0L;   - Based on above findings, I have done 
some code improvement and provided following patches. *And need community help 
for reviewing these changes.* Kindly provide any improvements or suggestion you 
have in mind :)

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*

I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*

Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*


I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*


Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the key benefits of using lambdas will introduce [unctional style over 
Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*
Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
 - Map systemProps = UtilGenerics. 
checkMap(System.getProperties());
 - + Map systemProps = UtilGenerics.checkMap(System.getProperties());
 
 *4.) Use of single quote for character*
There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);
+ throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" 
 
is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*Lastly some of the variable declarations is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.*  
 - - private long cumulativeEvents = 0;
 - + private long cumulativeEvents = 0L;  
 - Based on above findings, I have done some code improvement and provided 
following patches. *And need community help for reviewing these changes.* 
Kindly provide any improvements or suggestion you have in mind :)

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 

 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 
{code:java}
public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
 
{code:java}
void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
 
 *2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example: 

 
{code:java}
Map initParameters = new LinkedHashMap<>();
for (Element e : initParamList) {
initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
}{code}
 

 
{code:java}
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
Some of the key benefits of using lambdas will introduce [unctional style over 
Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*
Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
 - Map systemProps = UtilGenerics. 
checkMap(System.getProperties());
 - + Map systemProps = UtilGenerics.checkMap(System.getProperties());
 
 *4.) Use of single quote for character*
There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);
+ throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" 
 
is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*Lastly some of the variable declarations is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.*  
 - - private long cumulativeEvents = 0;
 - + private long cumulativeEvents = 0L;  
 - Based on above findings, I have done some code improvement and provided 
following patches. *And need community help for reviewing these changes.* 
Kindly provide any improvements or suggestion you have in mind :)

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 

 
 *2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example:
 
 - Map initParameters = new LinkedHashMap<>();
 - - for (Element e : initParamList) \{ - 
initParameters.put(e.getAttribute("name"), e.getAttribute("value")); - } + 
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new)); Some of the key 
benefits of using lambdas will introduce[Functional style over Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 

 

 
 *2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example:
 
 - Map initParameters = new LinkedHashMap<>();
 - - for (Element e : initParamList) \{ - 
initParameters.put(e.getAttribute("name"), e.getAttribute("value")); - } + 
Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new)); Some of the key 
benefits of using lambdas will introduce[Functional style over Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*
Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
 - Map systemProps = UtilGenerics. 
checkMap(System.getProperties());
 - + Map systemProps = UtilGenerics.checkMap(System.getProperties());
 
 *4.) Use of single quote for character*
There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);
+ throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" 
 
is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*Lastly some of the variable declarations is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.*  
 - - private long cumulativeEvents = 0;
 - + private long cumulativeEvents = 0L;  
 - Based on above findings, I have done some code improvement and provided 
following patches. *And need community help for reviewing these changes.* 
Kindly provide any improvements or suggestion you have in mind :)

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 
 - public void noteKeyRemoval(UtilCache cache, K key, V oldValue); + void 
noteKeyRemoval(UtilCache cache, K key, V oldValue);Limiting the scope of 
the method from public modifier to package level.

 
 *2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example:
 
 - Map initParameters = new LinkedHashMap<>(); - for (Element e 
: initParamList) \{ - initParameters.put(e.getAttribute("name"), 
e.getAttribute("value")); - } + Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new)); Some of the key 
benefits of using lambdas will introduce[Functional style over Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
 *1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 
 - public void noteKeyRemoval(UtilCache cache, K key, V oldValue); + void 
noteKeyRemoval(UtilCache cache, K key, V oldValue);Limiting the scope of 
the method from public modifier to package level.

 
 *2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example:
 
 - Map initParameters = new LinkedHashMap<>(); - for (Element e 
: initParamList) \{ - initParameters.put(e.getAttribute("name"), 
e.getAttribute("value")); - } + Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new)); Some of the key 
benefits of using lambdas will introduce[Functional style over Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
 *3.) Using Type Inference*
Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
 - Map systemProps = UtilGenerics. 
checkMap(System.getProperties()); + Map systemProps = 
UtilGenerics.checkMap(System.getProperties());
 
 *4.) Use of single quote for character*
There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);
+ throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" 
 
is comparatively slower than ']' Java internally uses Flyweight Design pattern 
to create String literals so for every call it will not create a new Object and 
used an existing one this will improve performance to some extent a study can 
be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
 *5.) Updated Variable Declaration*Lastly some of the variable declarations is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.  - private long cumulativeEvents = 0; + private long 
cumulativeEvents = 0L;  Based on above findings, I have done some code 
improvement and provided following patches. *And need community help for 
reviewing these changes.* Kindly provide any improvements or suggestion you 
have in mind :)

P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
*1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 
- public void noteKeyRemoval(UtilCache cache, K key, V oldValue); + void 
noteKeyRemoval(UtilCache cache, K key, V oldValue);Limiting the scope of 
the method from public modifier to package level.

 
*2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example:
 
- Map initParameters = new LinkedHashMap<>(); - for (Element e 
: initParamList) \{ - initParameters.put(e.getAttribute("name"), 
e.getAttribute("value")); - } + Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new)); Some of the 

[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

[Pradhan Yash Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-10343:

Description: 
Here is the detailed information about the things I am working on for 
performance optimization in our OFBiz code.
 
*1.) Downsize Accessibility Scope*
I've tried to downsize accessibility scope of classes, interfaces, abstract 
class, declared member variables, enumerations, methods, and constructors to as 
minimum as possible as per OFBIz current implementation, still there is a lot 
of scope for improvement but it would require changes at the granular level. 
I've used 
[this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
as my reference point. example:
 
- public void noteKeyRemoval(UtilCache cache, K key, V oldValue); + void 
noteKeyRemoval(UtilCache cache, K key, V oldValue);Limiting the scope of 
the method from public modifier to package level.

 
*2.) Using Lambda Expressions*
Then tried to use lambda expressions on simple functional work to leverage 
implicit type of coding an example:
 
- Map initParameters = new LinkedHashMap<>(); - for (Element e 
: initParamList) \{ - initParameters.put(e.getAttribute("name"), 
e.getAttribute("value")); - } + Map initParameters = 
initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), e 
-> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new)); Some of the key 
benefits of using lambdas will introduce[Functional style over Imperative 
style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
 we can use [method 
referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
 usage of aggregate operations, and it will help developers to write memory 
efficient code. 
 
*3.) Using Type Inference*
Java uses type inference so to make code lightweight I've updated code 
constructs as shown in the example for more on this refer this 
[article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
 
- Map systemProps = UtilGenerics. 
checkMap(System.getProperties()); + Map systemProps = 
UtilGenerics.checkMap(System.getProperties());
 
*4.) Use of single quote for character*
There is a significant usage of <"Single Character"> in the codebase for 
example:-
 
throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + "]", e);
+ throw new GenericConfigException("Error opening file at location [" + 
fileUrl.toExternalForm() + ']', e);  "]" 
 
is comparativlelly slower then ']' Java internally uses Flyweight Design 
pattern to create String literals so for every call it will not create a new 
Object and used an existing one this will improve performace to some extend an 
study can be seen on 
[this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
 page.  
 
*5.) Updated Variable Declaration*Lastly some of the variable declaration is 
updated this doesn't create a huge difference but helps JVM at the from 
implicit conversion.  - private long cumulativeEvents = 0; + private long 
cumulativeEvents = 0L;  Based on above findings, I have done some code 
improvement and provided following patches. *And need community help for 
reviewing these changes.* Kindly provide any improvents or suggestion you have 
in mind :)  # [OFBIZ-10344] Refactoring Variable Scope for 
org.apache.ofbiz.base package
 # [OFBIZ-10345] Refactoring Variable Scope for 
org.apache.ofbiz.catalina.container
 # [OFBIZ-10346] Refactoring Variable Scope for org.apache.ofbiz.common
 # [OFBIZ-10347] Refactoring Variable Scope for org.apache.ofbiz.datafile
 # [OFBIZ-10348] Refactoring Variable Scope for org.apache.ofbiz.entity


P.S. Apart from this I am also working on performance matrix and will share it 
soon.

  was:Method and Variable access modifiers can be narrowed down to private 
access modifier. Set assignments to type variables. Usage of the implicit style 
of coding.


> Refactoring Variable Scope  
> 
>
> Key: OFBIZ-10343
> URL: https://issues.apache.org/jira/browse/OFBIZ-10343
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>
> Here is the detailed information about the things I am working on for 
> performance optimization in our OFBiz code.
>  
> *1.) Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation,