[jira] [Commented] (OFBIZ-10394) Fix typo "paramters" => "parameters"
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482014#comment-16482014 ] Mathieu Lirzin commented on OFBIZ-10394: Thanks Deepak, your request regarding the use of `git diff --noprefix` instead of `git format-patch --no-prefix` has been noted. > Fix typo "paramters" => "parameters" > > > Key: OFBIZ-10394 > URL: https://issues.apache.org/jira/browse/OFBIZ-10394 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Deepak Dixit >Priority: Minor > Fix For: 16.11.05 > > Attachments: OFBIZ-10394-Fix-typo-paramters-parameters.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method
[ https://issues.apache.org/jira/browse/OFBIZ-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10412: --- Component/s: base > Remove `UtilValidate::isEmpty(String)` method > - > > Key: OFBIZ-10412 > URL: https://issues.apache.org/jira/browse/OFBIZ-10412 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10412-remove-isEmpty-for-strings.patch > > > UtilValidate class contains a `isEmpty` method both for `CharSequence` and > for `String` types but since the first is an interface for the other and that > the implementation are the same we don't need to keep the one for the > concrete type. > Additionnaly I have removed the unused Generic type for the remaining > implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Labels: patch (was: ) > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Labels: patch > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch, > OFBIZ-10411-xml-use-boolean-type-follow-up.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype it > will be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method
[ https://issues.apache.org/jira/browse/OFBIZ-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10412: --- Attachment: OFBIZ-10412-remove-isEmpty-for-strings.patch > Remove `UtilValidate::isEmpty(String)` method > - > > Key: OFBIZ-10412 > URL: https://issues.apache.org/jira/browse/OFBIZ-10412 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10412-remove-isEmpty-for-strings.patch > > > UtilValidate class contains a `isEmpty` method both for `CharSequence` and > for `String` types but since the first is an interface for the other and that > the implementation are the same we don't need to keep the one for the > concrete type. > Additionnaly I have removed the unused Generic type for the remaining > implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10412) Remove `UtilValidate::isEmpty(String)` method
Mathieu Lirzin created OFBIZ-10412: -- Summary: Remove `UtilValidate::isEmpty(String)` method Key: OFBIZ-10412 URL: https://issues.apache.org/jira/browse/OFBIZ-10412 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Mathieu Lirzin UtilValidate class contains a `isEmpty` method both for `CharSequence` and for `String` types but since the first is an interface for the other and that the implementation are the same we don't need to keep the one for the concrete type. Additionnaly I have removed the unused Generic type for the remaining implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: OFBIZ-10411-xml-use-boolean-type-follow-up.patch > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch, > OFBIZ-10411-xml-use-boolean-type-follow-up.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype it > will be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: (was: OFBIZ-10411-xml-use-boolean-type-follow-up.patch) > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype it > will be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Description: To define boolean values, some ad-hoc enumeration of "true" and "false" are repeatedly used. Since XML Schema defines a standard boolean datatype it will be better to use it. For now I have only fixed `site-conf.xsd` was: To define boolean values, some ad-hoc enumeration of "true" and "false" are repeatedly used. Since XML Schema defines a standard boolean datatype I will be better to use it. For now I have only fixed `site-conf.xsd` > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch, > OFBIZ-10411-xml-use-boolean-type-follow-up.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype it > will be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10411) XML schemas should use predefined boolean type
[
https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481967#comment-16481967
]
Mathieu Lirzin commented on OFBIZ-10411:
I have included the fix for the other xsd files.
{code:java}
17 files changed, 240 insertions(+), 1324 deletions(-)
framework/base/dtd/ofbiz-component.xsd| 53 +---
framework/datafile/dtd/datafiles.xsd | 36 +--
framework/entity/dtd/entity-config.xsd| 197 ++--
framework/entity/dtd/entity-eca.xsd | 54 +---
framework/entity/dtd/entitymodel.xsd | 48 ++-
framework/minilang/dtd/simple-methods.xsd | 39 +--
framework/service/dtd/service-config.xsd | 17 +-
framework/service/dtd/service-eca.xsd | 80 +
framework/service/dtd/service-group.xsd | 9 +-
framework/service/dtd/service-mca.xsd | 9 +-
framework/service/dtd/services.xsd| 124 +---
framework/widget/dtd/widget-common.xsd| 141 ++---
framework/widget/dtd/widget-form.xsd | 481 +-
framework/widget/dtd/widget-menu.xsd | 57 +---
framework/widget/dtd/widget-screen.xsd| 150 ++
framework/widget/dtd/widget-theme.xsd | 21 +-
framework/widget/dtd/widget-tree.xsd | 48 +--
{code}
> XML schemas should use predefined boolean type
> --
>
> Key: OFBIZ-10411
> URL: https://issues.apache.org/jira/browse/OFBIZ-10411
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch,
> OFBIZ-10411-xml-use-boolean-type-follow-up.patch
>
>
> To define boolean values, some ad-hoc enumeration of "true" and "false" are
> repeatedly used. Since XML Schema defines a standard boolean datatype I will
> be better to use it.
> For now I have only fixed `site-conf.xsd`
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10411: --- Attachment: OFBIZ-10411-xml-use-boolean-type-follow-up.patch > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch, > OFBIZ-10411-xml-use-boolean-type-follow-up.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype I will > be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481955#comment-16481955 ] Mathieu Lirzin commented on OFBIZ-10411: Thanks Jacques for applying this patch. > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype I will > be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10411: --- Assignee: Mathieu Lirzin (was: Jacques Le Roux) > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype I will > be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481899#comment-16481899 ] Jacques Le Roux commented on OFBIZ-10411: - Thanks Mathieu, Yes we use that already in few other places and it's better indeed. Your "OFBIZ-10411-use-boolean-type-in-site-conf.patch" is in trunk at revision: 1831930 > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype I will > be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10411) XML schemas should use predefined boolean type
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10411: --- Assignee: Jacques Le Roux > XML schemas should use predefined boolean type > -- > > Key: OFBIZ-10411 > URL: https://issues.apache.org/jira/browse/OFBIZ-10411 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10411-use-boolean-type-in-site-conf.patch > > > To define boolean values, some ad-hoc enumeration of "true" and "false" are > repeatedly used. Since XML Schema defines a standard boolean datatype I will > be better to use it. > For now I have only fixed `site-conf.xsd` -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481892#comment-16481892 ] Jacques Le Roux commented on OFBIZ-10145: - Hi Nicolas, That seems indeed doable for Windows > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
