[jira] [Commented] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro
[
https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491681#comment-16491681
]
Aditya Sharma commented on OFBIZ-9846:
--
Thanks Jacques :)
Actually, I just forgot to mention that the above code was already commented
out so I kept it as it was instead of removing it. I found it quite absurd as
for common-theme the above code is not commented and parameters are passed with
data.
{quote}- <#--list parameterList as parameter>
- "${[parameter.name|http://parameter.name/]}":
"${parameter.value}",
-
{quote}
[https://markmail.org/message/ameuyjq6ik776mkg]
Apart from that, we can remove unused
themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl file. It may have been
committed by mistake.
> Replace Inline js with External js in renderFormClose macro
> ---
>
> Key: OFBIZ-9846
> URL: https://issues.apache.org/jira/browse/OFBIZ-9846
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9846.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491651#comment-16491651 ] Suraj Khurana commented on OFBIZ-7598: -- Hello, I have uploaded revised patch with some modification and it is working fine. Also, search in Party component is also working as expected. Thanks !! > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-7598: - Attachment: OFBIZ-7598.patch > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki closed OFBIZ-10409. - > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10409.patch, OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10408) Remove entity suffix from title of all entities
[ https://issues.apache.org/jira/browse/OFBIZ-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki closed OFBIZ-10408. - Closing the issue. > Remove entity suffix from title of all entities > --- > > Key: OFBIZ-10408 > URL: https://issues.apache.org/jira/browse/OFBIZ-10408 > Project: OFBiz > Issue Type: Sub-task > Components: datamodel >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10408.patch > > > In all EntityModel.xml files, title should not contain *Entity* as suffix. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-10409: -- Fix Version/s: Upcoming Branch > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10409.patch, OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki resolved OFBIZ-10409. --- Resolution: Fixed [~suraj.khurana]: Thanks for your contribution. Your patch has been committed in revision 1832309. > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10409.patch, OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-10409: -- Affects Version/s: Trunk Component/s: framework > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10409.patch, OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro
[
https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-9846.
--
Resolution: Implemented
Fix Version/s: Upcoming Branch
Thanks Aditya,
Great job, took me a moment to review :) Also because I had some still pending
(unrelated) changes.
Your silghtly modifed patch is in trunk at revision: 1832307
I simply removed from rainbowstone HtmlMenuMacroLibrary.ftl
<#--<#if parameterList?has_content>-->
<#--<#list parameterList as parameter>-->
<#--<#local params += ",'${parameter.name}':
'${parameter.value}'">-->
<#>
<#>
Not sure why you kept it, I guess it was forgotten after working on it, please
check
> Replace Inline js with External js in renderFormClose macro
> ---
>
> Key: OFBIZ-9846
> URL: https://issues.apache.org/jira/browse/OFBIZ-9846
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9846.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10367) Add Support for Disable attribute in CheckBox Form Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491638#comment-16491638 ] Rishi Solanki commented on OFBIZ-10367: --- [~pawan.verma]: Thanks for reporting and providing the nice enhancement. Reviewed your patch and it looks good to me. One input from my side, I see only getDisabled() method in place and no setter method for that. We can either add an setter method so that code will have flexibility to set it true/false on demand or we can make the disabled variable as final with no default value so that it will initialize only once from constructor only. Please let me know if you have any questions? > Add Support for Disable attribute in CheckBox Form Widget > - > > Key: OFBIZ-10367 > URL: https://issues.apache.org/jira/browse/OFBIZ-10367 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10367.patch > > > While working on the Inventory Transfer improvements, I have found that there > should be support in CheckBox form-widget to disable a checkbox. There might > be several use cases for this, I am listing one below: > Use Case: A screen list all the requirement out of which only Approved > Requirement is allowed to perform some action and other should not be allowed > to select. > To support this type of case there should be a support to disable a > form-widget checkbox. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10367) Add Support for Disable attribute in CheckBox Form Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki reassigned OFBIZ-10367: - Assignee: Rishi Solanki (was: Pawan Verma) > Add Support for Disable attribute in CheckBox Form Widget > - > > Key: OFBIZ-10367 > URL: https://issues.apache.org/jira/browse/OFBIZ-10367 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10367.patch > > > While working on the Inventory Transfer improvements, I have found that there > should be support in CheckBox form-widget to disable a checkbox. There might > be several use cases for this, I am listing one below: > Use Case: A screen list all the requirement out of which only Approved > Requirement is allowed to perform some action and other should not be allowed > to select. > To support this type of case there should be a support to disable a > form-widget checkbox. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10402) Introduce ability to clear specific cache from cache maintenance
[ https://issues.apache.org/jira/browse/OFBIZ-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-10402: --- Assignee: Yogesh Naroliya > Introduce ability to clear specific cache from cache maintenance > > > Key: OFBIZ-10402 > URL: https://issues.apache.org/jira/browse/OFBIZ-10402 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Yogesh Naroliya >Priority: Minor > > Currently, either you can clear all caches or you can clear specific cache > records from clear button. > There should be checkbox pattern which enables user to select multiple caches > and some button on top like clear selected caches. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9853) Replace Inline js with External js in renderFieldGroupOpen macro
[ https://issues.apache.org/jira/browse/OFBIZ-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9853: Assignee: Aditya Sharma > Replace Inline js with External js in renderFieldGroupOpen macro > > > Key: OFBIZ-9853 > URL: https://issues.apache.org/jira/browse/OFBIZ-9853 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491608#comment-16491608 ] Suraj Khurana commented on OFBIZ-10409: --- Thanks [~rishisolankii] for your inputs. I have uploaded an updated patch. Please have a look into it. > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10409.patch, OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-10409: -- Attachment: OFBIZ-10409.patch > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10409.patch, OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491589#comment-16491589 ] Rishi Solanki commented on OFBIZ-10409: --- +1 for using entityName. > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-7385) Allow user to select multiple options in "Sales By Store" report from basic search criteria while generating report
[ https://issues.apache.org/jira/browse/OFBIZ-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-7385: - I agree with Jacques, for suggesting improvement, reopening the ticket. > Allow user to select multiple options in "Sales By Store" report from basic > search criteria while generating report > --- > > Key: OFBIZ-7385 > URL: https://issues.apache.org/jira/browse/OFBIZ-7385 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: 16.11.01 >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala >Priority: Major > Attachments: OFBIZ-7385.patch, Salebystore.png > > > Currently system allow user to select any specific search criteria link and > hence report is generated only based on any one given selected criteria. > We can add the feature for generating single report based on multiple values > (possibly via checkbox?) within basic search criteria in this report namely: > 1) Product Store > 2) Order Status > and show the results based on all the selected values. Please refer attached > screenshot -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10149) ProductPriceRuleCondition "is Product" don't check the virtual product
[ https://issues.apache.org/jira/browse/OFBIZ-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10149: - Fix Version/s: (was: 17.12.01) (was: Trunk) > ProductPriceRuleCondition "is Product" don't check the virtual product > -- > > Key: OFBIZ-10149 > URL: https://issues.apache.org/jira/browse/OFBIZ-10149 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 16.11.05 > > > When you use a ProductPriceRuleCondition PRIP_PRODUCT_ID the input parameter > compare only the productId present on the cart and not to the > virtualProductId associate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10149) ProductPriceRuleCondition "is Product" don't check the virtual product
[ https://issues.apache.org/jira/browse/OFBIZ-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10149. > ProductPriceRuleCondition "is Product" don't check the virtual product > -- > > Key: OFBIZ-10149 > URL: https://issues.apache.org/jira/browse/OFBIZ-10149 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 16.11.05 > > > When you use a ProductPriceRuleCondition PRIP_PRODUCT_ID the input parameter > compare only the productId present on the cart and not to the > virtualProductId associate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9969) In 'ValidateMethod.java', when we don't pass any className from xml files. default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for className.
[ https://issues.apache.org/jira/browse/OFBIZ-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9969. --- > In 'ValidateMethod.java', when we don't pass any className from xml files. > default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for > className. > --- > > Key: OFBIZ-9969 > URL: https://issues.apache.org/jira/browse/OFBIZ-9969 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-9969.patch, OFBIZ-9969.patch > > > *Actual:* In 'ValidateMethod.java', If we have not passed any className from > the xml files.Then, className is set to null and throws an error of > 'Validation Method not found'. > *Expected:* A default value 'org.apache.ofbiz.base.util.UtilValidate' should > be assigned to the className. > As reference: Visit 'ValidateMethodCondition.java' and there, 'className' is > set with a default value 'org.apache.ofbiz.base.util.UtilValidate'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10371) Add a link onto a crashed Job to reset it
[ https://issues.apache.org/jira/browse/OFBIZ-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10371. > Add a link onto a crashed Job to reset it > - > > Key: OFBIZ-10371 > URL: https://issues.apache.org/jira/browse/OFBIZ-10371 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Upcoming Branch >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10371.patch > > > When a job crash due to OFBiz interruption, there is no easy way to replan it. > Everything exists in the code base to do it, just adding a link onto crashed > job in webtools. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10408) Remove entity suffix from title of all entities
[ https://issues.apache.org/jira/browse/OFBIZ-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491580#comment-16491580 ] Deepak Dixit commented on OFBIZ-10408: -- Hi [~rishisolankii], I think we can close this issue. > Remove entity suffix from title of all entities > --- > > Key: OFBIZ-10408 > URL: https://issues.apache.org/jira/browse/OFBIZ-10408 > Project: OFBiz > Issue Type: Sub-task > Components: datamodel >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10408.patch > > > In all EntityModel.xml files, title should not contain *Entity* as suffix. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491553#comment-16491553 ] Dhaval Wagela edited comment on OFBIZ-9849 at 5/26/18 8:21 AM: --- Replaced inline js from renderDropDownField macro to external js in OfbizUtils.js Steps to verify: Navigate to FormWidgetExamples([https://localhost:8443/example/control/FormWidgetExamples]). Check the functionality of Autocomplete Dropdown in 'Drop down fields' section. Done following: Added class 'autoCompleteDropDown' to the field if ajaxEnabled is true, removed the code for the condition from the markup and added in OfbizUtils.js for the class 'autoCompleteDropDown'. Removed js code for change event from the markup and added it to the 'change' event of combobox in ajaxAutoCompleteDropDown function. was (Author: dhaval.wagela): Replaced inline js from renderDropDownField macro to external js in OfbizUtils.js Steps to verify: Navigate to FormWidgetExamples([https://localhost:8443/example/control/FormWidgetExamples]). Check the functionality of Autocomplete Dropdown in 'Drop down fields section'. Done following: Added class 'autoCompleteDropDown' to the field if ajaxEnabled is true, removed the code for the condition from the markup and added in OfbizUtils.js for the class 'autoCompleteDropDown'. Removed js code for change event from the markup and added it to the 'change' event of combobox in ajaxAutoCompleteDropDown function. > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Dhaval Wagela >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9846) Replace Inline js with External js in renderFormClose macro
[ https://issues.apache.org/jira/browse/OFBIZ-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472964#comment-16472964 ] Jacques Le Roux edited comment on OFBIZ-9846 at 5/26/18 7:57 AM: - Replaced inline js from renderFormClose macro to external js in OfbizUtils.js Done following: Used custom data attributes: data-focus-field to define focus field for the form. Used attribute selector to find elements and set focus on the particular field. Added "requireValidation" class to all the forms with required fields. Used the class selector to find such forms & attached Validator plugin to it. Steps to verify: Add ProdCatalog page: https://localhost:8443/catalog/control/EditProdCatalog Dialogs: New Example dialog on Find Example page https://localhost:8443/example/control/FindExample # Go to Find Example page https://localhost:8443/example/control/FindExample # Click on New Example button # Validations should work in dialog on form submit. Additional Changes: Link for dialog in HtmlMenuMacroLibrary still had the inline code. Replaced the code with external js code. Validations on forms rendered with renderSubmitField macro from HtmlFormMacroLibrary.ftl seems not working https://demo-trunk.ofbiz.apache.org/partymgr/control/NewEmployee, will create a separate ticket for it. I observed that HtmlMenuMacroLibrary.ftl for rainbowstone is redundant at path themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl and themes/rainbowstone/template/macro/HtmlMenuMacroLibrary.ftl. The file at is themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl is not used and can be removed. was (Author: aditya.sharma): Replaced inline js from renderFormClose macro to external js in OfbizUtils.js Done following: Used custom data attributes: data-focus-field to define focus field for the form. Used attribute selector to find elements and set focus on the particular field. Added "requireValidation" class to all the forms with required fields. Used the class selector to find such forms & attached Validator plugin to it. Steps to verify: Add ProdCatalog page: [https://localhost:8443/catalog/control/EditProdCatalog|http://example.com/] Dialogs: New Example dialog on Find Example page [https://localhost:8443/example/control/FindExample] # Go to Find Example page ([https://localhost:8443/example/control/FindExample]) # Click on New Example button # Validations should work in dialog on form submit. Additional Changes: Link for dialog in HtmlMenuMacroLibrary still had the inline code. Replaced the code with external js code. Validations on forms rendered with renderSubmitField macro from HtmlFormMacroLibrary.ftl seems not working [https://demo-trunk.ofbiz.apache.org/partymgr/control/NewEmployee|http://example.com], will create a separate ticket for it. I observed that HtmlMenuMacroLibrary.ftl for rainbowstone is redundant at path themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl and themes/rainbowstone/template/macro/HtmlMenuMacroLibrary.ftl. The file at is themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl is not used and can be removed. > Replace Inline js with External js in renderFormClose macro > --- > > Key: OFBIZ-9846 > URL: https://issues.apache.org/jira/browse/OFBIZ-9846 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-9846.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10236) UI Issue with Status ID at Parties page
[ https://issues.apache.org/jira/browse/OFBIZ-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garima jain reassigned OFBIZ-10236: --- Assignee: (was: Garima jain) > UI Issue with Status ID at Parties page > --- > > Key: OFBIZ-10236 > URL: https://issues.apache.org/jira/browse/OFBIZ-10236 > Project: OFBiz > Issue Type: Bug > Components: party > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Priority: Trivial > Attachments: Enabled.png > > > Steps: > # Open URL > [https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?partyId=BLOGUSER_GUEST] > # Navigate to Status Id drop-down > # Check for Enabled > Actual: Displaying Enabled twice in drop-down section, Kindly refer > attachment for same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491553#comment-16491553 ] Dhaval Wagela edited comment on OFBIZ-9849 at 5/26/18 7:16 AM: --- Replaced inline js from renderDropDownField macro to external js in OfbizUtils.js Steps to verify: Navigate to FormWidgetExamples([https://localhost:8443/example/control/FormWidgetExamples]). Check the functionality of Autocomplete Dropdown in 'Drop down fields section'. Done following: Added class 'autoCompleteDropDown' to the field if ajaxEnabled is true, removed the code for the condition from the markup and added in OfbizUtils.js for the class 'autoCompleteDropDown'. Removed js code for change event from the markup and added it to the 'change' event of combobox in ajaxAutoCompleteDropDown function. was (Author: dhaval.wagela): Replaced inline js from renderDropDownField macro to external js in OfbizUtils.js Done following: Added class 'autoCompleteDropDown' to the field if ajaxEnabled is true, removed the code for the condition from the markup and added in OfbizUtils.js for the class 'autoCompleteDropDown'. Removed js code for change event from the markup and added it to the 'change' event of combobox in ajaxAutoCompleteDropDown function. Steps to verify: Navigate to FormWidgetExamples([https://localhost:8443/example/control/FormWidgetExamples]). Check the functionality of Autocomplete Dropdown in 'Drop down fields section'. > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Dhaval Wagela >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491553#comment-16491553 ] Dhaval Wagela commented on OFBIZ-9849: -- Replaced inline js from renderDropDownField macro to external js in OfbizUtils.js Done following: Added class 'autoCompleteDropDown' to the field if ajaxEnabled is true, removed the code for the condition from the markup and added in OfbizUtils.js for the class 'autoCompleteDropDown'. Removed js code for change event from the markup and added it to the 'change' event of combobox in ajaxAutoCompleteDropDown function. Steps to verify: Navigate to FormWidgetExamples([https://localhost:8443/example/control/FormWidgetExamples]). Check the functionality of Autocomplete Dropdown in 'Drop down fields section'. > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Dhaval Wagela >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Wagela updated OFBIZ-9849: - Attachment: OFBIZ-9849.patch > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Dhaval Wagela >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9890) Having condition is ignored on queryList() and queryFirst() calls in EntityQuery
[ https://issues.apache.org/jira/browse/OFBIZ-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prakhar Kumar reassigned OFBIZ-9890: Assignee: (was: Prakhar Kumar) > Having condition is ignored on queryList() and queryFirst() calls in > EntityQuery > > > Key: OFBIZ-9890 > URL: https://issues.apache.org/jira/browse/OFBIZ-9890 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Gareth Carter >Priority: Minor > > queryList() and queryFirst() both call internal private query() method. This > method calls delegator.findList if a normal Entity/ViewEntity is used (not a > DVE). This has no option to include a having condition and so must opt to use > queryIterator(). Even queryCount() can use a having condition -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10409) Generic message from entity-auto service can be enhanced
[ https://issues.apache.org/jira/browse/OFBIZ-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491538#comment-16491538 ] Suraj Khurana commented on OFBIZ-10409: --- Hello, I checked and found that if title on any entity definition is empty, then by default _+entitymodel+_ file level title attribute is set as title on _+ModelEntity+_ object. *Proposed solution*: I think we can put _+entityName+_ in title field if not present instead of putting default title value which contains generic file level title value. > Generic message from entity-auto service can be enhanced > > > Key: OFBIZ-10409 > URL: https://issues.apache.org/jira/browse/OFBIZ-10409 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-10409.patch > > > Currently, it is using entityName from ModelEntity, we can enhance it by > using entityTitle from ModelEntity. > So that instead of *_ProductStoreFacility Updated Successfully_*, we can > have better success message as *_Product Store Facility Updated > Successfully_*. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10391) Make accounting entry configurable
[ https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491530#comment-16491530 ] Aman Agrawal commented on OFBIZ-10391: -- Thanks Arun for reviewing. I have updated the patch in which default accounting is enabled. Accounting gets disabled when flag is set to 'N'. > Make accounting entry configurable > -- > > Key: OFBIZ-10391 > URL: https://issues.apache.org/jira/browse/OFBIZ-10391 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Reporter: Aman Agrawal >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10391.patch > > > In current flow, if we want to disable the accounting then we need to disable > the set of seca's. We don't have any configurable setting to disable > accounting. > We can manage this by adding a new field 'enableAccounting' in the > 'PartyAcctgPreference' entity. Accounting transaction entries will be > entertained accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10391) Make accounting entry configurable
[ https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Agrawal updated OFBIZ-10391: - Attachment: (was: OFBIZ-10391.patch) > Make accounting entry configurable > -- > > Key: OFBIZ-10391 > URL: https://issues.apache.org/jira/browse/OFBIZ-10391 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Reporter: Aman Agrawal >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10391.patch > > > In current flow, if we want to disable the accounting then we need to disable > the set of seca's. We don't have any configurable setting to disable > accounting. > We can manage this by adding a new field 'enableAccounting' in the > 'PartyAcctgPreference' entity. Accounting transaction entries will be > entertained accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10391) Make accounting entry configurable
[ https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Agrawal updated OFBIZ-10391: - Attachment: OFBIZ-10391.patch > Make accounting entry configurable > -- > > Key: OFBIZ-10391 > URL: https://issues.apache.org/jira/browse/OFBIZ-10391 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Reporter: Aman Agrawal >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10391.patch > > > In current flow, if we want to disable the accounting then we need to disable > the set of seca's. We don't have any configurable setting to disable > accounting. > We can manage this by adding a new field 'enableAccounting' in the > 'PartyAcctgPreference' entity. Accounting transaction entries will be > entertained accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
