[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530814#comment-16530814 ] Suraj Khurana commented on OFBIZ-7598: -- Thanks Dennis for reporting this and creating ticket. I will look into it and share more details about this soon. > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10456) Search Result Tables won't show first search result
[ https://issues.apache.org/jira/browse/OFBIZ-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-10456: - Assignee: Suraj Khurana > Search Result Tables won't show first search result > --- > > Key: OFBIZ-10456 > URL: https://issues.apache.org/jira/browse/OFBIZ-10456 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Suraj Khurana >Priority: Major > > Since the patch from Issue OFBIZ-7598, the search result tables won't show > the first search result. > When only one result is normally shown, the table now only show its header > without any results, and when more than one is shown the first one is simply > missing. > This is also is an issue when searching in entities. > When the user searches for a specific entry, is won't be shown, the user has > no possibility for finding what he searches for. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration
Pritam Kute created OFBIZ-10457: --- Summary: Short Messaging Service(SMS) Gateway Integration Key: OFBIZ-10457 URL: https://issues.apache.org/jira/browse/OFBIZ-10457 Project: OFBiz Issue Type: New Feature Reporter: Pritam Kute Assignee: Pritam Kute Fix For: Upcoming Branch In reference to the proposal sent on the developer list, this ticket will be used for tracking the work progress of the SMS gateway integration. I have added design proposal for the SMS gateway integration to the wiki and can be accessed from here. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530032#comment-16530032 ] Jacques Le Roux commented on OFBIZ-7598: That's another reasonnable solution. Not sure what's the best for the sake of history... Could be discussed in dev ML... After OFBIZ-10456, I let Suraj decide about closing here or not. > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529930#comment-16529930 ] Michael Brohl commented on OFBIZ-7598: -- I think we should generally immediately revert feature/improvement commits if it shows that they introduce bugs. They can be corrected afterwards and commited again if everything works fine. > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10456) Search Result Tables won't show first search result
[ https://issues.apache.org/jira/browse/OFBIZ-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10456: -- Description: Since the patch from Issue OFBIZ-7598, the search result tables won't show the first search result. When only one result is normally shown, the table now only show its header without any results, and when more than one is shown the first one is simply missing. This is also is an issue when searching in entities. When the user searches for a specific entry, is won't be shown, the user has no possibility for finding what he searches for. was: Since the patch from Issue 7598, the search result tables won't show the first search result. When only one result is normally shown, the table now only show its header without any results, and when more than one is shown the first one is simply missing. This is also is an issue when searching in entities. When the user searches for a specific entry, is won't be shown, the user has no possibility for finding what he searches for. > Search Result Tables won't show first search result > --- > > Key: OFBIZ-10456 > URL: https://issues.apache.org/jira/browse/OFBIZ-10456 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Major > > Since the patch from Issue OFBIZ-7598, the search result tables won't show > the first search result. > When only one result is normally shown, the table now only show its header > without any results, and when more than one is shown the first one is simply > missing. > This is also is an issue when searching in entities. > When the user searches for a specific entry, is won't be shown, the user has > no possibility for finding what he searches for. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10456) Search Result Tables won't show first search result
Dennis Balkir created OFBIZ-10456: - Summary: Search Result Tables won't show first search result Key: OFBIZ-10456 URL: https://issues.apache.org/jira/browse/OFBIZ-10456 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Since the patch from Issue 7598, the search result tables won't show the first search result. When only one result is normally shown, the table now only show its header without any results, and when more than one is shown the first one is simply missing. This is also is an issue when searching in entities. When the user searches for a specific entry, is won't be shown, the user has no possibility for finding what he searches for. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529741#comment-16529741 ] Jacques Le Roux commented on OFBIZ-7598: Note that maybe we should create a new Jira as it's now a bug... > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-7598: Assignee: Suraj Khurana (was: Jacques Le Roux) Reopen and assign to Suraj, now committer :) > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10437) <#if containerId?has_content> id="${containerId}" is missed in renderFormOpen
[
https://issues.apache.org/jira/browse/OFBIZ-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529739#comment-16529739
]
Jacques Le Roux commented on OFBIZ-10437:
-
Thanks Aditya for the clear explanation :)
> <#if containerId?has_content> id="${containerId}" is missed in
> renderFormOpen
> ---
>
> Key: OFBIZ-10437
> URL: https://issues.apache.org/jira/browse/OFBIZ-10437
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> <#if containerId?has_content> id="${containerId}" is missed for
> renderFormOpen in revision 1832307. And there is no id for html form in
> rendered html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529738#comment-16529738 ] Jacques Le Roux commented on OFBIZ-7598: Thanks Dennis for the information and steps to reproduce > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10437) <#if containerId?has_content> id="${containerId}" is missed in renderFormOpen
[
https://issues.apache.org/jira/browse/OFBIZ-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529735#comment-16529735
]
Jacques Le Roux commented on OFBIZ-10437:
-
Thanks Aditya for the clear explanation :)
> <#if containerId?has_content> id="${containerId}" is missed in
> renderFormOpen
> ---
>
> Key: OFBIZ-10437
> URL: https://issues.apache.org/jira/browse/OFBIZ-10437
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> <#if containerId?has_content> id="${containerId}" is missed for
> renderFormOpen in revision 1832307. And there is no id for html form in
> rendered html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10437) <#if containerId?has_content> id="${containerId}" is missed in renderFormOpen
[
https://issues.apache.org/jira/browse/OFBIZ-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529522#comment-16529522
]
Aditya Sharma edited comment on OFBIZ-10437 at 7/2/18 8:46 AM:
---
Yes Jacques, when we were using *inline* javascript we need to pass element
*id* to *identify* the *element*.
{quote}<#if containerId?has_content && hasRequiredField?has_content>
jQuery("#${containerId}").validate({
submitHandler:
function(form) {
form.submit();
}
});
{quote}
but when we applied .*requireValidation* class and used *query selector* in
external javascript to find it
{quote}jQuery(bind_element).find(".requireValidation").each(function()
Unknown macro: \{ var element = jQuery(this); element.validate(); }
);
{quote}
we *no longer need id* as we have the *element in* *"this"* variable.
was (Author: aditya.sharma):
Yes Jacques, when we were using *inline* javascript we need to pass element
*id* to *identify* the *element*.
{quote}<#if containerId?has_content && hasRequiredField?has_content>
jQuery("#${containerId}").validate({
submitHandler: - function(form) { - form.submit();
}
});
{quote}
but when we applied .*requireValidation* class and used *query selector* in
external javascript to find it
{quote}jQuery(bind_element).find(".requireValidation").each(function(){
var element = jQuery(this);
element.validate();
});
{quote}
we *no longer need id* as we have the *element in* *"this"* variable.
> <#if containerId?has_content> id="${containerId}" is missed in
> renderFormOpen
> ---
>
> Key: OFBIZ-10437
> URL: https://issues.apache.org/jira/browse/OFBIZ-10437
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> <#if containerId?has_content> id="${containerId}" is missed for
> renderFormOpen in revision 1832307. And there is no id for html form in
> rendered html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529527#comment-16529527 ] Dennis Balkir commented on OFBIZ-7598: -- Hi [~jacques.le.roux], I think this issue has to be reopened. I noticed, that in all entity search results, the first lines of the results are missing. The results only start to show if there is more than one, otherwise the table shows up without content, but just the header. I reverted this patch locally and the problems were gone, so somethings clearly not right with this solution. Please take a further look, thanks in advance > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10437) <#if containerId?has_content> id="${containerId}" is missed in renderFormOpen
[
https://issues.apache.org/jira/browse/OFBIZ-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529522#comment-16529522
]
Aditya Sharma commented on OFBIZ-10437:
---
Yes Jacques, when we were using *inline* javascript we need to pass element
*id* to *identify* the *element*.
{quote}<#if containerId?has_content && hasRequiredField?has_content>
jQuery("#${containerId}").validate({
submitHandler: - function(form) { - form.submit();
}
});
{quote}
but when we applied .*requireValidation* class and used *query selector* in
external javascript to find it
{quote}jQuery(bind_element).find(".requireValidation").each(function(){
var element = jQuery(this);
element.validate();
});
{quote}
we *no longer need id* as we have the *element in* *"this"* variable.
> <#if containerId?has_content> id="${containerId}" is missed in
> renderFormOpen
> ---
>
> Key: OFBIZ-10437
> URL: https://issues.apache.org/jira/browse/OFBIZ-10437
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> <#if containerId?has_content> id="${containerId}" is missed for
> renderFormOpen in revision 1832307. And there is no id for html form in
> rendered html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10437) <#if containerId?has_content> id="${containerId}" is missed in renderFormOpen
[
https://issues.apache.org/jira/browse/OFBIZ-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529493#comment-16529493
]
Jacques Le Roux commented on OFBIZ-10437:
-
Thanks Aditya,
Great to see you in action as a committer :)
I was just wondering, is it intended that you did not add {{#if
containerId?has_content}} in the expression which constraints
{{requireValidation}} ?
> <#if containerId?has_content> id="${containerId}" is missed in
> renderFormOpen
> ---
>
> Key: OFBIZ-10437
> URL: https://issues.apache.org/jira/browse/OFBIZ-10437
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> <#if containerId?has_content> id="${containerId}" is missed for
> renderFormOpen in revision 1832307. And there is no id for html form in
> rendered html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
