[jira] [Created] (OFBIZ-10541) Add a gradle task to compile less files in css and minify
Julien NICOLAS created OFBIZ-10541: -- Summary: Add a gradle task to compile less files in css and minify Key: OFBIZ-10541 URL: https://issues.apache.org/jira/browse/OFBIZ-10541 Project: OFBiz Issue Type: Improvement Components: themes Affects Versions: Trunk, Upcoming Branch Reporter: Julien NICOLAS Assignee: Julien NICOLAS For theme optimization, I would like to compile less files to css file. In this way, we can remove the js compilation script from theme. In the same times, I propose to minify and compress css files. For debugging, css files will not be compress nor minified. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593605#comment-16593605 ] Suraj Khurana commented on OFBIZ-7598: -- Attached final patch including all suggested changes. Thanks !! > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598-final.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.png, OFBIZ-7598_improvement.patch, OFBIZ-7598_improvement.patch > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-7598: - Attachment: OFBIZ-7598-final.patch > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598-final.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.png, OFBIZ-7598_improvement.patch, OFBIZ-7598_improvement.patch > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10307) Navigate from a domain to another with automated signed in authentication
[ https://issues.apache.org/jira/browse/OFBIZ-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593433#comment-16593433 ] Jacques Le Roux commented on OFBIZ-10307: - I also forgot to put above https://github.com/auth0/java-jwt#using-a-keyprovider. I already mentioned it in OFBIZ-9833 at "20/Feb/18 18:02". But that would mean to not use a secret key (HMAC algorithm) as OFBIZ-9833 currently does. And I'm not sure it's better, did not check, just another option... > Navigate from a domain to another with automated signed in authentication > - > > Key: OFBIZ-10307 > URL: https://issues.apache.org/jira/browse/OFBIZ-10307 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10307-test from example.patch, OFBIZ-10307-test > from example.patch, OFBIZ-10307-test.patch, OFBIZ-10307-test.patch, > OFBIZ-10307-test.patch, OFBIZ-10307.patch, OFBIZ-10307.patch, > OFBIZ-10307.patch, OFBIZ-10307.patch, OFBIZ-10307.patch, OFBIZ-10307.patch > > > This will use a JWT Token authentication to get from one domain, where you > are signed in, to another domain where you get signed in automatically. > Something like ExternalLoginKey or Tomcat SSO, but not on the same domain. > This will build upon the initial work done at OFBIZ-9833 which has been > partially reverted in trunk with r1827439 (see OFBIZ-10304) and r1827441. I > explained why and what I did at [https://s.apache.org/a5Km] > I turned to Ajax for the "Authorization" header sending. I initially thought > I'd just pass an "Authorization" header and use it in the > externalServerLoginCheck preprocessor, et voilà. > But I stumbled upon something I did not know well : CORS! And in particular > the upstream control (Pre-verified requests): > > [https://en.wikipedia.org/wiki/Cross-origin_resource_sharing#Preflight_example] > [https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS] > [https://www.w3.org/TR/cors/] > To be able to pass an "Authorization" header, the server must respond > positively in the Preflight HTTP response (OPTIONS). To do this, either you > use a Tomcat filter (or your own filter, there are examples on the Net) or > use HTTPD (or Nginx) configuration on the target server. > I tried Tomcat first, without success. With HTTPD it's easier just 3 lines. > For my tests, future tests by OFBiz users and as an example, I asked infra to > put them in our HTTPD trunk demo config: > Header set Access-Control-Allow-Origin "https://localhost:8443; > Header set Access-Control-Allow-Headers "Authorization" > Header set Access-Control-Allow-Credentials "true" > No code change (either in all web.xml files for Tomcat or Java for own > filter), and more safety. It does not give more right to outsiders than what > we give with the admin credential. > In Header set Access-Control-Allow-Origin you can put more domains. I just > used [https://localhost:8443|https://localhost:8443/] for the tests. > It works in Chrome, Firefox and Opera and partially in IE11 (not tested in > Edge). I did not test Safari, but I guess like other modern browsers it > should work. > For those (very few I guess) interested by IE11 (for Edge test yourself and > report please), here is the solution > > [https://stackoverflow.com/questions/12643960/internet-explorer-10-is-ignoring-xmlhttprequest-xhr-withcredentials-true] > > [https://web.archive.org/web/20130308142134/http://msdn.microsoft.com/en-us/library/ms537343%28v=vs.85%29.aspx] > > [https://blogs.msdn.microsoft.com/ieinternals/2013/09/17/a-quick-look-at-p3p/] > TODO (maybe) in the future, use the new Fetch API (not available yet): > [https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API] > > Here is a complement about the way it's architectured: > # A change to cookies was introduced with OFBIZ-4959. Actually it was not > really a bug rather a clean-up. The autoLogin cookies were only used by the > ecommerce component and maybe webpos. But all applications were creating such > cookies with a one year duration. They were useless until I needed them for > the feature of this Jira issue. But even if they were safe (httponly) then I > needed them to be clean, not a one year duration (to be as safe as possible, > temporary cookies are better). So after doing it crudely, [inspired by > Taher's suggestion|[https://s.apache.org/qLGC]] I introduced the > keep-autologin-cookie attribute in ofbiz-component.xml. It's used to > remove not kept cookies when login in or out. So those cookies are only kept > during a session. Also a cookie is created when an user jumps from one
[jira] [Created] (OFBIZ-10540) Warning in console logs related to entity definitions
Deepak Nigam created OFBIZ-10540: Summary: Warning in console logs related to entity definitions Key: OFBIZ-10540 URL: https://issues.apache.org/jira/browse/OFBIZ-10540 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Deepak Nigam On trunk, following warnings related to entity definitions are coming: 2018-08-27 14:10:32,129 |delegator-startup-1 |GenericDelegator |W| =-=-=-=-= Found 5 warnings when checking the entity definitions: 2018-08-27 14:10:32,130 |delegator-startup-1 |GenericDelegator |W| [RelationRelatedFieldNotFound] The field "partyId" of related entity FacilityContactMech was specified in the keymaps but is not found for relation FacilityContactMech of entity FacilityAndContactMech. 2018-08-27 14:10:32,131 |delegator-startup-1 |GenericDelegator |W| [RelationFieldNotFound] The field partyId was specified in the keymaps but is not found for relation FacilityContactMech of entity FacilityAndContactMech. 2018-08-27 14:10:32,131 |delegator-startup-1 |GenericDelegator |W| [RelationRelatedFieldNotFound] The field "contactMechPurposeTypeId" of related entity WorkEffortContactMech was specified in the keymaps but is not found for relation WorkEffortContactMech of entity WorkEffortAndContactMech. 2018-08-27 14:10:32,131 |delegator-startup-1 |GenericDelegator |W| [RelationFieldNotFound] The field contactMechPurposeTypeId was specified in the keymaps but is not found for relation WorkEffortContactMech of entity WorkEffortAndContactMech. 2018-08-27 14:10:32,131 |delegator-startup-1 |GenericDelegator |W| [RelationFieldNotFound] The field contactMechPurposeTypeId was specified in the keymaps but is not found for relation ContactMechPurposeType of entity WorkEffortAndContactMech. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.
[ https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593217#comment-16593217 ] Deepak Dixit commented on OFBIZ-6993: - Thanks Girish for looking into it, Did you get a chance to review Yash Comments ? > Cannot find the declaration of element 'web-app' in version 3.0 files. > -- > > Key: OFBIZ-6993 > URL: https://issues.apache.org/jira/browse/OFBIZ-6993 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, Release Branch 15.12 > Environment: Been seeing the error below in the logs. Strangely, > I've not been able to catch the exception in a debugger, but was able to > isolate it to the definition of the web-app with version 3.0. The error > disapears when you change the definition from > {code:xml} > > {code} > to this: > {code:xml} > xmlns="http://java.sun.com/xml/ns/javaee; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; > xsi:schemaLocation="http://java.sun.com/xml/ns/javaee > http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd;> > {code} > I only tested on 15.12 and Trunk, but it probably affects any release running > Tomcat 7.0.48 or higher. Here is the error: > {noformat} > [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester > error > [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot > find the declaration of element 'web-app'. > [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; > cvc-elt.1.a: Cannot find the declaration of element 'web-app'. > [java] at > org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown > Source) > [java] at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown > Source) > [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown > Source) > [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown > Source) > [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown > Source) > [java] at > org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown > Source) > [java] at > org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source) > [java] at > org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown > Source) > [java] at > org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown > Source) > [java] at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) > [java] at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown > Source) > [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown > Source) > [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown > Source) > [java] at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) > [java] at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown > Source) > [java] at > org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source) > [java] at > org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555) > [java] at > org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160) > [java] at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131) > [java] at > org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67) > [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > [java] at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > [java] at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > [java] at java.lang.reflect.Method.invoke(Method.java:498) > [java] at > freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458) > [java] at > freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71) > [java] at freemarker.core.MethodCall._eval(MethodCall.java:62) > [java] at freemarker.core.Expression.eval(Expression.java:78) > [java] at freemarker.core.Assignment.accept(Assignment.java:70) > [java] at freemarker.core.Environment.visit(Environment.java:312) > [java] at freemarker.core.MixedContent.accept(MixedContent.java:62) > [java] at > freemarker.core.Environment.visitByHiddingParent(Environment.java:333) > [java] at > freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148) > [java] at > freemarker.core.Environment.visitIteratorBlock(Environment.java:559) > [java] at freemarker.core.IteratorBlock.accept(IteratorBlock.java:67) >