[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 11:22 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 Perhaps it might be a good idea to change the title of this here issue, 
because not only setting the cart, but indeed *any* configuration change on 
this page renders that weird error page, doesn't it?

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques (again no 
matter what you try to change here in the configuration), but this time the 
intended changes are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

 
{code:java}
org.apache.tomcat.util.digester.Digester error

SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.

org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.
{code}
 

 


was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 Perhaps it might be a good idea to change the title of this here issue, 
because not only setting the cart, but indeed *any* configuration change on 
this page renders that weird error page, doesn't it?

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques (again no 
matter what you try to change here in the configuration), but this time the 
intended changes are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 11:17 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 Perhaps it might be a good idea to change the title of this here issue, 
because not only setting the cart, but indeed *any* configuration change on 
this page renders that weird error page, doesn't it?

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques (again no 
matter what you try to change here in the configuration), but this time the 
intended changes are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 


was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 Perhaps it might be a good idea to change the title of this here issue, 
because not only setting the cart, but indeed *any* configuration change on 
this page renders that weird error page.

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques (again no 
matter what you try to change here in the configuration), but this time the 
intended changes are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 11:13 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 Perhaps it might be a good idea to change the title of this here issue, 
because not only setting the cart, but indeed *any* configuration change on 
this page renders that weird error page.

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques (again no 
matter what you try to change here in the configuration), but this time the 
intended changes are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 


was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
Perhaps it might be a good idea to change the title of this here issue, because 
not only setting the cart, but indeed *any* change on this page renders that 
weird error page.

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 11:10 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
Perhaps it might be a good idea to change the title of this here issue, because 
not only setting the cart, but indeed *any* change on this page renders that 
weird error page.

My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but saved eventually.

In both cases, in the error message displayed in the console log, the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 


was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 My workaround at this point is to use the +Web Tools+ +Entity Data 
Maintenance+ on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 

 

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 10:21 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 My workaround at this point is to use the +Web Tools+ +Entity Data 
Maintenance+ on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:

{{org.apache.tomcat.util.digester.Digester error}}

{{SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}

{{org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 

 

 


was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 My workaround at this point is to use the +Web Tools+ +Entity Data 
Maintenance+ on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:
{{org.apache.tomcat.util.digester.Digester error}}
{{ SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}
{{ org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 10:19 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported -OFBIZ-10560- / OFBIZ-10536 

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
 My workaround at this point is to use the +Web Tools+ +Entity Data 
Maintenance+ on
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
 displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:
{{org.apache.tomcat.util.digester.Digester error}}
{{ SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.}}
{{ org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}

 


was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported 
[-OFBIZ-10560-|https://issues.apache.org/jira/browse/OFBIZ-10560] / 
[OFBIZ-10536 |https://issues.apache.org/jira/browse/OFBIZ-10536]

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:
{{org.apache.tomcat.util.digester.Digester error
SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.
org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}


> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger edited comment on OFBIZ-10567 at 9/14/18 10:17 PM:
---

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported 
[-OFBIZ-10560-|https://issues.apache.org/jira/browse/OFBIZ-10560] / 
[OFBIZ-10536 |https://issues.apache.org/jira/browse/OFBIZ-10536]

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:
{{org.apache.tomcat.util.digester.Digester error
SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.
org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}



was (Author: komdata):
 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported 
[-OFBIZ-10560-|https://issues.apache.org/jira/browse/OFBIZ-10560] / 
[OFBIZ-10536 |https://issues.apache.org/jira/browse/OFBIZ-10536]

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:
{{org.apache.tomcat.util.digester.Digester error
SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.
org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}


 

 

 

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Sebastian Wachinger (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615457#comment-16615457
 ] 

Sebastian Wachinger commented on OFBIZ-10567:
-

 I came across the very same issue myself (while working on our new shop, using 
the trunk, again, yes I know ...) before I reported 
[-OFBIZ-10560-|https://issues.apache.org/jira/browse/OFBIZ-10560] / 
[OFBIZ-10536 |https://issues.apache.org/jira/browse/OFBIZ-10536]

The thing is, not only does that weird page appear as described by Jacques, but 
the intended changes in the Product Store configuration are lost.
My workaround at this point is to use the +Web Tools+ +Entity Data Maintenance+ 
on
[https://demo-trunk.ofbiz.apache.org/webtools/control/ViewGeneric?entityName=ProductStore=9000=true]
 which upon saving renders the same kind of weird page on 
[https://demo-trunk.ofbiz.apache.org/webtools/control/UpdateGeneric?entityName=ProductStore]
displaying exactly the same error message as quoted by Jacques, but this time 
the intended changes in the configuration are not lost, but indeed saved.

In both cases in the error message displayed in the console log the following 
error features prominently:
{{org.apache.tomcat.util.digester.Digester error
SEVERE: Parse Error at line 21 column 24: cvc-elt.1: Cannot find the 
declaration of element 'web-app'.
org.xml.sax.SAXParseException; lineNumber: 21; columnNumber: 24; cvc-elt.1: 
Cannot find the declaration of element 'web-app'.}}


 

 

 

 

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9450) Fixing defects reported by code analysis tools

2018-09-14 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615206#comment-16615206
 ] 

Michael Brohl commented on OFBIZ-9450:
--

Hi [~gvasmatkar],

yes, that's why I left the umbrella issue open. Please go ahead and file new 
issues/patches as you like.

During the work on the FindBugs notifications we found that there are also 
false positives or the fixes would be ugly so we left them untouched. You might 
find details in the subtasks.

Happy fixing!

 

> Fixing defects reported by code analysis tools
> --
>
> Key: OFBIZ-9450
> URL: https://issues.apache.org/jira/browse/OFBIZ-9450
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> Following Jacopo's call to action on fixing defects found by code analysis 
> tools [1], I think it's time to get started with an umbrella task for the 
> work to do.
> At ecomify, we have setup a Jenkins build server which automatically 
> generates FindBugs analysis results. I'm looking for a way to make the 
> results available to the public so that the community can always access the 
> latest bug statistics.
> If people want to join this initiative, please first file a Jira subtask for 
> the class/package you want to work on so that efforts are not spent twice on 
> the same topic.
> Any help or suggestion is greatly appreciated, thanks!
> [1] 
> https://lists.apache.org/thread.html/a0a3511c59618b8db64b84b2b1107eb06a11d9129555a775d0d9a16d@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9450) Fixing defects reported by code analysis tools

2018-09-14 Thread Girish Vasmatkar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615044#comment-16615044
 ] 

Girish Vasmatkar commented on OFBIZ-9450:
-

Hi [~mbrohl]

I am running FB 3.0.1 against trunk and still seeing some issues reported by 
FB. I am assuming we can still create new tickets pertaining to this as this 
parent ticket is still open and In-Progress?

Let me know if you think otherwise. Else I can start creating tickets and then 
present for the review post patch availability.

 

> Fixing defects reported by code analysis tools
> --
>
> Key: OFBIZ-9450
> URL: https://issues.apache.org/jira/browse/OFBIZ-9450
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> Following Jacopo's call to action on fixing defects found by code analysis 
> tools [1], I think it's time to get started with an umbrella task for the 
> work to do.
> At ecomify, we have setup a Jenkins build server which automatically 
> generates FindBugs analysis results. I'm looking for a way to make the 
> results available to the public so that the community can always access the 
> latest bug statistics.
> If people want to join this initiative, please first file a Jira subtask for 
> the class/package you want to work on so that efforts are not spent twice on 
> the same topic.
> Any help or suggestion is greatly appreciated, thanks!
> [1] 
> https://lists.apache.org/thread.html/a0a3511c59618b8db64b84b2b1107eb06a11d9129555a775d0d9a16d@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7196) UI labels are not in alphabetic order

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614886#comment-16614886
 ] 

Jacques Le Roux commented on OFBIZ-7196:


Kudos Mridul and Suraj for the good work!

I did not check all subtasks but a few, and since a tool is used I'm confident 
it's OK. 

BTW could you not share here the tool used? This is in order to continue to 
maintain the future possible same issues, thanks.

> UI labels are not in alphabetic order
> -
>
> Key: OFBIZ-7196
> URL: https://issues.apache.org/jira/browse/OFBIZ-7196
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
>
> Actual: UI labels are not in alphabetic order.
> Expected: As per standard, UI labels should be in alphabetic order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7196) UI labels are not in alphabetic order

2018-09-14 Thread Mridul Pathak (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak closed OFBIZ-7196.

Resolution: Implemented

As all child tickets are complete closing the parent ticket.

> UI labels are not in alphabetic order
> -
>
> Key: OFBIZ-7196
> URL: https://issues.apache.org/jira/browse/OFBIZ-7196
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
>
> Actual: UI labels are not in alphabetic order.
> Expected: As per standard, UI labels should be in alphabetic order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7285.


> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285.patch, OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7196) UI labels are not in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7196:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> UI labels are not in alphabetic order
> -
>
> Key: OFBIZ-7196
> URL: https://issues.apache.org/jira/browse/OFBIZ-7196
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
>
> Actual: UI labels are not in alphabetic order.
> Expected: As per standard, UI labels should be in alphabetic order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614844#comment-16614844
 ] 

Suraj Khurana commented on OFBIZ-7285:
--

Hello team,

Attached updated patch file as previous one was not being applied, also made 
some enhancements in the naming convention of UiLabels so that they similar one 
can be easily clubbed. Updated related occurrences as well.

Thanks !!

> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285.patch, OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7285:
-
Attachment: OFBIZ-7285.patch

> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285.patch, OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7282) Myportal : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7282.


This has been done at rev#1840923.

> Myportal :  Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7282
> URL: https://issues.apache.org/jira/browse/OFBIZ-7282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7282.patch, OFBIZ-7282_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7282) Myportal : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7282:
-
Attachment: OFBIZ-7282.patch

> Myportal :  Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7282
> URL: https://issues.apache.org/jira/browse/OFBIZ-7282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7282.patch, OFBIZ-7282_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7284) Oagis : Arrange UI labels in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614820#comment-16614820
 ] 

Suraj Khurana commented on OFBIZ-7284:
--

As per communication on ML [https://markmail.org/message/vkxdyulvgvtf7t4e], 
closing this ticket. 

> Oagis : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7284
> URL: https://issues.apache.org/jira/browse/OFBIZ-7284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/oagis
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7284_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7284) Oagis : Arrange UI labels in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7284.


> Oagis : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7284
> URL: https://issues.apache.org/jira/browse/OFBIZ-7284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/oagis
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7284_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614801#comment-16614801
 ] 

Suraj Khurana edited comment on OFBIZ-7281 at 9/14/18 1:03 PM:
---

Here is the updated patch as earlier one was not being applied due to improper 
path and quite old. 


was (Author: suraj.khurana):
Here is the updated patch as earlier one not being applied due to improper path 
and quite old. 

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7281.


This has been done at rev#1840920.

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2018-09-14 Thread Girish Vasmatkar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Girish Vasmatkar reassigned OFBIZ-10347:


Assignee: Girish Vasmatkar

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614801#comment-16614801
 ] 

Suraj Khurana commented on OFBIZ-7281:
--

Here is the updated patch as earlier one not being applied due to improper path 
and quite old. 

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7281:
-
Attachment: OFBIZ-7281.patch

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2018-09-14 Thread Girish Vasmatkar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614800#comment-16614800
 ] 

Girish Vasmatkar commented on OFBIZ-10347:
--

Folks,

I reviewed the attached patch (OFBIZ-10347.patch) and tried to limit the 
changes and added some additional ones related to use of valueOf vs parseInt 
method. There are a couple code style changes as well. Most of the changes are 
related to method and variable scope. 

I will take a look at more such changes and will roll them out gradually. 

Any issue or concern with the changes, please let me know.

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2018-09-14 Thread Girish Vasmatkar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Girish Vasmatkar updated OFBIZ-10347:
-
Attachment: OFBIZ-10347_updated.patch

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-14 Thread Gil Portenseigne (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614780#comment-16614780
 ] 

Gil Portenseigne commented on OFBIZ-10566:
--

{quote} What about ecommerce, maybe also in webtools?{quote}
I check the presence of all ‘ findOne’ usage into groovy. And rewrite them, if 
I missed some do not hesitate to tell me which one :).
Even if i missed some, the findOne method is still implemented (marked 
deprecated), then that will not cause any issue at execution.

{quote} Is it normal to remove findList from 
OfbizDslDescriptorForEclipse?{quote}

yes, since it's no more implemented in ‘GroovyBaseScript.groovy’


> Update missing entries in GDSL descriptors and cleanup findOne to use 
> EntityQuery instead.
> --
>
> Key: OFBIZ-10566
> URL: https://issues.apache.org/jira/browse/OFBIZ-10566
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10566.patch
>
>
> While studying groovy DSL possibilities i stumbled upon missing descriptors 
> in Intellij gdsl.
> Cleaning intellij and eclipse descriptors, i checked all implementations and 
> find out that findAll do not exist anymore, surely thanks to EntityQuery 
> improvement.
> I wondered then why there remain a findOne method, since EntityQuery is here.
> I propose to deprecate it for next release (18.??) and remove it from next 
> one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7280) Ebaystore : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7280.


This has been done at rev#1840912.

> Ebaystore : Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7280
> URL: https://issues.apache.org/jira/browse/OFBIZ-7280
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7280.patch, OFBIZ-7280_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7280) Ebaystore : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7280:
-
Attachment: OFBIZ-7280.patch

> Ebaystore : Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7280
> URL: https://issues.apache.org/jira/browse/OFBIZ-7280
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7280.patch, OFBIZ-7280_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7284) Oagis : Arrange UI labels in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7284:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Oagis : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7284
> URL: https://issues.apache.org/jira/browse/OFBIZ-7284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/oagis
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7284_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7280) Ebaystore : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7280:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Ebaystore : Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7280
> URL: https://issues.apache.org/jira/browse/OFBIZ-7280
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7280_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7282) Myportal : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7282:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Myportal :  Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7282
> URL: https://issues.apache.org/jira/browse/OFBIZ-7282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7282_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7285:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7281:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7370) Scrum : Arrange UI Labels in alphabetic order according to best practice

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7370.


> Scrum : Arrange UI Labels in alphabetic order according to best practice
> 
>
> Key: OFBIZ-7370
> URL: https://issues.apache.org/jira/browse/OFBIZ-7370
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7370.patch, OFBIZ-7370_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7353) Party : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7353.


> Party : Arrange UI Labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7353
> URL: https://issues.apache.org/jira/browse/OFBIZ-7353
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7353.patch, OFBIZ-7353_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614620#comment-16614620
 ] 

Jacques Le Roux edited comment on OFBIZ-4361 at 9/14/18 10:04 AM:
--

I agree Pierre, this is a blocker to me. But I must say, after looking at the 
patch, that reviews may take some time...


was (Author: jacques.le.roux):
I agree Pierre, this is a blocker to me.

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614620#comment-16614620
 ] 

Jacques Le Roux commented on OFBIZ-4361:


I agree Pierre, this is a blocker to me.

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614608#comment-16614608
 ] 

Jacques Le Roux commented on OFBIZ-10566:
-

Hi Gil,

This patch has been committed at r1840898.

What about ecommerce, maybe also in webtools?

Is it normal to remove findList from OfbizDslDescriptorForEclipse?

Your proposition sounds legit to me.

> Update missing entries in GDSL descriptors and cleanup findOne to use 
> EntityQuery instead.
> --
>
> Key: OFBIZ-10566
> URL: https://issues.apache.org/jira/browse/OFBIZ-10566
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10566.patch
>
>
> While studying groovy DSL possibilities i stumbled upon missing descriptors 
> in Intellij gdsl.
> Cleaning intellij and eclipse descriptors, i checked all implementations and 
> find out that findAll do not exist anymore, surely thanks to EntityQuery 
> improvement.
> I wondered then why there remain a findOne method, since EntityQuery is here.
> I propose to deprecate it for next release (18.??) and remove it from next 
> one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614608#comment-16614608
 ] 

Jacques Le Roux edited comment on OFBIZ-10566 at 9/14/18 9:56 AM:
--

Hi Gil,

What about ecommerce, maybe also in webtools?

Is it normal to remove findList from OfbizDslDescriptorForEclipse?

Your proposition sounds legit to me.


was (Author: jacques.le.roux):
Hi Gil,

This patch has been committed at r1840898.

What about ecommerce, maybe also in webtools?

Is it normal to remove findList from OfbizDslDescriptorForEclipse?

Your proposition sounds legit to me.

> Update missing entries in GDSL descriptors and cleanup findOne to use 
> EntityQuery instead.
> --
>
> Key: OFBIZ-10566
> URL: https://issues.apache.org/jira/browse/OFBIZ-10566
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10566.patch
>
>
> While studying groovy DSL possibilities i stumbled upon missing descriptors 
> in Intellij gdsl.
> Cleaning intellij and eclipse descriptors, i checked all implementations and 
> find out that findAll do not exist anymore, surely thanks to EntityQuery 
> improvement.
> I wondered then why there remain a findOne method, since EntityQuery is here.
> I propose to deprecate it for next release (18.??) and remove it from next 
> one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10568) RequirementStatus record should be created while creating or updating requirement

2018-09-14 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10568:
-

 Summary: RequirementStatus record should be created while creating 
or updating requirement
 Key: OFBIZ-10568
 URL: https://issues.apache.org/jira/browse/OFBIZ-10568
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Upcoming Branch
Reporter: Suraj Khurana
Assignee: Suraj Khurana


As per current flow, requirement status record is never created, it must be 
created every time a requirement is created or updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-09-14 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614580#comment-16614580
 ] 

Pierre Smits commented on OFBIZ-4361:
-

Should the 'priority' of this ticket not be raised? This seems serious enough 
to be regarded a blocker.

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10566) Update missing entries in GDSL descriptors and cleanup findOne to use EntityQuery instead.

2018-09-14 Thread Gil Portenseigne (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne closed OFBIZ-10566.


> Update missing entries in GDSL descriptors and cleanup findOne to use 
> EntityQuery instead.
> --
>
> Key: OFBIZ-10566
> URL: https://issues.apache.org/jira/browse/OFBIZ-10566
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10566.patch
>
>
> While studying groovy DSL possibilities i stumbled upon missing descriptors 
> in Intellij gdsl.
> Cleaning intellij and eclipse descriptors, i checked all implementations and 
> find out that findAll do not exist anymore, surely thanks to EntityQuery 
> improvement.
> I wondered then why there remain a findOne method, since EntityQuery is here.
> I propose to deprecate it for next release (18.??) and remove it from next 
> one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-14 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: OFBiz-10518.patch

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, EditAllocationPlan.png, 
> FindAllocationPlan.png, OFBiz-10518.patch, ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-14 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614548#comment-16614548
 ] 

Deepak Nigam commented on OFBIZ-10518:
--

Removed the old patch and attached the latest one.

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, EditAllocationPlan.png, 
> FindAllocationPlan.png, OFBiz-10518.patch, ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-14 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: OFBiz-10518-Supply-Allocation-Plan.patch)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, EditAllocationPlan.png, 
> FindAllocationPlan.png, ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-09-14 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614515#comment-16614515
 ] 

Michael Brohl commented on OFBIZ-4361:
--

Hi [~jacopoc],

without surprise I would recommend the solution provided by Dennis. It does not 
only fix the bug but provide an overall, best practice and secure solution for 
registration, forget password/password reset.

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-09-14 Thread Jacopo Cappellato (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614503#comment-16614503
 ] 

Jacopo Cappellato commented on OFBIZ-4361:
--

Thank you all for your contributions.

It would be great if the contributors of the various solutions would indicate 
which one of the solution proposed should be committed: if they find an 
agreement and suggest one then the community could focus the review to that and 
then we could commit.

 

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614490#comment-16614490
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

I thought about my 10 mins action ;)

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10567:

Affects Version/s: Release Branch 17.12

R16 is not concerned

> Setting cart in store leads to error
> 
>
> Key: OFBIZ-10567
> URL: https://issues.apache.org/jira/browse/OFBIZ-10567
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> The catalogQuickaddUse var is missing when sets from 
> catalog/control/updateProductStore
> The error is
> bq. The following has evaluated to null or missing: ==> catalogQuickaddUse 
> [in template "component://ecommerce/template/includes/Header.ftl" at line 
> 108, column 12]  Tip: If the failing expression is known to legally refer 
> to something that's sometimes null or missing, either specify a default value 
> like myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
> step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack 
> trace ("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in 
> template "component://ecommerce/template/includes/Header.ftl" at line 108, 
> column 7]  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-09-14 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614484#comment-16614484
 ] 

Pierre Smits commented on OFBIZ-10536:
--

Nothing ever is. :D

 

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10567) Setting cart in store leads to error

2018-09-14 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10567:
---

 Summary: Setting cart in store leads to error
 Key: OFBIZ-10567
 URL: https://issues.apache.org/jira/browse/OFBIZ-10567
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Trunk
Reporter: Jacques Le Roux


The catalogQuickaddUse var is missing when sets from 
catalog/control/updateProductStore

The error is
bq. The following has evaluated to null or missing: ==> catalogQuickaddUse [in 
template "component://ecommerce/template/includes/Header.ftl" at line 108, 
column 12]  Tip: If the failing expression is known to legally refer to 
something that's sometimes null or missing, either specify a default value like 
myOptionalVar!myDefault, or use <#if 
myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
step of the expression; to cover the whole expression, use parenthesis: 
(myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack trace 
("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in template 
"component://ecommerce/template/includes/Header.ftl" at line 108, column 7] 
 




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package

2018-09-14 Thread Girish Vasmatkar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614475#comment-16614475
 ] 

Girish Vasmatkar commented on OFBIZ-10480:
--

Thanks [~pfm.smits] for your review,

 

Did you mean to restore the description of this ticket to its original value - 
"Reducing scope of variables in org.apache.ofbiz.common package".

 

I, sure can do that, please let me know. Thanks.

> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614472#comment-16614472
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

Hi Pierre, yes before creating the Jira I checked if I could fix it quickly but 
it's not trivial :/

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614459#comment-16614459
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

Strictly the same locally

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-09-14 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614434#comment-16614434
 ] 

Pierre Smits commented on OFBIZ-10536:
--

I believe the issue mentioned by [~jacques.le.roux] warrants a separate bug 
ticket.

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-09-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614428#comment-16614428
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

Thanks Sebastian,

On trunk demo, for me it appears either if {{[Always View Cart After Adding An 
Item]}} is checked or not, on the +showcart+ page (+modifycart+).

Also when I try to change it in the +EditProductStore+ page in the Catalog 
Manager, section {{ShoppingCart}}, option {{[View Cart On Add]}} I get a weird 
page beginning by "EcommerceNoProductStore" with this error message

bq. The following has evaluated to null or missing: ==> catalogQuickaddUse [in 
template "component://ecommerce/template/includes/Header.ftl" at line 108, 
column 12]  Tip: If the failing expression is known to legally refer to 
something that's sometimes null or missing, either specify a default value like 
myOptionalVar!myDefault, or use <#if 
myOptionalVar??>when-present<#else>when-missing. (These only cover the last 
step of the expression; to cover the whole expression, use parenthesis: 
(myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??   FTL stack trace 
("~" means nesting-related): - Failed at: #if catalogQuickaddUse [in template 
"component://ecommerce/template/includes/Header.ftl" at line 108, column 7] 
 

I'll check locally...

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Priority: Major
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package

2018-09-14 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614415#comment-16614415
 ] 

Pierre Smits commented on OFBIZ-10480:
--

HI [~gvasmatkar],

You changed the description of the ticket from 
{quote}Reducing scope of variables in org.apache.ofbiz.common package
{quote}
to

 
{quote}Updated summary of this ticket to include any code refactoring that can 
be done on this package. Not to limit this ticket for only variable/method 
scoping.

Please let me know if anyone has any issue and I will revert the update.
{quote}
, but that doesn't provide anymore insights. As this is is a sub-task of an 
master ticket, the master ticket should provide enough description to explain 
the benefit, need, etc.

I suggest to update the description (of this ticket), as it will be  - when the 
code change is committed and made available via a release - the first thing an 
adopter sees when he/she is perusing the release notes that accompany that 
release.
  

> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)