[jira] [Updated] (OFBIZ-7535) Broken page renders while click on Submit button

2018-09-18 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-7535:
-
Affects Version/s: Release Branch 17.12
   Trunk
   Release Branch 16.11

> Broken page renders while click on Submit button
> 
>
> Key: OFBIZ-7535
> URL: https://issues.apache.org/jira/browse/OFBIZ-7535
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ankush Upadhyay
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-7535.patch
>
>
> Steps to reproduce:
> 1. Go to party manager.
> 2. Find party Company and navigate to Employment Application tab.
> 3. Now if there is no existing application and Submit button visible then 
> click on submit button.
> 4. Broken page renders with error message "
> :ERROR MESSAGE:
> org.ofbiz.webapp.event.EventHandlerException: No rows to process"
> Ideally system should hide submit button if there is no application to 
> process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10572) Set Debugger in Eclipse

2018-09-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619582#comment-16619582
 ] 

Swapnil M Mane commented on OFBIZ-10572:


Hi Pankaj,

Jira is not the right place to ask your queries thus I am closing this issue.

Please post your queries/questions on 'user' or 'developer' [OFBiz mailing 
list|https://ofbiz.apache.org/mailing-lists.html].
Before posting your query on list, please subscribe to that list.

Thanks!

> Set Debugger in Eclipse
> ---
>
> Key: OFBIZ-10572
> URL: https://issues.apache.org/jira/browse/OFBIZ-10572
> Project: OFBiz
>  Issue Type: Task
> Environment: Ofbiz 16.11
> Java 1.8
> Gradlew
> Eclipse Photon
>Reporter: PANKAJ TRIVEDI
>Assignee: Swapnil M Mane
>Priority: Major
>  Labels: build
> Attachments: eclipse error.png
>
>
> Unable to configure debug in Eclipse(Photon) with Java 1.8 and building tool 
> used is Gradle. Please share the Process



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10572) Set Debugger in Eclipse

2018-09-18 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane closed OFBIZ-10572.
--
Resolution: Not A Problem

> Set Debugger in Eclipse
> ---
>
> Key: OFBIZ-10572
> URL: https://issues.apache.org/jira/browse/OFBIZ-10572
> Project: OFBiz
>  Issue Type: Task
> Environment: Ofbiz 16.11
> Java 1.8
> Gradlew
> Eclipse Photon
>Reporter: PANKAJ TRIVEDI
>Assignee: Swapnil M Mane
>Priority: Major
>  Labels: build
> Attachments: eclipse error.png
>
>
> Unable to configure debug in Eclipse(Photon) with Java 1.8 and building tool 
> used is Gradle. Please share the Process



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10572) Set Debugger in Eclipse

2018-09-18 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane reassigned OFBIZ-10572:
--

Assignee: Swapnil M Mane

> Set Debugger in Eclipse
> ---
>
> Key: OFBIZ-10572
> URL: https://issues.apache.org/jira/browse/OFBIZ-10572
> Project: OFBiz
>  Issue Type: Task
> Environment: Ofbiz 16.11
> Java 1.8
> Gradlew
> Eclipse Photon
>Reporter: PANKAJ TRIVEDI
>Assignee: Swapnil M Mane
>Priority: Major
>  Labels: build
> Attachments: eclipse error.png
>
>
> Unable to configure debug in Eclipse(Photon) with Java 1.8 and building tool 
> used is Gradle. Please share the Process



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10572) Set Debugger in Eclipse

2018-09-18 Thread PANKAJ TRIVEDI (JIRA)
PANKAJ TRIVEDI created OFBIZ-10572:
--

 Summary: Set Debugger in Eclipse
 Key: OFBIZ-10572
 URL: https://issues.apache.org/jira/browse/OFBIZ-10572
 Project: OFBiz
  Issue Type: Task
 Environment: Ofbiz 16.11

Java 1.8

Gradlew

Eclipse Photon
Reporter: PANKAJ TRIVEDI
 Attachments: eclipse error.png

Unable to configure debug in Eclipse(Photon) with Java 1.8 and building tool 
used is Gradle. Please share the Process



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7535) Broken page renders while click on Submit button

2018-09-18 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-7535:


Assignee: Aditya Sharma  (was: Divesh Dutta)

> Broken page renders while click on Submit button
> 
>
> Key: OFBIZ-7535
> URL: https://issues.apache.org/jira/browse/OFBIZ-7535
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Reporter: Ankush Upadhyay
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-7535.patch
>
>
> Steps to reproduce:
> 1. Go to party manager.
> 2. Find party Company and navigate to Employment Application tab.
> 3. Now if there is no existing application and Submit button visible then 
> click on submit button.
> 4. Broken page renders with error message "
> :ERROR MESSAGE:
> org.ofbiz.webapp.event.EventHandlerException: No rows to process"
> Ideally system should hide submit button if there is no application to 
> process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10571:
-

Assignee: Girish Vasmatkar  (was: Suraj Khurana)

> [FB] Package org.apache.ofbiz.minilang
> --
>
> Key: OFBIZ-10571
> URL: https://issues.apache.org/jira/browse/OFBIZ-10571
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> * [Should be a static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made static.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC*
> *org.apache.ofbiz.minilang.method.callops.CallService***
>  
>  * [Could be refactored into a named static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made into a _static_ inner 
> class. Since anonymous inner classes cannot be marked as static, doing this 
> will require refactoring the inner class so that it is a named inner class.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON*
> *org.apache.ofbiz.minilang.method.conditional.CombinedConditional*
>  
>  * [Boxing/unboxing to parse a 
> primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING]
> A boxed primitive is created from a String, just to extract the unboxed 
> primitive value. It is more efficient to just call the static parseXXX method.
> **
> *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING*
> *org.apache.ofbiz.minilang.method.otherops.Calculate*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10571:
-

Assignee: Suraj Khurana  (was: Girish Vasmatkar)

> [FB] Package org.apache.ofbiz.minilang
> --
>
> Key: OFBIZ-10571
> URL: https://issues.apache.org/jira/browse/OFBIZ-10571
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Suraj Khurana
>Priority: Minor
>
> * [Should be a static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made static.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC*
> *org.apache.ofbiz.minilang.method.callops.CallService***
>  
>  * [Could be refactored into a named static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made into a _static_ inner 
> class. Since anonymous inner classes cannot be marked as static, doing this 
> will require refactoring the inner class so that it is a named inner class.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON*
> *org.apache.ofbiz.minilang.method.conditional.CombinedConditional*
>  
>  * [Boxing/unboxing to parse a 
> primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING]
> A boxed primitive is created from a String, just to extract the unboxed 
> primitive value. It is more efficient to just call the static parseXXX method.
> **
> *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING*
> *org.apache.ofbiz.minilang.method.otherops.Calculate*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10465) Using "buttontext" styling for buttons inside the ListEntities table

2018-09-18 Thread Garima jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garima jain reassigned OFBIZ-10465:
---

Assignee: Garima jain

> Using "buttontext" styling for buttons inside the ListEntities table
> 
>
> Key: OFBIZ-10465
> URL: https://issues.apache.org/jira/browse/OFBIZ-10465
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Dennis Balkir
>Assignee: Garima jain
>Priority: Minor
> Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, 
> listEntities_buttons.patch
>
>
> I think it would be a good idea, to use the "buttontext" styling for the 
> buttons inside the lines of the ListEntities table.
> This way the links will look like buttons, and it will be more obvious, that 
> these are single clickable elements.
> I added some screenshots for all themes with the buttons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618906#comment-16618906
 ] 

Deepak Nigam commented on OFBIZ-10518:
--

Removed the old patch and mock-ups and attached the latest.

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: OFBiz-10518.patch
FindAllocationPlan.png
EditAllocationPlan.png
ViewAllocationPlan.png
CreateAllocationPlanEditMode-Step2.png
CreateAllocationPlan-Step2.png
CreateAllocationPlan-Step1.png

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: OFBiz-10518.patch)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: CreateAllocationPlan-Step1.png)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: CreateAllocationPlan-Step2.png)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: OFBiz-10518.patch)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: ViewAllocationPlan.png)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: FindAllocationPlan.png)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-18 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: (was: EditAllocationPlan.png)

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9989) Testing of New Releaes1

2018-09-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-9989:
---

Assignee: Pierre Smits

> Testing of New Releaes1
> ---
>
> Key: OFBIZ-9989
> URL: https://issues.apache.org/jira/browse/OFBIZ-9989
> Project: OFBiz
>  Issue Type: Bug
>Reporter: vivek
>Assignee: Pierre Smits
>Priority: Minor
>   Original Estimate: 8m
>  Remaining Estimate: 8m
>
> desct



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9989) Testing of New Releaes1

2018-09-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-9989.
---
Resolution: Not A Problem

> Testing of New Releaes1
> ---
>
> Key: OFBIZ-9989
> URL: https://issues.apache.org/jira/browse/OFBIZ-9989
> Project: OFBiz
>  Issue Type: Bug
>Reporter: vivek
>Assignee: Pierre Smits
>Priority: Minor
>   Original Estimate: 8m
>  Remaining Estimate: 8m
>
> desct



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9989) Testing of New Releaes1

2018-09-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618836#comment-16618836
 ] 

Swapnil M Mane commented on OFBIZ-9989:
---

+1, I think, we can proceed to close this ticket.

> Testing of New Releaes1
> ---
>
> Key: OFBIZ-9989
> URL: https://issues.apache.org/jira/browse/OFBIZ-9989
> Project: OFBiz
>  Issue Type: Bug
>Reporter: vivek
>Priority: Minor
>   Original Estimate: 8m
>  Remaining Estimate: 8m
>
> desct



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9989) Testing of New Releaes1

2018-09-18 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618805#comment-16618805
 ] 

Suraj Khurana commented on OFBIZ-9989:
--

Can we close this ticket ?

> Testing of New Releaes1
> ---
>
> Key: OFBIZ-9989
> URL: https://issues.apache.org/jira/browse/OFBIZ-9989
> Project: OFBiz
>  Issue Type: Bug
>Reporter: vivek
>Priority: Minor
>   Original Estimate: 8m
>  Remaining Estimate: 8m
>
> desct



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9763) Create separate Permission Services for CRUD services of ShoppingList and ShoppingListItem

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9763:


Assignee: Chinmay Patidar  (was: Suraj Khurana)

> Create separate Permission Services for CRUD services of ShoppingList and 
> ShoppingListItem
> --
>
> Key: OFBIZ-9763
> URL: https://issues.apache.org/jira/browse/OFBIZ-9763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, party
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Chinmay Patidar
>Assignee: Chinmay Patidar
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9763.patch, OFBIZ-9763.patch
>
>
> In CRUD services for ShoppingList and ShoppingListItem entities, the security 
> related checks are present inline in the services. This implementation 
> violates the best practice of keeping security implementation different from 
> the business logic.
> We need to implement security services for such operations and to call them 
> as a permission-service from the CRUD operation services definition



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10539) Issue with opening a page via bookmark when the user is logged out

2018-09-18 Thread Girish Vasmatkar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618753#comment-16618753
 ] 

Girish Vasmatkar commented on OFBIZ-10539:
--

Hi Ritesh and All

I have reviewed the patch and it looks good to me. I was just wondering why 
instead of just storing query string directly in the session, a map with key 
value is created and then stored in the session. This approach also requires us 
to do manual encoding and decoding and also fails if there are more than one 
values for a same parameter. Using query string directly also works without any 
issues.

I would however recommend we do not change much in the existing code and go 
with Ritesh's patch. This will ensure there is minimal impact to any hidden 
functionality. 

> Issue with opening a page via bookmark when the user is logged out
> --
>
> Key: OFBIZ-10539
> URL: https://issues.apache.org/jira/browse/OFBIZ-10539
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Ritesh Kumar
>Assignee: Ritesh Kumar
>Priority: Major
> Attachments: OFBIZ-10539.patch
>
>
> Please refer to the discussions on 
> [dev-mailing-list|https://markmail.org/message/zbdjmghgqldxbnbu]
> There are issues with opening a bookmarked page when the user is logged out. 
> Steps to generate: 
> (Please refer 
> [Demo-trunk|https://demo-trunk.ofbiz.apache.org/webtools/control/main])
> 1. Open this link, 
> [FindWorkEffort|https://demo-trunk.ofbiz.apache.org/workeffort/control/FindWorkEffort].
>  Find Work Effort screen will be rendered.
> 2. Inspect and change the form method to "GET".
> 3. Apply any of the two statuses (say, Cancelled and Declined). Click on Find.
> 4. Records will be fetched according to the applied filters. 
> 5. Check the URL. Cancelled and Declined statuses must be there in the URL.
> 6. Bookmark this page and log out.
> 7. Now, open the bookmark.
> 8. The login page will be rendered. Check the URL here. It will be the same 
> as it was when the page was being bookmarked.
> 9. Type in the credentials and log in.
> 10. The result may be different. Check the URL. One of the statuses is gone. 
> Following are the issues: 
> The bug here is (supposing the GET method is used)
> 1. On opening the bookmark, the page is rendered with double encoding (if the 
> value had a space character initially, the space character was already 
> encoded into '+' in the URL and when this bookmark is opened, this '+' is 
> again encoded). This particular issue cannot be generated from the 
> above-mentioned steps but it exists. 
> 2. Suppose the bookmarked URL had multiple values from the same filter (say, 
> Cancelled and Declined status), it renders with just one of the statutes 
> applied. It is because the request handler prepares a Map of parameters from 
> the query string and as is the property of Map to replace the old value if a 
> new value is being added with the same key (in this example, first Cancelled 
> status is put in this Map and then Declined), only Declined status is put in 
> this Map. 
> What happens is that the request handler prepares a map of query parameters 
> from the query string and this map is used to create a redirect target.  This 
> redirect target (at this instance having both the above-mentioned issues) is 
> called upon to render the requested page.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang

2018-09-18 Thread Girish Vasmatkar (JIRA)
Girish Vasmatkar created OFBIZ-10571:


 Summary: [FB] Package org.apache.ofbiz.minilang
 Key: OFBIZ-10571
 URL: https://issues.apache.org/jira/browse/OFBIZ-10571
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Girish Vasmatkar
Assignee: Girish Vasmatkar


* [Should be a static inner 
class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC]

This class is an inner class, but does not use its embedded reference to the 
object which created it.  This reference makes the instances of the class 
larger, and may keep the reference to the creator object alive longer than 
necessary.  If possible, the class should be made static.

*Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC*

*org.apache.ofbiz.minilang.method.callops.CallService***

 
 * [Could be refactored into a named static inner 
class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON]

This class is an inner class, but does not use its embedded reference to the 
object which created it.  This reference makes the instances of the class 
larger, and may keep the reference to the creator object alive longer than 
necessary.  If possible, the class should be made into a _static_ inner class. 
Since anonymous inner classes cannot be marked as static, doing this will 
require refactoring the inner class so that it is a named inner class.

*Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON*

*org.apache.ofbiz.minilang.method.conditional.CombinedConditional*

 
 * [Boxing/unboxing to parse a 
primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING]

A boxed primitive is created from a String, just to extract the unboxed 
primitive value. It is more efficient to just call the static parseXXX method.


**

*Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING*

*org.apache.ofbiz.minilang.method.otherops.Calculate*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9227) Violation of foreign key constraint

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-9227.

Resolution: Not A Problem

> Violation of foreign key constraint
> ---
>
> Key: OFBIZ-9227
> URL: https://issues.apache.org/jira/browse/OFBIZ-9227
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 16.11
> Environment: Win 7
>Reporter: Michael Clifton
>Assignee: Aman Agrawal
>Priority: Minor
>  Labels: database, tasks, workeffort
>
> Trying to add a task to a project phase, I receive the below error.
> 2017-02-21 09:23:54,189 |http-nio-8443-exec-1 |ServiceDispatcher |E| Error in 
> Service [createProjectTask]: Exception thrown while creating the "newEntity" 
> GenericValue: org.apache.ofbiz.entity.GenericEntityException: Error while 
> inserting: 
> [GenericEntity:WorkEffort][createdByUserLogin,admin(java.lang.String)][createdDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][createdStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][createdTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][currentStatusId,PTS_CREATED(java.lang.String)][description,Test(java.lang.String)][estimatedCompletionDate,2017-02-24
>  00:00:00.0(java.sql.Timestamp)][estimatedStartDate,2017-02-21 
> 00:00:00.0(java.sql.Timestamp)][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][lastStatusUpdate,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][priority,1(java.lang.Long)][revisionNumber,1(java.lang.Long)][scopeEnumId,WES_PRIVATE(java.lang.String)][sequenceNum,1(java.lang.Long)][workEffortId,10090(java.lang.String)][workEffortName,Test(java.lang.String)][workEffortParentId,10048(java.lang.String)][workEffortTypeId,Task(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.WORK_EFFORT 
> (WORK_EFFORT_ID, WORK_EFFORT_TYPE_ID, CURRENT_STATUS_ID, LAST_STATUS_UPDATE, 
> WORK_EFFORT_PURPOSE_TYPE_ID, WORK_EFFORT_PARENT_ID, SCOPE_ENUM_ID, PRIORITY, 
> PERCENT_COMPLETE, WORK_EFFORT_NAME, SHOW_AS_ENUM_ID, SEND_NOTIFICATION_EMAIL, 
> DESCRIPTION, LOCATION_DESC, ESTIMATED_START_DATE, ESTIMATED_COMPLETION_DATE, 
> ACTUAL_START_DATE, ACTUAL_COMPLETION_DATE, ESTIMATED_MILLI_SECONDS, 
> ESTIMATED_SETUP_MILLIS, ESTIMATE_CALC_METHOD, ACTUAL_MILLI_SECONDS, 
> ACTUAL_SETUP_MILLIS, TOTAL_MILLI_SECONDS_ALLOWED, TOTAL_MONEY_ALLOWED, 
> MONEY_UOM_ID, SPECIAL_TERMS, TIME_TRANSPARENCY, UNIVERSAL_ID, 
> SOURCE_REFERENCE_ID, FIXED_ASSET_ID, FACILITY_ID, INFO_URL, 
> RECURRENCE_INFO_ID, TEMP_EXPR_ID, RUNTIME_DATA_ID, NOTE_ID, 
> SERVICE_LOADER_NAME, QUANTITY_TO_PRODUCE, QUANTITY_PRODUCED, 
> QUANTITY_REJECTED, RESERV_PERSONS, RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, 
> ACCOMMODATION_MAP_ID, ACCOMMODATION_SPOT_ID, REVISION_NUMBER, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, 
> SEQUENCE_NUM) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'WORK_EFFORT' caused a 
> violation of foreign key constraint 'WK_EFFRT_TYPE' for key (Task). The 
> statement has been rolled back.)) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9227) Violation of foreign key constraint

2018-09-18 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618706#comment-16618706
 ] 

Suraj Khurana commented on OFBIZ-9227:
--

Thanks Aman,

I also checked and hence closing the ticket.

> Violation of foreign key constraint
> ---
>
> Key: OFBIZ-9227
> URL: https://issues.apache.org/jira/browse/OFBIZ-9227
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 16.11
> Environment: Win 7
>Reporter: Michael Clifton
>Assignee: Aman Agrawal
>Priority: Minor
>  Labels: database, tasks, workeffort
>
> Trying to add a task to a project phase, I receive the below error.
> 2017-02-21 09:23:54,189 |http-nio-8443-exec-1 |ServiceDispatcher |E| Error in 
> Service [createProjectTask]: Exception thrown while creating the "newEntity" 
> GenericValue: org.apache.ofbiz.entity.GenericEntityException: Error while 
> inserting: 
> [GenericEntity:WorkEffort][createdByUserLogin,admin(java.lang.String)][createdDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][createdStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][createdTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][currentStatusId,PTS_CREATED(java.lang.String)][description,Test(java.lang.String)][estimatedCompletionDate,2017-02-24
>  00:00:00.0(java.sql.Timestamp)][estimatedStartDate,2017-02-21 
> 00:00:00.0(java.sql.Timestamp)][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][lastStatusUpdate,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][priority,1(java.lang.Long)][revisionNumber,1(java.lang.Long)][scopeEnumId,WES_PRIVATE(java.lang.String)][sequenceNum,1(java.lang.Long)][workEffortId,10090(java.lang.String)][workEffortName,Test(java.lang.String)][workEffortParentId,10048(java.lang.String)][workEffortTypeId,Task(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.WORK_EFFORT 
> (WORK_EFFORT_ID, WORK_EFFORT_TYPE_ID, CURRENT_STATUS_ID, LAST_STATUS_UPDATE, 
> WORK_EFFORT_PURPOSE_TYPE_ID, WORK_EFFORT_PARENT_ID, SCOPE_ENUM_ID, PRIORITY, 
> PERCENT_COMPLETE, WORK_EFFORT_NAME, SHOW_AS_ENUM_ID, SEND_NOTIFICATION_EMAIL, 
> DESCRIPTION, LOCATION_DESC, ESTIMATED_START_DATE, ESTIMATED_COMPLETION_DATE, 
> ACTUAL_START_DATE, ACTUAL_COMPLETION_DATE, ESTIMATED_MILLI_SECONDS, 
> ESTIMATED_SETUP_MILLIS, ESTIMATE_CALC_METHOD, ACTUAL_MILLI_SECONDS, 
> ACTUAL_SETUP_MILLIS, TOTAL_MILLI_SECONDS_ALLOWED, TOTAL_MONEY_ALLOWED, 
> MONEY_UOM_ID, SPECIAL_TERMS, TIME_TRANSPARENCY, UNIVERSAL_ID, 
> SOURCE_REFERENCE_ID, FIXED_ASSET_ID, FACILITY_ID, INFO_URL, 
> RECURRENCE_INFO_ID, TEMP_EXPR_ID, RUNTIME_DATA_ID, NOTE_ID, 
> SERVICE_LOADER_NAME, QUANTITY_TO_PRODUCE, QUANTITY_PRODUCED, 
> QUANTITY_REJECTED, RESERV_PERSONS, RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, 
> ACCOMMODATION_MAP_ID, ACCOMMODATION_SPOT_ID, REVISION_NUMBER, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, 
> SEQUENCE_NUM) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'WORK_EFFORT' caused a 
> violation of foreign key constraint 'WK_EFFRT_TYPE' for key (Task). The 
> statement has been rolled back.)) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10570) Requirement is created for wrong facility

2018-09-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10570:
-

 Summary: Requirement is created for wrong facility
 Key: OFBIZ-10570
 URL: https://issues.apache.org/jira/browse/OFBIZ-10570
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Upcoming Branch
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Design description:

In service _createAutoRequirementsForOrder_ ProductStore.inventoryFacilityId is 
directly used for creating requirement.
Here, an order can have multiple ship group and each ship group can be 
fulfilled from various facilities, so instead of creating requirement for 
ProductStore.inventoryFacilityId, it should create requirement using 
OrderItemShipGroup.facilityId. If not found, we can have an additional check to 
use orderHeader.facilityId.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10568) RequirementStatus record should be created while creating or updating requirement

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10568:
--
Attachment: OFBIZ-10568.patch

> RequirementStatus record should be created while creating or updating 
> requirement
> -
>
> Key: OFBIZ-10568
> URL: https://issues.apache.org/jira/browse/OFBIZ-10568
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10568.patch
>
>
> As per current flow, requirement status record is never created, it must be 
> created every time a requirement is created or updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)