[jira] [Updated] (OFBIZ-10313) Capture Transactions are still displayed as Authorize

2018-09-23 Thread Humera Khan (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-10313:

Component/s: accounting

> Capture Transactions are still displayed as Authorize
> -
>
> Key: OFBIZ-10313
> URL: https://issues.apache.org/jira/browse/OFBIZ-10313
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Humera Khan
>Priority: Major
>
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses
> 2. Navigate to Transactions with Authorize
> 3. Try to Capture payment
> 4. Again navigate to FindGatewayResponses and check for transaction
> Actual Result:
> The transaction still displayed with Authorize status and no update on 
> payment capture
> Expected Result:
> Correct status of transaction should be displayed (Capture/Authorize)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10313) Capture Transactions are still displayed as Authorize

2018-09-23 Thread Humera Khan (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-10313:

Affects Version/s: Trunk

> Capture Transactions are still displayed as Authorize
> -
>
> Key: OFBIZ-10313
> URL: https://issues.apache.org/jira/browse/OFBIZ-10313
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Humera Khan
>Priority: Major
>
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses
> 2. Navigate to Transactions with Authorize
> 3. Try to Capture payment
> 4. Again navigate to FindGatewayResponses and check for transaction
> Actual Result:
> The transaction still displayed with Authorize status and no update on 
> payment capture
> Expected Result:
> Correct status of transaction should be displayed (Capture/Authorize)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10309) HTTP Status 500 – Internal Server Error on InvoiceAcctgTransEntriesPdf

2018-09-23 Thread Humera Khan (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-10309:

Affects Version/s: Trunk

> HTTP Status 500 – Internal Server Error on InvoiceAcctgTransEntriesPdf
> --
>
> Key: OFBIZ-10309
> URL: https://issues.apache.org/jira/browse/OFBIZ-10309
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
> Environment: https://demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Humera Khan
>Priority: Major
>
> Steps:
> 1. Open URL 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices]
> 2. Navigate to Find Invoices
> 3. Click on Any Invoice id
> 4. Click on AcctgTransEntriesPdf
>  
> Actual Result:
> HTTP Status 500 – Internal Server Error Type Status Report Message ERROR 
> rendering error page [/error/error.jsp], but here is the error text: 
> org.eclipse.birt.report.engine.api.EngineException Error happened while 
> running the report. Description The server encountered an unexpected 
> condition that prevented it from fulfilling the request. Apache Tomcat/8.5.24
> Expected Result:
> AcctgTransEntriesPdf button should work as expected.
> Thanks in Advance!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-09-23 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625396#comment-16625396
 ] 

Suraj Khurana commented on OFBIZ-10579:
---

Thanks [~lektran] for the patch, I have done some slight modifications (majorly 
in _EntityQuery_) in it as required.

This patch introduces a new class _EntityDateFilterDetector._ It is used to 
check if condition object is instance of _EntityDateFilterCondition_ or an 
_EntityExpr_ where the left hand side (e.g. fieldName) contains "fromDate" 
(case insensitive). It will log warning ("Date filter detected in query 
condition, ignoring request to cache") instead of caching with date condition.

This also improves performance as now after this patch, filtered records are 
fetched from DB, instead of fetching records first and then using 
filterByCondition (dateCondition) on them.

> Date filtered queries with caching should be restricted to cache
> 
>
> Key: OFBIZ-10579
> URL: https://issues.apache.org/jira/browse/OFBIZ-10579
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-09-23 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10579:
--
Attachment: OFBIZ-10579.patch

> Date filtered queries with caching should be restricted to cache
> 
>
> Key: OFBIZ-10579
> URL: https://issues.apache.org/jira/browse/OFBIZ-10579
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10497) UI issues with select box for Classification Group on findparty page

2018-09-23 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625378#comment-16625378
 ] 

Aditya Sharma commented on OFBIZ-10497:
---

Indeed [~pfm.smits] .

Though *Affects Version* was already set with the ticket creation.

Thanks for the concern :)

> UI issues with select box for Classification Group on findparty page
> 
>
> Key: OFBIZ-10497
> URL: https://issues.apache.org/jira/browse/OFBIZ-10497
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Anushi Gupta
>Priority: Trivial
> Attachments: EmptySelectbox.png, OFBIZ-10497.patch
>
>
> Steps to regenerate:
> Login to partymgr 
> ([https://demo-trunk.ofbiz.apache.org/partymgr/control/main).]
> Notice Classification Group field.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10357) Missing uiLabel for Page in webtools entity engine

2018-09-23 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-10357.
---
Resolution: Cannot Reproduce

> Missing uiLabel for Page in webtools entity engine
> --
>
> Key: OFBIZ-10357
> URL: https://issues.apache.org/jira/browse/OFBIZ-10357
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10357.png, missinguilabel.png
>
>
> Please find attached screenshot.
> Steps to regenerate:
>  # Go to entity engine.
>  # select any entity and click on search.
>  # See the missing uiLabel for Page under pagination while showing results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10357) Missing uiLabel for Page in webtools entity engine

2018-09-23 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reopened OFBIZ-10357:
-

> Missing uiLabel for Page in webtools entity engine
> --
>
> Key: OFBIZ-10357
> URL: https://issues.apache.org/jira/browse/OFBIZ-10357
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10357.png, missinguilabel.png
>
>
> Please find attached screenshot.
> Steps to regenerate:
>  # Go to entity engine.
>  # select any entity and click on search.
>  # See the missing uiLabel for Page under pagination while showing results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8842) Search operation on 'AssocRevisionItemView' entity causing exception.

2018-09-23 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625360#comment-16625360
 ] 

Deepak Dixit commented on OFBIZ-8842:
-

IMO we need to revert this, as this will affect the business cases

> Search operation on 'AssocRevisionItemView' entity causing exception.
> -
>
> Key: OFBIZ-8842
> URL: https://issues.apache.org/jira/browse/OFBIZ-8842
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Release Branch 16.11, Release Branch 17.12
>
> Attachments: Assoc_Actual.png, Assoc_Expected.png, OFBIZ-8842.patch
>
>
> Steps to regenerate : 
> 1. Go to Entity Data Maintenance in webtools.
> 2. Search entity 'AssocRevisionItemView'. Click on it and go to the overview 
> page.
> 3. Click on the Find button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8842) Search operation on 'AssocRevisionItemView' entity causing exception.

2018-09-23 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625359#comment-16625359
 ] 

Deepak Dixit commented on OFBIZ-8842:
-

Hi [~humera.khan] ,

These view entity does not works well in webtools, there are several others 
similar issues reported in past, these view entity define to access from code, 
and when we pass the filedToSelect properly it works well, in case of webtools 
access all the entity fields pass as filedToSelect so it does not works file. 

> Search operation on 'AssocRevisionItemView' entity causing exception.
> -
>
> Key: OFBIZ-8842
> URL: https://issues.apache.org/jira/browse/OFBIZ-8842
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Release Branch 16.11, Release Branch 17.12
>
> Attachments: Assoc_Actual.png, Assoc_Expected.png, OFBIZ-8842.patch
>
>
> Steps to regenerate : 
> 1. Go to Entity Data Maintenance in webtools.
> 2. Search entity 'AssocRevisionItemView'. Click on it and go to the overview 
> page.
> 3. Click on the Find button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-8842) Search operation on 'AssocRevisionItemView' entity causing exception.

2018-09-23 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reopened OFBIZ-8842:
-

> Search operation on 'AssocRevisionItemView' entity causing exception.
> -
>
> Key: OFBIZ-8842
> URL: https://issues.apache.org/jira/browse/OFBIZ-8842
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Release Branch 16.11, Release Branch 17.12
>
> Attachments: Assoc_Actual.png, Assoc_Expected.png, OFBIZ-8842.patch
>
>
> Steps to regenerate : 
> 1. Go to Entity Data Maintenance in webtools.
> 2. Search entity 'AssocRevisionItemView'. Click on it and go to the overview 
> page.
> 3. Click on the Find button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10325) EntityOne.java doesn't throw proper exception if field is not available in entity

2018-09-23 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10325:

Attachment: PartyProfile.png

> EntityOne.java doesn't throw proper exception if field is not available in 
> entity
> -
>
> Key: OFBIZ-10325
> URL: https://issues.apache.org/jira/browse/OFBIZ-10325
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Priority: Major
> Attachments: PartyProfile.png
>
>
> Using entity-one tag in xml services, if field is not a part of entity, 
> proper exception message should be thrown with returned error service 
> response.
>  Suppose:
> 
>      
>      
>     
>  
> partyId is not part of ProductFacility entity, if such code is used inside 
> any xml service, than proper exception should be thrown from EntityOne.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10325) EntityOne.java doesn't throw proper exception if field is not available in entity

2018-09-23 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625114#comment-16625114
 ] 

Pritam Kute commented on OFBIZ-10325:
-

Hello Suraj,

I have verified this issue and I think this improvement has been already done 
in the codebase. I have checked it at "Attributes" screen on party profile. 
Please check the following code snippet:

{code:xml}

  

















  

{code}

I have got a proper exception on the console like following:

{code:java}
2018-09-22 17:51:24,331 |jsse-nio-8443-exec-1 |ControlServlet
|E| Error in request handler: 
java.lang.IllegalArgumentException: [GenericEntity.set] "partyIdTo" is not a 
field of Party, must be one of: partyId, partyTypeId, externalId, 
preferredCurrencyUomId, description, statusId, createdDate, createdByUserLogin, 
lastModifiedDate, lastModifiedByUserLogin, dataSourceId, isUnread, 
lastUpdatedStamp, lastUpdatedTxStamp, createdStamp, createdTxStamp
at org.apache.ofbiz.entity.GenericEntity.set(GenericEntity.java:463) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.GenericEntity.setFields(GenericEntity.java:1057) 
~[ofbiz.jar:?]
at org.apache.ofbiz.entity.GenericEntity.init(GenericEntity.java:199) 
~[ofbiz.jar:?]
at org.apache.ofbiz.entity.GenericPK.create(GenericPK.java:45) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.GenericDelegator.makePK(GenericDelegator.java:695) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:145)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:90)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.widget.model.AbstractModelAction$EntityOne.runAction(AbstractModelAction.java:278)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
 ~[ofbiz.jar:?]
{code}

Also, see the error displayed on the party profile screen. I have attached the 
screenshot of the same. Please let me if I am missing something or you expect 
it in some other way,

> EntityOne.java doesn't throw proper exception if field is not available in 
> entity
> -
>
> Key: OFBIZ-10325
> URL: https://issues.apache.org/jira/browse/OFBIZ-10325
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Priority: Major
> Attachments: PartyProfile.png
>
>
> Using entity-one tag in xml services, if field is not a part of entity, 
> proper exception message should be thrown with returned error service 
> response.
>  Suppose:
> 
>      
>      
>     
>  
> partyId is not part of ProductFacility entity, if such code is used inside 
> any xml service, than proper exception should be thrown from EntityOne.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10307) Navigate from a domain to another with automated signed in authentication

2018-09-23 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625047#comment-16625047
 ] 

Taher Alkhateeb commented on OFBIZ-10307:
-

I think the refactoring in this case did not achieve the desired results, and 
it might look a bit _more_ complex now. Here are a few ideas for things to 
clean up if you find them useful:
 * Return error or return success could have one location only within the logic
 * validation and null checking could be abstracted away behind private methods 
to convey what is being attempted without polluting the fucntion with too many 
ifs, nested ifs, validations, and null checks
 * The try / catch block is buried too deep in conditionals that makes it hard 
to test and understand, perhaps it can propagated and handled in one central 
location for all errors instead of these multiple returns sprinkled throughout 
the code
 * Breaking a long function to two functions, with the second function taking 
in 4 parameters, which are the same ones passed to the parent function makes 
the code actually harder to read and more complex. It's not a matter of 
chopping a function to two, but more of specializing the code to what is being 
attempted.

This refactoring would make it easier to read the code, and hence test it. So 
my recommendation is to revisit the code, and not simply take part of it, cut 
it, and paste it into another method.

> Navigate from a domain to another with automated signed in authentication
> -
>
> Key: OFBIZ-10307
> URL: https://issues.apache.org/jira/browse/OFBIZ-10307
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10307-test from example.patch, OFBIZ-10307-test 
> from example.patch, OFBIZ-10307-test from example.patch, 
> OFBIZ-10307-test.patch, OFBIZ-10307-test.patch, OFBIZ-10307-test.patch, 
> OFBIZ-10307-test.patch, OFBIZ-10307.patch, OFBIZ-10307.patch, 
> OFBIZ-10307.patch, OFBIZ-10307.patch, OFBIZ-10307.patch, OFBIZ-10307.patch, 
> OFBIZ-10307.patch, OFBIZ-10307.patch
>
>
> This will use a JWT Token authentication to get from one domain, where you 
> are signed in, to another domain where you get signed in automatically. 
> Something like ExternalLoginKey or Tomcat SSO, but not on the same domain.
> This will build upon the initial work done at OFBIZ-9833 which has been 
> partially reverted in trunk with r1827439 (see OFBIZ-10304) and r1827441. I 
> explained why and what I did at [https://s.apache.org/a5Km]
> I turned to Ajax for the "Authorization" header sending. I initially thought 
> I'd just pass an "Authorization" header and use it in the 
> externalServerLoginCheck preprocessor, et voilà.
> But I stumbled upon something I did not know well : CORS! And in particular 
> the upstream control (Pre-verified requests):
>  
> [https://en.wikipedia.org/wiki/Cross-origin_resource_sharing#Preflight_example]
>  [https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS]
>  [https://www.w3.org/TR/cors/]
> To be able to pass an "Authorization" header, the server must respond 
> positively in the Preflight HTTP response (OPTIONS). To do this, either you 
> use a Tomcat filter (or your own filter, there are examples on the Net) or 
> use HTTPD (or Nginx) configuration on the target server.
> I tried Tomcat first, without success. With HTTPD it's easier just 3 lines. 
> For my tests, future tests by OFBiz users and as an example, I asked infra to 
> put them in our HTTPD trunk demo config:
>  Header set Access-Control-Allow-Origin "https://localhost:8443;
>  Header set Access-Control-Allow-Headers "Authorization"
>  Header set Access-Control-Allow-Credentials "true"
> No code change (either in all web.xml files for Tomcat or Java for own 
> filter), and more safety. It does not give more right to outsiders than what 
> we give with the admin credential.
> In Header set Access-Control-Allow-Origin you can put more domains. I just 
> used [https://localhost:8443|https://localhost:8443/] for the tests.
> It works in Chrome, Firefox and Opera and partially in IE11 (not tested in 
> Edge). I did not test Safari, but I guess like other modern browsers it 
> should work.
>  For those (very few I guess) interested by IE11 (for Edge test yourself and 
> report please), here is the solution
>  
> [https://stackoverflow.com/questions/12643960/internet-explorer-10-is-ignoring-xmlhttprequest-xhr-withcredentials-true]
>  
> [https://web.archive.org/web/20130308142134/http://msdn.microsoft.com/en-us/library/ms537343%28v=vs.85%29.aspx]
>  
> [https://blogs.msdn.microsoft.com/ieinternals/2013/09/17/a-quick-look-at-p3p/]
> 

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-09-23 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625046#comment-16625046
 ] 

Taher Alkhateeb commented on OFBIZ-10515:
-

The way I recommend refactoring the userImpersonate is by dividing work into 
specialized areas. This function has too many if this then that blocks followed 
by a big try / catch block. So here are some ideas that might be helpful:
 * Try to put all the data preparation logic in one place / function
 * Try to put all the validation logic in one function, perhaps it would return 
a boolean or a string
 * Try to put the failing of the services from validation errors (returning 
different error messages) in one place.
 * Try to construct the returned data in one place.
 * Minimize the scope of try / catch to the essentials / mandatory things.

So in essence, you would ideally have one place for preparing data, one place 
for validation, one place for failing, and one place for the logic of building 
the service returned data.

> Impersonation of userLogin feature
> --
>
> Key: OFBIZ-10515
> URL: https://issues.apache.org/jira/browse/OFBIZ-10515
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: ImpersonationWidget.png, OFBIZ-10515.patch, 
> OFBIZ-10515.patch, OFBIZ-10515.patch, OFBIZ-10515.patch, OFBIZ-10515.patch, 
> impersonate-ico.png, impersonateButton.png
>
>
> This JIRA introduce a new feature that allow the impersonation of a login by 
> an authorized user.
> This is implemeted with :·
> * A new service ‘userImpersonate’ that will check security, store 
> impersonation in UserLoginHistory, and return the new session
> * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow 
> impersonation/depersonation action persisting current user session
> * A new modal widget in the common-theme that inform the user about 
> ‘impersonation in process’ and offering a way to depersonate.
> * A new field in UserLoginHistory to store impersonation originator
> * A button in party viewprofile page to illustrate the feature



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10585) Production run not created for marketing package auto type product if component inventory is not available

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625004#comment-16625004
 ] 

Pierre Smits commented on OFBIZ-10585:
--

Please set 'Affects Version' field and the Component fieldto correct values as 
this is regarded a bug. Without such values it is difficult for adopters to 
determine whether it affects the version they have implemented and it makes it 
difficult for contributors to apply it to all (correct) maintenance branches 
and the correct component.

> Production run not created for marketing package auto type product if 
> component inventory is not available
> --
>
> Key: OFBIZ-10585
> URL: https://issues.apache.org/jira/browse/OFBIZ-10585
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Yashwant Dhakad
>Priority: Major
>
> When we create an order for marketing package auto, the system checks the 
> component inventory and if found then it creates the production run job and 
> produce marketing package inventory, but if component quantity not available 
> then it does not create the job. So if we don't have an inventory item of 
> component then production run should be created with created status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9612) Documentation: Order Fulfillment User Stories, Use Cases and Test Cases

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624998#comment-16624998
 ] 

Pierre Smits commented on OFBIZ-9612:
-

Please set 'Affects Version'  and 'Component' field to correct values as this 
is regarded a bug. Without such values it is difficult for adopters to 
determine whether it affects the version they have implemented and it makes it 
difficult for contributors to apply it to all (correct) maintenance branches 
and the correct component(s).

> Documentation: Order Fulfillment User Stories, Use Cases and Test Cases
> ---
>
> Key: OFBIZ-9612
> URL: https://issues.apache.org/jira/browse/OFBIZ-9612
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sonal Patwari
>Priority: Major
>  Labels: BPRB, Fulfillment, OBPRB, Order
>
> Order Fulfillment business process user stories, use cases and test cases to 
> be documented.
> *Doc Content*:
> Every Order Fulfillment business activity to be covered under below-given 
> headings-
> - User Story (Write, if doesn't exist already OR review and refine as 
> required)
> - Use Cases (Write, if don't exist already OR review and refine as required)
> - Test Cases (Write, if don't exist already OR review and refine as required. 
> Verify every test case and mark it with appropriate status- PASS, FAIL).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10497) UI issues with select box for Classification Group on findparty page

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624999#comment-16624999
 ] 

Pierre Smits commented on OFBIZ-10497:
--

Please set 'Affects Version' field to correct values as this is regarded a bug. 
Without such values it is difficult for adopters to determine whether it 
affects the version they have implemented and it makes it difficult for 
contributors to apply it to all (correct) maintenance branches.

> UI issues with select box for Classification Group on findparty page
> 
>
> Key: OFBIZ-10497
> URL: https://issues.apache.org/jira/browse/OFBIZ-10497
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Anushi Gupta
>Priority: Trivial
> Attachments: EmptySelectbox.png, OFBIZ-10497.patch
>
>
> Steps to regenerate:
> Login to partymgr 
> ([https://demo-trunk.ofbiz.apache.org/partymgr/control/main).]
> Notice Classification Group field.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10373) UI/UX issues found with Find Agreements screen

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624997#comment-16624997
 ] 

Pierre Smits commented on OFBIZ-10373:
--

Please set 'Affects Version' field  and the 'Component' field to correct values 
as this is regarded a bug. Without such values it is difficult for adopters to 
determine whether it affects the version they have implemented and it makes it 
difficult for contributors to apply it to all (correct) maintenance branches 
and the correct component(s).

 

>  UI/UX issues found with Find Agreements screen
> ---
>
> Key: OFBIZ-10373
> URL: https://issues.apache.org/jira/browse/OFBIZ-10373
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/FindAgreement?fromDate_fld1_op=opLessThan=thruDate=Y_ic=Y_fld0_op=equals_op=contains
>Reporter: Aayush jain
>Assignee: Pritam Kute
>Priority: Trivial
> Attachments: OFBIZ-10373.patch, UI UX Issues.png
>
>
> Following UI/UX issues found with Find Agreements screen:
> 1. Create a new agreement and navigate to find agreements page and check for 
> from date on the newly created agreement. It is displayed in Red color, there 
> should be a color consistency on the screen. ( When we edit a date to 
> back-date is works fine)
> 2.  Behavior of Cancel button is not proper ( On find agreements page, Click 
> on Cancel button to cancel any of the active agreement, it will set a through 
> date. But Cancel button is still been displayed and the user is allowed to 
> cancel any kind of agreement multiple time with a success message). The 
> application should not be allowed to cancel already canceled agreement. I 
> think no process happens on click on cancel button again and again, but a 
> success message is displayed on the screen. Cancel button can be disabled for 
> already canceled agreements.
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/webtools
> 2. Navigate to Agreements
> 3. Check for Issues
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10238) Last 3 Months Sales Report not Working

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624995#comment-16624995
 ] 

Pierre Smits commented on OFBIZ-10238:
--

Please set 'Affects Version' field and the 'component'  field to correct values 
as this is regarded a bug. Without such values it is difficult for adopters to 
determine whether it affects the version they have implemented and it makes it 
difficult for contributors to apply it to all (correct) maintenance branches 
and the correct components.

> Last 3 Months Sales Report not Working 
> ---
>
> Key: OFBIZ-10238
> URL: https://issues.apache.org/jira/browse/OFBIZ-10238
> Project: OFBiz
>  Issue Type: Bug
> Environment: demo-trunk.ofbiz.apache.org/
>Reporter: Aayush jain
>Priority: Major
> Attachments: 
> screencapture-demo-trunk-ofbiz-apache-org-ordermgr-control-Last3MonthsSalesReport-pdf-1519472089670.png
>
>
> Steps:
>  # Open URL 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions]
>  # Navigate to Last 3 Months Sales Report
>  # Click on Run Button
> Actual: No data found, displaying an Empty Report
>  
> Kindly refer attachment for the same. Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9513) Not able to change Portal Page Sequence on preferences section of SFA Component

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624996#comment-16624996
 ] 

Pierre Smits commented on OFBIZ-9513:
-

Please set 'Affects Version' field to correct values as this is regarded a bug. 
Without such values it is difficult for adopters to determine whether it 
affects the version they have implemented and it makes it difficult for 
contributors to apply it to all (correct) maintenance branches.

> Not able to change Portal Page Sequence on preferences section of SFA 
> Component
> ---
>
> Key: OFBIZ-9513
> URL: https://issues.apache.org/jira/browse/OFBIZ-9513
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Parakh Maheshwari
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: OFBIZ-9513.patch, screenshot-1.png
>
>
> Here are the steps to generate the issue:
> 1.Navigate to  
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main?externalLoginKey=ELa07b118d-1e90-421a-adae-f7ab0b5bbe22].
> 2.Click on Preferences link in 
> sub-menu.[https://demo-trunk.ofbiz.apache.org/sfa/control/ManagePortalPages?parentPortalPageId=SFA_MAIN].
> 3.If there is a single portal page, then create more than one page to 
> generate the issue.
> 4.Click on the green arrow button on any page to change its sequence, It show 
> error message on screen.
> Note All the arrow buttons are not working (whether It is single step down or 
> multiple step down or up button)
> I am also attaching the screenshot for the same. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9475) Refactor serialize and non-serialize inventory item implementaion

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624994#comment-16624994
 ] 

Pierre Smits commented on OFBIZ-9475:
-

Please set 'Components' field to the correct values.

> Refactor serialize and non-serialize inventory item implementaion
> -
>
> Key: OFBIZ-9475
> URL: https://issues.apache.org/jira/browse/OFBIZ-9475
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Yashwant Dhakad
>Priority: Major
> Attachments: OFBIZ-9475.patch, OFBIZ-9475.patch, OFBIZ-9475.patch, 
> OFBIZ-9475.patch
>
>
> As discussed on dev mailing list [1][2] we need to refactor serialize and 
> non-serialize inventory item design.
> As per current implementation serialize inventory item work on status and 
> non-serialized inventory item work on inventory item detail.
> Proposed Design:
> - Use inventory item detail for both serialise and non-serialize inventory 
> item. Only one additional condition for serialized inventory item that qoh 
> can't be greater then one.
> - We can maintain inventory item status record for both type
> [1] http://markmail.org/thread/bd2bpiv6c5wvl7km
> [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7
> As we do a lot of discussion in the respective mail threads.
> [1] http://markmail.org/thread/bd2bpiv6c5wvl7km
> [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7
> According to this email threads, I conclude that:-
> There are 2 types of the inventory item in OFBiz.
> 1. *Serialized*
> 2. *Non serialized*
> Majorly there are 3 entities to manage the various transaction of serialised 
> and non-serialized inventory items.
> 1. _InventoryItem_
> 2. _InventoryItemDetail_
> 3. _InventoryItemStatus_
> Following changes need to be done in the workflow of inventory item records:-
> 1) There is no need to manage a different workflow for serialised and non- 
> serialised inventory items.
> 2) Transaction of serialised and non-serialised inventory item should be 
> managed in both InventoryItemStatus and InventoryItemDetail entity.
>  a) Transaction of serialised inventory items is managed by 
> inventoryItemstatus entity not managed in inventoryItemDetail entity. While 
> inventoryItemDetail and inventoryItemStatus should be managed for both 
> serialised and non-serialised inventory items.
>  b) As ATP/QOH/AQT are updated on the basis of ATPDIFF/QOHDIFF/AQTDIFF in 
> non-serialised inventory item. We should follow the same pattern for 
> serialised inventory item.
>  c) Change in ATP/QOH/AQT is tracked by inventoryItemDetail entity.
>  d)Status transaction of an inventory item is tracked in 
> InventoryItemStatus entity.
> 3) No need to manage separate status for serialised and non-serialised 
> inventory item. They are already distinguished on the basis of inventory item 
> type.
> 1. *Serialised*:-
> In a serialised inventory item as of now ATP/QOH/AQT are managed on the 
> basis of inventory item status.While  ATP/QOH/AQT should be the sum of 
> ATPDIFF/QOHDIFF/AQTDIFF of inventory item detail.
> Ex:
> 1. If we receive 2 inventory of serialised inventory item then 2 separate 
> inventory item records are created
> InventoryItem:-
> inventoryItemId="10001",status="AVAILABLE", ATP="1", QOH="1",AQT="1"
> inventoryItemId="10002",status="AVAILABLE", ATP="1", QOH="1",AQT="1"
> InventoryItemDetail:-
> inventoryItemId="10001", inventoryItemDetailSeqId="10001", ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> inventoryItemId="10002", inventoryItemDetailSeqId="10002", ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> InventoryItemStatus:-
> inventoryItemId="10001" statusId="AVAILABLE" 
> inventoryItemId="10002" statusId="AVAILABLE" 
> 2. If status of inventory item is changed from AVAILABLE -> PROMISED then 
> InventoryItem:-
> inventoryItemId="10001",status="PROMISED", ATP="1", QOH="1",AQT="1"
> inventoryItemId="10002",status="AVAILABLE", ATP="1", QOH="1",AQT="1"
> InventoryItemDetail:-
> inventoryItemId="10001", inventoryItemDetailSeqId="10001",  ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> inventoryItemId="10001", inventoryItemDetailSeqId="10002",  ATPDIFF="-1", 
> QOHDIFF="0", AQTDIFF="0"
> inventoryItemId="10002", inventoryItemDetailSeqId="10002",  ATPDIFF="1", 
> QOHDIFF="1", AQTDIFF="1"
> InventoryItemStatus:-
> inventoryItemId="10001" statusId="AVAILABLE" statusEndDateTime=""
> inventoryItemId="10002" statusId="PROMISED" 
> 2. *Non-serialised*:-
> At the time of receive non-serialised inventory, Item should be received 
> in Available status. So that status of non-serialised inventory item can be 
> managed further.
> Status of non-serialised inventory item should be managed at inventory 
> item level not on inventory item detail level i.e. there are limited 

[jira] [Commented] (OFBIZ-9743) updateContent service does not return an error/success message

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624991#comment-16624991
 ] 

Pierre Smits commented on OFBIZ-9743:
-

Please set 'Affects Version' field to correct values as this is regarded a bug. 
Without such values it is difficult for adopters to determine whether it 
affects the version they have implemented and it makes it difficult for 
contributors to apply it to all (correct) maintenance branches.

> updateContent service does not return an error/success message 
> ---
>
> Key: OFBIZ-9743
> URL: https://issues.apache.org/jira/browse/OFBIZ-9743
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Devanshu Vyas
>Priority: Major
>
> 1. Go to Content,
> 2. Click on Find in the search options to get a list of all the contents in 
> the system.
> 3. Select a content from the list of content.
> 4. Edit Content form should get opened.
> 5. Click on update, the user is not presented with success or error message 
> on the screen.
> Although, the service works and the content gets updated.
> Here is a link to the issue,
> https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10313) Capture Transactions are still displayed as Authorize

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624992#comment-16624992
 ] 

Pierre Smits commented on OFBIZ-10313:
--

Please set 'Affects Version' and the component field to correct values as this 
is regarded a bug. Without such values it is difficult for adopters to 
determine whether it affects the version they have implemented and it makes it 
difficult for contributors to apply it to all (correct) maintenance branches, 
or the right component(s).

> Capture Transactions are still displayed as Authorize
> -
>
> Key: OFBIZ-10313
> URL: https://issues.apache.org/jira/browse/OFBIZ-10313
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Humera Khan
>Priority: Major
>
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses
> 2. Navigate to Transactions with Authorize
> 3. Try to Capture payment
> 4. Again navigate to FindGatewayResponses and check for transaction
> Actual Result:
> The transaction still displayed with Authorize status and no update on 
> payment capture
> Expected Result:
> Correct status of transaction should be displayed (Capture/Authorize)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10309) HTTP Status 500 – Internal Server Error on InvoiceAcctgTransEntriesPdf

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624990#comment-16624990
 ] 

Pierre Smits commented on OFBIZ-10309:
--

Please set 'Affects Version' field to correct value as this is regarded a bug. 
Without such values it is difficult for adopters to determine whether it 
affects the version they have implemented and it makes it difficult for 
contributors to apply it to all (correct) maintenance branches.

> HTTP Status 500 – Internal Server Error on InvoiceAcctgTransEntriesPdf
> --
>
> Key: OFBIZ-10309
> URL: https://issues.apache.org/jira/browse/OFBIZ-10309
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: https://demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Humera Khan
>Priority: Major
>
> Steps:
> 1. Open URL 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices]
> 2. Navigate to Find Invoices
> 3. Click on Any Invoice id
> 4. Click on AcctgTransEntriesPdf
>  
> Actual Result:
> HTTP Status 500 – Internal Server Error Type Status Report Message ERROR 
> rendering error page [/error/error.jsp], but here is the error text: 
> org.eclipse.birt.report.engine.api.EngineException Error happened while 
> running the report. Description The server encountered an unexpected 
> condition that prevented it from fulfilling the request. Apache Tomcat/8.5.24
> Expected Result:
> AcctgTransEntriesPdf button should work as expected.
> Thanks in Advance!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9894) Dropdown dependent mechanism should be there while selecting any Sales Forecast detail

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624989#comment-16624989
 ] 

Pierre Smits commented on OFBIZ-9894:
-

This is already a quite old ticket. Please set 'Affects Version' and Component' 
field to correct values as this is regarded a bug. Without such values it is 
difficult for adopters to determine whether it affects the version they have 
implemented and it makes it difficult for contributors to apply it to all 
(correct) maintenance branches.

> Dropdown dependent mechanism should be there while selecting any Sales 
> Forecast detail
> --
>
> Key: OFBIZ-9894
> URL: https://issues.apache.org/jira/browse/OFBIZ-9894
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Sonal Patwari
>Priority: Major
>
> Navigate to SFA component and on Sales Forecast screen, after creating a 
> forecast when we add forecast details, it allows us to add any of the fields 
> separately without depending on the other fields. 
> Expected result: There should be a dependency while selecting forecast 
> details.
> For example, While adding quantity, quantity UOM field should be dependent 
> and vice versa should also be possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624986#comment-16624986
 ] 

Pierre Smits commented on OFBIZ-10366:
--

Please do not forget to set the component it affects when creating the ticket?

Does this bug only apply to trunk? Or does it also affect any release branch 
currently in maintenance?

> Proper User friendly message should visible at Create Inventory Transfer 
> screen
> ---
>
> Key: OFBIZ-10366
> URL: https://issues.apache.org/jira/browse/OFBIZ-10366
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-10366.png
>
>
> Steps to regenerate:
>  # Go to facility component.
>  # Select any facility.
>  # Click on Inventory Xfers.
>  # Now click on Inventory Transfer to create new Inventory Transfer.
>  # Now add any product id and submit
>  # At "Quantity To Transfer" field add quantity more than ATP.
>  # See the error message. PFA for error message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624985#comment-16624985
 ] 

Pierre Smits commented on OFBIZ-10366:
--

Are we to understand (from the image attached) that the quantity to transfer is 
8 units? And that there are 50 units in stock? Or that the quantity to transfer 
is 50 and there are only 8 units in stock?

> Proper User friendly message should visible at Create Inventory Transfer 
> screen
> ---
>
> Key: OFBIZ-10366
> URL: https://issues.apache.org/jira/browse/OFBIZ-10366
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-10366.png
>
>
> Steps to regenerate:
>  # Go to facility component.
>  # Select any facility.
>  # Click on Inventory Xfers.
>  # Now click on Inventory Transfer to create new Inventory Transfer.
>  # Now add any product id and submit
>  # At "Quantity To Transfer" field add quantity more than ATP.
>  # See the error message. PFA for error message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10581) In country input box, Input type not verified while requesting for a new account.

2018-09-23 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624981#comment-16624981
 ] 

Pierre Smits commented on OFBIZ-10581:
--

Against what will it be verified?

 

> In country input box, Input type not verified while requesting for a new 
> account.
> -
>
> Key: OFBIZ-10581
> URL: https://issues.apache.org/jira/browse/OFBIZ-10581
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Rajat Temaniya
>Priority: Major
> Attachments: Screen Shot 2018-09-22 at 4.13.40 PM.png
>
>
> Follow the process to find this issue:
> 1) Go to this link [ 
> [https://demo-trunk.ofbiz.apache.org/webtools/control/main|https://www.google.com/url?q=https://demo-trunk.ofbiz.apache.org/webtools/control/main=D=hangouts=153770510500=AFQjCNEEwMlYPP50NOAEQg5SRakR6-9sww]
>  ].
>  2) Fill the required information about user.
>  3) GO to the phone number  inside the country input box must be  verified 
> it's input.
>      like: Type, Length
> Issue:- Right now its taking any type without verifying.
> Please find attachment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)