[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686138#comment-16686138 ] Jacques Le Roux commented on OFBIZ-10303: - Thanks Olivier, I'm considering to work more on an AsciiDoc generated online documentation (see [this thread|[https://markmail.org/message/nujdq5rmegcg3p4z])] This seems quite useful for new commers and even in some cases for seasoned developers. > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: humanres.adoc.patch, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409194#comment-16409194 ] Jacques Le Roux edited comment on OFBIZ-10303 at 11/14/18 6:39 AM: --- Thanks [~holivier], I'll take a look at this patch as a start. Just for information, myself and [~cparker] started putting together a global glossary at https://cwiki.apache.org/confluence/display/OFBENDUSER/Glossary was (Author: sharan ): Thanks [~holivier], I'll take a look at this patch as a start. Just for information, myself and [~cparker] started putting together a global glossary [[https://cwiki.apache.org/confluence/display/OFBENDUSER/Glossary].|https://cwiki.apache.org/confluence/display/OFBENDUSER/Glossary] > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: humanres.adoc.patch, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10300) Convert Minilang to Groovy Guide into asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686135#comment-16686135 ] Jacques Le Roux commented on OFBIZ-10300: - Hi Benjamin, There is an issue applying your patch on developer-manual.adoc (trunk HEAD), please update before creating the patch, thanks. Somehow related, we refer to "Release 17.12" in the main *.adoc files but those files are not present in the R17 branch. Anyway I'll start a discussion about that on dev ML. > Convert Minilang to Groovy Guide into asciidoc > --- > > Key: OFBIZ-10300 > URL: https://issues.apache.org/jira/browse/OFBIZ-10300 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: > OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc.patch > > > Convert [~Dennis Balkir]s [Minilang to Groovy > Guide|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+From+Mini+Language+to+Groovy] > into AsciiDoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc
[ https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686128#comment-16686128 ] Jacques Le Roux commented on OFBIZ-10647: - The blog post will be updated when the AsciiDoc online generated will be available. I'll then close this issue. > Convert Birt component doc from Markdown to AsciiDoc > - > > Key: OFBIZ-10647 > URL: https://issues.apache.org/jira/browse/OFBIZ-10647 > Project: OFBiz > Issue Type: Improvement > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], > convert Birt component doc from Markdown to AsciiDoc. > While doing so move images from > [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] > to source and update the > [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a]. > And finally remove the "Birt Flexible Reports" wiki page (and entries in > updateWiki.bat) when we will automatically generate the documentation from > Buildbot. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc
[ https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686125#comment-16686125 ] Jacques Le Roux commented on OFBIZ-10647: - Lines generating the HTML files used in the "Birt Flexible Reports" wiki page have been removed at revision: 1846565 > Convert Birt component doc from Markdown to AsciiDoc > - > > Key: OFBIZ-10647 > URL: https://issues.apache.org/jira/browse/OFBIZ-10647 > Project: OFBiz > Issue Type: Improvement > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], > convert Birt component doc from Markdown to AsciiDoc. > While doing so move images from > [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] > to source and update the > [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a]. > And finally remove the "Birt Flexible Reports" wiki page (and entries in > updateWiki.bat) when we will automatically generate the documentation from > Buildbot. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10300) Convert Minilang to Groovy Guide into asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10300: --- Assignee: Jacques Le Roux (was: Benjamin Jugl) > Convert Minilang to Groovy Guide into asciidoc > --- > > Key: OFBIZ-10300 > URL: https://issues.apache.org/jira/browse/OFBIZ-10300 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: > OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc.patch > > > Convert [~Dennis Balkir]s [Minilang to Groovy > Guide|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+From+Mini+Language+to+Groovy] > into AsciiDoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc
[ https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685632#comment-16685632 ] Jacques Le Roux commented on OFBIZ-10647: - First step done at revision: 1846531 > Convert Birt component doc from Markdown to AsciiDoc > - > > Key: OFBIZ-10647 > URL: https://issues.apache.org/jira/browse/OFBIZ-10647 > Project: OFBiz > Issue Type: Improvement > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], > convert Birt component doc from Markdown to AsciiDoc. > While doing so move images from > [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] > to source and update the > [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a]. > And finally remove the "Birt Flexible Reports" wiki page (and entries in > updateWiki.bat) when we will automatically generate the documentation from > Buildbot. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc
[ https://issues.apache.org/jira/browse/OFBIZ-10647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10647: Description: Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], convert Birt component doc from Markdown to AsciiDoc. While doing so move images from [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] to source and update the [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a]. And finally remove the "Birt Flexible Reports" wiki page (and entries in updateWiki.bat) when we will automatically generate the documentation from Buildbot. was: Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], convert Birt component doc from Markdown to AsciiDoc. While doing so move images from [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] to source and update the [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a] > Convert Birt component doc from Markdown to AsciiDoc > - > > Key: OFBIZ-10647 > URL: https://issues.apache.org/jira/browse/OFBIZ-10647 > Project: OFBiz > Issue Type: Improvement > Components: birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], > convert Birt component doc from Markdown to AsciiDoc. > While doing so move images from > [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] > to source and update the > [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a]. > And finally remove the "Birt Flexible Reports" wiki page (and entries in > updateWiki.bat) when we will automatically generate the documentation from > Buildbot. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10647) Convert Birt component doc from Markdown to AsciiDoc
Jacques Le Roux created OFBIZ-10647: --- Summary: Convert Birt component doc from Markdown to AsciiDoc Key: OFBIZ-10647 URL: https://issues.apache.org/jira/browse/OFBIZ-10647 Project: OFBiz Issue Type: Improvement Components: birt Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch Following [this thread|https://markmail.org/message/nujdq5rmegcg3p4z], convert Birt component doc from Markdown to AsciiDoc. While doing so move images from [wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Birt+Flexible+Reports] to source and update the [blog|https://blogs.apache.org/ofbiz/entry/the-birt-flexible-reports-a] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6436) Different price Order vs. Invoice due rounding
[ https://issues.apache.org/jira/browse/OFBIZ-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685252#comment-16685252 ] Ingo Wolfmayr commented on OFBIZ-6436: -- I have updated the patch in case someone needs it. Another use case for it: if webpos is used with sales tax (added on product level) it may happen that the amount to be payed is rounded with 3 digits. As the payment amount must be equal with the price shown it is a problem. Without the patch the amount is rounded when creating the order which is one step to late for the webpos case. The issue with the invoice still applies. > Different price Order vs. Invoice due rounding > -- > > Key: OFBIZ-6436 > URL: https://issues.apache.org/jira/browse/OFBIZ-6436 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Major > Attachments: ofbiz.patch, priceservices.patch > > > When creating an order with the following data, invoice and order calculates > different prices due to different rounding strategies: > Example: > Net price: 8,70 > Price Rule: 2 % > Calc price: 8,526 > Order quantity: 2 > Rounding order: 2 dec > Rounding invoice: 2 dec > Both: ROUND_HALF_UP > Calculation for order price: > 8,526 * 2 = 17,052 --> Rouning = 17,05 (rounding takes place after multipying > with the order quantity ) > Calculation for invoice price: > 8,53 * 2 = 17,06 (rounding takes place before multipying with the order > quantity) > Rounding takes place on different places and leads to (from my understanding) > misscalculation. > I create a patch that applies rounding on PriceCalculation level. Therefore: > 1) get singe unit price and do all calculations on it (Price rules ...) > 2) before forwarding the price, apply rounding (ORDER SETTINGS) on single > unit price > As the invoice calculation uses the unit price (if invoice is associate with > order) from ORDER_ITEM it will calculate with the already rounded value. > Result: Order Price = Invoice Price > I would appreciate any thought on it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-6436) Different price Order vs. Invoice due rounding
[ https://issues.apache.org/jira/browse/OFBIZ-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-6436: - Attachment: ofbiz.patch > Different price Order vs. Invoice due rounding > -- > > Key: OFBIZ-6436 > URL: https://issues.apache.org/jira/browse/OFBIZ-6436 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Major > Attachments: ofbiz.patch, priceservices.patch > > > When creating an order with the following data, invoice and order calculates > different prices due to different rounding strategies: > Example: > Net price: 8,70 > Price Rule: 2 % > Calc price: 8,526 > Order quantity: 2 > Rounding order: 2 dec > Rounding invoice: 2 dec > Both: ROUND_HALF_UP > Calculation for order price: > 8,526 * 2 = 17,052 --> Rouning = 17,05 (rounding takes place after multipying > with the order quantity ) > Calculation for invoice price: > 8,53 * 2 = 17,06 (rounding takes place before multipying with the order > quantity) > Rounding takes place on different places and leads to (from my understanding) > misscalculation. > I create a patch that applies rounding on PriceCalculation level. Therefore: > 1) get singe unit price and do all calculations on it (Price rules ...) > 2) before forwarding the price, apply rounding (ORDER SETTINGS) on single > unit price > As the invoice calculation uses the unit price (if invoice is associate with > order) from ORDER_ITEM it will calculate with the already rounded value. > Result: Order Price = Invoice Price > I would appreciate any thought on it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10611) Allow unit tests to be written in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684890#comment-16684890
]
Mathieu Lirzin commented on OFBIZ-10611:
Indeed, I am glad you spotted it early :)
> Allow unit tests to be written in Groovy
>
>
> Key: OFBIZ-10611
> URL: https://issues.apache.org/jira/browse/OFBIZ-10611
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10611_Allow-unit-tests-to-be-written-in-Groovy.patch
>
>
> Since OFBIZ-9996 it is possible to write integration tests in Groovy, meaning
> test that depend on the dispatcher and the delegator. It would be nice if the
> unit tests could be written in Groovy too.
> The major benefit of writing tests in Groovy is that you create inputs and
> expected outputs more easily with objects literals. For example the following
> java code:
> {code:java}
> Map input = new HashMap<>();
> input.put("foo", 42);
> input.put("bar", 37);
> {code}
> can be rewritten in Groovy like this:
> {code:java}
> def input = [foo: 42, bar: 37]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
