[jira] [Commented] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-21 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694542#comment-16694542
 ] 

Pierre Smits commented on OFBIZ-6958:
-

Also, in the spirit of collaboration, you could have worked the issue yourself 
instead of just chucking it over the wall. 

> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-21 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6958:
---

Assignee: Pierre Smits  (was: Jacques Le Roux)

> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-21 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694541#comment-16694541
 ] 

Pierre Smits commented on OFBIZ-6958:
-

HI [~suraj.khurana],

It seems you have found a bug in the code that is related to this 'closed' 
ticket. Instead of reopening this old ticket (and reassigning it without prior 
consultation and consent of past and newly assigned assignee) it would have 
been better to open a new ticket and reference this one. 

Nevertheless, I will take care of it.

Best regards,

Pierre

> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-6958) Adding event definitions for inbound and outbound shipments

2018-11-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reopened OFBIZ-6958:
--
  Assignee: Jacques Le Roux  (was: Pierre Smits)

Hi,

I think there is a typo in the patch INGOING_SHIPMENT is there instead of 
INCOMING_SHIPMENT.
No such type exists in OFBiz.

[~jacques.le.roux], Can you please take care of it.

Thanks in advance !!

> Adding event definitions for inbound and outbound shipments
> ---
>
> Key: OFBIZ-6958
> URL: https://issues.apache.org/jira/browse/OFBIZ-6958
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product, workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: purpose, shipment, workeffort
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6958-ShipmentServices.xml.patch, 
> OFBIZ-6958-WorkEffortTypeData.xml.patch
>
>
> When inbound and outbound shipments are registered also WorkEffort records 
> are persisted. 
> * This action doesn't set the workEffortPurposeTypeId for the created work 
> efforts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10553) Convert QuoteServices.xml mini lang to groovy

2018-11-21 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin reassigned OFBIZ-10553:
--

Assignee: Mathieu Lirzin  (was: Nicolas Malin)

> Convert QuoteServices.xml mini lang to groovy
> -
>
> Key: OFBIZ-10553
> URL: https://issues.apache.org/jira/browse/OFBIZ-10553
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Antoine Ouvrard
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments: OFBIZ-10553.patch
>
>
> This is an attempt to migrate QuoteServices.xml to groovy file version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10553) Convert QuoteServices.xml mini lang to groovy

2018-11-21 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin reassigned OFBIZ-10553:
--

Assignee: Nicolas Malin  (was: Mathieu Lirzin)

> Convert QuoteServices.xml mini lang to groovy
> -
>
> Key: OFBIZ-10553
> URL: https://issues.apache.org/jira/browse/OFBIZ-10553
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Antoine Ouvrard
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-10553.patch
>
>
> This is an attempt to migrate QuoteServices.xml to groovy file version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694393#comment-16694393
 ] 

Jacques Le Roux commented on OFBIZ-4160:


Hi [~bjugl]

Before I commit could you please confirm you tested and use this feature?


> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: VAT, tax
> Attachments: OFBIZ-4160_shipping_tax.patch, 
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is 
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not 
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see 
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)