[jira] [Commented] (OFBIZ-10500) Tax calculation incorrect when creating orders

2018-11-25 Thread Frank Herrman (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698586#comment-16698586
 ] 

Frank Herrman commented on OFBIZ-10500:
---

Hi [~ankush.upadhyay] , thank you for looking into it. In hindsight I think it 
is related to the 'show prices including tax' option in the store settings. If 
you put that to 'yes' it is incorrect.

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Invoice.png, Schermafbeelding 2018-07-30 om 
> 10.15.51.png, Schermafbeelding 2018-07-30 om 10.16.16.png, VAT.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{ applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9768) While converting the lead, it redirects to the Create Party Relationship in SFA component

2018-11-25 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698215#comment-16698215
 ] 

Suraj Khurana commented on OFBIZ-9768:
--

Thanks Lalit for your contribution.

I will wait for some days incase of any concerns, and then proceed.

> While converting the lead, it redirects to the Create Party Relationship in 
> SFA component
> -
>
> Key: OFBIZ-9768
> URL: https://issues.apache.org/jira/browse/OFBIZ-9768
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 13.07, Trunk, Release Branch 16.11, 
> Release Branch 17.12
>Reporter: Rubia Elza Joshep
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-9768.patch, screenshot-1.png, screenshot-2.png
>
>
> Steps to regenerate:
> 1) Open URL 
> https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?roleTypeId=LEAD=10007
> 2) Click on Convert lead and select the related company and click on Add.
> 3) It redirects to the Create Party Relationship.
> Expected: It should redirect to the Lead conversion page since the company is 
> associated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10580) Classification group filter not working on find party screen

2018-11-25 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698216#comment-16698216
 ] 

Suraj Khurana commented on OFBIZ-10580:
---

Thanks Saurabh for your contribution.

I will wait for few days incase of any concerns, and then proceed.

> Classification group filter not working on find party screen
> 
>
> Key: OFBIZ-10580
> URL: https://issues.apache.org/jira/browse/OFBIZ-10580
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Anushi Gupta
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10580.patch
>
>
> Steps to regenerate:
>  # Login to 
> partymgr([[https://demo-trunk.ofbiz.apache.org/partymgr/control/findparty])]
>  # Select classification group (if present, otherwise create new group) and 
> find party
> Actual :
> All parties are listed on searching
> Expected :
> Parties which are under the selected classification group should only be 
> listed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10588) Incorrect PartyContactMechPurpose created while calling createUpdateBillingAddress service

2018-11-25 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10588:
--
Attachment: OFBIZ-10588.patch

> Incorrect PartyContactMechPurpose created while calling 
> createUpdateBillingAddress service
> --
>
> Key: OFBIZ-10588
> URL: https://issues.apache.org/jira/browse/OFBIZ-10588
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10588.patch
>
>
> createUpdateBillingAddress and createUpdateShippingAddress services create 
> incorrect PartyContactMechPurpose records with userLogin.partyId.
> These services works well in case of when e-commerce logged-in user perform 
> these operation. But in-correct data is created by these services if called 
> from admin or any other user.
> Need to check relevant code and fix it.
> I called createUpdateBillingAddress service from webtools and and didn't get 
> desired results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2018-11-25 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698208#comment-16698208
 ] 

Suraj Khurana commented on OFBIZ-10579:
---

Hi [~mthl],

Pardon me for the late response.

Idea here is to notify the developer that hey! you have used cache and 
filterByDate both which is not going to create any impact, so we log a message 
while using entityListCache#put method.

Hope that helps.

Thanks !!

> Date filtered queries with caching should be restricted to cache
> 
>
> Key: OFBIZ-10579
> URL: https://issues.apache.org/jira/browse/OFBIZ-10579
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698204#comment-16698204
 ] 

Pritam Kute edited comment on OFBIZ-10457 at 11/25/18 3:34 PM:
---

Thanks [~mbrohl]. You got it right. The patch contains the generic changes 
which can be pushed to the codebase. The plugin contains all the specific code 
need to write to push messages to the gateway server.

Thanks [~pfm.smits] for your review. Msg91 API can send the SMS all over the 
world. I haven't tested it but [API 
documentation|https://help.msg91.com/article/76-how-to-send-sms-worldwide] 
claims that. I can push some more plugins to show how this generic code can 
work with popular SMS gateways like [Textlocal|https://www.textlocal.in/] and 
[Twilio|https://www.twilio.com/].

I have used the implementation flow similar to payment gateway integration in 
OFBiz. The "Msg91GatewayConfig" entity is similar to "PaymentGatewayPayPal" 
entity.


was (Author: pritam.kute):
Thanks [~mbrohl]. You got it right. The patch contains the generic changes 
which can be pushed to the codebase. The plugin contains all the specific code 
need to write to push messages to the gateway server.

Thanks [~pfm.smits] for your review. Msg91 API can send the SMS all over the 
world I haven't tested it but [API 
documentation|https://help.msg91.com/article/76-how-to-send-sms-worldwide] 
claims that. I can push some more plugins to show how this generic code can 
work with popular SMS gateways like [Textlocal|https://www.textlocal.in/] and 
[Twilio|https://www.twilio.com/].

I have used the implementation flow similar to payment gateway integration in 
OFBiz. The "Msg91GatewayConfig" entity is similar to "PaymentGatewayPayPal" 
entity.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10457:

Attachment: mobile-screenshot.jpeg

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, mobile-screenshot.jpeg, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698204#comment-16698204
 ] 

Pritam Kute commented on OFBIZ-10457:
-

Thanks [~mbrohl]. You got it right. The patch contains the generic changes 
which can be pushed to the codebase. The plugin contains all the specific code 
need to write to push messages to the gateway server.

Thanks [~pfm.smits] for your review. Msg91 API can send the SMS all over the 
world I haven't tested it but [API 
documentation|https://help.msg91.com/article/76-how-to-send-sms-worldwide] 
claims that. I can push some more plugins to show how this generic code can 
work with popular SMS gateways like [Textlocal|https://www.textlocal.in/] and 
[Twilio|https://www.twilio.com/].

I have used the implementation flow similar to payment gateway integration in 
OFBiz. The "Msg91GatewayConfig" entity is similar to "PaymentGatewayPayPal" 
entity.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698122#comment-16698122
 ] 

Michael Brohl commented on OFBIZ-10457:
---

I only had a brief look but my basic understanding of the approach is that we 
have generic functionality in the framework (configuration, productstore 
setiings etc.), see patch.

The specific SMS providers will then be provided as a plugin. In this case, the 
plugin is specifically for the msg91 provider. This way you only use the plugin 
for a provider you need.

If you need another one you'll have to write the integration code for it.

This looks good to my in the overview (no in depth review from my side yet).

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10661) Significant gaps reflecting in between Input values in the dropdown

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10661:
---

Assignee: Jacques Le Roux

> Significant gaps reflecting in between Input values in the dropdown
> ---
>
> Key: OFBIZ-10661
> URL: https://issues.apache.org/jira/browse/OFBIZ-10661
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
>Reporter: Archana Asthana
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: ValueDropdown.png
>
>
> Steps to Regenerate
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond
> 2. Add the name for a new Price Rule
> 3. While adding Condition, choose input as Party
> 4. Scroll down the end for Values reflecting in the dropdown
> *Actual: *
> Seems, Some of the parties are not listed in the dropdown.
> Significant gap is reflecting in between the values.
> The Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out

2018-11-25 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698117#comment-16698117
 ] 

Jacques Le Roux commented on OFBIZ-10666:
-

This is certainly related to OFBIZ-4959 and OFBIZ-10635. I'll have a look as 
soon as I get a chance. I'd not be upset if someone fix it before me ;)

> User's name is displayed on ecommerce even after user logs out
> --
>
> Key: OFBIZ-10666
> URL: https://issues.apache.org/jira/browse/OFBIZ-10666
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Garima jain
>Priority: Major
> Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, 
> 4-NotYou.png
>
>
> Steps to regenerate:
>  # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. 
> Welcome is displayed and user's name is not displayed when URL is opened. 
> (Please refer attachment: 1-OpenURL)
>  # Login at ecommerce by clicking on login and entering Username: "admin" and 
> Password: "ofbiz". Username will be displayed after user logs in. (Please 
> refer attachment: 2-LoggedIn)
>  # Logout of ecommerce by clicking on logout. User will be logged out and 
> login link will be displayed in place of logout link, but the name of user is 
> still displayed. (Please refer attachment: 3-LoggedOut)
> Actual: Username is still displayed after user logs out
>  
> Expected: Username should not be displayed after the user logs out
>  
> Note: Similar issue also exists when the user clicks on (Not You? Click Here) 
> link. (Please refer attachment: 4-NotYou)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9840.
--
   Resolution: Fixed
Fix Version/s: 16.11.06
   17.12.01

Thanks Aman,

Your patch is in

trunk r1847402

R17 & R16 r1847403

 

Thanks Julian for report.

 

> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
> Attachments: OFBIZ-9840.patch
>
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
> {{Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
> Composite Pdf}}
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9840:
---
Description: 
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
{{Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf}}

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}


  was:
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
{{  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf}}

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}



> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-9840.patch
>
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
> {{Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
> Composite Pdf}}
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9840:
---
Description: 
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}


  was:
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
  Content Manager-> CompDoc ->T ree-> View Instances-> Tree -> Generate 
Composite Pdf

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}



> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-9840.patch
>
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
>   Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
> Composite Pdf
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9840:
---
Description: 
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
{{  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf}}

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}


  was:
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}



> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-9840.patch
>
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
> {{  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
> Composite Pdf}}
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9840:
--

Assignee: Jacques Le Roux  (was: Aman Mishra)

> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-9840.patch
>
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
>   Content Manager-> CompDoc ->T ree-> View Instances-> Tree -> Generate 
> Composite Pdf
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698110#comment-16698110
 ] 

Pierre Smits commented on OFBIZ-10457:
--

Having done a cursory review of the artefacts in the attached zip file, I found:
 * that everything references a specific texting service provider (*msg91* - 
[https://msg91.com)|https://msg91.com)/] instead of using a generic functional 
name;
 * I could not find whether the service provider (Walkover Web Solutions Pvt. 
Ltd.) operates in other countries than only India;
 * a new entity is introduced (*Msg91*GatewayConfig),  which seems to be 
intended to capture (and deliver for the functions) the configuration aspects. 
This is unnecessary as such parameters can also be in the SystemProperty table.

Though I did not explore this thoroughly I doubt that this would work with 
other 3rd party SMS solutions. IMO, in order to have this incorporated in the 
code base some more effort should be applied to make it more generic and 
applicable to multiple 3rd party SMS solutions. Otherwise this is too 1party 
specific.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10542) Instructions for Configurable PC don't work

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10542.
---
   Resolution: Fixed
Fix Version/s: 16.11.06
   17.12.01

Thanks Priya,

This seems indeed the best solution. I wondered about 
{{question.content.get("IMAGE_URL", "url")}} but it's handled otherwise and 
it's OK.

Your patch is in 
trunk r1847398
R17 r1847399+1847400(plugins)
R16 r1847401

> Instructions for Configurable PC don't work
> ---
>
> Key: OFBIZ-10542
> URL: https://issues.apache.org/jira/browse/OFBIZ-10542
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01, 16.11.06
>
> Attachments: OFBIZ-10542-framework-trunk.patch, 
> OFBIZ-10542-plugins-trunk.patch, console-error.png
>
>
> This concerns only R16, R17 and the trunk. The "Instructions" button was not 
> present in R13. 
> This kind of message shows:
> Trunk:
>  class="btn btn-outline-secondary btn-sm">Instructions
> R16:
>  occurred","");"="" class="buttontext">Instructions
> The same exists for all configurable products, notably Gold Pizza



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2018-11-25 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698106#comment-16698106
 ] 

Pierre Smits commented on OFBIZ-8014:
-

In the latest patch a permission check is introduced for a menu item:
{code:java}
+
+
+
+
+
+
+
+
{code}
in generic business processes this role type is typically associated with the 
external parties where goods/services are ordered from (and delivered/supplied 
by). This is typically an entity that is registered with the Chamber of 
Commerce and the Tax Authority.

In OFBiz a party with this role type (most often a PartyGroup) ships to any of 
the internal parties and in accounting invoices from this party are registered 
as purchasing invoices and payments are registered as withdrawal payments. So 
such an external party would normally not have access to the internal functions 
of OFBiz. And if the party is indeed a PartyGroup, one could say that such an 
organisation should not have login credentials (only persons should have - if 
need be - login credentials).

With setting the permission to role type = SUPPLIER, it is required that all 
appropriate internal parties working this feature would need to be associated 
with the role, which would then show up in the accounting module (for above 
mentioned invoice and payment functions) as selectable supplier. This should be 
considered a undesirable effect.

 

 

 

 

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Chinmay Patidar
>Priority: Major
> Attachments: SupplierProduct.png, SupplierProducts.patch
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10542) Instructions for Configurable PC don't work

2018-11-25 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10542:
---

Assignee: Jacques Le Roux  (was: Priya Sharma)

> Instructions for Configurable PC don't work
> ---
>
> Key: OFBIZ-10542
> URL: https://issues.apache.org/jira/browse/OFBIZ-10542
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10542-framework-trunk.patch, 
> OFBIZ-10542-plugins-trunk.patch, console-error.png
>
>
> This concerns only R16, R17 and the trunk. The "Instructions" button was not 
> present in R13. 
> This kind of message shows:
> Trunk:
>  class="btn btn-outline-secondary btn-sm">Instructions
> R16:
>  occurred","");"="" class="buttontext">Instructions
> The same exists for all configurable products, notably Gold Pizza



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)