[jira] [Assigned] (OFBIZ-6965)

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-6965:
--

Assignee: Jacques Le Roux

>  ---
>
> Key: OFBIZ-6965
> URL: https://issues.apache.org/jira/browse/OFBIZ-6965
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: entity
>
> The Test/Production 
> mode has a reserved name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-6152) Add a label element into menu widgets for menu entries separation

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-6152:
--

Assignee: Jacques Le Roux

> Add a label element into menu widgets for menu entries separation
> -
>
> Key: OFBIZ-6152
> URL: https://issues.apache.org/jira/browse/OFBIZ-6152
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework, themes
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: menu, separation
> Attachments: Image 059.png
>
>
> This could be usefull to separate and "group" menu entries. Something like 
> !Image 059.png!
> An alternative is to modify htmlMenuMacroLibrary.ftl as below
> {code}
> Index: framework/widget/templates/htmlMenuMacroLibrary.ftl
> ===
> --- framework/widget/templates/htmlMenuMacroLibrary.ftl   (revision 
> 1634839)
> +++ framework/widget/templates/htmlMenuMacroLibrary.ftl   (working copy)
> @@ -28,7 +28,7 @@
>
>
>  
> -  
> +  class="sb-slidebar sb-left 
> sb-style-overlay">
>  
>  <#macro renderMenuEnd boundaryComment="">
> @@ -62,7 +62,12 @@
>  
>  <#macro renderMenuItemBegin style toolTip linkStr containsNestedMenus>
> - class="${style}"<#if 
> toolTip?has_content> title="${toolTip}"><#if 
> linkStr?has_content>${linkStr}<#if containsNestedMenus><#rt/>
> +  <#if style?has_content && style == "h3">
> +
> +<#if linkStr?has_content>${linkStr}<#rt/>
> +  <#else>
> + class="${style}"<#if 
> toolTip?has_content> title="${toolTip}"><#if 
> linkStr?has_content>${linkStr}<#if containsNestedMenus><#rt/>
> +  
>  
>  <#macro renderMenuItemEnd containsNestedMenus>
> {code}
> The CSS classes used come from http://plugins.adchsm.me/slidebars/. The 
> result is simple and quite good, but all that is more hackish, though maybe 
> enough? After all menus don't need much more...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10225) Localise the messages returned by groovy scripts used in UI context

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10225:
---

Assignee: Jacques Le Roux

> Localise the messages returned by groovy scripts used in UI context
> ---
>
> Key: OFBIZ-10225
> URL: https://issues.apache.org/jira/browse/OFBIZ-10225
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Currently among the 40 cases (look for 
> <> in Groovy files) not all are 
> localised. We need to create labels and use them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9659) Remove the embedded self signed certificate on demos

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9659:
---
Summary: Remove the embedded self signed certificate on demos  (was: Remove 
the embedded self signed certificate on demos (but R13.07))

> Remove the embedded self signed certificate on demos
> 
>
> Key: OFBIZ-9659
> URL: https://issues.apache.org/jira/browse/OFBIZ-9659
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Remove the embedded self signed certificate (useful for localhost usage) on 
> demos to prevent using ports. Else it shows a certificate exception (non 
> signed) when actually we have a letsencrytp certificate for demos



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10024:

Description: 
At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an INOUT 
parameter with entity-auto engine and triggering an SECA. 

Here it is:

Hi Dennis,

No there is no problems with entity-auto as is, ie as it's used so far, in 
other words no known bugs. The problem I crossed is something "special" (or 
new).

Using entity-auto, I wanted to mimic the current createBudget Minilang 
implementation which also calls createBudgetStatus.  So I thought that by 
trigerring createBudgetStatus with a SECA it would be OK.

Here is the patch:
{code}
Index: secas.xml
===
--- secas.xml   (revision 1815825)
+++ secas.xml   (working copy)
@@ -99,7 +99,13 @@
 
 

-
+
+
+
+
+
+
+
 
 
 
Index: services_budget.xml
===
--- services_budget.xml (revision 1815825)
+++ services_budget.xml (working copy)
@@ -25,8 +25,7 @@
 1.0

 
-
+
 Create a Budget
 
 
{code}

And here is the error
{code}
2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher 
|E| Incoming context (in runSync : createBudgetStatus) does not match expected 
requirements
org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis 
suivant manque : [createBudgetStatus.budgetId]
at 
org.apache.ofbiz.service.ModelService.validate(ModelService.java:565) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
 at 
org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160) 
[ofbiz.jar:?]
 at 
org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
 at 
org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316) 
[ofbiz.jar:?]
{code}

I did not check the relation between the entity-auto and SECA code yet, but at 
the moment {{}} 
does not pass a budgetId in the SECA environement so the SECA fails.

BTW the service-eca.xsd seriously lacks documentation. I have created 
OFBIZ-9994 for that

  was:At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an 
INOUT parameter with entity-auto engine and triggering an SECA. 


>  INOUT entity-auto engine parameter not seen in SECA
> 
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an 
> INOUT parameter with entity-auto engine and triggering an SECA. 
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in 
> other words no known bugs. The problem I crossed is something "special" (or 
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang 
> implementation which also calls createBudgetStatus.  So I thought that by 
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
>   persist="true"/>
>  
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>  
>  
>  
> Index: services_budget.xml
> ===
> --- services_budget.xml   (revision 1815825)
> +++ services_budget.xml   (working copy)
> @@ -25,8 +25,7 @@
>  1.0
>  
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml" 
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
>  Create a Budget
>  
>  
> 

[jira] [Assigned] (OFBIZ-10152) Use properties for hard-coded date/time strings

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10152:
---

Assignee: Jacques Le Roux

> Use properties for hard-coded date/time strings 
> 
>
> Key: OFBIZ-10152
> URL: https://issues.apache.org/jira/browse/OFBIZ-10152
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This refers to a suggestion from Adrian at 
> http://markmail.org/message/bldm5eajql4in3yg
> {quote}
> The current OFBiz framework supports a user-selected locale and time 
> zone. There are places in the UI where those settings are ignored and 
> date/time strings are hard-coded to the -MM-dd HH:mm:ss.SSS format. 
> That was a design decision made by the developer community.
> Most of the framework code uses a formatting string constant found in 
> UtilDateTime.java:
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> If you want to change the date/time format, that would be place to do it.
> It would be best to have those format strings loaded from a properties 
> file, so that users like yourself can change it easily - without having 
> to modify framework code. Anyone wanting to work on that improvement can 
> submit a patch to Jira and I would be happy to review and commit it.
> -Adrian
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9335) Check why on demo VM we need to use terminateOFBiz in trunk-manual.sh

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9335:
--

Assignee: Jacques Le Roux

> Check why on demo VM we need to use terminateOFBiz in trunk-manual.sh
> -
>
> Key: OFBIZ-9335
> URL: https://issues.apache.org/jira/browse/OFBIZ-9335
> Project: OFBiz
>  Issue Type: Task
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The trunk-manual.sh is the 1st script launched when we daily update the 
> demos. I tried to use 
> bq. ./gradlew "ofbizBackground --shutdown"
> but it did not work and I had to rely on 
> bq. ./gradlew terminateOFBiz
> I tested locally and I was able to run 2 instances in background, trunk and 
> R16, and close them both using "ofbizBackground --shutdown"
> I must have missed something, we need to double check that



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10024:
---

Assignee: Jacques Le Roux

>  INOUT entity-auto engine parameter not seen in SECA
> 
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an 
> INOUT parameter with entity-auto engine and triggering an SECA. 
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in 
> other words no known bugs. The problem I crossed is something "special" (or 
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang 
> implementation which also calls createBudgetStatus.  So I thought that by 
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
>   persist="true"/>
>  
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>  
>  
>  
> Index: services_budget.xml
> ===
> --- services_budget.xml   (revision 1815825)
> +++ services_budget.xml   (working copy)
> @@ -25,8 +25,7 @@
>  1.0
>  
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml" 
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
>  Create a Budget
>  
>  
> {code}
> And here is the error
> {code}
> 2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher 
> |E| Incoming context (in runSync : createBudgetStatus) does not match 
> expected requirements
> org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis 
> suivant manque : [createBudgetStatus.budgetId]
> at 
> org.apache.ofbiz.service.ModelService.validate(ModelService.java:565) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160) 
> [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316) 
> [ofbiz.jar:?]
> {code}
> I did not check the relation between the entity-auto and SECA code yet, but 
> at the moment {{ optional="true"/>}} does not pass a budgetId in the SECA environement so the 
> SECA fails.
> BTW the service-eca.xsd seriously lacks documentation. I have created 
> OFBIZ-9994 for that



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9673) CommonEvents improvements

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722273#comment-16722273
 ] 

Jacques Le Roux commented on OFBIZ-9673:


Hi Wai,

What is the situation here? Should we not close as "Won't do"?

> CommonEvents improvements
> -
>
> Key: OFBIZ-9673
> URL: https://issues.apache.org/jira/browse/OFBIZ-9673
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9673.patch, OFBIZ-9673.patch
>
>
> replaced private to protected so that CommonEvents.java is more usable to 
> derived classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10151) Check which variables created from properties should be final

2018-12-15 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722271#comment-16722271
 ] 

Pierre Smits commented on OFBIZ-10151:
--

It is a pity that the description is just a reference.

> Check which variables created from properties should be final
> -
>
> Key: OFBIZ-10151
> URL: https://issues.apache.org/jira/browse/OFBIZ-10151
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This follows this discussion: http://markmail.org/message/jbrhply6u2rqyw5p



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9185:
--

Assignee: Jacques Le Roux

> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just 
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship 
> with a RuntimeData or any of the entities Workeffort has a relation with (eg 
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one 
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort, 
> would be to add
> {code}
>  relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of 
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a 
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service  needs more work. The only solution I 
> see is to remove the FK from the Workeffort (ie put null in the related field 
> if it's not) and then deleted the related entity instead of directly calling 
> remove-related



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9994) Improves service-eca.xsd documentation

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9994:
--

Assignee: Jacques Le Roux

> Improves  service-eca.xsd documentation 
> 
>
> Key: OFBIZ-9994
> URL: https://issues.apache.org/jira/browse/OFBIZ-9994
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> service-eca.xsd seriously lacks documentation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9890) Having condition is ignored on queryList() and queryFirst() calls in EntityQuery

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722255#comment-16722255
 ] 

Jacques Le Roux commented on OFBIZ-9890:


Hi Gareth,

Any chances?

> Having condition is ignored on queryList() and queryFirst() calls in 
> EntityQuery
> 
>
> Key: OFBIZ-9890
> URL: https://issues.apache.org/jira/browse/OFBIZ-9890
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Gareth Carter
>Priority: Minor
>
> queryList() and queryFirst() both call internal private query() method. This 
> method calls delegator.findList if a normal Entity/ViewEntity is used (not a 
> DVE). This has no option to include a having condition and so must opt to use 
> queryIterator(). Even queryCount() can use a having condition



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10145:
---

Assignee: Jacques Le Roux

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9602) java.lang.Exception: Current Stack Trace in ofbiz 16.11.3. This is happening sometimes after restarting ofbiz

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722250#comment-16722250
 ] 

Jacques Le Roux commented on OFBIZ-9602:


Could you please see if the same appears in the lasts R16 release (16.11.05)? 
Else if you stay with 16.11.03 we need more information about the context. 
Without these information I'll close in a week, thanks.

> java.lang.Exception: Current Stack Trace in ofbiz 16.11.3. This is happening 
> sometimes after restarting ofbiz
> -
>
> Key: OFBIZ-9602
> URL: https://issues.apache.org/jira/browse/OFBIZ-9602
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: 16.11.03
>Reporter: vivek
>Priority: Major
>
> {code}
> 2017-08-22 04:22:51,763 |http-nio-8443-exec-8 |TransactionUtil   
> |W| In getSetRollbackOnlyCause no stack placeholder was in place, here is the 
> current location: 
> java.lang.Exception: Current Stack Trace
>   at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.getSetRollbackOnlyCause(TransactionUtil.java:841)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.commit(TransactionUtil.java:262)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.commit(TransactionUtil.java:235)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:165)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:157)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:984)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:648)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210) 
> [ofbiz.jar:?]
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) 
> [javax.servlet-api-3.1.0.jar:3.1.0]
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) 
> [javax.servlet-api-3.1.0.jar:3.1.0]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) 
> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209)
>  [ofbiz.jar:?]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:94)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) 
> [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) 
> [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88)
>  [tomcat-catalina-8.0.42.jar:8.0.42]
>   at 
> 

[jira] [Assigned] (OFBIZ-4931) Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-4931:
--

Assignee: Jacques Le Roux

> Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"
> -
>
> Key: OFBIZ-4931
> URL: https://issues.apache.org/jira/browse/OFBIZ-4931
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-4931.patch
>
>
> In reference to the posting, 
> http://ofbiz.135035.n4.nabble.com/Proposal-to-remove-catalog-s-quot-Template-Path-Prefix-quot-field-from-user-interface-td4633296.html
> http://demo-trunk.ofbiz.apache.org/catalog/control/EditProdCatalog?prodCatalogId=DemoCatalog
> It seems that the code blindly prepends the "Template Path Prefix" value to 
> the category's "Detail Screen" field resulting in a file path format that 
> would cause an exception.
> Hence, if a catalog's "Template Path Prefix" is "zzz" and a category's 
> "Detail Screen" is "somedetailscreen", the resulting screen that ofbiz looks 
> for is "/zzzsomedetailscreen".  Which ofbiz would not be able to locate based 
> on the format of the screen location.  Hence, cause an exception.
> If a catalog's "Template Path Prefix" is "zzz" and a category's "Detail 
> Screen" is 
> "component://ecommerce/widget/CatalogScreens.xml#somedetailscreen", the 
> resulting screen that ofbiz looks for is 
> "/zzzcomponent://ecommerce/widget/CatalogScreens.xml#somedetailscreen".  
> Which ofbiz would not be able to located due to the improper format. Hence 
> cause an exception.
> Since this code never worked since 2006 when it was first placed into the svn 
> repository.  I don't think anyone has made use of it since.
> Regarding a catalog's "Content Path Prefix" field, it also exhibits the same 
> flaw. That of blindly prepending this field.  This field is generally used to 
> specify the product images to be shown in the ecommerce component.
> When this field is empty, the generated image url in ecommerce is shown below 
> (note that it is using "image" webapp context):
> /images/products/ENCHILADAS/small.png
> If you were to specify "/zzz" for "Content Path Prefix", the resulting url 
> for the generated image tag is shown below (note that it is using "zzz" 
> webapp context):
> /zzz/images/products/ENCHILADAS/small.png
> As you can see.  "Content Path Prefix" specifies a "zzz" webapp context with 
> a subdirectory "image".  I doubt this was the intent of the field.  The 
> question is, where exactly are you supposed to place this field value? 
> I propose to remove the catalog's "Template Path Prefix" field from the 
> catalog's user interface and assoc code to reduce the confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10212) Open ecommerce by default on user default language

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10212.
---
Resolution: Won't Do

> Open ecommerce by default on user default language 
> ---
>
> Key: OFBIZ-10212
> URL: https://issues.apache.org/jira/browse/OFBIZ-10212
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> By default the ecommerce always open in English. It should open in the user 
> default language like it happens for backend applications.
> I'm not sure but I wonder if the webpos has not the same problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10151) Check which variables created from properties should be final

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10151:
---

Assignee: Jacques Le Roux

> Check which variables created from properties should be final
> -
>
> Key: OFBIZ-10151
> URL: https://issues.apache.org/jira/browse/OFBIZ-10151
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This follows this discussion: http://markmail.org/message/jbrhply6u2rqyw5p



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9469) POC: Using JSF

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722251#comment-16722251
 ] 

Jacques Le Roux commented on OFBIZ-9469:


Hi James, now that Tomcat SSO is available, what about this issue?

> POC: Using JSF
> --
>
> Key: OFBIZ-9469
> URL: https://issues.apache.org/jira/browse/OFBIZ-9469
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: James Yong
>Priority: Minor
> Attachments: OFBIZ-9469.patch, OFBIZ-9469.patch
>
>
> JavaServerFaces (JSF) can be used to build Rich Internet Applications which 
> is suitable for business-facing part of an ERP system.
> Some Advantages
> ==
> JSF is similar to OFBiz widget; both can use declarative XML UI. 
> JSF can map directly to a backing bean and doesn't requires any request 
> mapping.
> JSF also allows the direct coding of HTML within the XML, while OFBiz widgets 
> need to link to external FTL file.
> I have done some initial work to add JSF capabilities for developers to 
> evaluate its suitability further. It is also possible to render OFBiz Widgets 
> (for reuse) and programmatically placed within JSF, but I haven't go into it 
> yet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7680) Attribute 'value-field' must appear on element 'entity-one'

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7680:
---
Description: 
I found these errors

cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 25
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 57
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 93
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 125
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.ContentForms.xml
/ofbiz/applications/content/widget/content  line 235
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.ContentSetupForms.xml   
/ofbiz/applications/content/widget/contentsetup line 217
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.EmploymentAppForms.xml  
/ofbiz/applications/humanres/widget/forms   line 27
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.PayGradeForms.xml   
/ofbiz/applications/humanres/widget/forms   line 65

This thread is related: 
https://lists.apache.org/thread.html/e8ec89da78021209c381f7081480ee3fda78912f5b452c29e196e0cb@%3Cdev.ofbiz.apache.org%3E

  was:
I found these errors

cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 25
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 57
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 93
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.CompDocTemplateTree.xml 
/ofbiz/applications/content/widget/compdoc  line 125
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.ContentForms.xml
/ofbiz/applications/content/widget/content  line 235
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.ContentSetupForms.xml   
/ofbiz/applications/content/widget/contentsetup line 217
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.EmploymentAppForms.xml  
/ofbiz/applications/humanres/widget/forms   line 27
cvc-complex-type.4: Attribute 'value-field' must appear on element 
'entity-one'.PayGradeForms.xml   
/ofbiz/applications/humanres/widget/forms   line 65



> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-7680
> URL: https://issues.apache.org/jira/browse/OFBIZ-7680
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> I found these errors
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  CompDocTemplateTree.xml 
> /ofbiz/applications/content/widget/compdoc  line 25
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  CompDocTemplateTree.xml 
> /ofbiz/applications/content/widget/compdoc  line 57
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  CompDocTemplateTree.xml 
> /ofbiz/applications/content/widget/compdoc  line 93
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  CompDocTemplateTree.xml 
> /ofbiz/applications/content/widget/compdoc  line 125
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  ContentForms.xml
> /ofbiz/applications/content/widget/content  line 235
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  ContentSetupForms.xml   
> /ofbiz/applications/content/widget/contentsetup line 217
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  EmploymentAppForms.xml  
> /ofbiz/applications/humanres/widget/forms   line 27
> cvc-complex-type.4: Attribute 'value-field' must appear on element 
> 'entity-one'.  PayGradeForms.xml   
> 

[jira] [Updated] (OFBIZ-9659) Remove the embedded self signed certificate on demos (but R13.07)

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9659:
---
Description: Remove the embedded self signed certificate (useful for 
localhost usage) on demos to prevent using ports. Else it shows a certificate 
exception (non signed) when actually we have a letsencrytp certificate for 
demos  (was: Remove the embedded self signed certificate (useful for localhost 
usage) on demos (but R13.07) to prevent using ports. Else it shows a 
certificate exception (non signed) when actually we have a letsencrytp 
certificate for demos)

> Remove the embedded self signed certificate on demos (but R13.07)
> -
>
> Key: OFBIZ-9659
> URL: https://issues.apache.org/jira/browse/OFBIZ-9659
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Remove the embedded self signed certificate (useful for localhost usage) on 
> demos to prevent using ports. Else it shows a certificate exception (non 
> signed) when actually we have a letsencrytp certificate for demos



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9659) Remove the embedded self signed certificate on demos (but R13.07)

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9659.
--
Resolution: Fixed

This is not needed for FF ("old" version 56 here) which returns: 
SEC_ERROR_UNKNOWN_ISSUER and blocks.

Chrome does not, and allows you to get to 
https://demo-stable.ofbiz.apache.org:18443/catalog/control/main?USERNAME=admin=ofbiz=Y
But once the self certificate is removed it no longer does. IE (11 for me) and 
Opera (45) do the same. Same for old.

Remains INFRA-16716

> Remove the embedded self signed certificate on demos (but R13.07)
> -
>
> Key: OFBIZ-9659
> URL: https://issues.apache.org/jira/browse/OFBIZ-9659
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Remove the embedded self signed certificate (useful for localhost usage) on 
> demos (but R13.07) to prevent using ports. Else it shows a certificate 
> exception (non signed) when actually we have a letsencrytp certificate for 
> demos



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6807) UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with publicId [null] and the file/resource is [web-app_3_0.xsd]

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722150#comment-16722150
 ] 

Jacques Le Roux commented on OFBIZ-6807:


Hi Paul, 

So we could close this issue and create one based on your comment to cleanup 
things with a catalog.xlm file including for webapp.xml files?

Note that we already have 
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/.xmlcatalog.xml

> UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with 
> publicId [null] and the file/resource is [web-app_3_0.xsd]
> 
>
> Key: OFBIZ-6807
> URL: https://issues.apache.org/jira/browse/OFBIZ-6807
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> System throws following exception on server start:
> {code}
> [java] 2016-01-16 15:04:50,942 |catalina-startup-2   |UtilXml 
>   |W| [UtilXml.LocalResolver.resolveEntity] could not find LOCAL 
> DTD/Schema with publicId [null] and the file/resource is [web-app_3_0.xsd]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6734) Better explain fields in FormWidgetExampleForms

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722143#comment-16722143
 ] 

Jacques Le Roux commented on OFBIZ-6734:


I started a convo indev ML at https://s.apache.org/7brX

> Better explain fields in FormWidgetExampleForms
> ---
>
> Key: OFBIZ-6734
> URL: https://issues.apache.org/jira/browse/OFBIZ-6734
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.01
>
>
> We have currently a number of fields not explained



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9297) EntityListIterator Not Closed for Entity [EntityName], caught in Finalize

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9297.
--
Resolution: Fixed

Definitely close after closing OFBIZ-9603

> EntityListIterator Not Closed for Entity [EntityName], caught in Finalize
> -
>
> Key: OFBIZ-9297
> URL: https://issues.apache.org/jira/browse/OFBIZ-9297
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> This is an umbrella issue for all related ones



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

2018-12-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9603.
--
Resolution: Information Provided
  Assignee: Jacques Le Roux

> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> 
>
> Key: OFBIZ-9603
> URL: https://issues.apache.org/jira/browse/OFBIZ-9603
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to SFA component (https://localhost:8443/sfa/control/main)
> 2. Click on sub-menu "Leads" (https://localhost:8443/sfa/control/FindLeads)
> Following error in logs:
> {code:java}
> 2017-08-22 08:59:50,496 |Finalizer|EntityListIterator
> |E| 
> ==
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> ==
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

2018-12-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722080#comment-16722080
 ] 

Jacques Le Roux commented on OFBIZ-9603:


I found the reason. After fixing OFBIZ-10711 I wondered about this one and 
found that as much as 3 EntityListIterators are initialised in this page by 
FindServices::executeFind.

When you use the menu as reported by Aditya only 2 EntityListIterators are 
initialised with respectively the conditions:

* ((statusId <> 'PARTY_DISABLED' OR statusId IS NULL) AND roleTypeId = 
'ACCOUNT')
* ((statusId <> 'PARTY_DISABLED' OR statusId IS NULL) AND roleTypeId = 'LEAD')

Same when you the "Find" button.

If you use the "All Leads" button another EntityListIterator is added to these 
2, with the condition

* (partyIdFrom = 'admin' AND (statusId <> 'PARTY_DISABLED' OR statusId IS NULL) 
AND roleTypeIdTo = 'LEAD' AND partyRelationshipTypeId = 'LEAD_OWNER' AND 
(partyStatusId <> 'PARTY_DISABLED' OR partyStatusId IS NULL) AND ((thruDate IS 
NULL OR thruDate > '2018-12-15 10:23:51.373') AND (fromDate IS NULL OR fromDate 
<= '2018-12-15 10:23:51.373')))

But only one of these EntityListIterators is really used and closed in 
FormRenderer::renderItemRows when you use one of the functionality. So the 
others are caught and close in EntityListIterator::finalize.

I see no easy ways to prevent that and see no problems with it since the 
superfluous EntityListIterators are only initialised not used.

So closing with "Informtation Provided"


> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> 
>
> Key: OFBIZ-9603
> URL: https://issues.apache.org/jira/browse/OFBIZ-9603
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to SFA component (https://localhost:8443/sfa/control/main)
> 2. Click on sub-menu "Leads" (https://localhost:8443/sfa/control/FindLeads)
> Following error in logs:
> {code:java}
> 2017-08-22 08:59:50,496 |Finalizer|EntityListIterator
> |E| 
> ==
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], 
> caught in Finalize
> ==
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)