[jira] [Assigned] (OFBIZ-8423) Unit test case for service - getDataResource
[ https://issues.apache.org/jira/browse/OFBIZ-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-8423: -- Assignee: Yogesh Naroliya > Unit test case for service - getDataResource > > > Key: OFBIZ-8423 > URL: https://issues.apache.org/jira/browse/OFBIZ-8423 > Project: OFBiz > Issue Type: Sub-task > Components: content >Reporter: Tanmay Muley >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8423.patch > > > Unit test case for service - getDataResource -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8579) Unit test case for service - updateProductCategory
[ https://issues.apache.org/jira/browse/OFBIZ-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-8579: -- Assignee: Yogesh Naroliya > Unit test case for service - updateProductCategory > -- > > Key: OFBIZ-8579 > URL: https://issues.apache.org/jira/browse/OFBIZ-8579 > Project: OFBiz > Issue Type: Sub-task > Components: product >Reporter: Akash Jain >Assignee: Yogesh Naroliya >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-8579.patch > > > Unit test case for service - updateProductCategory -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741454#comment-16741454 ] Paul Foxworthy commented on OFBIZ-9677: --- Thanks Jacques. Sorry I didn't get to this. I will commit with backports in future. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741414#comment-16741414
]
Jacques Le Roux commented on OFBIZ-10692:
-
Thanks Gil,
Ha indeed, I thought that filling in the dates was enough. Works, +1
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10805) OFBiz shell
[
https://issues.apache.org/jira/browse/OFBIZ-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741409#comment-16741409
]
Mathieu Lirzin edited comment on OFBIZ-10805 at 1/12/19 9:33 PM:
-
Hello Michael,
Here is sample shell session that shows what kind of things are possible:
{code:java}
mthl@token ~/src/ofbiz$ java -jar build/libs/ofbiz.jar -i
Config.java using configuration file start.properties
Set OFBIZ_HOME to - /home/mthl/src/ofbiz
SHELL
Groovy Shell (2.4.16, JVM: 1.8.0_161)
Type ':help' or ':h' for help.
---
groovy:000> import org.apache.ofbiz.entity.util.EntityQuery
===> org.apache.ofbiz.entity.util.EntityQuery
groovy:000> def system =
EntityQuery.use(delegator).from('UserLogin').where(userLoginId:
'system').queryOne()
===> [lastUpdatedStamp:2019-01-07 23:48:33.674, successiveFailedLogins:null,
passwordHint:null, createdTxStamp:2019-01-07 23:48:23.512,
createdStamp:2019-01-07 23:48:23.653, externalAuthId:null,
lastUpdatedTxStamp:2019-01-07 23:48:32.721, lastTimeZone:null, enabled:N,
lastLocale:null, currentPassword:null, userLoginId:system, isSystem:Y,
disabledDateTime:null, disabledBy:null, hasLoggedOut:null, userLdapDn:null,
requirePasswordChange:null, lastCurrencyUom:null, partyId:system]
groovy:000> dispatcher.runSync('echoService', [userLogin: system])
===> [userLogin:[lastUpdatedStamp:2019-01-07 23:48:33.674,
successiveFailedLogins:null, passwordHint:null, createdTxStamp:2019-01-07
23:48:23.512, createdStamp:2019-01-07 23:48:23.653, externalAuthId:null,
lastUpdatedTxStamp:2019-01-07 23:48:32.721, lastTimeZone:null, enabled:N,
lastLocale:null, currentPassword:null, userLoginId:system, isSystem:Y,
disabledDateTime:null, disabledBy:null, hasLoggedOut:null, userLdapDn:null,
requirePasswordChange:null, lastCurrencyUom:null, partyId:system], locale:en,
responseMessage:success]
{code}
Given the experimental state of the implementation there are still a lot of
ruff edges (one major one is concerning the UI Labels which are not handle
properly).
Regarding the security issues, yes this is sensitive. Like for {{java -jar
build/libs/ofbiz.jar --shutdown}}, anyone knowing the {{ofbiz.admin.key}}
property and able to connect to the admin socket can start a shell session. The
difference is that the shell feature has wider consequences since the attacker
can do far more thing than just shuting OFBiz down.
was (Author: mthl):
Hello Michael,
Here is sample shell session that would hopefully show what kind of things are
possible:
{code}
mthl@token ~/src/ofbiz$ java -jar build/libs/ofbiz.jar -i
Config.java using configuration file start.properties
Set OFBIZ_HOME to - /home/mthl/src/ofbiz
SHELL
Groovy Shell (2.4.16, JVM: 1.8.0_161)
Type ':help' or ':h' for help.
---
groovy:000> import org.apache.ofbiz.entity.util.EntityQuery
===> org.apache.ofbiz.entity.util.EntityQuery
groovy:000> def system =
EntityQuery.use(delegator).from('UserLogin').where(userLoginId:
'system').queryOne()
===> [lastUpdatedStamp:2019-01-07 23:48:33.674, successiveFailedLogins:null,
passwordHint:null, createdTxStamp:2019-01-07 23:48:23.512,
createdStamp:2019-01-07 23:48:23.653, externalAuthId:null,
lastUpdatedTxStamp:2019-01-07 23:48:32.721, lastTimeZone:null, enabled:N,
lastLocale:null, currentPassword:null, userLoginId:system, isSystem:Y,
disabledDateTime:null, disabledBy:null, hasLoggedOut:null, userLdapDn:null,
requirePasswordChange:null, lastCurrencyUom:null, partyId:system]
groovy:000> dispatcher.runSync('echoService', [userLogin: system])
===> [userLogin:[lastUpdatedStamp:2019-01-07 23:48:33.674,
successiveFailedLogins:null, passwordHint:null, createdTxStamp:2019-01-07
23:48:23.512, createdStamp:2019-01-07 23:48:23.653, externalAuthId:null,
lastUpdatedTxStamp:2019-01-07 23:48:32.721, lastTimeZone:null, enabled:N,
lastLocale:null, currentPassword:null, userLoginId:system, isSystem:Y,
disabledDateTime:null, disabledBy:null, hasLoggedOut:null, userLdapDn:null,
requirePasswordChange:null, lastCurrencyUom:null, partyId:system], locale:en,
responseMessage:success]
{code}
Given the experimental state of the implementation there are still a lot of
ruff edges (one major one is concerning the UI Labels which are not handle
properly).
Regarding the security issues, yes this is sensitive. Like for {{java -jar
build/libs/ofbiz.jar --shutdown}}, anyone knowing the {{ofbiz.admin.key}}
property and able to connect to the admin socket can start a shell session. The
difference is that the shell feature has wider consequences since the attacker
can do far more thing than just shuting OFBiz down.
> OFBiz shell
> ---
>
> Key: OFBIZ-10805
> URL: https://issues.apache.org/jira/browse/OFBIZ-10805
>
[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741389#comment-16741389
]
Gil Portenseigne commented on OFBIZ-10692:
--
Hi [~jacques.le.roux],
Here is the screenshot of the test, you miss to give a parameter in the form :D
:
!screenshot-1.png!
And after the patch :
!Sélection_088.png!
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-10692:
-
Attachment: screenshot-1.png
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741388#comment-16741388 ] Taher Alkhateeb commented on OFBIZ-7016: I prefer to close this ticket. It is dead weight and too old to be of value. I wish if we can eliminate the plethora of useless JIRAs and focus on those with higher value. Our Jira is mostly filled with noise unfortunately which makes focusing on what matters rather difficult. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne updated OFBIZ-10692:
-
Attachment: Sélection_088.png
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch,
> Sélection_088.png, screenshot-1.png
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10804: - Issue Type: Sub-task (was: Bug) Parent: OFBIZ-9760 > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10749) Unable to submit set Billing form in order manager when payment method is EFT
[ https://issues.apache.org/jira/browse/OFBIZ-10749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741380#comment-16741380 ] Deepak Dixit commented on OFBIZ-10749: -- Hi [~Chandrashekhar.dhakad], I reviewed your patch, We need to check another use case as well, In BillSettings.groovy file we are setting paymentMethodType as EFT so need to verify other use cases as well. > Unable to submit set Billing form in order manager when payment method is EFT > - > > Key: OFBIZ-10749 > URL: https://issues.apache.org/jira/browse/OFBIZ-10749 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Chandrashekhar Dhakad >Priority: Major > Attachments: 1-SetCustomer.png, 10-ConsoleError.png, 2-Continue.png, > 3-AddProduct.png, 4-QuickFinalizeOrder.png, 5-EftAccount.png, > 6-TelecomNumber.png, 7-Address.png, 8-EFT.png, 9-BillingAddress.png, > OFBIZ-10749.patch > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue (Please refer attachment: 1-SetCustomer) > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Add product and click on Quick Finalize Order (Please refer attachment: > 3-AddProduct) > # On Quick Finalize Order page select UPS Air and click on EFT Account > (Please refer attachment: 4-QuickFinalizeOrder) > # Enter account details but do not select billing address and click on Save > button(Please refer attachment: 5-EftAccount) > # Add phone and email address and click on continue (Please refer > attachment: 6-TelecomNumber) > # Enter address (Please refer attachment: 7-Address) > # Click continue on Sales Order : Order Entry Order Terms page > # Select Electronic Fund Transfer on Sales Order : Order Entry Payment > Settings and click continue (Please refer attachment: 8-EFT) > # Enter billing address and click on continue (Please refer attachment: > 9-BillingAddress) > Actual: Unable to Submit form and error message was displayed on console > (Please refer attachment: 10-ConsoleError) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10793) Convert Promotion Screen of e-commerce as per Bootstrap Styling
[ https://issues.apache.org/jira/browse/OFBIZ-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741373#comment-16741373 ] Deepak Dixit commented on OFBIZ-10793: -- Thanks Nitish for your contribution This has been committed at ofbiz trunk plugins at r#1851185 R18.12 plugins at r#1851186 R17.12 plugin at r#1851187 > Convert Promotion Screen of e-commerce as per Bootstrap Styling > --- > > Key: OFBIZ-10793 > URL: https://issues.apache.org/jira/browse/OFBIZ-10793 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10793.patch > > > Use bootstrap framework for promotions screen for markup improvements. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10793) Convert Promotion Screen of e-commerce as per Bootstrap Styling
[ https://issues.apache.org/jira/browse/OFBIZ-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10793. Resolution: Fixed Fix Version/s: 17.12.01 > Convert Promotion Screen of e-commerce as per Bootstrap Styling > --- > > Key: OFBIZ-10793 > URL: https://issues.apache.org/jira/browse/OFBIZ-10793 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10793.patch > > > Use bootstrap framework for promotions screen for markup improvements. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10793) Convert Promotion Screen of e-commerce as per Bootstrap Styling
[ https://issues.apache.org/jira/browse/OFBIZ-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10793: Assignee: Deepak Dixit (was: Nitish Mishra) > Convert Promotion Screen of e-commerce as per Bootstrap Styling > --- > > Key: OFBIZ-10793 > URL: https://issues.apache.org/jira/browse/OFBIZ-10793 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10793.patch > > > Use bootstrap framework for promotions screen for markup improvements. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10118) Update multifex theme as per new markup
[ https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10118. Resolution: Done Fix Version/s: 17.12.01 > Update multifex theme as per new markup > --- > > Key: OFBIZ-10118 > URL: https://issues.apache.org/jira/browse/OFBIZ-10118 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10118_Body.patch, OFBIZ-10118_Footer.patch, > OFBIZ-10118_HEADER.patch > > > As we are updating UX of ecommerce site, this breaks the multifex them of > ecommerce. > Need to update css rule of multiflex theme as per new markup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10118) Update multifex theme as per new markup
[ https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741366#comment-16741366 ] Deepak Dixit commented on OFBIZ-10118: -- This has been committed at R17.12 at r#1851184 Thanks Parakh Maheshwari for your contribution. > Update multifex theme as per new markup > --- > > Key: OFBIZ-10118 > URL: https://issues.apache.org/jira/browse/OFBIZ-10118 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10118_Body.patch, OFBIZ-10118_Footer.patch, > OFBIZ-10118_HEADER.patch > > > As we are updating UX of ecommerce site, this breaks the multifex them of > ecommerce. > Need to update css rule of multiflex theme as per new markup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9760) Using Bootstrap Framework for E-Commerce Website
[ https://issues.apache.org/jira/browse/OFBIZ-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741365#comment-16741365 ] Deepak Dixit commented on OFBIZ-9760: - Thanks Parakh for your contribution, this has been done at R17/12 plugins at r#1851184 > Using Bootstrap Framework for E-Commerce Website > > > Key: OFBIZ-9760 > URL: https://issues.apache.org/jira/browse/OFBIZ-9760 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Saurabh Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: FooterSectionAfterBootstrapIntgration.png, > FooterSectionBeforeBootstrapIntegration.png, > HeaderAfterBootstrapIntegration.png, HeaderBeforeBootstrapIntegration.png, > OFBIZ-9760-Bootstrap-Library.patch, OFBIZ-9760-Footer-improvement.patch, > OFBIZ-9760-Footer.patch, OFBIZ-9760-Header.patch, OFBIZ-9760-Logo.patch, > OFBIZ-9760-OFBIZ-17.12.patch, ofbiz_logo.png > > > Use of the bootstrap framework so that the UI of the e-commerce would be more > arranged and user-friendly -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10118) Update multifex theme as per new markup
[ https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10118: Assignee: Deepak Dixit (was: Parakh Maheshwari) > Update multifex theme as per new markup > --- > > Key: OFBIZ-10118 > URL: https://issues.apache.org/jira/browse/OFBIZ-10118 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10118_Body.patch, OFBIZ-10118_Footer.patch, > OFBIZ-10118_HEADER.patch > > > As we are updating UX of ecommerce site, this breaks the multifex them of > ecommerce. > Need to update css rule of multiflex theme as per new markup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10805) OFBiz shell
[
https://issues.apache.org/jira/browse/OFBIZ-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741364#comment-16741364
]
Michael Brohl commented on OFBIZ-10805:
---
Hi Mathieu,
that sounds great!
How would I use the feature? Can you give an example?
Do we have to deal with security issues?
> OFBiz shell
> ---
>
> Key: OFBIZ-10805
> URL: https://issues.apache.org/jira/browse/OFBIZ-10805
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10805_OFBiz-shell.patch
>
>
> One issue with the current way of writing Groovy tests is that the feedback
> between writing an instruction and checking its result is slow because one
> has to rerun the corresponding test case.
> Providing a Groovy shell access with a delegator and dispatcher allows
> developers to interactively execute commands and check their results
> instantly.
> The shell access has been done via Remote Procedure Call (RPC) which was
> already implemented by the {{AdminClient}} and {{AdminServer}} classes.
> In order to test, you must start the server first:
> {code}
> $ ./gradlew ofbiz
> {code}
> then you can run the following command in another terminal:
> {code}
> $ java -jar build/libs/ofbiz.jar --shell
> {code}
> or this equivalent one which uses the corresponding short option:
> {code}
> $ java -jar build/libs/ofbiz.jar -i
> {code}
> *Limitation*: It is currently not possible to connect multiple shells at
> the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9243) load demo data failure
[ https://issues.apache.org/jira/browse/OFBIZ-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741360#comment-16741360 ] Deepak Dixit commented on OFBIZ-9243: - [~mbrohl] Let me check will pick it ASAP > load demo data failure > -- > > Key: OFBIZ-9243 > URL: https://issues.apache.org/jira/browse/OFBIZ-9243 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Deepak Dixit >Priority: Major > Attachments: ofbiz-framework-buildbot gradlew loadDefault.log.txt > > > checkout latest ofbiz-framework and ofbiz-plugins > $ gradlew cleanAll build > $ gradlew loadDefault...using derby > console output... > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| 00040 of 17229 from > file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| The following errors occurred in the data load: > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A > transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error > was: A transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed. > }} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[ https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741355#comment-16741355 ] Jacques Le Roux commented on OFBIZ-9115: The problem comes from OFBIZ-9677: https://ci.apache.org/builders/ofbizTrunkFramework?numbuilds=25 https://ci.apache.org/builders/ofbizTrunkFramework/builds/612 If you revert, tests then pass locally. Unfortunately I did not spot it then and backported. Hopefully it's a test issue and I'll not have to revert. > Unit test case for service - updatePaymentGatewayConfig > > > Key: OFBIZ-9115 > URL: https://issues.apache.org/jira/browse/OFBIZ-9115 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch > > > Unit test case for service - updatePaymentGatewayConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10805) OFBiz shell
[
https://issues.apache.org/jira/browse/OFBIZ-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10805:
---
Attachment: OFBIZ-10805_OFBiz-shell.patch
> OFBiz shell
> ---
>
> Key: OFBIZ-10805
> URL: https://issues.apache.org/jira/browse/OFBIZ-10805
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10805_OFBiz-shell.patch
>
>
> One issue with the current way of writing Groovy tests is that the feedback
> between writing an instruction and checking its result is slow because one
> has to rerun the corresponding test case.
> Providing a Groovy shell access with a delegator and dispatcher allows
> developers to interactively execute commands and check their results
> instantly.
> The shell access has been done via Remote Procedure Call (RPC) which was
> already implemented by the {{AdminClient}} and {{AdminServer}} classes.
> In order to test, you must start the server first:
> {code}
> $ ./gradlew ofbiz
> {code}
> then you can run the following command in another terminal:
> {code}
> $ java -jar build/libs/ofbiz.jar --shell
> {code}
> or this equivalent one which uses the corresponding short option:
> {code}
> $ java -jar build/libs/ofbiz.jar -i
> {code}
> *Limitation*: It is currently not possible to connect multiple shells at
> the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10805) OFBiz shell
Mathieu Lirzin created OFBIZ-10805:
--
Summary: OFBiz shell
Key: OFBIZ-10805
URL: https://issues.apache.org/jira/browse/OFBIZ-10805
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
One issue with the current way of writing Groovy tests is that the feedback
between writing an instruction and checking its result is slow because one has
to rerun the corresponding test case.
Providing a Groovy shell access with a delegator and dispatcher allows
developers to interactively execute commands and check their results instantly.
The shell access has been done via Remote Procedure Call (RPC) which was
already implemented by the {{AdminClient}} and {{AdminServer}} classes.
In order to test, you must start the server first:
{code}
$ ./gradlew ofbiz
{code}
then you can run the following command in another terminal:
{code}
$ java -jar build/libs/ofbiz.jar --shell
{code}
or this equivalent one which uses the corresponding short option:
{code}
$ java -jar build/libs/ofbiz.jar -i
{code}
*Limitation*: It is currently not possible to connect multiple shells at
the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.
[ https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741341#comment-16741341 ] Jacques Le Roux commented on OFBIZ-10536: - Thanks Priya, I know about that, but it has worked during several years. So something has changed in between. BTW you 2nd link leads to a 404, better use Markmail or Apache MLs archive, eg https://lists.apache.org/list.html?d...@ofbiz.apache.org > Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box > appears with no reason. > > > Key: OFBIZ-10536 > URL: https://issues.apache.org/jira/browse/OFBIZ-10536 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Jacques Le Roux >Assignee: Priya Sharma >Priority: Major > Attachments: Image 002.png, OFBIZ-10536.patch, > OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png > > > Try at > https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p, > same locally of course > R16 is also concerned (hence R17 I surmise) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[ https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741336#comment-16741336 ] Suraj Khurana commented on OFBIZ-9115: -- Yes, I also noticed. Will check it as well. > Unit test case for service - updatePaymentGatewayConfig > > > Key: OFBIZ-9115 > URL: https://issues.apache.org/jira/browse/OFBIZ-9115 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch > > > Unit test case for service - updatePaymentGatewayConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[ https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9115. > Unit test case for service - updatePaymentGatewayConfig > > > Key: OFBIZ-9115 > URL: https://issues.apache.org/jira/browse/OFBIZ-9115 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch > > > Unit test case for service - updatePaymentGatewayConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[ https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741331#comment-16741331 ] Michael Brohl commented on OFBIZ-9115: -- Thanks, [~suraj.khurana], the test is successful now. There are other failing tests but they do not seem to be related to this issue. > Unit test case for service - updatePaymentGatewayConfig > > > Key: OFBIZ-9115 > URL: https://issues.apache.org/jira/browse/OFBIZ-9115 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch > > > Unit test case for service - updatePaymentGatewayConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[ https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana resolved OFBIZ-9115. -- Resolution: Fixed Thanks Michael for reporting. Corrected typo at rev# 1851179. Please check and close this issue. > Unit test case for service - updatePaymentGatewayConfig > > > Key: OFBIZ-9115 > URL: https://issues.apache.org/jira/browse/OFBIZ-9115 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch > > > Unit test case for service - updatePaymentGatewayConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10795) Product dropdown should be replaced with product lookup on Edit Price Rule screen
[ https://issues.apache.org/jira/browse/OFBIZ-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741320#comment-16741320 ] Jacques Le Roux commented on OFBIZ-10795: - Hi Mohammad, The problem with this solution is that we use generalised dependent dropdowns in this screen (also in promo rules). So if you replace with a lookup you lose this functionality. We could have a properties to decide on which type of field to use in case of long lists of products (or other entries). But that would let the user with another issue to resolve: how to handle the dependency. > Product dropdown should be replaced with product lookup on Edit Price Rule > screen > - > > Key: OFBIZ-10795 > URL: https://issues.apache.org/jira/browse/OFBIZ-10795 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Mohammad Kathawala >Assignee: Pradeep Choudhary >Priority: Minor > Fix For: Trunk, Release Branch 16.11, Release Branch 17.12 > > > On Edit Price Rule screen, all the products of the system are fetched in a > single dropdown. > If a system has thousands or more products, then it will take too much time > to load those products in the dropdown and screen loading time will increase > or even it can make the system down. > > We should have a product lookup here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741301#comment-16741301
]
Mathieu Lirzin edited comment on OFBIZ-10680 at 1/12/19 2:46 PM:
-
Hello Ankit,
To avoid you the pain of searching, OFBiz community requires people to provides
patches without prefixes which is apparently more convenient for some old
timers like Jacques ;). this is achieved in {{git diff}} by adding the
{{--no-prefix}} option.
was (Author: mthl):
Hello Ankit,
To avoid you the pain to search, OFBiz community requires people to provides
patches without prefixes which is apparently more convenient for some old
timers like Jacques ;). this is achieved in {{git diff}} by adding the
{{--no-prefix}} option.
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741311#comment-16741311 ] Jacques Le Roux commented on OFBIZ-10663: - This could be somehow related with OFBIZ-10536 > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Sasikant Biswal >Priority: Major > Attachments: Editable amount.png, Missing Heading.png > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-6100) Inconsistent tax calculation between checkout finalize and order created screen
[ https://issues.apache.org/jira/browse/OFBIZ-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6100. -- Resolution: Won't Do Thanks Michael, Despite being a committer Christian is for long no longer participating, better close. If soemone want to work on it s/he can still reopen it. > Inconsistent tax calculation between checkout finalize and order created > screen > --- > > Key: OFBIZ-6100 > URL: https://issues.apache.org/jira/browse/OFBIZ-6100 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > > I changed arithmetic.properties salestax.calc.decimals = 4 instead of 3 > because my purchase order tax was 1 cent less than the receipt. After > accounting for 4 decimals, the tax was correctly calculated at the checkout > finalize page, but once the order was created, the tax was 1 cent less than > its previously calculated value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741301#comment-16741301
]
Mathieu Lirzin commented on OFBIZ-10680:
Hello Ankit,
To avoid you the pain to search, OFBiz community requires people to provides
patches without prefixes which is apparently more convenient for some old
timers like Jacques ;). this is achieved in {{git diff}} by adding the
{{--no-prefix}} option.
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741293#comment-16741293
]
Mathieu Lirzin commented on OFBIZ-10760:
Thanks Michael,
Yes I think we should keep it open (or open another dedicated one)
My investigations didn't led me to a straightforward solution on how to fix
that issue. The problem leading to {{null}} pointers exceptions is that
Artifact info retrieval tries to access the {{delegator}} which is
intentionally not provided in the dispatch context according the comment inside
the {{ArtifactInfoFactory}} constructor:
{code:java}
protected ArtifactInfoFactory(String delegatorName) throws GeneralException {
this.delegatorName = delegatorName;
this.entityModelReader = ModelReader.getModelReader(delegatorName);
DelegatorElement delegatorInfo =
EntityConfig.getInstance().getDelegator(delegatorName);
String modelName;
if (delegatorInfo != null) {
modelName = delegatorInfo.getEntityModelReader();
} else {
modelName = "main";
}
// since we do not associate a dispatcher to this DispatchContext, it is
important to set a name of an existing entity model reader:
// in this way it will be possible to retrieve the service models from the
cache
this.dispatchContext = new DispatchContext(modelName,
this.getClass().getClassLoader(), null);
this.prepareAll();
}
{code}
I fail to understand the full picture even after looking at the commit logs, so
some help would be welcome.
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[
https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741278#comment-16741278
]
Jacques Le Roux commented on OFBIZ-10666:
-
Thanks Deepak,
Got it w/ your 1st link, it's troublesome. The Javadoc is really not well done
and should speak about this aspect rather than simply telling us
{quote}
Gets the maximum age in seconds of this Cookie.
By default, -1 is returned, which indicates that the cookie will persist until
browser shutdown.
Returns:an integer specifying the maximum age of the cookie in seconds; if
negative, means the cookie persists until browser shutdown
{quote}
misleading!
Anyway, because if the cookie is still valid we will get its name, I think we
are good to remove getMaxAge as in the patch below
{code}
Index:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
===
---
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(révision 1851160)
+++
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(copie de travail)
@@ -975,8 +975,7 @@
}
if (cookies != null) {
for (Cookie cookie: cookies) {
-if (cookie.getName().equals(getAutoLoginCookieName(request))
-&& cookie.getMaxAge() > 0) {
+if (cookie.getName().equals(getAutoLoginCookieName(request))) {
autoUserLoginId = cookie.getValue();
break;
}
{code}
I'll commit soon.
This said it's also used in CrossSubdomainSessionValve::replaceCookie, not sure
it's an issue or not there.
> User's name is displayed on ecommerce even after user logs out
> --
>
> Key: OFBIZ-10666
> URL: https://issues.apache.org/jira/browse/OFBIZ-10666
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
> Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png,
> 4-NotYou.png, OFBIZ-10666.patch
>
>
> Steps to regenerate:
> # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
> Welcome is displayed and user's name is not displayed when URL is opened.
> (Please refer attachment: 1-OpenURL)
> # Login at ecommerce by clicking on login and entering Username: "admin" and
> Password: "ofbiz". Username will be displayed after user logs in. (Please
> refer attachment: 2-LoggedIn)
> # Logout of ecommerce by clicking on logout. User will be logged out and
> login link will be displayed in place of logout link, but the name of user is
> still displayed. (Please refer attachment: 3-LoggedOut)
> Actual: Username is still displayed after user logs out
>
> Expected: Username should not be displayed after the user logs out
>
> Note: Similar issue also exists when the user clicks on (Not You? Click Here)
> link. (Please refer attachment: 4-NotYou)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9677. -- Resolution: Fixed > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741276#comment-16741276 ] Jacques Le Roux commented on OFBIZ-9677: Backported in R18 r1851163 R17 r1851164 R16 r1851165 after resolving a conflict by hand > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741261#comment-16741261
]
Jacques Le Roux commented on OFBIZ-10692:
-
Hi Leila,
In trunk the error I see when applyin the test patch in UI is:
{quote}Le paramètre requis suivant manque :
[updateFXConversion.conversionFactor]
{quote}
In log:
{noformat}
2019-01-12 12:37:15,115 |jsse-nio-8443-exec-3 |ServiceDispatcher |E| Incoming
context (in runSync : updateFXConversion) does not match expected requirements
org.apache.ofbiz.service.ServiceValidationException: Le paramÞtre requis
suivant manque : [updateFXConversion.conversionFactor]
at org.apache.ofbiz.service.ModelService.validate(ModelService.java:575)
~[ofbiz.jar:?]
{noformat}
After applying the patch inEclipse (fuzz 5, it's not an up to date trunk patch)
I get the same message. So please check with an updated trunk, because we only
apply improvements over the trunk, thanks.
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using {{run
> service}} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With [^OFBIZ-10692.patch] update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6638: --- Affects Version/s: (was: Release Branch 15.12) (was: Release Branch 14.12) Release Branch 18.12 Release Branch 17.12 Release Branch 16.11 > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Arun Patidar >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741257#comment-16741257 ] Jacques Le Roux commented on OFBIZ-6638: Right Pierre, done > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Arun Patidar >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10760:
--
Fix Version/s: 18.12.01
17.12.01
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741256#comment-16741256
]
Michael Brohl commented on OFBIZ-10760:
---
Thanks Mathieu,
your patches have been committed in
trunk r1851158
release18.12 r1851159
release17.12 r1851160
Should I leave this issue open to cover the NullPointerException issue?
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741240#comment-16741240
]
Pierre Smits edited comment on OFBIZ-10680 at 1/12/19 11:21 AM:
It seems we're getting more and more Git oriented patches from contributors.
While it is convenient to stick to what has decided in the past, it looks like
we're getting more misaligned with what contributors actually work with
(regarding their actual work setups).
Maybe we should revisit the SVN vs Git discussion regarding the project's
future.
was (Author: pfm.smits):
It seems we're getting more and more Git oriented patches from contributors.
While it is convenient to stick to what has decided in the past, it looks like
we're getting more misaligned with what contributors actually work with
(regarding their actual work setups).
Maybe we should revisit the SVN vs Git discussion in lieu of the project's
future.
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[ https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-9115: -- Reopen because of failing test. > Unit test case for service - updatePaymentGatewayConfig > > > Key: OFBIZ-9115 > URL: https://issues.apache.org/jira/browse/OFBIZ-9115 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch > > > Unit test case for service - updatePaymentGatewayConfig -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9115) Unit test case for service - updatePaymentGatewayConfig
[
https://issues.apache.org/jira/browse/OFBIZ-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741253#comment-16741253
]
Michael Brohl commented on OFBIZ-9115:
--
One of these tests are failing on my local setup:
{noformat}
accountingtests testUpdatePaymentGatewayConfig Error assert
ServiceUtil.isSuccess(serviceResult) | | false [errorMessage:Value not found,
cannot update, responseMessage:error, successMessage:null]
Assertion failed:
assert ServiceUtil.isSuccess(serviceResult)
| |
false [errorMessage:Value not found, cannot update, responseMessage:error,
successMessage:null]
at
org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:420)
at
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:663)
at
AutoAcctgPaymentGatewayTests.testUpdatePaymentGatewayConfig(AutoAcctgPaymentGatewayTests.groovy:33)
at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:89)
at
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:148)
at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:73)
at
org.apache.ofbiz.base.start.StartupControlPanel.loadStartupLoaders(StartupControlPanel.java:218)
at
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:71)
at org.apache.ofbiz.base.start.Start.main(Start.java:85){noformat}
> Unit test case for service - updatePaymentGatewayConfig
>
>
> Key: OFBIZ-9115
> URL: https://issues.apache.org/jira/browse/OFBIZ-9115
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9115.patch, OFBIZ-9115.patch
>
>
> Unit test case for service - updatePaymentGatewayConfig
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10760:
--
Affects Version/s: Release Branch 18.12
Release Branch 17.12
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-10760:
-
Assignee: Michael Brohl
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741240#comment-16741240
]
Pierre Smits commented on OFBIZ-10680:
--
It seems we're getting more and more Git oriented patches from contributors.
While it is convenient to stick to what has decided in the past, it looks like
we're getting more misaligned with what contributors actually work with
(regarding their actual work setups).
Maybe we should revisit the SVN vs Git discussion in lieu of the project's
future.
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741243#comment-16741243 ] Pierre Smits commented on OFBIZ-6638: - Then the 'affected version' field should be adjusted. > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Jacques Le Roux >Assignee: Arun Patidar >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741239#comment-16741239 ] Michael Brohl commented on OFBIZ-7016: -- I suggest to leave it open to decide for every contributor himself ;) I'm currently just working though the issues which I am assigned to. Your comments are not very helpful to get things worked on. Let's keep being objective. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-10680:
---
Assignee: Jacques Le Roux
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741238#comment-16741238 ] Pierre Smits commented on OFBIZ-7016: - I suggest to start with the oldest first (OFBIZ-72) when assessing status and work your way up towards most recent. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10661) Significant gaps reflecting in between Input values in the dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704402#comment-16704402 ] Jacques Le Roux edited comment on OFBIZ-10661 at 1/12/19 10:31 AM: --- Hi Archana, This is when a party has no firstName or lastName for a PERSON, or no groupName for a PARTY_GROUP. OOTB there are few cases like all BLOG_* group: BLOG_USERS BLOG_EDITORS BLOG_ADMINS BLOG_AUTHORS BLOG_PUBLISHERS For Person, "_NA_" has no name, nor TestSupplyAdmin So it's more a data issue. You could maybe fill these names? Else please close as won't fix. was (Author: jacques.le.roux): Hi Archana, This is when a party has no firstName or lastName for a PERSON, or no groupName for a PARTY_GROUP. OOTB there are few cases like all BLOG_* group: BLOG_USERS BLOG_EDITORS BLOG_ADMINS BLOG_AUTHORS BLOG_PUBLISHERS For Person, "_NA_" has no name, nor TestSupplyAdmin So it's more a data issue. You could maybe fill these names? Else please as won't fix. > Significant gaps reflecting in between Input values in the dropdown > --- > > Key: OFBIZ-10661 > URL: https://issues.apache.org/jira/browse/OFBIZ-10661 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Garima jain >Priority: Minor > Attachments: ValueDropdown.png > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. While adding Condition, choose input as Party > 4. Scroll down the end for Values reflecting in the dropdown > *Actual: * > Seems, Some of the parties are not listed in the dropdown. > Significant gap is reflecting in between the values. > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741230#comment-16741230 ] Michael Brohl commented on OFBIZ-7016: -- Thanks Jacques. What do others say? Should we better keep this issue open or close? > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741224#comment-16741224 ] Jacques Le Roux commented on OFBIZ-6638: Thanks Rohit, Yes it works in R15 but not in trunk. R15 was never released and is no longer supported. I could not check stable (R16) on demo, someone messed up with the admin password and flexadmin has not accces to that. Anyway I'm pretty sure that R16, R17 and R18 have the same issue. > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Jacques Le Roux >Assignee: Arun Patidar >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741229#comment-16741229 ] Jacques Le Roux commented on OFBIZ-7016: It remind us that the problem is still there. But if you really want to close I'll not oppose, we know the (BIG) problem anyway. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741221#comment-16741221 ] Michael Brohl commented on OFBIZ-7016: -- The information is still there even if this issue is closed. I don't see much value in keeping open issues noone wants to further work on. The pile only grows and it's already big enough. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9774) [FB] Package org.apache.ofbiz.product.config
[ https://issues.apache.org/jira/browse/OFBIZ-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741227#comment-16741227 ] Michael Brohl commented on OFBIZ-9774: -- I'll work on it to fix the error. > [FB] Package org.apache.ofbiz.product.config > > > Key: OFBIZ-9774 > URL: https://issues.apache.org/jira/browse/OFBIZ-9774 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9774_org.apache.ofbiz.product.config_bugfixes.patch > > > ProductConfigItemContentWrapper.java:125, > RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > - RCN: Nullcheck of ProductConfigItemContentWrapper.configItemContentCache at > line 137 of value previously dereferenced in > org.apache.ofbiz.product.config.ProductConfigItemContentWrapper.getProductConfigItemContentAsText(GenericValue, > String, Locale, String, Delegator, LocalDispatcher, String) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the previous dereference disagree as to whether > this value is allowed to be null. Either the check is redundant or the > previous dereference is erroneous. > ProductConfigWorker.java:397, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > - RCN: Redundant nullcheck of configWrapper, which is known to be non-null in > org.apache.ofbiz.product.config.ProductConfigWorker.loadProductConfigWrapper(Delegator, > LocalDispatcher, String, String, String, String, String, String, Locale, > GenericValue) > This method contains a redundant check of a known non-null value against the > constant null. > ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED > - Se: The field > org.apache.ofbiz.product.config.ProductConfigWrapper.dispatcher is transient > but isn't set by deserialization > This class contains a field that is updated at multiple places in the class, > thus it seems to be part of the state of the class. However, since the field > is marked as transient and not set in readObject or readResolve, it will > contain the default value in any deserialized instance of the class. > ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED > - Se: The field > org.apache.ofbiz.product.config.ProductConfigWrapper.delegator is transient > but isn't set by deserialization > This class contains a field that is updated at multiple places in the class, > thus it seems to be part of the state of the class. However, since the field > is marked as transient and not set in readObject or readResolve, it will > contain the default value in any deserialized instance of the class. > ProductConfigWrapper.java:-1, SE_BAD_FIELD > - Se: Class org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigItem > defines non-transient non-serializable instance field content > This Serializable class defines a non-primitive instance field which is > neither transient, Serializable, or java.lang.Object, and does not appear to > implement the Externalizable interface or the readObject() and writeObject() > methods. Objects of this class will not be deserialized correctly if a > non-Serializable object is stored in this field. > ProductConfigWrapper.java:50, SE_NO_SERIALVERSIONID > - SnVI: org.apache.ofbiz.product.config.ProductConfigWrapper is Serializable; > consider declaring a serialVersionUID > This class implements the Serializable interface, but does not define a > serialVersionUID field. A change as simple as adding a reference to a .class > object will add synthetic fields to the class, which will unfortunately > change the implicit serialVersionUID (e.g., adding a reference to > String.class will generate a static field class$java$lang$String). Also, > different source code to bytecode compilers may use different naming > conventions for synthetic variables generated for references to class objects > or inner classes. To ensure interoperability of Serializable across versions, > consider adding an explicit serialVersionUID. > ProductConfigWrapper.java:226, HE_EQUALS_USE_HASHCODE > - HE: org.apache.ofbiz.product.config.ProductConfigWrapper defines equals and > uses Object.hashCode() > This class overrides equals(Object), but does not override hashCode(), and > inherits the implementation of hashCode() from java.lang.Object (which > returns the identity hash code, an arbitrary value assigned to the object by > the VM). Therefore, the class is very likely to violate the invariant that > equal objects must have equal hashcodes. > If you don't think
[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741225#comment-16741225 ] Michael Brohl commented on OFBIZ-10741: --- [~priya.sharma.9362], should I assign this to me as it seems that I was the one to break it with OFBIZ-9774? > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10804: Affects Version/s: (was: Release Branch 17.12) Trunk > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741226#comment-16741226
]
Jacques Le Roux commented on OFBIZ-10680:
-
Thanks Ankit,
Please provide a patch formatted for svn. You can easily find how to do it in
our archives or stackoverflow.
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10803: Affects Version/s: Trunk > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10803: Affects Version/s: (was: Release Branch 17.12) > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10803: Component/s: ecommerce > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9442) Provide (more) tests for the Solr and Lucene components
[ https://issues.apache.org/jira/browse/OFBIZ-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9442. Resolution: Implemented Closing to finish the whole task. If there will be more tests provided, we can create a new issue. > Provide (more) tests for the Solr and Lucene components > --- > > Key: OFBIZ-9442 > URL: https://issues.apache.org/jira/browse/OFBIZ-9442 > Project: OFBiz > Issue Type: Sub-task > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The Lucene component has only one test, the Solr component has none. There > should be some integration tests to test the creation of index entries and > reading from the index. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9440) Refactor the Lucene and Solr Components
[ https://issues.apache.org/jira/browse/OFBIZ-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9440. Resolution: Implemented > Refactor the Lucene and Solr Components > --- > > Key: OFBIZ-9440 > URL: https://issues.apache.org/jira/browse/OFBIZ-9440 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The Lucene and Solr components has several issues which makes it untestable > and unusable as a single plugin. I'm not even sure if this should be a bug or > improvement issue. > There are several file and data dependencies left which should be (re-)moved. > The file runtime/indexes/index.properties should be moved to the solr > component. The folder runtime/indexes should be removed, the components have > to take care of creating their index path(s). > This issue might receive some subtasks along this journey... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10803: Affects Version/s: Release Branch 17.12 > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12 > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Fix For: Release Branch 17.12 > > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10803: Fix Version/s: (was: Release Branch 17.12) > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12 > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741222#comment-16741222 ] Michael Brohl commented on OFBIZ-8297: -- I'm the assignee because I was willing to review and possibly commit your patch. The patch is icomplete and I have described what's wrong with it. I did not get an answer for a year so it seems legitimate to ask if this is an issue you want to work on. If this is not the case (which is ok) and noone else is interested in doing so, I'll close this issue in due time. > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving configuration variables. This doesn't work > in a multi-tenant setup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10804: Fix Version/s: (was: Release Branch 17.12) > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12 > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10804: Affects Version/s: Release Branch 17.12 > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12 > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Fix For: Release Branch 17.12 > > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10804: Fix Version/s: Release Branch 17.12 > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Fix For: Release Branch 17.12 > > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6638: --- Description: # Get to http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company #pick a "Custom Time Period Id" (default works also) #Submit Then the CSV export works but not the PDF, this in trunk demo. was: # Get to http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company #pick a "Custom Time Period Id" (default works also) #Submit Then the CSV export works but not the PDF, this in trunk demo. > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Jacques Le Roux >Assignee: Arun Patidar >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10804: Component/s: ecommerce > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Archana Asthana updated OFBIZ-10803: Fix Version/s: Release Branch 17.12 > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Components: ecommerce > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Fix For: Release Branch 17.12 > > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741220#comment-16741220 ] Jacques Le Roux commented on OFBIZ-7016: Hi Michael, Pierre, I think we can keep open even if we don't work on it right now. There are valuable information there, even if incomplete or even wrong patches. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741218#comment-16741218 ] Pierre Smits commented on OFBIZ-8297: - [~mbrohl], The ticket, and the patch, are more than 2 years old. So it is logical to say that with the rate of changes applied to the code base patches provided will get outdated rather fast. This can be avoided very easily. But, Michael, you're the assignee of the ticket. Why don't you redo the work I contributed on this ticket? > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving configuration variables. This doesn't work > in a multi-tenant setup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9398) Initialize UserLogin.hasLoggedOut to false on very fist login
[ https://issues.apache.org/jira/browse/OFBIZ-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9398. Resolution: Duplicate Closed because this is already fixed in OFBIZ-10506. > Initialize UserLogin.hasLoggedOut to false on very fist login > - > > Key: OFBIZ-9398 > URL: https://issues.apache.org/jira/browse/OFBIZ-9398 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Trivial > > LoginServices.userLogin: If the user is in his very first login session, the > hasLoggedOut flag will still be null during the session since it was never > set by a previous session. In order to read the correct flag value during the > first user session (which should be false), this patch includes an explicit > update to the hasLoggedOut flag to "N" when hasLoggedOut is checked. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7017) Move demo data from content seed files to demo files
[ https://issues.apache.org/jira/browse/OFBIZ-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7017: - Priority: Minor (was: Major) > Move demo data from content seed files to demo files > > > Key: OFBIZ-7017 > URL: https://issues.apache.org/jira/browse/OFBIZ-7017 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > Currently a lot of demo data exists in the data files of the content > component that are load with the command ./ant load-seed. > This data should move to the appropriate data files so that it, a.o. doesn't > trigger lucene indexing unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8317) Update Apache POI to release 3.15
[ https://issues.apache.org/jira/browse/OFBIZ-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-8317. Resolution: Won't Do Closed as announced. > Update Apache POI to release 3.15 > - > > Key: OFBIZ-8317 > URL: https://issues.apache.org/jira/browse/OFBIZ-8317 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > According to the announcement in > https://lists.apache.org/thread.html/777608ec8efada4f441b67ff8327094d0db8be05204d9d073b6f2878@%3Cannounce.apache.org%3E > there is a new POI release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741215#comment-16741215 ] Michael Brohl commented on OFBIZ-8297: -- [~pfm.smits], do you want to provide a corrected patch? > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving configuration variables. This doesn't work > in a multi-tenant setup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8298) Gradle doesn't allow reset of password of tenant-admin
[ https://issues.apache.org/jira/browse/OFBIZ-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-8298. Resolution: Won't Do There seems to be no interest in this requirement. > Gradle doesn't allow reset of password of tenant-admin > -- > > Key: OFBIZ-8298 > URL: https://issues.apache.org/jira/browse/OFBIZ-8298 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > > There is no function available to reset the password of a tenant-admin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-6655) Add session tracking mode and make cookie secure
[
https://issues.apache.org/jira/browse/OFBIZ-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741211#comment-16741211
]
Jacques Le Roux edited comment on OFBIZ-6655 at 1/12/19 10:04 AM:
--
Thanks Deepak,
Your patch is in trunk r1851157
I then checked using the regexp from https://s.apache.org/8Y1Q that there are
not other cases. I did not want to pass 1 hour to create it ;)
was (Author: jacques.le.roux):
Thanks Deepak,
Your patch is in trunk r1851157
I then checked using this regexp:
{code}^(?!.[\s\S]*minutes).[\s\S]*servlet.*${code}
That there is not other cases. The regexp comes from
https://stackoverflow.com/questions/15209711/regex-to-find-files-containing-one-word-but-not-another
I did not want to pass 1 hour to create it ;)
> Add session tracking mode and make cookie secure
>
>
> Key: OFBIZ-6655
> URL: https://issues.apache.org/jira/browse/OFBIZ-6655
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 14.12.01
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01, 17.12.01, 18.12.01
>
> Attachments: OFBIA-6655.applications.patch,
> OFBIZ-6655-programmatically-session-cookies-plugins.patch,
> OFBIZ-6655-programmatically-session-cookies-trunk.patch,
> OFBIZ-6655.framework_themes.patch, OFBIZ-6655_specialpurpose_leftover.patch,
> OFBiz-6655.patch, sessionConifg_ecommerce.patch
>
>
> Need to enhance security at web-app level.
> As per current implementation:
> - The cookie containing the session identifier is not secure
> - The session identifier is transmitted in the query string of the URL
> To fix these issue we have to add following session config otpions in web.xml
> {code}
>
>
> true
> true
>
> COOKIE
>
> {code}
> Also we need to update the web-app servlet specification from 2.3 to 3.0
> {code}
> xmlns="http://java.sun.com/xml/ns/javaee;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
>
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd;>
> {code}
> https://tomcat.apache.org/whichversion.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-8297: - Priority: Minor (was: Major) > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving configuration variables. This doesn't work > in a multi-tenant setup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7016: - Priority: Minor (was: Major) > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8230) Disentangle platform specific entity engine schemas
[ https://issues.apache.org/jira/browse/OFBIZ-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-8230. Resolution: Won't Do Closing as there seems to be no more supporters of this change and there are objections against ist. > Disentangle platform specific entity engine schemas > --- > > Key: OFBIZ-8230 > URL: https://issues.apache.org/jira/browse/OFBIZ-8230 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Labels: database, devops, refactoring > Attachments: OFBIZ-8230-entityengine-postgresql.xml.patch, > OFBIZ-8230-entityengine.xml.patch > > > Disentangle entity engine schemas for specific rdbms platforms from > entityengine.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741212#comment-16741212 ] Michael Brohl commented on OFBIZ-7016: -- I'm just trying to clean up the issues. In this case, you were asked questions on the issue you raised, hence this follow-up. If you don't want to work on this further or provide a clean set of changes (see comments), it's fine. If there is noone else to work on this or interested in doing so, I'll close the ticket as "Won't do". > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10749) Unable to submit set Billing form in order manager when payment method is EFT
[ https://issues.apache.org/jira/browse/OFBIZ-10749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741210#comment-16741210 ] Pierre Smits commented on OFBIZ-10749: -- Does this need to be backported? If so, please correct the affected version field. > Unable to submit set Billing form in order manager when payment method is EFT > - > > Key: OFBIZ-10749 > URL: https://issues.apache.org/jira/browse/OFBIZ-10749 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Chandrashekhar Dhakad >Priority: Major > Attachments: 1-SetCustomer.png, 10-ConsoleError.png, 2-Continue.png, > 3-AddProduct.png, 4-QuickFinalizeOrder.png, 5-EftAccount.png, > 6-TelecomNumber.png, 7-Address.png, 8-EFT.png, 9-BillingAddress.png, > OFBIZ-10749.patch > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue (Please refer attachment: 1-SetCustomer) > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Add product and click on Quick Finalize Order (Please refer attachment: > 3-AddProduct) > # On Quick Finalize Order page select UPS Air and click on EFT Account > (Please refer attachment: 4-QuickFinalizeOrder) > # Enter account details but do not select billing address and click on Save > button(Please refer attachment: 5-EftAccount) > # Add phone and email address and click on continue (Please refer > attachment: 6-TelecomNumber) > # Enter address (Please refer attachment: 7-Address) > # Click continue on Sales Order : Order Entry Order Terms page > # Select Electronic Fund Transfer on Sales Order : Order Entry Payment > Settings and click continue (Please refer attachment: 8-EFT) > # Enter billing address and click on continue (Please refer attachment: > 9-BillingAddress) > Actual: Unable to Submit form and error message was displayed on console > (Please refer attachment: 10-ConsoleError) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-6655) Add session tracking mode and make cookie secure
[
https://issues.apache.org/jira/browse/OFBIZ-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-6655.
--
Resolution: Fixed
Thanks Deepak,
Your patch is in trunk r1851157
I then checked using this regexp:
{code}^(?!.[\s\S]*minutes).[\s\S]*servlet.*${code}
That there is not other cases. The regexp comes from
https://stackoverflow.com/questions/15209711/regex-to-find-files-containing-one-word-but-not-another
I did not want to pass 1 hour to create it ;)
> Add session tracking mode and make cookie secure
>
>
> Key: OFBIZ-6655
> URL: https://issues.apache.org/jira/browse/OFBIZ-6655
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 14.12.01
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01, 14.12.01, 15.12.01
>
> Attachments: OFBIA-6655.applications.patch,
> OFBIZ-6655-programmatically-session-cookies-plugins.patch,
> OFBIZ-6655-programmatically-session-cookies-trunk.patch,
> OFBIZ-6655.framework_themes.patch, OFBIZ-6655_specialpurpose_leftover.patch,
> OFBiz-6655.patch, sessionConifg_ecommerce.patch
>
>
> Need to enhance security at web-app level.
> As per current implementation:
> - The cookie containing the session identifier is not secure
> - The session identifier is transmitted in the query string of the URL
> To fix these issue we have to add following session config otpions in web.xml
> {code}
>
>
> true
> true
>
> COOKIE
>
> {code}
> Also we need to update the web-app servlet specification from 2.3 to 3.0
> {code}
> xmlns="http://java.sun.com/xml/ns/javaee;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
>
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd;>
> {code}
> https://tomcat.apache.org/whichversion.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7017) Move demo data from content seed files to demo files
[ https://issues.apache.org/jira/browse/OFBIZ-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741208#comment-16741208 ] Pierre Smits commented on OFBIZ-7017: - The situation regarding this ticket is similar to OFBIZ-7016 > Move demo data from content seed files to demo files > > > Key: OFBIZ-7017 > URL: https://issues.apache.org/jira/browse/OFBIZ-7017 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > Currently a lot of demo data exists in the data files of the content > component that are load with the command ./ant load-seed. > This data should move to the appropriate data files so that it, a.o. doesn't > trigger lucene indexing unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741206#comment-16741206 ] Pierre Smits commented on OFBIZ-7016: - [~mbrohl], If you had paid a bit more attention you would have noticed that I am not the assignee of the ticket. At the moment I have other fish to fry to go through the entire set of comment provided by various participants to determine the status. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10804) Screen seems distorted while allowing split to Shipment
[ https://issues.apache.org/jira/browse/OFBIZ-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741198#comment-16741198 ] Pierre Smits commented on OFBIZ-10804: -- Please set the correct value at the 'Component' field of the ticket. Please set the correct value at the 'Affects Version' field. The next contributor and our (potential) adopter can then more easily assess where the issue is occurring. > Screen seems distorted while allowing split to Shipment > --- > > Key: OFBIZ-10804 > URL: https://issues.apache.org/jira/browse/OFBIZ-10804 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship >Reporter: Archana Asthana >Priority: Major > Attachments: SplitItemsForShipping.png > > > Steps to Regenerate > 1. Open url: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/splitship > 2. Add few products to the cart > 3. Click View Cart > 4. Allow split to the shipment and check the screen > *Actual: * > The screen seems distorted. Alignment issue is also visible. > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741201#comment-16741201 ] Pierre Smits commented on OFBIZ-10740: -- Please set the correct value at the 'Component' field of the ticket. Please set the correct value at the 'Affects Version' field. As this is regarded a bug, it would help if it reference the correct release branch where it first occurred. The next contributor and our (potential) adopter can then more easily assess where the issue is occurring, and where it should be applied. > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Bug >Reporter: Dikpal Kanungo >Assignee: Sourabh Punyani >Priority: Trivial > Attachments: Screenshot.png, ellipsis for consistency.png, ellipsis > for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > !ellipsis for consistency.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7017) Move demo data from content seed files to demo files
[ https://issues.apache.org/jira/browse/OFBIZ-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741200#comment-16741200 ] Michael Brohl commented on OFBIZ-7017: -- Hi [~pfm.smits], what's the state if this issue? > Move demo data from content seed files to demo files > > > Key: OFBIZ-7017 > URL: https://issues.apache.org/jira/browse/OFBIZ-7017 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > > Currently a lot of demo data exists in the data files of the content > component that are load with the command ./ant load-seed. > This data should move to the appropriate data files so that it, a.o. doesn't > trigger lucene indexing unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741199#comment-16741199 ] Michael Brohl commented on OFBIZ-7016: -- [~pfm.smits], can you please give us a status of this work? > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9243) load demo data failure
[ https://issues.apache.org/jira/browse/OFBIZ-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741197#comment-16741197 ] Michael Brohl commented on OFBIZ-9243: -- [~deepak.dixit], any plans with this issue? > load demo data failure > -- > > Key: OFBIZ-9243 > URL: https://issues.apache.org/jira/browse/OFBIZ-9243 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Deepak Dixit >Priority: Major > Attachments: ofbiz-framework-buildbot gradlew loadDefault.log.txt > > > checkout latest ofbiz-framework and ofbiz-plugins > $ gradlew cleanAll build > $ gradlew loadDefault...using derby > console output... > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| 00040 of 17229 from > file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| The following errors occurred in the data load: > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A > transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error > was: A transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed. > }} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10803) Product Images are not rendering on View Cart screen
[ https://issues.apache.org/jira/browse/OFBIZ-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741196#comment-16741196 ] Pierre Smits commented on OFBIZ-10803: -- Please set the correct value at the 'Component' field of the ticket. Please set the correct value at the 'Affects Version' field. The next contributor and our (potential) adopter can then more easily assess where the issue is occurring. > Product Images are not rendering on View Cart screen > > > Key: OFBIZ-10803 > URL: https://issues.apache.org/jira/browse/OFBIZ-10803 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart >Reporter: Archana Asthana >Priority: Major > Attachments: ProductImages.png > > > Steps to Regenerate > 1. Open url: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/view/showcart > 2. Add few products to the cart > 3. Click View Cart and check the product images > *Actual: * > Product images are not rendering on view cart screen > The Image is attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10776) Change 'uiLabelMap' requirement in Framework code
[ https://issues.apache.org/jira/browse/OFBIZ-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10776: - Assignee: Michael Brohl (was: Pierre Smits) > Change 'uiLabelMap' requirement in Framework code > - > > Key: OFBIZ-10776 > URL: https://issues.apache.org/jira/browse/OFBIZ-10776 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > > Reducing byte size of 'uiLabelMap' from code elements in Framework will lead > to significant saves in widgets, templates and functions downstream. > See > https://github.com/PierreSmits/ofbiz-framework/commit/438e9c45eede9c7036ba9e658036085908dce09d -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6100) Inconsistent tax calculation between checkout finalize and order created screen
[ https://issues.apache.org/jira/browse/OFBIZ-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741194#comment-16741194 ] Michael Brohl commented on OFBIZ-6100: -- [~ofbizzer], any chance to provide an example? Else I tend to close this issue. > Inconsistent tax calculation between checkout finalize and order created > screen > --- > > Key: OFBIZ-6100 > URL: https://issues.apache.org/jira/browse/OFBIZ-6100 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > > I changed arithmetic.properties salestax.calc.decimals = 4 instead of 3 > because my purchase order tax was 1 cent less than the receipt. After > accounting for 4 decimals, the tax was correctly calculated at the checkout > finalize page, but once the order was created, the tax was 1 cent less than > its previously calculated value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10796) Check run payment(A/P) transactions not getting available for reconciliation
[ https://issues.apache.org/jira/browse/OFBIZ-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741193#comment-16741193 ] Pierre Smits commented on OFBIZ-10796: -- A check run transaction is not a financial transaction but rather a obligation transaction that leads to a movement of amounts from one gl account to another (both related to obligations). A financial transaction only occurs when the payment is effectuated by the financial service provider (reported via their account statements). Creating a financial transaction the moment the payment run is created leads to additional (correction) work in the accounting department to ensure that actuals are indeed happening on the correct date. > Check run payment(A/P) transactions not getting available for reconciliation > > > Key: OFBIZ-10796 > URL: https://issues.apache.org/jira/browse/OFBIZ-10796 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01 >Reporter: Chinmay Patidar >Assignee: Chinmay Patidar >Priority: Major > Attachments: OFBIZ-10796.patch > > > Check run payment group transactions don't get available for Financial > Account reconciliation. Though the financial account balance gets updated > during the A/P check run process, the system must allow the user with an > additional step of reconciling the transactions. > Steps to regenerate: > # Create a Check Run type payment group by issuing checks for an invoice/ > the invoices from the following screen: > [https://demo-trunk.ofbiz.apache.org/ap/control/FindPurchaseInvoices] > # (Additional Note)The balance of the financial account gets updated as soon > as the payment group is created. > # Visit to the "Find Transaction" screen of the company from which the check > run was created. > # Set 'Gl Reconciliation ID' field to value 'Not Assigned' and find the > transaction. The newly created Financial account transaction won't be > available to assign to a reconciliation. > The cause of this is that the financial account transaction doesn't get > created in the 'Created' status and has an 'Approved' status. An approved > status financial transaction directly updates the financial account balance > and thus don't appear in the list of the transactions to be reconciled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
