[jira] [Closed] (OFBIZ-10661) Significant gaps reflecting in between Input values in the dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10661. --- Resolution: Not A Problem Assignee: Jacques Le Roux (was: Garima jain) > Significant gaps reflecting in between Input values in the dropdown > --- > > Key: OFBIZ-10661 > URL: https://issues.apache.org/jira/browse/OFBIZ-10661 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Jacques Le Roux >Priority: Minor > Attachments: ValueDropdown.png > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. While adding Condition, choose input as Party > 4. Scroll down the end for Values reflecting in the dropdown > *Actual: * > Seems, Some of the parties are not listed in the dropdown. > Significant gap is reflecting in between the values. > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10741: - Assignee: Michael Brohl > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Michael Brohl >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741784#comment-16741784 ] Jacques Le Roux commented on OFBIZ-10666: - Yes the problem is autoName, will see later... > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741773#comment-16741773 ] Aditya Sharma edited comment on OFBIZ-9848 at 1/14/19 5:25 AM: --- Done for trunk at r1851224 and R18.12 at r1851225 Slightly modified commit from patch mask applied input with to identifier as id rather than Id_i18n was (Author: aditya.sharma): Done for trunk at r1851224 and R18.12 at r1851225 > Replace Inline js with External js in renderDateTimeField macro > --- > > Key: OFBIZ-9848 > URL: https://issues.apache.org/jira/browse/OFBIZ-9848 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Fix For: 18.12.01 > > Attachments: OFBIZ-9848.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741773#comment-16741773 ] Aditya Sharma commented on OFBIZ-9848: -- Done for trunk at r1851224 and R18.12 at r1851225 > Replace Inline js with External js in renderDateTimeField macro > --- > > Key: OFBIZ-9848 > URL: https://issues.apache.org/jira/browse/OFBIZ-9848 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9848.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-10741: Assignee: (was: Priya Sharma) > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9848. > Replace Inline js with External js in renderDateTimeField macro > --- > > Key: OFBIZ-9848 > URL: https://issues.apache.org/jira/browse/OFBIZ-9848 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Fix For: 18.12.01 > > Attachments: OFBIZ-9848.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741771#comment-16741771 ] Priya Sharma commented on OFBIZ-10741: -- Sure, Michael. > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10661) Significant gaps reflecting in between Input values in the dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741767#comment-16741767 ] Garima jain commented on OFBIZ-10661: - Yes, when working on this ticket, explored the code and also the entity and found that the data is missing. Added missing data and now we can close this ticket. > Significant gaps reflecting in between Input values in the dropdown > --- > > Key: OFBIZ-10661 > URL: https://issues.apache.org/jira/browse/OFBIZ-10661 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Garima jain >Priority: Minor > Attachments: ValueDropdown.png > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. While adding Condition, choose input as Party > 4. Scroll down the end for Values reflecting in the dropdown > *Actual: * > Seems, Some of the parties are not listed in the dropdown. > Significant gap is reflecting in between the values. > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741761#comment-16741761 ] Deepak Nigam edited comment on OFBIZ-10666 at 1/14/19 4:56 AM: --- Thanks for the detailed research [~jacques.le.roux]. I have already tried by removing getMaxAge() from LoginWorker.getAutoUserLoginId() and setMaxAge(0) in the method LoginWorker.autoLoginRemove(). Even after setting the max age 0 I was getting the auto-login cookie from the cookies array inside LoginWorker.getAutoUserLoginId() method. It means the above statement "If a cookie has expired, the browser does not send that particular cookie to the server with the page request; instead, the expired cookie is deleted." is not 100% correct. So, if we remove the getMaxAge() check from the condition, then the issue reported in this ticket will come again. was (Author: deepak.nigam): Thanks for the detailed research [~jacques.le.roux]. I have already tried by removing getMaxAge() from LoginWorker.getAutoUserLoginId() and setMaxAge(0). Even after setting the max age 0 I was getting the auto-login cookie from the cookies array inside LoginWorker.getAutoUserLoginId() method. It means the above statement "If a cookie has expired, the browser does not send that particular cookie to the server with the page request; instead, the expired cookie is deleted." is not 100% correct. So, if we remove the getMaxAge() check from the condition, then the issue reported in this ticket will come again. > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741761#comment-16741761 ] Deepak Nigam commented on OFBIZ-10666: -- Thanks for the detailed research [~jacques.le.roux]. I have already tried by removing getMaxAge() from LoginWorker.getAutoUserLoginId() and setMaxAge(0). Even after setting the max age 0 I was getting the auto-login cookie from the cookies array inside LoginWorker.getAutoUserLoginId() method. It means the above statement "If a cookie has expired, the browser does not send that particular cookie to the server with the page request; instead, the expired cookie is deleted." is not 100% correct. So, if we remove the getMaxAge() check from the condition, then the issue reported in this ticket will come again. > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741642#comment-16741642 ] Jacques Le Roux commented on OFBIZ-7016: Yes, not implemented. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741586#comment-16741586 ] Pierre Smits commented on OFBIZ-7016: - [~jacques.le.roux], Now you got even me confused. According to your last posting the issue still exists. Yet, your peer set the status of the ticket to 'Closed' with the project's resolution to 'Won't Do'. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10672) Errors on Quick Add Page
[ https://issues.apache.org/jira/browse/OFBIZ-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741582#comment-16741582 ] Jacques Le Roux commented on OFBIZ-10672: - Hi Rashi, Is that only in old demo (R16)? > Errors on Quick Add Page > > > Key: OFBIZ-10672 > URL: https://issues.apache.org/jira/browse/OFBIZ-10672 > Project: OFBiz > Issue Type: Bug >Reporter: Rashi Dhagat >Priority: Major > Attachments: QuickAdd.gif, QuickAddPage.png > > > Steps to regenerate: > # Open URL [http://demo-old.ofbiz.apache.org:28080/ecommerce/control/main] > # Click on Quick Add > # Add 1 quantity of Round Gizmo > # Click on Add all to cart > # Add 1 quantity of Big Gizmo > # Click on Add all to cart > Actual: > # When added Round Gizmo, only one quantity is added to cart with 0 price > # When added Big Gizmo, all items are added to cart > # Distorted UI of Quick Add page > # Quantity field is empty > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10766) Impossible secure and autologin cookie names when mountpoint contains a slash inside its name
[ https://issues.apache.org/jira/browse/OFBIZ-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741581#comment-16741581 ] Jacques Le Roux commented on OFBIZ-10766: - I have finally reverted to the initial commits (ie the ones in the 1st comment) in trunk r1851200 R18 r1851201 R17 r1851203 R16 r1851202 > Impossible secure and autologin cookie names when mountpoint contains a slash > inside its name > - > > Key: OFBIZ-10766 > URL: https://issues.apache.org/jira/browse/OFBIZ-10766 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > > When you set a mountpoint which contains a slash inside its name (ie not only > a slash as a trailer, which is possible), as it's needed with OFBIZ-10765, > OFBiz tries to create a cookie with a slash in its name and [that's > impossible|https://stackoverflow.com/questions/1969232/allowed-characters-in-cookies]. > This was reported by [~mz4wheeler] on [ilscipio > forum|https://forum.scipioerp.com/t/control-payment-type-options-in-store/215/53] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741556#comment-16741556 ] Jacques Le Roux edited comment on OFBIZ-9677 at 1/13/19 1:39 PM: - Before reverting all (easy), I let Paul have a look at it. Notably if he should not have changed the tests which fail, say a week... was (Author: jacques.le.roux): Before reverting all (easy), I let Paul have a look at it. Notably if he should not have changed the tests which fail, say 3 days... > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741580#comment-16741580 ] Jacques Le Roux commented on OFBIZ-7016: Hi Pierre, could you please support this comment with somes references, like commits or Jiras? I my memory we still have data dependencies from ecommerce to the framework (at large including applications); only the data model is OK. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10805) OFBiz shell
[
https://issues.apache.org/jira/browse/OFBIZ-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741577#comment-16741577
]
Mathieu Lirzin commented on OFBIZ-10805:
One issue that I discover is that currently the shell doesn't play well with
services implemented using the Groovy engine since it relies on the Groovy DSL.
The issue looks like a shared instance problem. If the Groovy engine is loaded
before the first shell session things works fine, however if that's not the
case then services implemented in Groovy can not be invoked anymore. Here is an
example showing the issue at hand with the {{createQuote}} service which is
implemented in Groovy.
Here is the failing scenario: I launch the OFBiz server, then invoke
{{createQuote}} directly via the shell and obtains the following error:
{code:java}
groovy:000> dispatcher.runSync('createQuote', [userLogin: admin, partyId:
'Company'])
ERROR org.apache.ofbiz.service.GenericServiceException:
Error running Groovy method [createQuote] in Groovy file
[component://order/groovyScripts/quote/QuoteServices.groovy]:
(groovy.lang.MissingMethodException: No signature of method:
QuoteServices.makeValue() is applicable for argument types: (java.lang.String,
java.util.HashMap) values: [Quote, [userLogin:[lastUpdatedStamp:2019-01-08
09:30:37.047, ...], ...]])
at org.apache.ofbiz.service.engine.GroovyEngine.serviceInvoker
(GroovyEngine.java:129)
at org.apache.ofbiz.service.engine.GroovyEngine.runSync
(GroovyEngine.java:83)
at org.apache.ofbiz.service.ServiceDispatcher.runSync
(ServiceDispatcher.java:415)
at org.apache.ofbiz.service.ServiceDispatcher.runSync
(ServiceDispatcher.java:240)
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync
(GenericDispatcherFactory.java:88)
at org.apache.ofbiz.service.LocalDispatcher$runSync.call (Unknown
Source)
{code}
Afterwards invoking the {{createQuote}} service via the the web interface fails
with the same error.
Here is the successful scenario: I launch the OFBiz server, then invoke
{{createQuote}} via the web interface
{{[https://localhost:8443/webtools/control/runService]}} which loads the Groovy
Engine with the DSL features., and finally I reinvoke {{createQuote}} via the
shell:
{code:java}
groovy:000> dispatcher.runSync('createQuote', [userLogin: admin, partyId:
'Company'])
===> [successMessage:Quote Created Successfully, quoteId:10051]
{code}
Does anyone know a proper way to embed multiple Groovy runtimes inside a single
Java application?
> OFBiz shell
> ---
>
> Key: OFBIZ-10805
> URL: https://issues.apache.org/jira/browse/OFBIZ-10805
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10805_OFBiz-shell.patch
>
>
> One issue with the current way of writing Groovy tests is that the feedback
> between writing an instruction and checking its result is slow because one
> has to rerun the corresponding test case.
> Providing a Groovy shell access with a delegator and dispatcher allows
> developers to interactively execute commands and check their results
> instantly.
> The shell access has been done via Remote Procedure Call (RPC) which was
> already implemented by the {{AdminClient}} and {{AdminServer}} classes.
> In order to test, you must start the server first:
> {code}
> $ ./gradlew ofbiz
> {code}
> then you can run the following command in another terminal:
> {code}
> $ java -jar build/libs/ofbiz.jar --shell
> {code}
> or this equivalent one which uses the corresponding short option:
> {code}
> $ java -jar build/libs/ofbiz.jar -i
> {code}
> *Limitation*: It is currently not possible to connect multiple shells at
> the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10805) OFBiz shell
[
https://issues.apache.org/jira/browse/OFBIZ-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10805:
---
Attachment: (was: OFBIZ-10805_OFBiz-shell.patch)
> OFBiz shell
> ---
>
> Key: OFBIZ-10805
> URL: https://issues.apache.org/jira/browse/OFBIZ-10805
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
>
> One issue with the current way of writing Groovy tests is that the feedback
> between writing an instruction and checking its result is slow because one
> has to rerun the corresponding test case.
> Providing a Groovy shell access with a delegator and dispatcher allows
> developers to interactively execute commands and check their results
> instantly.
> The shell access has been done via Remote Procedure Call (RPC) which was
> already implemented by the {{AdminClient}} and {{AdminServer}} classes.
> In order to test, you must start the server first:
> {code}
> $ ./gradlew ofbiz
> {code}
> then you can run the following command in another terminal:
> {code}
> $ java -jar build/libs/ofbiz.jar --shell
> {code}
> or this equivalent one which uses the corresponding short option:
> {code}
> $ java -jar build/libs/ofbiz.jar -i
> {code}
> *Limitation*: It is currently not possible to connect multiple shells at
> the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741556#comment-16741556 ] Jacques Le Roux commented on OFBIZ-9677: Before reverting all (easy), I let Paul have a look at it. Notably if he should not have changed the tests which fail, say 3 days... > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[
https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741530#comment-16741530
]
Jacques Le Roux edited comment on OFBIZ-10666 at 1/13/19 11:41 AM:
---
Actually we need more than that, and it's still not enough. According to
[https://www.google.com/search?q=java+get+rid+of+a+cookie=UTF-8] , we need:
{noformat}
Index:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
===
---
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(revision 1851194)
+++
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(working copy)
@@ -975,8 +975,7 @@
}
if (cookies != null) {
for (Cookie cookie: cookies) {
-if (cookie.getName().equals(getAutoLoginCookieName(request))
-&& cookie.getMaxAge() > 0) {
+if (cookie.getName().equals(getAutoLoginCookieName(request))) {
autoUserLoginId = cookie.getValue();
break;
}
@@ -1012,7 +1011,6 @@
if (autoUserLogin != null){
return "success";
}
-
return autoLoginCheck(delegator, session, getAutoUserLoginId(request));
}
@@ -1052,7 +1050,7 @@
// remove the cookie
if (userLogin != null) {
-Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request), userLogin.getString("userLoginId"));
+Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request), "");
autoLoginCookie.setMaxAge(0);
autoLoginCookie.setPath("/");
response.addCookie(autoLoginCookie);
{noformat}
But then we still have an issue with
{noformat}
private static String autoLoginCheck(Delegator delegator, HttpSession session,
String autoUserLoginId) {
[...]
if (person != null) {
session.setAttribute("autoName",
person.getString("firstName") + " " + person.getString("lastName"));
} else if (group != null) {
session.setAttribute("autoName",
group.getString("groupName"));
}
{noformat}
Which systematically resurrects autoName.
BTW we have 2 other occurences of {{setMaxAge(0)}} and only one use the right
strategy (using null instead of an empty String, I guess both work).
was (Author: jacques.le.roux):
Actually we need more than that, and it's still not enough. According to
[https://www.google.com/search?q=java+get+rid+of+a+cookie=UTF-8] , we need:
{noformat}
Index:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
===
---
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(revision 1851194)
+++
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(working copy)
@@ -975,8 +975,7 @@
}
if (cookies != null) {
for (Cookie cookie: cookies) {
-if (cookie.getName().equals(getAutoLoginCookieName(request))
-&& cookie.getMaxAge() > 0) {
+if (cookie.getName().equals(getAutoLoginCookieName(request))) {
autoUserLoginId = cookie.getValue();
break;
}
@@ -1012,7 +1011,6 @@
if (autoUserLogin != null){
return "success";
}
-
return autoLoginCheck(delegator, session, getAutoUserLoginId(request));
}
@@ -1052,7 +1050,7 @@
// remove the cookie
if (userLogin != null) {
-Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request), userLogin.getString("userLoginId"));
+Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request), "");
autoLoginCookie.setMaxAge(0);
autoLoginCookie.setPath("/");
response.addCookie(autoLoginCookie);
{noformat}
But then we still have an issue with
{noformat}
private static String autoLoginCheck(Delegator delegator, HttpSession session,
String autoUserLoginId) {
[...]
if (person != null) {
session.setAttribute("autoName",
person.getString("firstName") + " " + person.getString("lastName"));
} else if (group != null) {
session.setAttribute("autoName",
group.getString("groupName"));
}
{noformat}
Which systematically resurrects autoName. I begin to wonder if we should not
rewrite the whole and use rather another not cookie based strategy like exposed
at
[https://stackoverflow.com/questions/2185951/how-do-i-keep-a-user-logged-into-my-site-for-months]
(1st answer, Java 8).
It's a bit early to tell, but I already spent
[jira] [Updated] (OFBIZ-10805) OFBiz shell
[
https://issues.apache.org/jira/browse/OFBIZ-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10805:
---
Attachment: OFBIZ-10805_OFBiz-shell.patch
> OFBiz shell
> ---
>
> Key: OFBIZ-10805
> URL: https://issues.apache.org/jira/browse/OFBIZ-10805
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10805_OFBiz-shell.patch
>
>
> One issue with the current way of writing Groovy tests is that the feedback
> between writing an instruction and checking its result is slow because one
> has to rerun the corresponding test case.
> Providing a Groovy shell access with a delegator and dispatcher allows
> developers to interactively execute commands and check their results
> instantly.
> The shell access has been done via Remote Procedure Call (RPC) which was
> already implemented by the {{AdminClient}} and {{AdminServer}} classes.
> In order to test, you must start the server first:
> {code}
> $ ./gradlew ofbiz
> {code}
> then you can run the following command in another terminal:
> {code}
> $ java -jar build/libs/ofbiz.jar --shell
> {code}
> or this equivalent one which uses the corresponding short option:
> {code}
> $ java -jar build/libs/ofbiz.jar -i
> {code}
> *Limitation*: It is currently not possible to connect multiple shells at
> the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741535#comment-16741535 ] Pierre Smits edited comment on OFBIZ-7016 at 1/13/19 10:54 AM: --- I guess that, with the dependency on ecommerce data (by applications/components in the base repo) having been removed, the status of this ticket should be 'implemented' instead of 'Won't do'. The result is achieved, though through actions of another kind. was (Author: pfm.smits): I guess that, with the dependency on ecommerce data (by applications/components in the base repo) being removed, the status of this ticket should be 'implemented' instead of 'Won't do'. The result is achieved, though through actions of another kind. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741535#comment-16741535 ] Pierre Smits commented on OFBIZ-7016: - I guess that, with the dependency on ecommerce data (by applications/components in the base repo) being removed, the status of this ticket should be 'implemented' instead of 'Won't do'. The result is achieved, though through actions of another kind. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[
https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741530#comment-16741530
]
Jacques Le Roux commented on OFBIZ-10666:
-
Actually we need more than that, and it's still not enough. According to
[https://www.google.com/search?q=java+get+rid+of+a+cookie=UTF-8] , we need:
{noformat}
Index:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
===
---
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(revision 1851194)
+++
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
(working copy)
@@ -975,8 +975,7 @@
}
if (cookies != null) {
for (Cookie cookie: cookies) {
-if (cookie.getName().equals(getAutoLoginCookieName(request))
-&& cookie.getMaxAge() > 0) {
+if (cookie.getName().equals(getAutoLoginCookieName(request))) {
autoUserLoginId = cookie.getValue();
break;
}
@@ -1012,7 +1011,6 @@
if (autoUserLogin != null){
return "success";
}
-
return autoLoginCheck(delegator, session, getAutoUserLoginId(request));
}
@@ -1052,7 +1050,7 @@
// remove the cookie
if (userLogin != null) {
-Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request), userLogin.getString("userLoginId"));
+Cookie autoLoginCookie = new
Cookie(getAutoLoginCookieName(request), "");
autoLoginCookie.setMaxAge(0);
autoLoginCookie.setPath("/");
response.addCookie(autoLoginCookie);
{noformat}
But then we still have an issue with
{noformat}
private static String autoLoginCheck(Delegator delegator, HttpSession session,
String autoUserLoginId) {
[...]
if (person != null) {
session.setAttribute("autoName",
person.getString("firstName") + " " + person.getString("lastName"));
} else if (group != null) {
session.setAttribute("autoName",
group.getString("groupName"));
}
{noformat}
Which systematically resurrects autoName. I begin to wonder if we should not
rewrite the whole and use rather another not cookie based strategy like exposed
at
[https://stackoverflow.com/questions/2185951/how-do-i-keep-a-user-logged-into-my-site-for-months]
(1st answer, Java 8).
It's a bit early to tell, but I already spent a lot of time with this...
BTW we have 2 other occurences of {{setMaxAge(0)}} and only one use the right
strategy (using null instead of an empty String, I guess both work).
> User's name is displayed on ecommerce even after user logs out
> --
>
> Key: OFBIZ-10666
> URL: https://issues.apache.org/jira/browse/OFBIZ-10666
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
> Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png,
> 4-NotYou.png, OFBIZ-10666.patch
>
>
> Steps to regenerate:
> # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
> Welcome is displayed and user's name is not displayed when URL is opened.
> (Please refer attachment: 1-OpenURL)
> # Login at ecommerce by clicking on login and entering Username: "admin" and
> Password: "ofbiz". Username will be displayed after user logs in. (Please
> refer attachment: 2-LoggedIn)
> # Logout of ecommerce by clicking on logout. User will be logged out and
> login link will be displayed in place of logout link, but the name of user is
> still displayed. (Please refer attachment: 3-LoggedOut)
> Actual: Username is still displayed after user logs out
>
> Expected: Username should not be displayed after the user logs out
>
> Note: Similar issue also exists when the user clicks on (Not You? Click Here)
> link. (Please refer attachment: 4-NotYou)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741526#comment-16741526 ] Michael Brohl commented on OFBIZ-9677: -- The issue should at least be updated with the correct affects and fix versions. If the commit(s) introduced a new bug, they should be reverted and corrected before being committed again. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-7016. Resolution: Won't Do Assignee: Michael Brohl I'm closing this ticket. It's based on an now outdated situation (we do not have specialpurpose anymore) and all tests regarding this work are running successful without the plugins (former specialpurpose). If needed, we can always open a new Jira linked to this, using the current codebase/structure and providing proper patches. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10802) UserLoginPasswordHistory is not maintaining password as present in UserLogin.
[ https://issues.apache.org/jira/browse/OFBIZ-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741519#comment-16741519 ] Rohit Koushal commented on OFBIZ-10802: --- [~suraj.khurana] , This glitch is available since 12.04. > UserLoginPasswordHistory is not maintaining password as present in UserLogin. > - > > Key: OFBIZ-10802 > URL: https://issues.apache.org/jira/browse/OFBIZ-10802 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, > 16.11.06, Release Branch 17.12, Release Branch 18.12 >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10802.patch, UL.png, ULPH.png > > > While maintaining UserLoginPasswordHistory in the system, the password is > encrypted with the random salt hence it will not match with the password save > in UserLogin. So we need to improve this area of code. > > Please refer below screenshots > *UserLogin* > *!UL.png!* > *UserLoginPasswordHistory* > *!ULPH.png!* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10802) UserLoginPasswordHistory is not maintaining password as present in UserLogin.
[ https://issues.apache.org/jira/browse/OFBIZ-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10802: -- Affects Version/s: Release Branch 18.12 Release Branch 17.12 16.11.06 17.12.01 Release Branch 13.07 Release Branch 14.12 Trunk Release Branch 15.12 Release Branch 16.11 16.11.04 16.11.05 > UserLoginPasswordHistory is not maintaining password as present in UserLogin. > - > > Key: OFBIZ-10802 > URL: https://issues.apache.org/jira/browse/OFBIZ-10802 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, > 16.11.06, Release Branch 17.12, Release Branch 18.12 >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10802.patch, UL.png, ULPH.png > > > While maintaining UserLoginPasswordHistory in the system, the password is > encrypted with the random salt hence it will not match with the password save > in UserLogin. So we need to improve this area of code. > > Please refer below screenshots > *UserLogin* > *!UL.png!* > *UserLoginPasswordHistory* > *!ULPH.png!* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741515#comment-16741515 ] Pierre Smits commented on OFBIZ-9677: - I would suggest not to backport when the 'affected version' does not indicate that it experienced in an already released version/branch. > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7016) move base component demo data from specialpurpose/ecommerce to base components
[ https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741513#comment-16741513 ] Pierre Smits commented on OFBIZ-7016: - Hi [~taher], It seems that the gist of your second paragraph should be discussed elsewhere. > move base component demo data from specialpurpose/ecommerce to base components > -- > > Key: OFBIZ-7016 > URL: https://issues.apache.org/jira/browse/OFBIZ-7016 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7016-EcommercePartyData-v3.patch, > OFBIZ-7016-EcommercePartyData.patch, > OFBIZ-7016-EcommerceProductData-v2.patch, > OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch > > > Currently a lot of demo data exists in the ecommerce component that should go > into the appropriate base components (e.g. party, product, etc)... > If a adopting organisation wants to assess OFBiz without the components in > special purpose (which should be possible), loading of the demo data of sec > the base components fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand
[ https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741512#comment-16741512 ] Jacques Le Roux commented on OFBIZ-9677: Hi Paul; Actually I backported too early. There is a test problem with your commit, see bottom of OFBIZ-9115 > In packing, only use reservations with stock on hand > > > Key: OFBIZ-9677 > URL: https://issues.apache.org/jira/browse/OFBIZ-9677 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Major > Labels: pack, reservation > Fix For: Trunk > > Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, > OFBIZ-9677_PackingIgnoreBackorderReservations.patch > > > During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the > order item. Some reservations are for back ordered items not on hand. These > reservations should not be used during packing, but they are. > The attached patch fixes this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
