[jira] [Closed] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10680.
---
Resolution: Fixed
Fix Version/s: 18.12.01
16.11.06
17.12.01
Thanks Ankit,
Your patch is in
trunk r1851319
R18 r1851320
R17 r1851321
R16 r1851322
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10680.patch, OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742784#comment-16742784
]
Ankit Joshi commented on OFBIZ-10680:
-
Thanks, [~jacques.le.roux], [~pfm.smits], and [~mthl]. I have uploaded the
patch with no prefixes. Thanks!
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch, OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10680) partyId misses in EditEftAccount.ftl (party) when you create an EFT account from the quick finalize page
[
https://issues.apache.org/jira/browse/OFBIZ-10680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Joshi updated OFBIZ-10680:
Attachment: OFBIZ-10680.patch
> partyId misses in EditEftAccount.ftl (party) when you create an EFT account
> from the quick finalize page
>
>
> Key: OFBIZ-10680
> URL: https://issues.apache.org/jira/browse/OFBIZ-10680
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10680.patch, OFBIZ-10680.patch
>
>
> While working on OFBIZ-9913 I stumbled upon this issue.
> {quote}bq. If you split the payment and want to create an EFT account you get
> an error in EditEftAccount.ftl (party) at line 40 colum 50: the partyId is
> missing.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9850. > Replace Inline js with External js in renderDateFindField macro > --- > > Key: OFBIZ-9850 > URL: https://issues.apache.org/jira/browse/OFBIZ-9850 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Fix For: 18.12.01 > > Attachments: OFBIZ-9850.patch, OFBIZ-9850_example.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9850: - Affects Version/s: Release Branch 18.12 Trunk > Replace Inline js with External js in renderDateFindField macro > --- > > Key: OFBIZ-9850 > URL: https://issues.apache.org/jira/browse/OFBIZ-9850 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Fix For: 18.12.01 > > Attachments: OFBIZ-9850.patch, OFBIZ-9850_example.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742739#comment-16742739 ] Aditya Sharma commented on OFBIZ-9850: -- Slightly modified commit from the patch. Fixed condition of shortDateInput to "date" == dateType. Done for trunk at R1851315 and plugins at R1851316. R18.12 at R1851317 and its plugins at R1851318. > Replace Inline js with External js in renderDateFindField macro > --- > > Key: OFBIZ-9850 > URL: https://issues.apache.org/jira/browse/OFBIZ-9850 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9850.patch, OFBIZ-9850_example.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742274#comment-16742274 ] Jacques Le Roux commented on OFBIZ-10476: - We could wait a bit before backporting (say a month?), but I'm for it yes (in both, nothing has been released yet). > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742267#comment-16742267 ] Michael Brohl commented on OFBIZ-10476: --- This looks good to me. Any objections to move on and commit this? Should we at least backport this to 18.12 or even 17.12? It can be viewed as a bugfix (even if I changed to "improvement"). > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10476: -- Issue Type: Improvement (was: Bug) > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10476: -- Summary: Remove Compdoc functionality from content manager (was: Fix / Remove Compdoc?) > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10476) Fix / Remove Compdoc?
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742244#comment-16742244 ] Dennis Balkir commented on OFBIZ-10476: --- I added a patch, which removes everything of the CompDoc funcionality that I could find. I also did run the tests, and there was nothing failing. The other functions of content seem to work fine too. > Fix / Remove Compdoc? > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10476) Fix / Remove Compdoc?
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10476: -- Attachment: OFBIZ-10476_Content-CompDoc.patch > Fix / Remove Compdoc? > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10741. - Resolution: Fixed Fix Version/s: 18.12.01 Upcoming Branch 17.12.01 Thanks Arpit, Jacques and Priya this is fixed in trunk r1851254 release 17.12 r1851258 release 18.12 r1851255 > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Arpit Mor >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9774) [FB] Package org.apache.ofbiz.product.config
[ https://issues.apache.org/jira/browse/OFBIZ-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9774. Resolution: Fixed Fixed with OFBIZ-10741 > [FB] Package org.apache.ofbiz.product.config > > > Key: OFBIZ-9774 > URL: https://issues.apache.org/jira/browse/OFBIZ-9774 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9774_org.apache.ofbiz.product.config_bugfixes.patch > > > ProductConfigItemContentWrapper.java:125, > RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > - RCN: Nullcheck of ProductConfigItemContentWrapper.configItemContentCache at > line 137 of value previously dereferenced in > org.apache.ofbiz.product.config.ProductConfigItemContentWrapper.getProductConfigItemContentAsText(GenericValue, > String, Locale, String, Delegator, LocalDispatcher, String) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the previous dereference disagree as to whether > this value is allowed to be null. Either the check is redundant or the > previous dereference is erroneous. > ProductConfigWorker.java:397, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > - RCN: Redundant nullcheck of configWrapper, which is known to be non-null in > org.apache.ofbiz.product.config.ProductConfigWorker.loadProductConfigWrapper(Delegator, > LocalDispatcher, String, String, String, String, String, String, Locale, > GenericValue) > This method contains a redundant check of a known non-null value against the > constant null. > ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED > - Se: The field > org.apache.ofbiz.product.config.ProductConfigWrapper.dispatcher is transient > but isn't set by deserialization > This class contains a field that is updated at multiple places in the class, > thus it seems to be part of the state of the class. However, since the field > is marked as transient and not set in readObject or readResolve, it will > contain the default value in any deserialized instance of the class. > ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED > - Se: The field > org.apache.ofbiz.product.config.ProductConfigWrapper.delegator is transient > but isn't set by deserialization > This class contains a field that is updated at multiple places in the class, > thus it seems to be part of the state of the class. However, since the field > is marked as transient and not set in readObject or readResolve, it will > contain the default value in any deserialized instance of the class. > ProductConfigWrapper.java:-1, SE_BAD_FIELD > - Se: Class org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigItem > defines non-transient non-serializable instance field content > This Serializable class defines a non-primitive instance field which is > neither transient, Serializable, or java.lang.Object, and does not appear to > implement the Externalizable interface or the readObject() and writeObject() > methods. Objects of this class will not be deserialized correctly if a > non-Serializable object is stored in this field. > ProductConfigWrapper.java:50, SE_NO_SERIALVERSIONID > - SnVI: org.apache.ofbiz.product.config.ProductConfigWrapper is Serializable; > consider declaring a serialVersionUID > This class implements the Serializable interface, but does not define a > serialVersionUID field. A change as simple as adding a reference to a .class > object will add synthetic fields to the class, which will unfortunately > change the implicit serialVersionUID (e.g., adding a reference to > String.class will generate a static field class$java$lang$String). Also, > different source code to bytecode compilers may use different naming > conventions for synthetic variables generated for references to class objects > or inner classes. To ensure interoperability of Serializable across versions, > consider adding an explicit serialVersionUID. > ProductConfigWrapper.java:226, HE_EQUALS_USE_HASHCODE > - HE: org.apache.ofbiz.product.config.ProductConfigWrapper defines equals and > uses Object.hashCode() > This class overrides equals(Object), but does not override hashCode(), and > inherits the implementation of hashCode() from java.lang.Object (which > returns the identity hash code, an arbitrary value assigned to the object by > the VM). Therefore, the class is very likely to violate the invariant that > equal objects must have equal hashcodes. > If you don't think instances of this class will ever be
[jira] [Updated] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10741: -- Affects Version/s: Release Branch 18.12 Release Branch 17.12 > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Arpit Mor >Assignee: Michael Brohl >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741938#comment-16741938 ] Jacques Le Roux edited comment on OFBIZ-10666 at 1/14/19 1:56 PM: -- BTW Deepak, if you did not read it already, I think you should like [the Onion parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860] I linked to above. It takes little experiences with cookies, login, logout and SSO to really appreciate it. The more I work on these subjects the more I understand why they wrote it ;) was (Author: jacques.le.roux): BTW Deepak, if you did not read it already, I think you should appreciate [the Onion parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860] I linked to above. It takes little experiences with cookies, login, logout and SSO to really appreciate it. The more I work on these subjects the more I understand why they wrote it ;) > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10666. --- Resolution: Fixed Fix Version/s: 18.12.01 You nailed it, thanks Deepak! Your patch is in trunk r1851247 R18 r1851248 R17 r1851249 R16 r1851250 > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742083#comment-16742083 ] Jacques Le Roux edited comment on OFBIZ-10666 at 1/14/19 1:57 PM: -- You nailed it, thanks Deepak! Your patch is in trunk r1851247 R18 r1851248 R17 r1851249 R16 r1851250 (editing in "Visual" mode adds useless lines :() was (Author: jacques.le.roux): You nailed it, thanks Deepak! Your patch is in trunk r1851247 R18 r1851248 R17 r1851249 R16 r1851250 > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741938#comment-16741938 ] Jacques Le Roux edited comment on OFBIZ-10666 at 1/14/19 1:56 PM: -- BTW Deepak, if you did not read it already, I think you should appreciate [the Onion parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860] I linked to above. It takes little experiences with cookies, login, logout and SSO to really appreciate it. The more I work on these subjects the more I understand why they wrote it ;) was (Author: jacques.le.roux): BTW Deepak, if you did not read it already, I think you should better appreciate [the Onion parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860] I linked to above. It takes little experiences with cookies, login, logout and SSO to really appreciate it. The more I work on these subjects the more I understand why they wrote it ;) > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9850: Assignee: Aditya Sharma > Replace Inline js with External js in renderDateFindField macro > --- > > Key: OFBIZ-9850 > URL: https://issues.apache.org/jira/browse/OFBIZ-9850 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9850.patch, OFBIZ-9850_example.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9850: - Attachment: OFBIZ-9850.patch OFBIZ-9850_example.patch > Replace Inline js with External js in renderDateFindField macro > --- > > Key: OFBIZ-9850 > URL: https://issues.apache.org/jira/browse/OFBIZ-9850 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9850.patch, OFBIZ-9850_example.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741991#comment-16741991 ] Aditya Sharma commented on OFBIZ-9850: -- Added patch. I will commit asap. Added an example in FormWidgetExamples for the field. > Replace Inline js with External js in renderDateFindField macro > --- > > Key: OFBIZ-9850 > URL: https://issues.apache.org/jira/browse/OFBIZ-9850 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9850.patch, OFBIZ-9850_example.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10552) Move Accounting AP AR webapps to plugin
[ https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10552: - Summary: Move Accounting AP AR webapps to plugin (was: Move Acccounting AP AR webapps to plugin) > Move Accounting AP AR webapps to plugin > --- > > Key: OFBIZ-10552 > URL: https://issues.apache.org/jira/browse/OFBIZ-10552 > Project: OFBiz > Issue Type: Task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, > accounting-ap-ar.tar.gz > > > As exchanged on [this discussion > |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E] > I created the first patch [^OFBIZ-10552.patch] that contains the separation > between accounting component and AP/AR webapps. > I detected cross dependency on screens between accounting and AP /AR, so I > realized following change : > * the commissionRun link in accounting to keep this present on AP > * move all Financial account deposit payment group screen from AR to > Accounting > You can see the svn status command result [^OFBIZ-10552-status.txt] that > will be helpfull to read the patch. > To test without plugin ap-ar: > * apply patch [^OFBIZ-10552.patch] > * ./gradlew ofbiz > To test with plugin ap-ar > * apply patch [^OFBIZ-10552.patch] > * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ > * ./gradlew loadAll ofbiz > I named the plugin accounting-ap-ar but you'll probably find a much better > name :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10552) Move Acccounting AP AR webapps to plugin
[ https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10552: - Summary: Move Acccounting AP AR webapps to plugin (was: Move Acccounint AP AR webapps to plugin) > Move Acccounting AP AR webapps to plugin > > > Key: OFBIZ-10552 > URL: https://issues.apache.org/jira/browse/OFBIZ-10552 > Project: OFBiz > Issue Type: Task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, > accounting-ap-ar.tar.gz > > > As exchanged on [this discussion > |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E] > I created the first patch [^OFBIZ-10552.patch] that contains the separation > between accounting component and AP/AR webapps. > I detected cross dependency on screens between accounting and AP /AR, so I > realized following change : > * the commissionRun link in accounting to keep this present on AP > * move all Financial account deposit payment group screen from AR to > Accounting > You can see the svn status command result [^OFBIZ-10552-status.txt] that > will be helpfull to read the patch. > To test without plugin ap-ar: > * apply patch [^OFBIZ-10552.patch] > * ./gradlew ofbiz > To test with plugin ap-ar > * apply patch [^OFBIZ-10552.patch] > * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ > * ./gradlew loadAll ofbiz > I named the plugin accounting-ap-ar but you'll probably find a much better > name :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10552) Move Acccounint AP AR webapps to plugin
[ https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-10552: Assignee: Nicolas Malin (was: Pierre Smits) > Move Acccounint AP AR webapps to plugin > --- > > Key: OFBIZ-10552 > URL: https://issues.apache.org/jira/browse/OFBIZ-10552 > Project: OFBiz > Issue Type: Task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, > accounting-ap-ar.tar.gz > > > As exchanged on [this discussion > |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E] > I created the first patch [^OFBIZ-10552.patch] that contains the separation > between accounting component and AP/AR webapps. > I detected cross dependency on screens between accounting and AP /AR, so I > realized following change : > * the commissionRun link in accounting to keep this present on AP > * move all Financial account deposit payment group screen from AR to > Accounting > You can see the svn status command result [^OFBIZ-10552-status.txt] that > will be helpfull to read the patch. > To test without plugin ap-ar: > * apply patch [^OFBIZ-10552.patch] > * ./gradlew ofbiz > To test with plugin ap-ar > * apply patch [^OFBIZ-10552.patch] > * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ > * ./gradlew loadAll ofbiz > I named the plugin accounting-ap-ar but you'll probably find a much better > name :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10552) Move Acccounint AP AR webapps to plugin
[ https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-10552: Assignee: Pierre Smits (was: Nicolas Malin) > Move Acccounint AP AR webapps to plugin > --- > > Key: OFBIZ-10552 > URL: https://issues.apache.org/jira/browse/OFBIZ-10552 > Project: OFBiz > Issue Type: Task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, > accounting-ap-ar.tar.gz > > > As exchanged on [this discussion > |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E] > I created the first patch [^OFBIZ-10552.patch] that contains the separation > between accounting component and AP/AR webapps. > I detected cross dependency on screens between accounting and AP /AR, so I > realized following change : > * the commissionRun link in accounting to keep this present on AP > * move all Financial account deposit payment group screen from AR to > Accounting > You can see the svn status command result [^OFBIZ-10552-status.txt] that > will be helpfull to read the patch. > To test without plugin ap-ar: > * apply patch [^OFBIZ-10552.patch] > * ./gradlew ofbiz > To test with plugin ap-ar > * apply patch [^OFBIZ-10552.patch] > * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ > * ./gradlew loadAll ofbiz > I named the plugin accounting-ap-ar but you'll probably find a much better > name :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10552) Move Acccounint AP AR webapps to plugin
[ https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10552: Description: As exchanged on [this discussion |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E] I created the first patch [^OFBIZ-10552.patch] that contains the separation between accounting component and AP/AR webapps. I detected cross dependency on screens between accounting and AP /AR, so I realized following change : * the commissionRun link in accounting to keep this present on AP * move all Financial account deposit payment group screen from AR to Accounting You can see the svn status command result [^OFBIZ-10552-status.txt] that will be helpfull to read the patch. To test without plugin ap-ar: * apply patch [^OFBIZ-10552.patch] * ./gradlew ofbiz To test with plugin ap-ar * apply patch [^OFBIZ-10552.patch] * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ * ./gradlew loadAll ofbiz I named the plugin accounting-ap-ar but you'll probably find a much better name :) was: As exchanged on [this discussion |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E]I created the first patch [^OFBIZ-10552.patch] that contains the separation between accounting component and AP/AR webapps. I detected cross dependency on screens between accounting and AP /AR, so I realized following change : * the commissionRun link in accounting to keep this present on AP * move all Financial account deposit payment group screen from AR to Accounting You can see the svn status command result [^OFBIZ-10552-status.txt] that will be helpfull to read the patch. To test without plugin ap-ar: * apply patch [^OFBIZ-10552.patch] * ./gradlew ofbiz To test with plugin ap-ar * apply patch [^OFBIZ-10552.patch] * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ * ./gradlew loadAll ofbiz I named the plugin accounting-ap-ar but you'll probably find a much better name :) > Move Acccounint AP AR webapps to plugin > --- > > Key: OFBIZ-10552 > URL: https://issues.apache.org/jira/browse/OFBIZ-10552 > Project: OFBiz > Issue Type: Task > Components: accounting >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, > accounting-ap-ar.tar.gz > > > As exchanged on [this discussion > |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E] > I created the first patch [^OFBIZ-10552.patch] that contains the separation > between accounting component and AP/AR webapps. > I detected cross dependency on screens between accounting and AP /AR, so I > realized following change : > * the commissionRun link in accounting to keep this present on AP > * move all Financial account deposit payment group screen from AR to > Accounting > You can see the svn status command result [^OFBIZ-10552-status.txt] that > will be helpfull to read the patch. > To test without plugin ap-ar: > * apply patch [^OFBIZ-10552.patch] > * ./gradlew ofbiz > To test with plugin ap-ar > * apply patch [^OFBIZ-10552.patch] > * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^ > * ./gradlew loadAll ofbiz > I named the plugin accounting-ap-ar but you'll probably find a much better > name :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741938#comment-16741938 ] Jacques Le Roux commented on OFBIZ-10666: - BTW Deepak, if you did not read it already, I think you should better appreciate [the Onion parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860] I linked to above. It takes little experiences with cookies, login, logout and SSO to really appreciate it. The more I work on these subjects the more I understand why they wrote it ;) > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10810) Improvements of ‘AbstractEngine#createLocationMap’
[
https://issues.apache.org/jira/browse/OFBIZ-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10810:
---
Attachment: OFBIZ-10810.patch
> Improvements of ‘AbstractEngine#createLocationMap’
> --
>
> Key: OFBIZ-10810
> URL: https://issues.apache.org/jira/browse/OFBIZ-10810
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10810.patch
>
>
> The {{createLocationMap}} method lacks documentation and could use the
> {{forEach}} method instead of a for loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10810) Improvements of ‘AbstractEngine#createLocationMap’
Mathieu Lirzin created OFBIZ-10810:
--
Summary: Improvements of ‘AbstractEngine#createLocationMap’
Key: OFBIZ-10810
URL: https://issues.apache.org/jira/browse/OFBIZ-10810
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
The {{createLocationMap}} method lacks documentation and could use the
{{forEach}} method instead of a for loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10808) Inline ‘serviceInvoker’ method in Groovy engine
[
https://issues.apache.org/jira/browse/OFBIZ-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741895#comment-16741895
]
Mathieu Lirzin commented on OFBIZ-10808:
I have included [^OFBIZ-10808.patch] which inlines the {{serviceInvoker}}
method and do some trivial rewriting/reformatting.
> Inline ‘serviceInvoker’ method in Groovy engine
> ---
>
> Key: OFBIZ-10808
> URL: https://issues.apache.org/jira/browse/OFBIZ-10808
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10808.patch
>
>
> The {{runSync}} method of the Groovy engine is only passed its arguments to
> the {{serviceInvoker}} method which is private and used only by the
> {{runSync}} method. As a consequence it seems preferable to inline the
> {{serviceInvoker}} method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10808) Inline ‘serviceInvoker’ method in Groovy engine
[
https://issues.apache.org/jira/browse/OFBIZ-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10808:
---
Attachment: OFBIZ-10808.patch
> Inline ‘serviceInvoker’ method in Groovy engine
> ---
>
> Key: OFBIZ-10808
> URL: https://issues.apache.org/jira/browse/OFBIZ-10808
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10808.patch
>
>
> The {{runSync}} method of the Groovy engine is only passed its arguments to
> the {{serviceInvoker}} method which is private and used only by the
> {{runSync}} method. As a consequence it seems preferable to inline the
> {{serviceInvoker}} method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10809) Rewrite ‘AbstractEngine#getLocation’
[
https://issues.apache.org/jira/browse/OFBIZ-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10809:
---
Attachment: OFBIZ-10809.patch
> Rewrite ‘AbstractEngine#getLocation’
>
>
> Key: OFBIZ-10809
> URL: https://issues.apache.org/jira/browse/OFBIZ-10809
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10809.patch
>
>
> The {{AbstractEngine#getLocation}} method lacks javadoc and could be
> rewritten with a simple expression.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10809) Rewrite ‘AbstractEngine#getLocation’
Mathieu Lirzin created OFBIZ-10809:
--
Summary: Rewrite ‘AbstractEngine#getLocation’
Key: OFBIZ-10809
URL: https://issues.apache.org/jira/browse/OFBIZ-10809
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
The {{AbstractEngine#getLocation}} method lacks javadoc and could be rewritten
with a simple expression.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10808) Inline ‘serviceInvoker’ method in Groovy engine
Mathieu Lirzin created OFBIZ-10808:
--
Summary: Inline ‘serviceInvoker’ method in Groovy engine
Key: OFBIZ-10808
URL: https://issues.apache.org/jira/browse/OFBIZ-10808
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
The {{runSync}} method of the Groovy engine is only passed its arguments to the
{{serviceInvoker}} method which is private and used only by the {{runSync}}
method. As a consequence it seems preferable to inline the {{serviceInvoker}}
method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10807) Rewrite ‘GroovyUtil#runScriptAtLocation’
[ https://issues.apache.org/jira/browse/OFBIZ-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10807: --- Attachment: OFBIZ-10807.patch > Rewrite ‘GroovyUtil#runScriptAtLocation’ > > > Key: OFBIZ-10807 > URL: https://issues.apache.org/jira/browse/OFBIZ-10807 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: OFBIZ-10807.patch > > > The ‘GroovyUtil#runScriptAtLocation’ lacks a javadoc and could be rewritten > with a simple expression. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Nigam updated OFBIZ-10666: - Attachment: OFBiz-10666.patch > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out
[ https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741879#comment-16741879 ] Deepak Nigam commented on OFBIZ-10666: -- It seems that the actual problem is not 'autoName' (at least for this particular issue). On further investigation, I found that cookie path and domain are different in the methods of creating the auto-login cookie i.e. LoginWorker.autoLoginSet() and removing the auto-login cookie i.e. LoginWorker.autoLoginRemove(). After following changes the issue seems to be fixed: 1. Removed getMaxAge() check from the condition used in LoginWorker.getAutoUserLoginId() method. 2. Corrected the path and domain in the method LoginWorker.autoLoginRemove(). Please find the attached patch for reference and commit. > User's name is displayed on ecommerce even after user logs out > -- > > Key: OFBIZ-10666 > URL: https://issues.apache.org/jira/browse/OFBIZ-10666 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06 > > Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, > 4-NotYou.png, OFBIZ-10666.patch > > > Steps to regenerate: > # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > Welcome is displayed and user's name is not displayed when URL is opened. > (Please refer attachment: 1-OpenURL) > # Login at ecommerce by clicking on login and entering Username: "admin" and > Password: "ofbiz". Username will be displayed after user logs in. (Please > refer attachment: 2-LoggedIn) > # Logout of ecommerce by clicking on logout. User will be logged out and > login link will be displayed in place of logout link, but the name of user is > still displayed. (Please refer attachment: 3-LoggedOut) > Actual: Username is still displayed after user logs out > > Expected: Username should not be displayed after the user logs out > > Note: Similar issue also exists when the user clicks on (Not You? Click Here) > link. (Please refer attachment: 4-NotYou) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10807) Rewrite ‘GroovyUtil#runScriptAtLocation’
Mathieu Lirzin created OFBIZ-10807: -- Summary: Rewrite ‘GroovyUtil#runScriptAtLocation’ Key: OFBIZ-10807 URL: https://issues.apache.org/jira/browse/OFBIZ-10807 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Mathieu Lirzin Fix For: Upcoming Branch The ‘GroovyUtil#runScriptAtLocation’ lacks a javadoc and could be rewritten with a simple expression. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10806) Groovy Base script redundancy
[
https://issues.apache.org/jira/browse/OFBIZ-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741874#comment-16741874
]
Mathieu Lirzin commented on OFBIZ-10806:
I have included [^OFBIZ-10806.patch] which removes the {{GroovyInit.groovy}}
script and its usage which like described above is redundant.
> Groovy Base script redundancy
> -
>
> Key: OFBIZ-10806
> URL: https://issues.apache.org/jira/browse/OFBIZ-10806
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10806.patch
>
>
> According to [Groovy
> documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
> the following construction:
> {code:java}
> CompilerConfiguration conf = new CompilerConfiguration();
> conf.setScriptBaseClass(scriptBaseClass);
> groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
> conf);
> {code}
> is equivalent to running the a script containing the {{@BaseScript}}
> annotation.
> In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one
> solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10806) Groovy Base script redundancy
[
https://issues.apache.org/jira/browse/OFBIZ-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10806:
---
Attachment: OFBIZ-10806.patch
> Groovy Base script redundancy
> -
>
> Key: OFBIZ-10806
> URL: https://issues.apache.org/jira/browse/OFBIZ-10806
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10806.patch
>
>
> According to [Groovy
> documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
> the following construction:
> {code:java}
> CompilerConfiguration conf = new CompilerConfiguration();
> conf.setScriptBaseClass(scriptBaseClass);
> groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
> conf);
> {code}
> is equivalent to running the a script containing the {{@BaseScript}}
> annotation.
> In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one
> solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10806) Groovy Base script redundancy
[
https://issues.apache.org/jira/browse/OFBIZ-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10806:
---
Description:
According to [Groovy
documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
the following construction:
{code:java}
CompilerConfiguration conf = new CompilerConfiguration();
conf.setScriptBaseClass(scriptBaseClass);
groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
conf);
{code}
is equivalent to running the a script containing the {{@BaseScript}} annotation.
In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one solution,
we are doing both. :-)
was:
According to [Groovy
documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
the following construction:
{code:java}
CompilerConfiguration conf = new CompilerConfiguration();
conf.setScriptBaseClass(scriptBaseClass);
groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
conf);
{code}
is equivalent to running the a script containing the {{@BaseScript}}
annotation. In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing
one solution, we are doing both. :-)
> Groovy Base script redundancy
> -
>
> Key: OFBIZ-10806
> URL: https://issues.apache.org/jira/browse/OFBIZ-10806
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> According to [Groovy
> documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
> the following construction:
> {code:java}
> CompilerConfiguration conf = new CompilerConfiguration();
> conf.setScriptBaseClass(scriptBaseClass);
> groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
> conf);
> {code}
> is equivalent to running the a script containing the {{@BaseScript}}
> annotation.
> In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one
> solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10806) Groovy Base script redundancy
[
https://issues.apache.org/jira/browse/OFBIZ-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10806:
---
Attachment: (was: OFBIZ-10806_Remove-BaseScript-handling.patch)
> Groovy Base script redundancy
> -
>
> Key: OFBIZ-10806
> URL: https://issues.apache.org/jira/browse/OFBIZ-10806
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> According to [Groovy
> documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
> the following construction:
> {code:java}
> CompilerConfiguration conf = new CompilerConfiguration();
> conf.setScriptBaseClass(scriptBaseClass);
> groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
> conf);
> {code}
> is equivalent to running the a script containing the {{@BaseScript}}
> annotation.
> In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one
> solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10806) Groovy Base script redundancy
[
https://issues.apache.org/jira/browse/OFBIZ-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10806:
---
Attachment: OFBIZ-10806_Remove-BaseScript-handling.patch
> Groovy Base script redundancy
> -
>
> Key: OFBIZ-10806
> URL: https://issues.apache.org/jira/browse/OFBIZ-10806
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10806_Remove-BaseScript-handling.patch
>
>
> According to [Groovy
> documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
> the following construction:
> {code:java}
> CompilerConfiguration conf = new CompilerConfiguration();
> conf.setScriptBaseClass(scriptBaseClass);
> groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
> conf);
> {code}
> is equivalent to running the a script containing the {{@BaseScript}}
> annotation.
> In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one
> solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10806) Groovy Base script redundancy
Mathieu Lirzin created OFBIZ-10806:
--
Summary: Groovy Base script redundancy
Key: OFBIZ-10806
URL: https://issues.apache.org/jira/browse/OFBIZ-10806
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
According to [Groovy
documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
the following construction:
{code:java}
CompilerConfiguration conf = new CompilerConfiguration();
conf.setScriptBaseClass(scriptBaseClass);
groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
conf);
{code}
is equivalent to running the a script containing the {{@BaseScript}}
annotation. In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing
one solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
